All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Jonathan Hunter
	<jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Kyungmin Park
	<kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Michael Turquette
	<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	MyungJoo Ham
	<myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v1 2/5] clk: Introduce clk_round_rate_unboundly()
Date: Tue, 26 May 2020 22:55:49 -0700	[thread overview]
Message-ID: <159055894944.88029.2029223648098859689@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20200330231617.17079-3-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Quoting Dmitry Osipenko (2020-03-30 16:16:14)
> In same cases it may be desired to round clock's rate without taking into
> account current min/max requests made by the clock's users. One example is
> building up OPP table based on a possible clock rates.

Shouldn't the OPP table come from firmware/DT? I don't quite understand
why we're generating OPP tables on top of the rate rounding API.
clk_round_rate() is supposed to tell us what rate we'll get if we call
clk_set_rate() with the same arguments. An unboundly version of that
doesn't make sense. 

I wonder if perhaps the clk provider should be populating OPP tables in
this case? Or basically anything besides adding another clk consumer API
to solve this problem. Who is the caller? Something later in this
series?

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Chanwoo Choi <cw00.choi@samsung.com>,
	Dmitry Osipenko <digetx@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Michael Turquette <mturquette@baylibre.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Thierry Reding <thierry.reding@gmail.com>
Cc: linux-clk@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/5] clk: Introduce clk_round_rate_unboundly()
Date: Tue, 26 May 2020 22:55:49 -0700	[thread overview]
Message-ID: <159055894944.88029.2029223648098859689@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20200330231617.17079-3-digetx@gmail.com>

Quoting Dmitry Osipenko (2020-03-30 16:16:14)
> In same cases it may be desired to round clock's rate without taking into
> account current min/max requests made by the clock's users. One example is
> building up OPP table based on a possible clock rates.

Shouldn't the OPP table come from firmware/DT? I don't quite understand
why we're generating OPP tables on top of the rate rounding API.
clk_round_rate() is supposed to tell us what rate we'll get if we call
clk_set_rate() with the same arguments. An unboundly version of that
doesn't make sense. 

I wonder if perhaps the clk provider should be populating OPP tables in
this case? Or basically anything besides adding another clk consumer API
to solve this problem. Who is the caller? Something later in this
series?

  parent reply	other threads:[~2020-05-27  5:55 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-30 23:16 [PATCH v1 0/5] NVIDIA Tegra devfreq drivers improvements Dmitry Osipenko
2020-03-30 23:16 ` [PATCH v1 1/5] PM / devfreq: tegra: Add Dmitry as a maintainer Dmitry Osipenko
     [not found]   ` <20200330231617.17079-2-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-31 23:13     ` Chanwoo Choi
2020-03-31 23:13       ` Chanwoo Choi
     [not found]       ` <db4883d4-18b7-238a-798b-ad45aad978fc-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2020-04-01 18:52         ` Dmitry Osipenko
2020-04-01 18:52           ` Dmitry Osipenko
2020-03-30 23:16 ` [PATCH v1 4/5] PM / devfreq: tegra30: Use clk_round_rate_unboundly() Dmitry Osipenko
2020-03-31 23:22   ` Chanwoo Choi
     [not found]     ` <147b571a-bae1-8a58-942c-579a5297299b-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2020-03-31 23:23       ` Chanwoo Choi
2020-03-31 23:23         ` Chanwoo Choi
     [not found] ` <20200330231617.17079-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-30 23:16   ` [PATCH v1 2/5] clk: Introduce clk_round_rate_unboundly() Dmitry Osipenko
2020-03-30 23:16     ` Dmitry Osipenko
     [not found]     ` <20200330231617.17079-3-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-02  0:33       ` Michał Mirosław
2020-04-02  0:33         ` Michał Mirosław
2020-04-02 14:21         ` Dmitry Osipenko
2020-05-27  5:55       ` Stephen Boyd [this message]
2020-05-27  5:55         ` Stephen Boyd
     [not found]         ` <159055894944.88029.2029223648098859689-n1Xw8LXHxjTHt/MElyovVYaSKrA+ACpX0E9HWUfgJXw@public.gmane.org>
2020-05-27 17:57           ` Dmitry Osipenko
2020-05-27 17:57             ` Dmitry Osipenko
     [not found]             ` <3fcac59c-7a37-d4af-9d12-710d7af05845-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-05-28  0:38               ` Stephen Boyd
2020-05-28  0:38                 ` Stephen Boyd
2020-05-27  5:57       ` Stephen Boyd
2020-05-27  5:57         ` Stephen Boyd
2020-03-30 23:16   ` [PATCH v1 3/5] PM / devfreq: tegra20: Use clk_round_rate_unboundly() Dmitry Osipenko
2020-03-30 23:16     ` Dmitry Osipenko
     [not found]     ` <20200330231617.17079-4-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-31 23:22       ` Chanwoo Choi
2020-03-31 23:22         ` Chanwoo Choi
2020-03-31 23:23         ` Chanwoo Choi
2020-03-30 23:16   ` [PATCH v1 5/5] PM / devfreq: tegra30: Make CPUFreq notifier to take into account boosting Dmitry Osipenko
2020-03-30 23:16     ` Dmitry Osipenko
2020-03-31 23:29     ` Chanwoo Choi
     [not found]       ` <afcc9f80-c102-da42-8f7f-9b66417a9d4d-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2020-04-01 18:53         ` Dmitry Osipenko
2020-04-01 18:53           ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=159055894944.88029.2029223648098859689@swboyd.mtv.corp.google.com \
    --to=sboyd-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.