From: chenxb_99091@126.com To: Daniel Vetter <daniel@ffwll.ch> Cc: dri-devel <dri-devel@lists.freedesktop.org>, linux-kernel <linux-kernel@vger.kernel.org>, David Airlie <airlied@linux.ie>, Xuebing Chen <chenxb_99091@126.com> Subject: Re:Re:[PATCH] drm: fix setting of plane_mask in pan_display_atomic() function for linux-4.4 Date: Wed, 27 May 2020 21:33:27 +0800 [thread overview] Message-ID: <1590586407-4109-1-git-send-email-chenxb_99091@126.com> (raw) From: Xuebing Chen <chenxb_99091@126.com> On Mon, May 25, 2020 at 04:34:28PM +0200, Daniel Vetter wrote: > On Sat, May 23, 2020 at 11:49:07AM +0800, chenxb_99091@126.com wrote: > > From: Xuebing Chen <chenxb_99091@126.com> > > > > The <include/drm/drm_crtc.h> provides drm_for_each_plane_mask macro and > > plane_mask is defined as bitmask of plane indices, such as > > 1<<drm_plane_index(plane). This patch fixes error setting of plane_mask > > in pan_display_atomic() function. > > > > Signed-off-by: Xuebing Chen <chenxb_99091@126.com> > > What kernel is this patch against? Latest upstream doesn't have any such > code anymore ... I'm assuming that Ville fixed this in one of his patches, > but I can't find the right one just now. This bug is still present in the longterm-supported versions of kernel 4.4.y, including the latest kernel v4.4.224, See https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/?h=v4.4.224 > -Daniel > > > --- > > drivers/gpu/drm/drm_fb_helper.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > > index e449f22..6a9f7ee 100644 > > --- a/drivers/gpu/drm/drm_fb_helper.c > > +++ b/drivers/gpu/drm/drm_fb_helper.c > > @@ -1256,7 +1256,7 @@ retry: > > goto fail; > > > > plane = mode_set->crtc->primary; > > - plane_mask |= drm_plane_index(plane); > > + plane_mask |= 1 << drm_plane_index(plane); > > plane->old_fb = plane->fb; > > } > > > > -- > > 2.7.4 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: chenxb_99091@126.com To: Daniel Vetter <daniel@ffwll.ch> Cc: David Airlie <airlied@linux.ie>, linux-kernel <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Xuebing Chen <chenxb_99091@126.com> Subject: Re:Re:[PATCH] drm: fix setting of plane_mask in pan_display_atomic() function for linux-4.4 Date: Wed, 27 May 2020 21:33:27 +0800 [thread overview] Message-ID: <1590586407-4109-1-git-send-email-chenxb_99091@126.com> (raw) From: Xuebing Chen <chenxb_99091@126.com> On Mon, May 25, 2020 at 04:34:28PM +0200, Daniel Vetter wrote: > On Sat, May 23, 2020 at 11:49:07AM +0800, chenxb_99091@126.com wrote: > > From: Xuebing Chen <chenxb_99091@126.com> > > > > The <include/drm/drm_crtc.h> provides drm_for_each_plane_mask macro and > > plane_mask is defined as bitmask of plane indices, such as > > 1<<drm_plane_index(plane). This patch fixes error setting of plane_mask > > in pan_display_atomic() function. > > > > Signed-off-by: Xuebing Chen <chenxb_99091@126.com> > > What kernel is this patch against? Latest upstream doesn't have any such > code anymore ... I'm assuming that Ville fixed this in one of his patches, > but I can't find the right one just now. This bug is still present in the longterm-supported versions of kernel 4.4.y, including the latest kernel v4.4.224, See https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/?h=v4.4.224 > -Daniel > > > --- > > drivers/gpu/drm/drm_fb_helper.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > > index e449f22..6a9f7ee 100644 > > --- a/drivers/gpu/drm/drm_fb_helper.c > > +++ b/drivers/gpu/drm/drm_fb_helper.c > > @@ -1256,7 +1256,7 @@ retry: > > goto fail; > > > > plane = mode_set->crtc->primary; > > - plane_mask |= drm_plane_index(plane); > > + plane_mask |= 1 << drm_plane_index(plane); > > plane->old_fb = plane->fb; > > } > > > > -- > > 2.7.4 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2020-05-27 13:35 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-27 13:33 chenxb_99091 [this message] 2020-05-27 13:33 ` Re:Re:[PATCH] drm: fix setting of plane_mask in pan_display_atomic() function for linux-4.4 chenxb_99091 2020-05-29 8:43 ` Ville Syrjälä 2020-05-29 8:43 ` Ville Syrjälä -- strict thread matches above, loose matches on Subject: below -- 2020-05-23 3:49 [PATCH] " chenxb_99091 2020-05-25 14:34 ` Daniel Vetter 2020-05-26 2:56 ` chenxb_99091
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1590586407-4109-1-git-send-email-chenxb_99091@126.com \ --to=chenxb_99091@126.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.