From: Souptick Joarder <jrdr.linux@gmail.com> To: rspringer@google.com, toddpoynor@google.com, benchan@chromium.org, gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Souptick Joarder <jrdr.linux@gmail.com>, John Hubbard <jhubbard@nvidia.com> Subject: [PATCH] staging: gasket: Convert get_user_pages*() --> pin_user_pages*() Date: Thu, 28 May 2020 02:32:42 +0530 [thread overview] Message-ID: <1590613362-27495-1-git-send-email-jrdr.linux@gmail.com> (raw) This code was using get_user_pages_fast(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to convert the get_user_pages_fast() + put_page() calls to pin_user_pages_fast() + unpin_user_page() calls. There is some helpful background in [2]: basically, this is a small part of fixing a long-standing disconnect between pinning pages, and file systems' use of those pages. [1] Documentation/core-api/pin_user_pages.rst [2] "Explicit pinning of user-space pages": https://lwn.net/Articles/807108/ Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> Cc: John Hubbard <jhubbard@nvidia.com> Hi, I'm compile tested this, but unable to run-time test, so any testing help is much appriciated. --- drivers/staging/gasket/gasket_page_table.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gasket/gasket_page_table.c b/drivers/staging/gasket/gasket_page_table.c index f6d7157..d712ad4 100644 --- a/drivers/staging/gasket/gasket_page_table.c +++ b/drivers/staging/gasket/gasket_page_table.c @@ -449,7 +449,7 @@ static bool gasket_release_page(struct page *page) if (!PageReserved(page)) SetPageDirty(page); - put_page(page); + unpin_user_page(page); return true; } @@ -486,12 +486,12 @@ static int gasket_perform_mapping(struct gasket_page_table *pg_tbl, ptes[i].dma_addr = pg_tbl->coherent_pages[0].paddr + off + i * PAGE_SIZE; } else { - ret = get_user_pages_fast(page_addr - offset, 1, + ret = pin_user_pages_fast(page_addr - offset, 1, FOLL_WRITE, &page); if (ret <= 0) { dev_err(pg_tbl->device, - "get user pages failed for addr=0x%lx, offset=0x%lx [ret=%d]\n", + "pin user pages failed for addr=0x%lx, offset=0x%lx [ret=%d]\n", page_addr, offset, ret); return ret ? ret : -ENOMEM; } -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Souptick Joarder <jrdr.linux@gmail.com> To: rspringer@google.com, toddpoynor@google.com, benchan@chromium.org, gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, John Hubbard <jhubbard@nvidia.com>, linux-kernel@vger.kernel.org, Souptick Joarder <jrdr.linux@gmail.com> Subject: [PATCH] staging: gasket: Convert get_user_pages*() --> pin_user_pages*() Date: Thu, 28 May 2020 02:32:42 +0530 [thread overview] Message-ID: <1590613362-27495-1-git-send-email-jrdr.linux@gmail.com> (raw) This code was using get_user_pages_fast(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to convert the get_user_pages_fast() + put_page() calls to pin_user_pages_fast() + unpin_user_page() calls. There is some helpful background in [2]: basically, this is a small part of fixing a long-standing disconnect between pinning pages, and file systems' use of those pages. [1] Documentation/core-api/pin_user_pages.rst [2] "Explicit pinning of user-space pages": https://lwn.net/Articles/807108/ Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> Cc: John Hubbard <jhubbard@nvidia.com> Hi, I'm compile tested this, but unable to run-time test, so any testing help is much appriciated. --- drivers/staging/gasket/gasket_page_table.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gasket/gasket_page_table.c b/drivers/staging/gasket/gasket_page_table.c index f6d7157..d712ad4 100644 --- a/drivers/staging/gasket/gasket_page_table.c +++ b/drivers/staging/gasket/gasket_page_table.c @@ -449,7 +449,7 @@ static bool gasket_release_page(struct page *page) if (!PageReserved(page)) SetPageDirty(page); - put_page(page); + unpin_user_page(page); return true; } @@ -486,12 +486,12 @@ static int gasket_perform_mapping(struct gasket_page_table *pg_tbl, ptes[i].dma_addr = pg_tbl->coherent_pages[0].paddr + off + i * PAGE_SIZE; } else { - ret = get_user_pages_fast(page_addr - offset, 1, + ret = pin_user_pages_fast(page_addr - offset, 1, FOLL_WRITE, &page); if (ret <= 0) { dev_err(pg_tbl->device, - "get user pages failed for addr=0x%lx, offset=0x%lx [ret=%d]\n", + "pin user pages failed for addr=0x%lx, offset=0x%lx [ret=%d]\n", page_addr, offset, ret); return ret ? ret : -ENOMEM; } -- 1.9.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next reply other threads:[~2020-05-27 20:54 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-27 21:02 Souptick Joarder [this message] 2020-05-27 21:02 ` [PATCH] staging: gasket: Convert get_user_pages*() --> pin_user_pages*() Souptick Joarder 2020-05-28 11:04 ` Dan Carpenter 2020-05-28 11:04 ` Dan Carpenter 2020-05-29 6:16 ` Souptick Joarder 2020-05-29 6:16 ` Souptick Joarder 2020-05-29 6:27 ` Souptick Joarder 2020-05-29 6:27 ` Souptick Joarder 2020-05-29 7:38 ` John Hubbard 2020-05-29 7:38 ` John Hubbard 2020-05-29 7:45 ` Dan Carpenter 2020-05-29 7:45 ` Dan Carpenter 2020-05-29 7:46 ` Dan Carpenter 2020-05-29 7:46 ` Dan Carpenter 2020-05-29 8:00 ` John Hubbard 2020-05-29 8:00 ` John Hubbard 2020-05-29 11:53 ` Dan Carpenter 2020-05-29 11:53 ` Dan Carpenter 2020-05-29 20:28 ` John Hubbard 2020-05-29 20:28 ` John Hubbard 2020-05-31 7:23 Souptick Joarder 2020-05-31 7:23 ` Souptick Joarder 2020-05-31 8:59 ` Dan Carpenter 2020-05-31 8:59 ` Dan Carpenter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1590613362-27495-1-git-send-email-jrdr.linux@gmail.com \ --to=jrdr.linux@gmail.com \ --cc=benchan@chromium.org \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=jhubbard@nvidia.com \ --cc=linux-kernel@vger.kernel.org \ --cc=rspringer@google.com \ --cc=toddpoynor@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.