All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] add I2C device and compatible ID
@ 2020-05-28  7:05 Seven Lee
  2020-05-28 11:46 ` Mark Brown
  2020-05-28 13:02 ` Mark Brown
  0 siblings, 2 replies; 6+ messages in thread
From: Seven Lee @ 2020-05-28  7:05 UTC (permalink / raw)
  To: broonie; +Cc: alsa-devel, Seven Lee, lgirdwood, YHCHuang, CTLIN0, KCHSU0

The nau8810 driver can also compatible with nau8812 and nau8814.

Signed-off-by: Seven Lee <wtli@nuvoton.com>
---
 Documentation/devicetree/bindings/sound/nau8810.txt | 5 +++--
 sound/soc/codecs/nau8810.c                          | 4 ++++
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/nau8810.txt b/Documentation/devicetree/bindings/sound/nau8810.txt
index 05830e477acd..7deaa452b200 100644
--- a/Documentation/devicetree/bindings/sound/nau8810.txt
+++ b/Documentation/devicetree/bindings/sound/nau8810.txt
@@ -1,10 +1,11 @@
-NAU8810 audio CODEC
+NAU8810/NAU8812/NAU8814 audio CODEC
 
 This device supports I2C only.
 
 Required properties:
 
-  - compatible : "nuvoton,nau8810"
+  - compatible : One of "nuvoton,nau8810" or "nuvoton,nau8812" or
+	"nuvoton,nau8814"
 
   - reg : the I2C address of the device.
 
diff --git a/sound/soc/codecs/nau8810.c b/sound/soc/codecs/nau8810.c
index efe9fb3fb225..33ebc6398426 100644
--- a/sound/soc/codecs/nau8810.c
+++ b/sound/soc/codecs/nau8810.c
@@ -895,6 +895,8 @@ static int nau8810_i2c_probe(struct i2c_client *i2c,
 
 static const struct i2c_device_id nau8810_i2c_id[] = {
 	{ "nau8810", 0 },
+	{ "nau8812", 0 },
+	{ "nau8814", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, nau8810_i2c_id);
@@ -902,6 +904,8 @@ MODULE_DEVICE_TABLE(i2c, nau8810_i2c_id);
 #ifdef CONFIG_OF
 static const struct of_device_id nau8810_of_match[] = {
 	{ .compatible = "nuvoton,nau8810", },
+	{ .compatible = "nuvoton,nau8812", },
+	{ .compatible = "nuvoton,nau8814", },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, nau8810_of_match);
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] add I2C device and compatible ID
  2020-05-28  7:05 [PATCH] add I2C device and compatible ID Seven Lee
@ 2020-05-28 11:46 ` Mark Brown
  2020-05-28 13:02 ` Mark Brown
  1 sibling, 0 replies; 6+ messages in thread
From: Mark Brown @ 2020-05-28 11:46 UTC (permalink / raw)
  To: Seven Lee; +Cc: YHCHuang, alsa-devel, KCHSU0, CTLIN0, lgirdwood

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

On Thu, May 28, 2020 at 03:05:10PM +0800, Seven Lee wrote:
> The nau8810 driver can also compatible with nau8812 and nau8814.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] add I2C device and compatible ID
  2020-05-28  7:05 [PATCH] add I2C device and compatible ID Seven Lee
  2020-05-28 11:46 ` Mark Brown
@ 2020-05-28 13:02 ` Mark Brown
  1 sibling, 0 replies; 6+ messages in thread
From: Mark Brown @ 2020-05-28 13:02 UTC (permalink / raw)
  To: Seven Lee; +Cc: YHCHuang, alsa-devel, KCHSU0, CTLIN0, lgirdwood

On Thu, 28 May 2020 15:05:10 +0800, Seven Lee wrote:
> The nau8810 driver can also compatible with nau8812 and nau8814.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: nau8810: add I2C device and compatible ID
      commit: 2b1878afc8fb778a881e9a1d7d17b14e13f579dc

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] add I2C device and compatible ID
  2020-05-25 10:13 Seven Lee
  2020-05-25 10:13 ` Seven Lee
@ 2020-05-25 10:49 ` Mark Brown
  1 sibling, 0 replies; 6+ messages in thread
From: Mark Brown @ 2020-05-25 10:49 UTC (permalink / raw)
  To: Seven Lee; +Cc: YHCHuang, alsa-devel, KCHSU0, CTLIN0, lgirdwood

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

On Mon, May 25, 2020 at 06:13:34PM +0800, Seven Lee wrote:
> The nau8810 driver can also compatible with nau8812 and nau8814.
> 
> Signed-off-by: Seven Lee <wtli@nuvoton.com>
> ---
>  .../devicetree/bindings/sound/nau8812.txt        | 16 ++++++++++++++++
>  .../devicetree/bindings/sound/nau8814.txt        | 16 ++++++++++++++++
>  sound/soc/codecs/nau8810.c                       |  4 ++++

If they're compatible you should add the additional IDs to the same
binding document rather than adding additional binding documents.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] add I2C device and compatible ID
  2020-05-25 10:13 Seven Lee
@ 2020-05-25 10:13 ` Seven Lee
  2020-05-25 10:49 ` Mark Brown
  1 sibling, 0 replies; 6+ messages in thread
From: Seven Lee @ 2020-05-25 10:13 UTC (permalink / raw)
  To: broonie; +Cc: alsa-devel, Seven Lee, lgirdwood, YHCHuang, CTLIN0, KCHSU0

The nau8810 driver can also compatible with nau8812 and nau8814.

Signed-off-by: Seven Lee <wtli@nuvoton.com>
---
 .../devicetree/bindings/sound/nau8812.txt        | 16 ++++++++++++++++
 .../devicetree/bindings/sound/nau8814.txt        | 16 ++++++++++++++++
 sound/soc/codecs/nau8810.c                       |  4 ++++
 3 files changed, 36 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/nau8812.txt
 create mode 100644 Documentation/devicetree/bindings/sound/nau8814.txt

diff --git a/Documentation/devicetree/bindings/sound/nau8812.txt b/Documentation/devicetree/bindings/sound/nau8812.txt
new file mode 100644
index 000000000000..7aab29586a1f
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/nau8812.txt
@@ -0,0 +1,16 @@
+NAU8812 audio CODEC
+
+This device supports I2C only.
+
+Required properties:
+
+  - compatible : "nuvoton,nau8812"
+
+  - reg : the I2C address of the device.
+
+Example:
+
+codec: nau8812@1a {
+	compatible = "nuvoton,nau8812";
+	reg = <0x1a>;
+};
diff --git a/Documentation/devicetree/bindings/sound/nau8814.txt b/Documentation/devicetree/bindings/sound/nau8814.txt
new file mode 100644
index 000000000000..24bf2ba3d23b
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/nau8814.txt
@@ -0,0 +1,16 @@
+NAU8814 audio CODEC
+
+This device supports I2C only.
+
+Required properties:
+
+  - compatible : "nuvoton,nau8814"
+
+  - reg : the I2C address of the device.
+
+Example:
+
+codec: nau8814@1a {
+	compatible = "nuvoton,nau8814";
+	reg = <0x1a>;
+};
diff --git a/sound/soc/codecs/nau8810.c b/sound/soc/codecs/nau8810.c
index efe9fb3fb225..33ebc6398426 100644
--- a/sound/soc/codecs/nau8810.c
+++ b/sound/soc/codecs/nau8810.c
@@ -895,6 +895,8 @@ static int nau8810_i2c_probe(struct i2c_client *i2c,
 
 static const struct i2c_device_id nau8810_i2c_id[] = {
 	{ "nau8810", 0 },
+	{ "nau8812", 0 },
+	{ "nau8814", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, nau8810_i2c_id);
@@ -902,6 +904,8 @@ MODULE_DEVICE_TABLE(i2c, nau8810_i2c_id);
 #ifdef CONFIG_OF
 static const struct of_device_id nau8810_of_match[] = {
 	{ .compatible = "nuvoton,nau8810", },
+	{ .compatible = "nuvoton,nau8812", },
+	{ .compatible = "nuvoton,nau8814", },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, nau8810_of_match);
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] add I2C device and compatible ID
@ 2020-05-25 10:13 Seven Lee
  2020-05-25 10:13 ` Seven Lee
  2020-05-25 10:49 ` Mark Brown
  0 siblings, 2 replies; 6+ messages in thread
From: Seven Lee @ 2020-05-25 10:13 UTC (permalink / raw)
  To: broonie; +Cc: alsa-devel, Seven Lee, lgirdwood, YHCHuang, CTLIN0, KCHSU0

The nau8810 driver can also compatible with nau8812 and nau8814.

Signed-off-by: Seven Lee <wtli@nuvoton.com>
---
 .../devicetree/bindings/sound/nau8812.txt        | 16 ++++++++++++++++
 .../devicetree/bindings/sound/nau8814.txt        | 16 ++++++++++++++++
 sound/soc/codecs/nau8810.c                       |  4 ++++
 3 files changed, 36 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/nau8812.txt
 create mode 100644 Documentation/devicetree/bindings/sound/nau8814.txt

diff --git a/Documentation/devicetree/bindings/sound/nau8812.txt b/Documentation/devicetree/bindings/sound/nau8812.txt
new file mode 100644
index 000000000000..7aab29586a1f
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/nau8812.txt
@@ -0,0 +1,16 @@
+NAU8812 audio CODEC
+
+This device supports I2C only.
+
+Required properties:
+
+  - compatible : "nuvoton,nau8812"
+
+  - reg : the I2C address of the device.
+
+Example:
+
+codec: nau8812@1a {
+	compatible = "nuvoton,nau8812";
+	reg = <0x1a>;
+};
diff --git a/Documentation/devicetree/bindings/sound/nau8814.txt b/Documentation/devicetree/bindings/sound/nau8814.txt
new file mode 100644
index 000000000000..24bf2ba3d23b
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/nau8814.txt
@@ -0,0 +1,16 @@
+NAU8814 audio CODEC
+
+This device supports I2C only.
+
+Required properties:
+
+  - compatible : "nuvoton,nau8814"
+
+  - reg : the I2C address of the device.
+
+Example:
+
+codec: nau8814@1a {
+	compatible = "nuvoton,nau8814";
+	reg = <0x1a>;
+};
diff --git a/sound/soc/codecs/nau8810.c b/sound/soc/codecs/nau8810.c
index efe9fb3fb225..33ebc6398426 100644
--- a/sound/soc/codecs/nau8810.c
+++ b/sound/soc/codecs/nau8810.c
@@ -895,6 +895,8 @@ static int nau8810_i2c_probe(struct i2c_client *i2c,
 
 static const struct i2c_device_id nau8810_i2c_id[] = {
 	{ "nau8810", 0 },
+	{ "nau8812", 0 },
+	{ "nau8814", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, nau8810_i2c_id);
@@ -902,6 +904,8 @@ MODULE_DEVICE_TABLE(i2c, nau8810_i2c_id);
 #ifdef CONFIG_OF
 static const struct of_device_id nau8810_of_match[] = {
 	{ .compatible = "nuvoton,nau8810", },
+	{ .compatible = "nuvoton,nau8812", },
+	{ .compatible = "nuvoton,nau8814", },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, nau8810_of_match);
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-28 13:05 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28  7:05 [PATCH] add I2C device and compatible ID Seven Lee
2020-05-28 11:46 ` Mark Brown
2020-05-28 13:02 ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2020-05-25 10:13 Seven Lee
2020-05-25 10:13 ` Seven Lee
2020-05-25 10:49 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.