* [PATCH] drivers/dax/bus: Use kobj_to_dev() API
@ 2020-05-29 3:42 ` Shuai He
0 siblings, 0 replies; 6+ messages in thread
From: Shuai He @ 2020-05-29 3:42 UTC (permalink / raw)
To: dan.j.williams, vishal.l.verma, dave.jiang
Cc: linux-nvdimm, linux-kernel, Shuai He
Use kobj_to_dev() API instead of container_of().
Signed-off-by: Shuai He <hexiaoshuaishuai@gmail.com>
---
drivers/dax/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
index df238c8..24625d2 100644
--- a/drivers/dax/bus.c
+++ b/drivers/dax/bus.c
@@ -331,7 +331,7 @@ static DEVICE_ATTR_RO(numa_node);
static umode_t dev_dax_visible(struct kobject *kobj, struct attribute *a, int n)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct dev_dax *dev_dax = to_dev_dax(dev);
if (a == &dev_attr_target_node.attr && dev_dax_target_node(dev_dax) < 0)
--
2.7.4
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] drivers/dax/bus: Use kobj_to_dev() API
@ 2020-05-29 3:42 ` Shuai He
0 siblings, 0 replies; 6+ messages in thread
From: Shuai He @ 2020-05-29 3:42 UTC (permalink / raw)
To: dan.j.williams, vishal.l.verma, dave.jiang
Cc: linux-nvdimm, linux-kernel, Shuai He
Use kobj_to_dev() API instead of container_of().
Signed-off-by: Shuai He <hexiaoshuaishuai@gmail.com>
---
drivers/dax/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
index df238c8..24625d2 100644
--- a/drivers/dax/bus.c
+++ b/drivers/dax/bus.c
@@ -331,7 +331,7 @@ static DEVICE_ATTR_RO(numa_node);
static umode_t dev_dax_visible(struct kobject *kobj, struct attribute *a, int n)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct dev_dax *dev_dax = to_dev_dax(dev);
if (a == &dev_attr_target_node.attr && dev_dax_target_node(dev_dax) < 0)
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drivers/dax/bus: Use kobj_to_dev() API
2020-05-29 3:42 ` Shuai He
@ 2020-06-01 5:45 ` Ira Weiny
-1 siblings, 0 replies; 6+ messages in thread
From: Ira Weiny @ 2020-06-01 5:45 UTC (permalink / raw)
To: Shuai He; +Cc: linux-nvdimm, linux-kernel
On Fri, May 29, 2020 at 11:42:57AM +0800, Shuai He wrote:
> Use kobj_to_dev() API instead of container_of().
>
> Signed-off-by: Shuai He <hexiaoshuaishuai@gmail.com>
Seems reasonable:
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
> drivers/dax/bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
> index df238c8..24625d2 100644
> --- a/drivers/dax/bus.c
> +++ b/drivers/dax/bus.c
> @@ -331,7 +331,7 @@ static DEVICE_ATTR_RO(numa_node);
>
> static umode_t dev_dax_visible(struct kobject *kobj, struct attribute *a, int n)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct dev_dax *dev_dax = to_dev_dax(dev);
>
> if (a == &dev_attr_target_node.attr && dev_dax_target_node(dev_dax) < 0)
> --
> 2.7.4
> _______________________________________________
> Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
> To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drivers/dax/bus: Use kobj_to_dev() API
@ 2020-06-01 5:45 ` Ira Weiny
0 siblings, 0 replies; 6+ messages in thread
From: Ira Weiny @ 2020-06-01 5:45 UTC (permalink / raw)
To: Shuai He
Cc: dan.j.williams, vishal.l.verma, dave.jiang, linux-nvdimm, linux-kernel
On Fri, May 29, 2020 at 11:42:57AM +0800, Shuai He wrote:
> Use kobj_to_dev() API instead of container_of().
>
> Signed-off-by: Shuai He <hexiaoshuaishuai@gmail.com>
Seems reasonable:
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
> drivers/dax/bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
> index df238c8..24625d2 100644
> --- a/drivers/dax/bus.c
> +++ b/drivers/dax/bus.c
> @@ -331,7 +331,7 @@ static DEVICE_ATTR_RO(numa_node);
>
> static umode_t dev_dax_visible(struct kobject *kobj, struct attribute *a, int n)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct dev_dax *dev_dax = to_dev_dax(dev);
>
> if (a == &dev_attr_target_node.attr && dev_dax_target_node(dev_dax) < 0)
> --
> 2.7.4
> _______________________________________________
> Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
> To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/dax/bus: Use kobj_to_dev() API
2020-05-29 3:42 ` Shuai He
@ 2020-06-02 21:12 ` Pankaj Gupta
-1 siblings, 0 replies; 6+ messages in thread
From: Pankaj Gupta @ 2020-06-02 21:12 UTC (permalink / raw)
To: Shuai He; +Cc: linux-nvdimm, LKML
> Use kobj_to_dev() API instead of container_of().
>
> Signed-off-by: Shuai He <hexiaoshuaishuai@gmail.com>
> ---
> drivers/dax/bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
> index df238c8..24625d2 100644
> --- a/drivers/dax/bus.c
> +++ b/drivers/dax/bus.c
> @@ -331,7 +331,7 @@ static DEVICE_ATTR_RO(numa_node);
>
> static umode_t dev_dax_visible(struct kobject *kobj, struct attribute *a, int n)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct dev_dax *dev_dax = to_dev_dax(dev);
>
> if (a == &dev_attr_target_node.attr && dev_dax_target_node(dev_dax) < 0)
Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drivers/dax/bus: Use kobj_to_dev() API
@ 2020-06-02 21:12 ` Pankaj Gupta
0 siblings, 0 replies; 6+ messages in thread
From: Pankaj Gupta @ 2020-06-02 21:12 UTC (permalink / raw)
To: Shuai He; +Cc: Dan Williams, Vishal Verma, Dave Jiang, linux-nvdimm, LKML
> Use kobj_to_dev() API instead of container_of().
>
> Signed-off-by: Shuai He <hexiaoshuaishuai@gmail.com>
> ---
> drivers/dax/bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
> index df238c8..24625d2 100644
> --- a/drivers/dax/bus.c
> +++ b/drivers/dax/bus.c
> @@ -331,7 +331,7 @@ static DEVICE_ATTR_RO(numa_node);
>
> static umode_t dev_dax_visible(struct kobject *kobj, struct attribute *a, int n)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct dev_dax *dev_dax = to_dev_dax(dev);
>
> if (a == &dev_attr_target_node.attr && dev_dax_target_node(dev_dax) < 0)
Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-06-02 21:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-29 3:42 [PATCH] drivers/dax/bus: Use kobj_to_dev() API Shuai He
2020-05-29 3:42 ` Shuai He
2020-06-01 5:45 ` Ira Weiny
2020-06-01 5:45 ` Ira Weiny
2020-06-02 21:12 ` Pankaj Gupta
2020-06-02 21:12 ` Pankaj Gupta
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.