All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-oe][PATCH 1/2] zchunk: upgrade 1.1.5 -> 1.1.6
@ 2020-06-01 11:51 Pierre-Jean Texier
  2020-06-01 11:51 ` [meta-oe][PATCH 2/2] uriparser: upgrade 0.9.3 -> 0.9.4 Pierre-Jean Texier
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Pierre-Jean Texier @ 2020-06-01 11:51 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Pierre-Jean Texier

- Remove patches already in version

Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
---
 .../zchunk/0001-zck.h-fix-build-on-musl.patch      | 39 --------------
 .../0002-unzck-fix-build-with-musl-libc.patch      | 61 ----------------------
 .../zchunk/{zchunk_1.1.5.bb => zchunk_1.1.6.bb}    |  8 +--
 3 files changed, 2 insertions(+), 106 deletions(-)
 delete mode 100644 meta-oe/recipes-support/zchunk/zchunk/0001-zck.h-fix-build-on-musl.patch
 delete mode 100644 meta-oe/recipes-support/zchunk/zchunk/0002-unzck-fix-build-with-musl-libc.patch
 rename meta-oe/recipes-support/zchunk/{zchunk_1.1.5.bb => zchunk_1.1.6.bb} (66%)

diff --git a/meta-oe/recipes-support/zchunk/zchunk/0001-zck.h-fix-build-on-musl.patch b/meta-oe/recipes-support/zchunk/zchunk/0001-zck.h-fix-build-on-musl.patch
deleted file mode 100644
index 64e0e8e..0000000
--- a/meta-oe/recipes-support/zchunk/zchunk/0001-zck.h-fix-build-on-musl.patch
+++ /dev/null
@@ -1,39 +0,0 @@
-From 78247d478cec254bad27f4ed97b532f4f54bf1b0 Mon Sep 17 00:00:00 2001
-From: Pierre-Jean Texier <pjtexier@koncepto.io>
-Date: Thu, 23 Jan 2020 19:14:40 +0100
-Subject: [PATCH 1/2] zck.h: fix build on musl
-
-The ssize_t type requires the <sys/types.h> header. This fixes build with musl
-libc:
-
-include/zck.h:68:1: error: unknown type name 'ssize_t'; did you mean 'size_t'?
-   68 | ssize_t zck_read(zckCtx *zck, char *dst, size_t dst_size)
-      | ^~~~~~~
-      | size_t
-include/zck.h:81:1: error: unknown type name 'ssize_t'; did you mean 'size_t'?
-   81 | ssize_t zck_write(zckCtx *zck, const char *src, const size_t src_size)
-      | ^~~~~~~
-      | size_t
-      
-Upstream-Status: Submitted [https://github.com/zchunk/zchunk/pull/23]
-
-Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
----
- include/zck.h.in | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/include/zck.h.in b/include/zck.h.in
-index 91d2557..b847576 100644
---- a/include/zck.h.in
-+++ b/include/zck.h.in
-@@ -5,6 +5,7 @@
- 
- #include <stdlib.h>
- #include <stdbool.h>
-+#include <sys/types.h>
- 
- typedef enum zck_hash {
-     ZCK_HASH_SHA1,
--- 
-2.7.4
-
diff --git a/meta-oe/recipes-support/zchunk/zchunk/0002-unzck-fix-build-with-musl-libc.patch b/meta-oe/recipes-support/zchunk/zchunk/0002-unzck-fix-build-with-musl-libc.patch
deleted file mode 100644
index a1c95bf..0000000
--- a/meta-oe/recipes-support/zchunk/zchunk/0002-unzck-fix-build-with-musl-libc.patch
+++ /dev/null
@@ -1,61 +0,0 @@
-From 72c55e3da59eccdfea3778d11f83862b58af723d Mon Sep 17 00:00:00 2001
-From: Pierre-Jean Texier <pjtexier@koncepto.io>
-Date: Thu, 23 Jan 2020 22:42:40 +0100
-Subject: [PATCH 2/2] unzck: fix build with musl libc
-
-On musl libc "stdout" is a preprocessor macro whose expansion leads to
-compilation errors.
-
-Fixes:
-
-| In file included from ../git/src/unzck.c:31:
-| ../git/src/unzck.c: In function 'parse_opt':
-| ../git/src/unzck.c:78:24: error: expected identifier before '(' token
-|    78 |             arguments->stdout = true;
-|       |                        ^~~~~~
-| ../git/src/unzck.c: In function 'main':
-| ../git/src/unzck.c:141:20: error: expected identifier before '(' token
-|   141 |     if(!(arguments.stdout)) {
-|       |                    ^~~~~~
-
-Upstream-Status: Submitted [https://github.com/zchunk/zchunk/pull/23]
-
-Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
----
- src/unzck.c | 6 +++---
- 1 file changed, 3 insertions(+), 3 deletions(-)
-
-diff --git a/src/unzck.c b/src/unzck.c
-index 8d6c62a..002492c 100644
---- a/src/unzck.c
-+++ b/src/unzck.c
-@@ -58,7 +58,7 @@ struct arguments {
-   char *args[1];
-   zck_log_type log_level;
-   bool dict;
--  bool stdout;
-+  bool stdOut;
-   bool exit;
- };
- 
-@@ -75,7 +75,7 @@ static error_t parse_opt (int key, char *arg, struct argp_state *state) {
-                 arguments->log_level = ZCK_LOG_DDEBUG;
-             break;
-         case 'c':
--            arguments->stdout = true;
-+            arguments->stdOut = true;
-             break;
-         case 'V':
-             version();
-@@ -138,7 +138,7 @@ int main (int argc, char *argv[]) {
-         snprintf(out_name + strlen(base_name) - 4, 7, ".zdict");
- 
-     int dst_fd = STDOUT_FILENO;
--    if(!arguments.stdout) {
-+    if(!arguments.stdOut) {
-         dst_fd = open(out_name, O_TRUNC | O_WRONLY | O_CREAT, 0666);
-         if(dst_fd < 0) {
-             dprintf(STDERR_FILENO, "Unable to open %s", out_name);
--- 
-2.7.4
-
diff --git a/meta-oe/recipes-support/zchunk/zchunk_1.1.5.bb b/meta-oe/recipes-support/zchunk/zchunk_1.1.6.bb
similarity index 66%
rename from meta-oe/recipes-support/zchunk/zchunk_1.1.5.bb
rename to meta-oe/recipes-support/zchunk/zchunk_1.1.6.bb
index f75412f..e041132 100644
--- a/meta-oe/recipes-support/zchunk/zchunk_1.1.5.bb
+++ b/meta-oe/recipes-support/zchunk/zchunk_1.1.6.bb
@@ -4,13 +4,9 @@ AUTHOR = "Jonathan Dieter"
 LICENSE = "BSD-2-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=cd6e590282010ce90a94ef25dd31410f"
 
-SRC_URI = " \
-	git://github.com/zchunk/zchunk.git;protocol=https \
-	file://0001-zck.h-fix-build-on-musl.patch \
-	file://0002-unzck-fix-build-with-musl-libc.patch \
-	"
+SRC_URI = "git://github.com/zchunk/zchunk.git;protocol=https"
 
-SRCREV = "c01bf12feede792982f165f52f4a6c573e3a8c17"
+SRCREV = "f5593aa11584faa691c81b4898f0aaded47f8bf7"
 S = "${WORKDIR}/git"
 
 DEPENDS = "\
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [meta-oe][PATCH 2/2] uriparser: upgrade 0.9.3 -> 0.9.4
  2020-06-01 11:51 [meta-oe][PATCH 1/2] zchunk: upgrade 1.1.5 -> 1.1.6 Pierre-Jean Texier
@ 2020-06-01 11:51 ` Pierre-Jean Texier
  2020-06-14 11:41 ` [oe] [meta-oe][PATCH 1/2] zchunk: upgrade 1.1.5 -> 1.1.6 Martin Jansa
       [not found] ` <1618663E8BD13912.1568@lists.openembedded.org>
  2 siblings, 0 replies; 6+ messages in thread
From: Pierre-Jean Texier @ 2020-06-01 11:51 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Pierre-Jean Texier

License-Update: copyright years updated

Changelog:

2020-05-31 -- 0.9.4

  * Fixed: testrunner: No longer crashes when compiled with NDEBUG (GitHub #67)
  * Fixed: CMake: Support GTest 1.8.0 (GitHub #68)
      Thanks to Ryan Schmidt for the related report!
  * Fixed: CMake: Use variable GTEST_INCLUDE_DIRS (with plural "S") rather than
      GTEST_INCLUDE_DIR (GitHub #79, #81)
      Thanks to Wouter Beek for the related report!
  * Improved: CMake: Send config summary to stdout, not stderr (GitHub #72)
      Thanks to Scott Donelan for the patch!
  * Improved: Make -DURIPARSER_BUILD_TESTS=OFF unlock compilation without
      a C++ compiler; thanks to Fabrice Fontaine for the patch! (GitHub #69)
  * Added: Functions to make UriUri[AW] instances independent of the original
      URI string (GitHub #77 and #78)
      New functions:
        uriMakeOwner[AW]
        uriMakeOwnerMm[AW]
  * Added: CMake option URIPARSER_ENABLE_INSTALL to toggle installation of
      files, defaults to "ON" (GitHub #74, #75)
      Thanks to Scott Donelan for the patch!
  * Soname: 1:26:0

Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
---
 .../uriparser/{uriparser_0.9.3.bb => uriparser_0.9.4.bb}             | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
 rename meta-oe/recipes-support/uriparser/{uriparser_0.9.3.bb => uriparser_0.9.4.bb} (64%)

diff --git a/meta-oe/recipes-support/uriparser/uriparser_0.9.3.bb b/meta-oe/recipes-support/uriparser/uriparser_0.9.4.bb
similarity index 64%
rename from meta-oe/recipes-support/uriparser/uriparser_0.9.3.bb
rename to meta-oe/recipes-support/uriparser/uriparser_0.9.4.bb
index da52bb5..d02cf5d 100644
--- a/meta-oe/recipes-support/uriparser/uriparser_0.9.3.bb
+++ b/meta-oe/recipes-support/uriparser/uriparser_0.9.4.bb
@@ -2,11 +2,10 @@ SUMMARY = "RFC 3986 compliant URI parsing library"
 HOMEPAGE = "https://uriparser.github.io"
 
 LICENSE = "BSD-3-Clause"
-LIC_FILES_CHKSUM = "file://COPYING;md5=fc3bbde670fc6e95392a0e23bf57bda0"
+LIC_FILES_CHKSUM = "file://COPYING;md5=fcc5a53146c2401f4b4f6a3bdf3f0168"
 
 SRC_URI = "https://github.com/${BPN}/${BPN}/releases/download/${BP}/${BP}.tar.gz"
-SRC_URI[md5sum] = "9874b64f6f4ff656f3f69598e38f12b7"
-SRC_URI[sha256sum] = "6cef39d6eaf1a48504ee0264ce85f078758057dafb1edd0a898183b55ff76014"
+SRC_URI[sha256sum] = "095e8a358a9ccbbef9d1f10d40495ca0fcb3d4490a948ba6449b213a66e08ef0"
 
 UPSTREAM_CHECK_URI = "https://github.com/${BPN}/${BPN}/releases"
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [oe] [meta-oe][PATCH 1/2] zchunk: upgrade 1.1.5 -> 1.1.6
  2020-06-01 11:51 [meta-oe][PATCH 1/2] zchunk: upgrade 1.1.5 -> 1.1.6 Pierre-Jean Texier
  2020-06-01 11:51 ` [meta-oe][PATCH 2/2] uriparser: upgrade 0.9.3 -> 0.9.4 Pierre-Jean Texier
@ 2020-06-14 11:41 ` Martin Jansa
       [not found] ` <1618663E8BD13912.1568@lists.openembedded.org>
  2 siblings, 0 replies; 6+ messages in thread
From: Martin Jansa @ 2020-06-14 11:41 UTC (permalink / raw)
  To: Pierre-Jean Texier; +Cc: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 7665 bytes --]

The argp check added in:
https://github.com/zchunk/zchunk/commit/73f9f26d43f6786eadc49f7d43f1672e03d92b7f

fails in builds with Werror=return-type with:
Code:
 #include <argp.h>
static error_t parse_opt (int key, char *arg, struct argp_state *state) {
argp_usage(state); }; void main() {}
Compiler stdout:

Compiler stderr:
 In file included from
zchunk/1.1.6-r0/recipe-sysroot/usr/include/bits/libc-header-start.h:33,
                 from zchunk/1.1.6-r0/recipe-sysroot/usr/include/stdio.h:27,
                 from zchunk/1.1.6-r0/recipe-sysroot/usr/include/argp.h:23,
                 from
zchunk/1.1.6-r0/build/meson-private/tmpqwvjccnp/testfile.c:1:
zchunk/1.1.6-r0/recipe-sysroot/usr/include/features.h:397:4: warning:
#warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
  397 | #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)
      |    ^~~~~~~
zchunk/1.1.6-r0/build/meson-private/tmpqwvjccnp/testfile.c: In function
'parse_opt':
zchunk/1.1.6-r0/build/meson-private/tmpqwvjccnp/testfile.c:2:54: error: no
return statement in function returning non-void [-Werror=return-type]
    2 | static error_t parse_opt (int key, char *arg, struct argp_state
*state) { argp_usage(state); }; void main() {}
      |                                                      ^~~~~~~~~~
cc1: some warnings being treated as errors

and then build with glibc fails

../git/meson.build:26:4: ERROR: C library 'argp' not found

It was building fine in 1.1.5 in my world builds, because this argp check
wasn't there yet. Can you please fix it in upstream and do another upgrade?

Thanks

On Mon, Jun 1, 2020 at 1:52 PM Pierre-Jean Texier via lists.openembedded.org
<pjtexier=koncepto.io@lists.openembedded.org> wrote:

> - Remove patches already in version
>
> Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
> ---
>  .../zchunk/0001-zck.h-fix-build-on-musl.patch      | 39 --------------
>  .../0002-unzck-fix-build-with-musl-libc.patch      | 61
> ----------------------
>  .../zchunk/{zchunk_1.1.5.bb => zchunk_1.1.6.bb}    |  8 +--
>  3 files changed, 2 insertions(+), 106 deletions(-)
>  delete mode 100644
> meta-oe/recipes-support/zchunk/zchunk/0001-zck.h-fix-build-on-musl.patch
>  delete mode 100644
> meta-oe/recipes-support/zchunk/zchunk/0002-unzck-fix-build-with-musl-libc.patch
>  rename meta-oe/recipes-support/zchunk/{zchunk_1.1.5.bb => zchunk_1.1.6.bb}
> (66%)
>
> diff --git
> a/meta-oe/recipes-support/zchunk/zchunk/0001-zck.h-fix-build-on-musl.patch
> b/meta-oe/recipes-support/zchunk/zchunk/0001-zck.h-fix-build-on-musl.patch
> deleted file mode 100644
> index 64e0e8e..0000000
> ---
> a/meta-oe/recipes-support/zchunk/zchunk/0001-zck.h-fix-build-on-musl.patch
> +++ /dev/null
> @@ -1,39 +0,0 @@
> -From 78247d478cec254bad27f4ed97b532f4f54bf1b0 Mon Sep 17 00:00:00 2001
> -From: Pierre-Jean Texier <pjtexier@koncepto.io>
> -Date: Thu, 23 Jan 2020 19:14:40 +0100
> -Subject: [PATCH 1/2] zck.h: fix build on musl
> -
> -The ssize_t type requires the <sys/types.h> header. This fixes build with
> musl
> -libc:
> -
> -include/zck.h:68:1: error: unknown type name 'ssize_t'; did you mean
> 'size_t'?
> -   68 | ssize_t zck_read(zckCtx *zck, char *dst, size_t dst_size)
> -      | ^~~~~~~
> -      | size_t
> -include/zck.h:81:1: error: unknown type name 'ssize_t'; did you mean
> 'size_t'?
> -   81 | ssize_t zck_write(zckCtx *zck, const char *src, const size_t
> src_size)
> -      | ^~~~~~~
> -      | size_t
> -
> -Upstream-Status: Submitted [https://github.com/zchunk/zchunk/pull/23]
> -
> -Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
> ----
> - include/zck.h.in | 1 +
> - 1 file changed, 1 insertion(+)
> -
> -diff --git a/include/zck.h.in b/include/zck.h.in
> -index 91d2557..b847576 100644
> ---- a/include/zck.h.in
> -+++ b/include/zck.h.in
> -@@ -5,6 +5,7 @@
> -
> - #include <stdlib.h>
> - #include <stdbool.h>
> -+#include <sys/types.h>
> -
> - typedef enum zck_hash {
> -     ZCK_HASH_SHA1,
> ---
> -2.7.4
> -
> diff --git
> a/meta-oe/recipes-support/zchunk/zchunk/0002-unzck-fix-build-with-musl-libc.patch
> b/meta-oe/recipes-support/zchunk/zchunk/0002-unzck-fix-build-with-musl-libc.patch
> deleted file mode 100644
> index a1c95bf..0000000
> ---
> a/meta-oe/recipes-support/zchunk/zchunk/0002-unzck-fix-build-with-musl-libc.patch
> +++ /dev/null
> @@ -1,61 +0,0 @@
> -From 72c55e3da59eccdfea3778d11f83862b58af723d Mon Sep 17 00:00:00 2001
> -From: Pierre-Jean Texier <pjtexier@koncepto.io>
> -Date: Thu, 23 Jan 2020 22:42:40 +0100
> -Subject: [PATCH 2/2] unzck: fix build with musl libc
> -
> -On musl libc "stdout" is a preprocessor macro whose expansion leads to
> -compilation errors.
> -
> -Fixes:
> -
> -| In file included from ../git/src/unzck.c:31:
> -| ../git/src/unzck.c: In function 'parse_opt':
> -| ../git/src/unzck.c:78:24: error: expected identifier before '(' token
> -|    78 |             arguments->stdout = true;
> -|       |                        ^~~~~~
> -| ../git/src/unzck.c: In function 'main':
> -| ../git/src/unzck.c:141:20: error: expected identifier before '(' token
> -|   141 |     if(!(arguments.stdout)) {
> -|       |                    ^~~~~~
> -
> -Upstream-Status: Submitted [https://github.com/zchunk/zchunk/pull/23]
> -
> -Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
> ----
> - src/unzck.c | 6 +++---
> - 1 file changed, 3 insertions(+), 3 deletions(-)
> -
> -diff --git a/src/unzck.c b/src/unzck.c
> -index 8d6c62a..002492c 100644
> ---- a/src/unzck.c
> -+++ b/src/unzck.c
> -@@ -58,7 +58,7 @@ struct arguments {
> -   char *args[1];
> -   zck_log_type log_level;
> -   bool dict;
> --  bool stdout;
> -+  bool stdOut;
> -   bool exit;
> - };
> -
> -@@ -75,7 +75,7 @@ static error_t parse_opt (int key, char *arg, struct
> argp_state *state) {
> -                 arguments->log_level = ZCK_LOG_DDEBUG;
> -             break;
> -         case 'c':
> --            arguments->stdout = true;
> -+            arguments->stdOut = true;
> -             break;
> -         case 'V':
> -             version();
> -@@ -138,7 +138,7 @@ int main (int argc, char *argv[]) {
> -         snprintf(out_name + strlen(base_name) - 4, 7, ".zdict");
> -
> -     int dst_fd = STDOUT_FILENO;
> --    if(!arguments.stdout) {
> -+    if(!arguments.stdOut) {
> -         dst_fd = open(out_name, O_TRUNC | O_WRONLY | O_CREAT, 0666);
> -         if(dst_fd < 0) {
> -             dprintf(STDERR_FILENO, "Unable to open %s", out_name);
> ---
> -2.7.4
> -
> diff --git a/meta-oe/recipes-support/zchunk/zchunk_1.1.5.bb
> b/meta-oe/recipes-support/zchunk/zchunk_1.1.6.bb
> similarity index 66%
> rename from meta-oe/recipes-support/zchunk/zchunk_1.1.5.bb
> rename to meta-oe/recipes-support/zchunk/zchunk_1.1.6.bb
> index f75412f..e041132 100644
> --- a/meta-oe/recipes-support/zchunk/zchunk_1.1.5.bb
> +++ b/meta-oe/recipes-support/zchunk/zchunk_1.1.6.bb
> @@ -4,13 +4,9 @@ AUTHOR = "Jonathan Dieter"
>  LICENSE = "BSD-2-Clause"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=cd6e590282010ce90a94ef25dd31410f"
>
> -SRC_URI = " \
> -       git://github.com/zchunk/zchunk.git;protocol=https \
> -       file://0001-zck.h-fix-build-on-musl.patch \
> -       file://0002-unzck-fix-build-with-musl-libc.patch \
> -       "
> +SRC_URI = "git://github.com/zchunk/zchunk.git;protocol=https"
>
> -SRCREV = "c01bf12feede792982f165f52f4a6c573e3a8c17"
> +SRCREV = "f5593aa11584faa691c81b4898f0aaded47f8bf7"
>  S = "${WORKDIR}/git"
>
>  DEPENDS = "\
> --
> 2.7.4
>
> 
>

[-- Attachment #2: Type: text/html, Size: 10763 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [oe] [meta-oe][PATCH 1/2] zchunk: upgrade 1.1.5 -> 1.1.6
       [not found] ` <1618663E8BD13912.1568@lists.openembedded.org>
@ 2020-07-08  7:53   ` Martin Jansa
  2020-07-08 16:53     ` Pierre-Jean Texier
  2020-07-10  0:49     ` Khem Raj
  0 siblings, 2 replies; 6+ messages in thread
From: Martin Jansa @ 2020-07-08  7:53 UTC (permalink / raw)
  To: Martin Jansa; +Cc: Pierre-Jean Texier, openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 8127 bytes --]

Now the same upgrade was merged to dunfell, are you going to fix it?

On Sun, Jun 14, 2020 at 1:41 PM Martin Jansa via lists.openembedded.org
<Martin.Jansa=gmail.com@lists.openembedded.org> wrote:

> The argp check added in:
>
> https://github.com/zchunk/zchunk/commit/73f9f26d43f6786eadc49f7d43f1672e03d92b7f
>
> fails in builds with Werror=return-type with:
> Code:
>  #include <argp.h>
> static error_t parse_opt (int key, char *arg, struct argp_state *state) {
> argp_usage(state); }; void main() {}
> Compiler stdout:
>
> Compiler stderr:
>  In file included from
> zchunk/1.1.6-r0/recipe-sysroot/usr/include/bits/libc-header-start.h:33,
>                  from
> zchunk/1.1.6-r0/recipe-sysroot/usr/include/stdio.h:27,
>                  from zchunk/1.1.6-r0/recipe-sysroot/usr/include/argp.h:23,
>                  from
> zchunk/1.1.6-r0/build/meson-private/tmpqwvjccnp/testfile.c:1:
> zchunk/1.1.6-r0/recipe-sysroot/usr/include/features.h:397:4: warning:
> #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
>   397 | #  warning _FORTIFY_SOURCE requires compiling with optimization
> (-O)
>       |    ^~~~~~~
> zchunk/1.1.6-r0/build/meson-private/tmpqwvjccnp/testfile.c: In function
> 'parse_opt':
> zchunk/1.1.6-r0/build/meson-private/tmpqwvjccnp/testfile.c:2:54: error: no
> return statement in function returning non-void [-Werror=return-type]
>     2 | static error_t parse_opt (int key, char *arg, struct argp_state
> *state) { argp_usage(state); }; void main() {}
>       |                                                      ^~~~~~~~~~
> cc1: some warnings being treated as errors
>
> and then build with glibc fails
>
> ../git/meson.build:26:4: ERROR: C library 'argp' not found
>
> It was building fine in 1.1.5 in my world builds, because this argp check
> wasn't there yet. Can you please fix it in upstream and do another upgrade?
>
> Thanks
>
> On Mon, Jun 1, 2020 at 1:52 PM Pierre-Jean Texier via
> lists.openembedded.org <pjtexier=koncepto.io@lists.openembedded.org>
> wrote:
>
>> - Remove patches already in version
>>
>> Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
>> ---
>>  .../zchunk/0001-zck.h-fix-build-on-musl.patch      | 39 --------------
>>  .../0002-unzck-fix-build-with-musl-libc.patch      | 61
>> ----------------------
>>  .../zchunk/{zchunk_1.1.5.bb => zchunk_1.1.6.bb}    |  8 +--
>>  3 files changed, 2 insertions(+), 106 deletions(-)
>>  delete mode 100644
>> meta-oe/recipes-support/zchunk/zchunk/0001-zck.h-fix-build-on-musl.patch
>>  delete mode 100644
>> meta-oe/recipes-support/zchunk/zchunk/0002-unzck-fix-build-with-musl-libc.patch
>>  rename meta-oe/recipes-support/zchunk/{zchunk_1.1.5.bb =>
>> zchunk_1.1.6.bb} (66%)
>>
>> diff --git
>> a/meta-oe/recipes-support/zchunk/zchunk/0001-zck.h-fix-build-on-musl.patch
>> b/meta-oe/recipes-support/zchunk/zchunk/0001-zck.h-fix-build-on-musl.patch
>> deleted file mode 100644
>> index 64e0e8e..0000000
>> ---
>> a/meta-oe/recipes-support/zchunk/zchunk/0001-zck.h-fix-build-on-musl.patch
>> +++ /dev/null
>> @@ -1,39 +0,0 @@
>> -From 78247d478cec254bad27f4ed97b532f4f54bf1b0 Mon Sep 17 00:00:00 2001
>> -From: Pierre-Jean Texier <pjtexier@koncepto.io>
>> -Date: Thu, 23 Jan 2020 19:14:40 +0100
>> -Subject: [PATCH 1/2] zck.h: fix build on musl
>> -
>> -The ssize_t type requires the <sys/types.h> header. This fixes build
>> with musl
>> -libc:
>> -
>> -include/zck.h:68:1: error: unknown type name 'ssize_t'; did you mean
>> 'size_t'?
>> -   68 | ssize_t zck_read(zckCtx *zck, char *dst, size_t dst_size)
>> -      | ^~~~~~~
>> -      | size_t
>> -include/zck.h:81:1: error: unknown type name 'ssize_t'; did you mean
>> 'size_t'?
>> -   81 | ssize_t zck_write(zckCtx *zck, const char *src, const size_t
>> src_size)
>> -      | ^~~~~~~
>> -      | size_t
>> -
>> -Upstream-Status: Submitted [https://github.com/zchunk/zchunk/pull/23]
>> -
>> -Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
>> ----
>> - include/zck.h.in | 1 +
>> - 1 file changed, 1 insertion(+)
>> -
>> -diff --git a/include/zck.h.in b/include/zck.h.in
>> -index 91d2557..b847576 100644
>> ---- a/include/zck.h.in
>> -+++ b/include/zck.h.in
>> -@@ -5,6 +5,7 @@
>> -
>> - #include <stdlib.h>
>> - #include <stdbool.h>
>> -+#include <sys/types.h>
>> -
>> - typedef enum zck_hash {
>> -     ZCK_HASH_SHA1,
>> ---
>> -2.7.4
>> -
>> diff --git
>> a/meta-oe/recipes-support/zchunk/zchunk/0002-unzck-fix-build-with-musl-libc.patch
>> b/meta-oe/recipes-support/zchunk/zchunk/0002-unzck-fix-build-with-musl-libc.patch
>> deleted file mode 100644
>> index a1c95bf..0000000
>> ---
>> a/meta-oe/recipes-support/zchunk/zchunk/0002-unzck-fix-build-with-musl-libc.patch
>> +++ /dev/null
>> @@ -1,61 +0,0 @@
>> -From 72c55e3da59eccdfea3778d11f83862b58af723d Mon Sep 17 00:00:00 2001
>> -From: Pierre-Jean Texier <pjtexier@koncepto.io>
>> -Date: Thu, 23 Jan 2020 22:42:40 +0100
>> -Subject: [PATCH 2/2] unzck: fix build with musl libc
>> -
>> -On musl libc "stdout" is a preprocessor macro whose expansion leads to
>> -compilation errors.
>> -
>> -Fixes:
>> -
>> -| In file included from ../git/src/unzck.c:31:
>> -| ../git/src/unzck.c: In function 'parse_opt':
>> -| ../git/src/unzck.c:78:24: error: expected identifier before '(' token
>> -|    78 |             arguments->stdout = true;
>> -|       |                        ^~~~~~
>> -| ../git/src/unzck.c: In function 'main':
>> -| ../git/src/unzck.c:141:20: error: expected identifier before '(' token
>> -|   141 |     if(!(arguments.stdout)) {
>> -|       |                    ^~~~~~
>> -
>> -Upstream-Status: Submitted [https://github.com/zchunk/zchunk/pull/23]
>> -
>> -Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
>> ----
>> - src/unzck.c | 6 +++---
>> - 1 file changed, 3 insertions(+), 3 deletions(-)
>> -
>> -diff --git a/src/unzck.c b/src/unzck.c
>> -index 8d6c62a..002492c 100644
>> ---- a/src/unzck.c
>> -+++ b/src/unzck.c
>> -@@ -58,7 +58,7 @@ struct arguments {
>> -   char *args[1];
>> -   zck_log_type log_level;
>> -   bool dict;
>> --  bool stdout;
>> -+  bool stdOut;
>> -   bool exit;
>> - };
>> -
>> -@@ -75,7 +75,7 @@ static error_t parse_opt (int key, char *arg, struct
>> argp_state *state) {
>> -                 arguments->log_level = ZCK_LOG_DDEBUG;
>> -             break;
>> -         case 'c':
>> --            arguments->stdout = true;
>> -+            arguments->stdOut = true;
>> -             break;
>> -         case 'V':
>> -             version();
>> -@@ -138,7 +138,7 @@ int main (int argc, char *argv[]) {
>> -         snprintf(out_name + strlen(base_name) - 4, 7, ".zdict");
>> -
>> -     int dst_fd = STDOUT_FILENO;
>> --    if(!arguments.stdout) {
>> -+    if(!arguments.stdOut) {
>> -         dst_fd = open(out_name, O_TRUNC | O_WRONLY | O_CREAT, 0666);
>> -         if(dst_fd < 0) {
>> -             dprintf(STDERR_FILENO, "Unable to open %s", out_name);
>> ---
>> -2.7.4
>> -
>> diff --git a/meta-oe/recipes-support/zchunk/zchunk_1.1.5.bb
>> b/meta-oe/recipes-support/zchunk/zchunk_1.1.6.bb
>> similarity index 66%
>> rename from meta-oe/recipes-support/zchunk/zchunk_1.1.5.bb
>> rename to meta-oe/recipes-support/zchunk/zchunk_1.1.6.bb
>> index f75412f..e041132 100644
>> --- a/meta-oe/recipes-support/zchunk/zchunk_1.1.5.bb
>> +++ b/meta-oe/recipes-support/zchunk/zchunk_1.1.6.bb
>> @@ -4,13 +4,9 @@ AUTHOR = "Jonathan Dieter"
>>  LICENSE = "BSD-2-Clause"
>>  LIC_FILES_CHKSUM = "file://LICENSE;md5=cd6e590282010ce90a94ef25dd31410f"
>>
>> -SRC_URI = " \
>> -       git://github.com/zchunk/zchunk.git;protocol=https \
>> -       file://0001-zck.h-fix-build-on-musl.patch \
>> -       file://0002-unzck-fix-build-with-musl-libc.patch \
>> -       "
>> +SRC_URI = "git://github.com/zchunk/zchunk.git;protocol=https"
>>
>> -SRCREV = "c01bf12feede792982f165f52f4a6c573e3a8c17"
>> +SRCREV = "f5593aa11584faa691c81b4898f0aaded47f8bf7"
>>  S = "${WORKDIR}/git"
>>
>>  DEPENDS = "\
>> --
>> 2.7.4
>>
>>
>> 
>

[-- Attachment #2: Type: text/html, Size: 11351 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [oe] [meta-oe][PATCH 1/2] zchunk: upgrade 1.1.5 -> 1.1.6
  2020-07-08  7:53   ` Martin Jansa
@ 2020-07-08 16:53     ` Pierre-Jean Texier
  2020-07-10  0:49     ` Khem Raj
  1 sibling, 0 replies; 6+ messages in thread
From: Pierre-Jean Texier @ 2020-07-08 16:53 UTC (permalink / raw)
  To: Martin Jansa; +Cc: openembedded-devel

Hi Martin,

Le 08/07/2020 à 09:53, Martin Jansa a écrit :
> Now the same upgrade was merged to dunfell, are you going to fix it?

It seems I missed you're first e-mail, sorry about that.
On my side, I didn't see this failure during the upgrade.

I will check that.
--
Pierre-Jean Texier
Embedded Linux Engineer
https://koncepto.io

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [oe] [meta-oe][PATCH 1/2] zchunk: upgrade 1.1.5 -> 1.1.6
  2020-07-08  7:53   ` Martin Jansa
  2020-07-08 16:53     ` Pierre-Jean Texier
@ 2020-07-10  0:49     ` Khem Raj
  1 sibling, 0 replies; 6+ messages in thread
From: Khem Raj @ 2020-07-10  0:49 UTC (permalink / raw)
  To: Martin Jansa; +Cc: Pierre-Jean Texier, openembedded-devel



On 7/8/20 12:53 AM, Martin Jansa wrote:
> Now the same upgrade was merged to dunfell, are you going to fix it?
> 
> On Sun, Jun 14, 2020 at 1:41 PM Martin Jansa via lists.openembedded.org
> <http://lists.openembedded.org>
> <Martin.Jansa=gmail.com@lists.openembedded.org
> <mailto:gmail.com@lists.openembedded.org>> wrote:
> 
>     The argp check added in:
>     https://github.com/zchunk/zchunk/commit/73f9f26d43f6786eadc49f7d43f1672e03d92b7f
> 
>     fails in builds with Werror=return-type with:
>     Code:
>      #include <argp.h>
>     static error_t parse_opt (int key, char *arg, struct argp_state
>     *state) { argp_usage(state); }; void main() {}
>     Compiler stdout:
> 
>     Compiler stderr:
>      In file included from
>     zchunk/1.1.6-r0/recipe-sysroot/usr/include/bits/libc-header-start.h:33,
>                      from
>     zchunk/1.1.6-r0/recipe-sysroot/usr/include/stdio.h:27,
>                      from
>     zchunk/1.1.6-r0/recipe-sysroot/usr/include/argp.h:23,
>                      from
>     zchunk/1.1.6-r0/build/meson-private/tmpqwvjccnp/testfile.c:1:
>     zchunk/1.1.6-r0/recipe-sysroot/usr/include/features.h:397:4:
>     warning: #warning _FORTIFY_SOURCE requires compiling with
>     optimization (-O) [-Wcpp]
>       397 | #  warning _FORTIFY_SOURCE requires compiling with
>     optimization (-O)
>           |    ^~~~~~~
>     zchunk/1.1.6-r0/build/meson-private/tmpqwvjccnp/testfile.c: In
>     function 'parse_opt':
>     zchunk/1.1.6-r0/build/meson-private/tmpqwvjccnp/testfile.c:2:54:
>     error: no return statement in function returning non-void
>     [-Werror=return-type]
>         2 | static error_t parse_opt (int key, char *arg, struct
>     argp_state *state) { argp_usage(state); }; void main() {}
>           |                                                      ^~~~~~~~~~
>     cc1: some warnings being treated as errors

this is fine, but I think this warning should be enabled upstream by
default as well

> 
>     and then build with glibc fails
> 
>     ../git/meson.build:26:4: ERROR: C library 'argp' not found
> 
>     It was building fine in 1.1.5 in my world builds, because this argp
>     check wasn't there yet. Can you please fix it in upstream and do
>     another upgrade?
> 
>     Thanks
> 
>     On Mon, Jun 1, 2020 at 1:52 PM Pierre-Jean Texier via
>     lists.openembedded.org <http://lists.openembedded.org>
>     <pjtexier=koncepto.io@lists.openembedded.org
>     <mailto:koncepto.io@lists.openembedded.org>> wrote:
> 
>         - Remove patches already in version
> 
>         Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io
>         <mailto:pjtexier@koncepto.io>>
>         ---
>          .../zchunk/0001-zck.h-fix-build-on-musl.patch      | 39
>         --------------
>          .../0002-unzck-fix-build-with-musl-libc.patch      | 61
>         ----------------------
>          .../zchunk/{zchunk_1.1.5.bb <http://zchunk_1.1.5.bb> =>
>         zchunk_1.1.6.bb <http://zchunk_1.1.6.bb>}    |  8 +--
>          3 files changed, 2 insertions(+), 106 deletions(-)
>          delete mode 100644
>         meta-oe/recipes-support/zchunk/zchunk/0001-zck.h-fix-build-on-musl.patch
>          delete mode 100644
>         meta-oe/recipes-support/zchunk/zchunk/0002-unzck-fix-build-with-musl-libc.patch
>          rename meta-oe/recipes-support/zchunk/{zchunk_1.1.5.bb
>         <http://zchunk_1.1.5.bb> => zchunk_1.1.6.bb
>         <http://zchunk_1.1.6.bb>} (66%)
> 
>         diff --git
>         a/meta-oe/recipes-support/zchunk/zchunk/0001-zck.h-fix-build-on-musl.patch
>         b/meta-oe/recipes-support/zchunk/zchunk/0001-zck.h-fix-build-on-musl.patch
>         deleted file mode 100644
>         index 64e0e8e..0000000
>         ---
>         a/meta-oe/recipes-support/zchunk/zchunk/0001-zck.h-fix-build-on-musl.patch
>         +++ /dev/null
>         @@ -1,39 +0,0 @@
>         -From 78247d478cec254bad27f4ed97b532f4f54bf1b0 Mon Sep 17
>         00:00:00 2001
>         -From: Pierre-Jean Texier <pjtexier@koncepto.io
>         <mailto:pjtexier@koncepto.io>>
>         -Date: Thu, 23 Jan 2020 19:14:40 +0100
>         -Subject: [PATCH 1/2] zck.h: fix build on musl
>         -
>         -The ssize_t type requires the <sys/types.h> header. This fixes
>         build with musl
>         -libc:
>         -
>         -include/zck.h:68:1: error: unknown type name 'ssize_t'; did you
>         mean 'size_t'?
>         -   68 | ssize_t zck_read(zckCtx *zck, char *dst, size_t dst_size)
>         -      | ^~~~~~~
>         -      | size_t
>         -include/zck.h:81:1: error: unknown type name 'ssize_t'; did you
>         mean 'size_t'?
>         -   81 | ssize_t zck_write(zckCtx *zck, const char *src, const
>         size_t src_size)
>         -      | ^~~~~~~
>         -      | size_t
>         -     
>         -Upstream-Status: Submitted
>         [https://github.com/zchunk/zchunk/pull/23]
>         -
>         -Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io
>         <mailto:pjtexier@koncepto.io>>
>         ----
>         - include/zck.h.in <http://zck.h.in> | 1 +
>         - 1 file changed, 1 insertion(+)
>         -
>         -diff --git a/include/zck.h.in <http://zck.h.in>
>         b/include/zck.h.in <http://zck.h.in>
>         -index 91d2557..b847576 100644
>         ---- a/include/zck.h.in <http://zck.h.in>
>         -+++ b/include/zck.h.in <http://zck.h.in>
>         -@@ -5,6 +5,7 @@
>         -
>         - #include <stdlib.h>
>         - #include <stdbool.h>
>         -+#include <sys/types.h>
>         -
>         - typedef enum zck_hash {
>         -     ZCK_HASH_SHA1,
>         ---
>         -2.7.4
>         -
>         diff --git
>         a/meta-oe/recipes-support/zchunk/zchunk/0002-unzck-fix-build-with-musl-libc.patch
>         b/meta-oe/recipes-support/zchunk/zchunk/0002-unzck-fix-build-with-musl-libc.patch
>         deleted file mode 100644
>         index a1c95bf..0000000
>         ---
>         a/meta-oe/recipes-support/zchunk/zchunk/0002-unzck-fix-build-with-musl-libc.patch
>         +++ /dev/null
>         @@ -1,61 +0,0 @@
>         -From 72c55e3da59eccdfea3778d11f83862b58af723d Mon Sep 17
>         00:00:00 2001
>         -From: Pierre-Jean Texier <pjtexier@koncepto.io
>         <mailto:pjtexier@koncepto.io>>
>         -Date: Thu, 23 Jan 2020 22:42:40 +0100
>         -Subject: [PATCH 2/2] unzck: fix build with musl libc
>         -
>         -On musl libc "stdout" is a preprocessor macro whose expansion
>         leads to
>         -compilation errors.
>         -
>         -Fixes:
>         -
>         -| In file included from ../git/src/unzck.c:31:
>         -| ../git/src/unzck.c: In function 'parse_opt':
>         -| ../git/src/unzck.c:78:24: error: expected identifier before
>         '(' token
>         -|    78 |             arguments->stdout = true;
>         -|       |                        ^~~~~~
>         -| ../git/src/unzck.c: In function 'main':
>         -| ../git/src/unzck.c:141:20: error: expected identifier before
>         '(' token
>         -|   141 |     if(!(arguments.stdout)) {
>         -|       |                    ^~~~~~
>         -
>         -Upstream-Status: Submitted
>         [https://github.com/zchunk/zchunk/pull/23]
>         -
>         -Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io
>         <mailto:pjtexier@koncepto.io>>
>         ----
>         - src/unzck.c | 6 +++---
>         - 1 file changed, 3 insertions(+), 3 deletions(-)
>         -
>         -diff --git a/src/unzck.c b/src/unzck.c
>         -index 8d6c62a..002492c 100644
>         ---- a/src/unzck.c
>         -+++ b/src/unzck.c
>         -@@ -58,7 +58,7 @@ struct arguments {
>         -   char *args[1];
>         -   zck_log_type log_level;
>         -   bool dict;
>         --  bool stdout;
>         -+  bool stdOut;
>         -   bool exit;
>         - };
>         -
>         -@@ -75,7 +75,7 @@ static error_t parse_opt (int key, char *arg,
>         struct argp_state *state) {
>         -                 arguments->log_level = ZCK_LOG_DDEBUG;
>         -             break;
>         -         case 'c':
>         --            arguments->stdout = true;
>         -+            arguments->stdOut = true;
>         -             break;
>         -         case 'V':
>         -             version();
>         -@@ -138,7 +138,7 @@ int main (int argc, char *argv[]) {
>         -         snprintf(out_name + strlen(base_name) - 4, 7, ".zdict");
>         -
>         -     int dst_fd = STDOUT_FILENO;
>         --    if(!arguments.stdout) {
>         -+    if(!arguments.stdOut) {
>         -         dst_fd = open(out_name, O_TRUNC | O_WRONLY | O_CREAT,
>         0666);
>         -         if(dst_fd < 0) {
>         -             dprintf(STDERR_FILENO, "Unable to open %s", out_name);
>         ---
>         -2.7.4
>         -
>         diff --git a/meta-oe/recipes-support/zchunk/zchunk_1.1.5.bb
>         <http://zchunk_1.1.5.bb>
>         b/meta-oe/recipes-support/zchunk/zchunk_1.1.6.bb
>         <http://zchunk_1.1.6.bb>
>         similarity index 66%
>         rename from meta-oe/recipes-support/zchunk/zchunk_1.1.5.bb
>         <http://zchunk_1.1.5.bb>
>         rename to meta-oe/recipes-support/zchunk/zchunk_1.1.6.bb
>         <http://zchunk_1.1.6.bb>
>         index f75412f..e041132 100644
>         --- a/meta-oe/recipes-support/zchunk/zchunk_1.1.5.bb
>         <http://zchunk_1.1.5.bb>
>         +++ b/meta-oe/recipes-support/zchunk/zchunk_1.1.6.bb
>         <http://zchunk_1.1.6.bb>
>         @@ -4,13 +4,9 @@ AUTHOR = "Jonathan Dieter"
>          LICENSE = "BSD-2-Clause"
>          LIC_FILES_CHKSUM =
>         "file://LICENSE;md5=cd6e590282010ce90a94ef25dd31410f"
> 
>         -SRC_URI = " \
>         -       git://github.com/zchunk/zchunk.git;protocol=https
>         <http://github.com/zchunk/zchunk.git;protocol=https> \
>         -       file://0001-zck.h-fix-build-on-musl.patch \
>         -       file://0002-unzck-fix-build-with-musl-libc.patch \
>         -       "
>         +SRC_URI = "git://github.com/zchunk/zchunk.git;protocol=https
>         <http://github.com/zchunk/zchunk.git;protocol=https>"
> 
>         -SRCREV = "c01bf12feede792982f165f52f4a6c573e3a8c17"
>         +SRCREV = "f5593aa11584faa691c81b4898f0aaded47f8bf7"
>          S = "${WORKDIR}/git"
> 
>          DEPENDS = "\
>         -- 
>         2.7.4
> 
> 
> 
> 
> 
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-07-10  0:49 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-01 11:51 [meta-oe][PATCH 1/2] zchunk: upgrade 1.1.5 -> 1.1.6 Pierre-Jean Texier
2020-06-01 11:51 ` [meta-oe][PATCH 2/2] uriparser: upgrade 0.9.3 -> 0.9.4 Pierre-Jean Texier
2020-06-14 11:41 ` [oe] [meta-oe][PATCH 1/2] zchunk: upgrade 1.1.5 -> 1.1.6 Martin Jansa
     [not found] ` <1618663E8BD13912.1568@lists.openembedded.org>
2020-07-08  7:53   ` Martin Jansa
2020-07-08 16:53     ` Pierre-Jean Texier
2020-07-10  0:49     ` Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.