From: Sowjanya Komatineni <skomatineni@nvidia.com> To: skomatineni@nvidia.com, thierry.reding@gmail.com, jonathanh@nvidia.com, frankc@nvidia.com, hverkuil@xs4all.nl, sakari.ailus@iki.fi, robh+dt@kernel.org, helen.koike@collabora.com Cc: digetx@gmail.com, sboyd@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org Subject: [RFC PATCH v2 13/18] gpu: host1x: mipi: Update tegra_mipi_request() to be node based Date: Tue, 16 Jun 2020 18:41:29 -0700 [thread overview] Message-ID: <1592358094-23459-14-git-send-email-skomatineni@nvidia.com> (raw) In-Reply-To: <1592358094-23459-1-git-send-email-skomatineni@nvidia.com> Tegra CSI driver need a separate MIPI device for each channel as calibration of corresponding MIPI pads for each channel should happen independently. So, this patch updates tegra_mipi_request() API to add a device_node pointer argument to allow creating mipi device for specific device node rather than a device. Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> --- drivers/gpu/drm/tegra/dsi.c | 2 +- drivers/gpu/host1x/mipi.c | 7 +++++-- include/linux/host1x.h | 3 ++- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index 38beab9..0443589 100644 --- a/drivers/gpu/drm/tegra/dsi.c +++ b/drivers/gpu/drm/tegra/dsi.c @@ -1618,7 +1618,7 @@ static int tegra_dsi_probe(struct platform_device *pdev) if (IS_ERR(dsi->regs)) return PTR_ERR(dsi->regs); - dsi->mipi = tegra_mipi_request(&pdev->dev); + dsi->mipi = tegra_mipi_request(&pdev->dev, NULL); if (IS_ERR(dsi->mipi)) return PTR_ERR(dsi->mipi); diff --git a/drivers/gpu/host1x/mipi.c b/drivers/gpu/host1x/mipi.c index e00809d..93b354b 100644 --- a/drivers/gpu/host1x/mipi.c +++ b/drivers/gpu/host1x/mipi.c @@ -206,13 +206,16 @@ static int tegra_mipi_power_down(struct tegra_mipi *mipi) return 0; } -struct tegra_mipi_device *tegra_mipi_request(struct device *device) +struct tegra_mipi_device *tegra_mipi_request(struct device *device, + struct device_node *np) { - struct device_node *np = device->of_node; struct tegra_mipi_device *dev; struct of_phandle_args args; int err; + if (!np) + np = device->of_node; + err = of_parse_phandle_with_args(np, "nvidia,mipi-calibrate", "#nvidia,mipi-calibrate-cells", 0, &args); diff --git a/include/linux/host1x.h b/include/linux/host1x.h index c230b4e..61dc577 100644 --- a/include/linux/host1x.h +++ b/include/linux/host1x.h @@ -325,7 +325,8 @@ int host1x_client_resume(struct host1x_client *client); struct tegra_mipi_device; -struct tegra_mipi_device *tegra_mipi_request(struct device *device); +struct tegra_mipi_device *tegra_mipi_request(struct device *device, + struct device_node *np); void tegra_mipi_free(struct tegra_mipi_device *device); int tegra_mipi_enable(struct tegra_mipi_device *device); int tegra_mipi_disable(struct tegra_mipi_device *device); -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Sowjanya Komatineni <skomatineni@nvidia.com> To: <skomatineni@nvidia.com>, <thierry.reding@gmail.com>, <jonathanh@nvidia.com>, <frankc@nvidia.com>, <hverkuil@xs4all.nl>, <sakari.ailus@iki.fi>, <robh+dt@kernel.org>, <helen.koike@collabora.com> Cc: <digetx@gmail.com>, <sboyd@kernel.org>, <gregkh@linuxfoundation.org>, <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-i2c@vger.kernel.org> Subject: [RFC PATCH v2 13/18] gpu: host1x: mipi: Update tegra_mipi_request() to be node based Date: Tue, 16 Jun 2020 18:41:29 -0700 [thread overview] Message-ID: <1592358094-23459-14-git-send-email-skomatineni@nvidia.com> (raw) In-Reply-To: <1592358094-23459-1-git-send-email-skomatineni@nvidia.com> Tegra CSI driver need a separate MIPI device for each channel as calibration of corresponding MIPI pads for each channel should happen independently. So, this patch updates tegra_mipi_request() API to add a device_node pointer argument to allow creating mipi device for specific device node rather than a device. Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> --- drivers/gpu/drm/tegra/dsi.c | 2 +- drivers/gpu/host1x/mipi.c | 7 +++++-- include/linux/host1x.h | 3 ++- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index 38beab9..0443589 100644 --- a/drivers/gpu/drm/tegra/dsi.c +++ b/drivers/gpu/drm/tegra/dsi.c @@ -1618,7 +1618,7 @@ static int tegra_dsi_probe(struct platform_device *pdev) if (IS_ERR(dsi->regs)) return PTR_ERR(dsi->regs); - dsi->mipi = tegra_mipi_request(&pdev->dev); + dsi->mipi = tegra_mipi_request(&pdev->dev, NULL); if (IS_ERR(dsi->mipi)) return PTR_ERR(dsi->mipi); diff --git a/drivers/gpu/host1x/mipi.c b/drivers/gpu/host1x/mipi.c index e00809d..93b354b 100644 --- a/drivers/gpu/host1x/mipi.c +++ b/drivers/gpu/host1x/mipi.c @@ -206,13 +206,16 @@ static int tegra_mipi_power_down(struct tegra_mipi *mipi) return 0; } -struct tegra_mipi_device *tegra_mipi_request(struct device *device) +struct tegra_mipi_device *tegra_mipi_request(struct device *device, + struct device_node *np) { - struct device_node *np = device->of_node; struct tegra_mipi_device *dev; struct of_phandle_args args; int err; + if (!np) + np = device->of_node; + err = of_parse_phandle_with_args(np, "nvidia,mipi-calibrate", "#nvidia,mipi-calibrate-cells", 0, &args); diff --git a/include/linux/host1x.h b/include/linux/host1x.h index c230b4e..61dc577 100644 --- a/include/linux/host1x.h +++ b/include/linux/host1x.h @@ -325,7 +325,8 @@ int host1x_client_resume(struct host1x_client *client); struct tegra_mipi_device; -struct tegra_mipi_device *tegra_mipi_request(struct device *device); +struct tegra_mipi_device *tegra_mipi_request(struct device *device, + struct device_node *np); void tegra_mipi_free(struct tegra_mipi_device *device); int tegra_mipi_enable(struct tegra_mipi_device *device); int tegra_mipi_disable(struct tegra_mipi_device *device); -- 2.7.4
next prev parent reply other threads:[~2020-06-17 1:41 UTC|newest] Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-17 1:41 [RFC PATCH v2 00/18] Support for Tegra video capture from external sensor Sowjanya Komatineni 2020-06-17 1:41 ` Sowjanya Komatineni 2020-06-17 1:41 ` [RFC PATCH v2 01/18] dt-bindings: i2c: tegra: Document Tegra210 VI I2C clocks and power-domains Sowjanya Komatineni 2020-06-17 1:41 ` Sowjanya Komatineni [not found] ` <1592358094-23459-2-git-send-email-skomatineni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-07-13 23:49 ` Rob Herring 2020-07-13 23:49 ` Rob Herring 2020-06-17 1:41 ` [RFC PATCH v2 05/18] i2c: tegra: Fix runtime resume to re-init VI I2C Sowjanya Komatineni 2020-06-17 1:41 ` Sowjanya Komatineni 2020-06-17 1:41 ` [RFC PATCH v2 06/18] i2c: tegra: Avoid tegra_i2c_init_dma() for Tegra210 vi i2c Sowjanya Komatineni 2020-06-17 1:41 ` Sowjanya Komatineni 2020-06-17 1:41 ` [RFC PATCH v2 09/18] media: tegra-video: Update format lookup to offset based Sowjanya Komatineni 2020-06-17 1:41 ` Sowjanya Komatineni [not found] ` <1592358094-23459-1-git-send-email-skomatineni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-06-17 1:41 ` [RFC PATCH v2 02/18] arm64: tegra: Add missing clocks and power-domains to Tegra210 VI I2C Sowjanya Komatineni 2020-06-17 1:41 ` Sowjanya Komatineni 2020-06-17 1:41 ` [RFC PATCH v2 03/18] i2c: tegra: Don't mark VI I2C as IRQ safe runtime PM Sowjanya Komatineni 2020-06-17 1:41 ` Sowjanya Komatineni 2020-06-17 1:41 ` [RFC PATCH v2 04/18] i2c: tegra: Fix the error path in tegra_i2c_runtime_resume Sowjanya Komatineni 2020-06-17 1:41 ` Sowjanya Komatineni [not found] ` <1592358094-23459-5-git-send-email-skomatineni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-06-17 4:52 ` Dmitry Osipenko 2020-06-17 4:52 ` Dmitry Osipenko 2020-06-17 1:41 ` [RFC PATCH v2 07/18] media: tegra-video: Fix channel format alignment Sowjanya Komatineni 2020-06-17 1:41 ` Sowjanya Komatineni 2020-06-17 1:41 ` [RFC PATCH v2 08/18] media: tegra-video: Enable TPG based on kernel config Sowjanya Komatineni 2020-06-17 1:41 ` Sowjanya Komatineni 2020-06-29 9:28 ` Hans Verkuil 2020-06-29 14:48 ` Sowjanya Komatineni 2020-06-29 14:48 ` Sowjanya Komatineni 2020-06-17 1:41 ` [RFC PATCH v2 10/18] dt-bindings: tegra: Update VI and CSI bindings with port info Sowjanya Komatineni 2020-06-17 1:41 ` Sowjanya Komatineni 2020-06-17 1:41 ` [RFC PATCH v2 11/18] media: tegra-video: Add support for external sensor capture Sowjanya Komatineni 2020-06-17 1:41 ` Sowjanya Komatineni [not found] ` <1592358094-23459-12-git-send-email-skomatineni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-07-06 9:10 ` Hans Verkuil 2020-07-06 9:10 ` Hans Verkuil [not found] ` <50deca28-c198-703c-96e2-82c53f48cd65-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> 2020-07-06 16:53 ` Sowjanya Komatineni 2020-07-06 16:53 ` Sowjanya Komatineni [not found] ` <6e09f5d3-85ca-5bf9-8617-b9c8bec36615@nvidia.com> [not found] ` <6e09f5d3-85ca-5bf9-8617-b9c8bec36615-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-07-07 9:51 ` Hans Verkuil 2020-07-07 9:51 ` Hans Verkuil 2020-07-07 10:32 ` Sowjanya Komatineni 2020-07-07 10:32 ` Sowjanya Komatineni [not found] ` <6ee18b4d-b63b-8053-1b7e-c3ec7c1d4956@nvidia.com> [not found] ` <6846e5bb-db1d-c2ff-c52c-70a2094c5b50@nvidia.com> 2020-07-07 19:35 ` Hans Verkuil [not found] ` <af11cb24-57b2-7326-ca29-e168dcbb8006-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> 2020-07-07 20:29 ` Sowjanya Komatineni 2020-07-07 20:29 ` Sowjanya Komatineni [not found] ` <c08ea38f-7629-1800-fb74-a2f75daf2eb0-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-07-07 20:41 ` Sowjanya Komatineni 2020-07-07 20:41 ` Sowjanya Komatineni [not found] ` <47134481-1aec-9c1b-0ed2-8e39158d69b5-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-07-07 21:15 ` Sowjanya Komatineni 2020-07-07 21:15 ` Sowjanya Komatineni 2020-07-06 11:49 ` Hans Verkuil 2020-07-06 11:49 ` Hans Verkuil 2020-06-30 9:21 ` [RFC PATCH v2 00/18] Support for Tegra video capture from external sensor Hans Verkuil 2020-06-30 9:21 ` Hans Verkuil 2020-06-30 14:58 ` Sowjanya Komatineni 2020-06-30 14:58 ` Sowjanya Komatineni 2020-06-30 15:13 ` Hans Verkuil [not found] ` <a60d8f80-312d-fce3-61f5-328e7f2a7a64-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> 2020-06-30 15:44 ` Sowjanya Komatineni 2020-06-30 15:44 ` Sowjanya Komatineni [not found] ` <72ca3b09-7ca6-7421-4a9d-98326d1af087-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-06-30 16:17 ` Sowjanya Komatineni 2020-06-30 16:17 ` Sowjanya Komatineni [not found] ` <e8a8a678-e9e8-e941-8dcb-0e747616ba59-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-06-30 16:34 ` Sowjanya Komatineni 2020-06-30 16:34 ` Sowjanya Komatineni [not found] ` <a606ac84-e0bc-aa85-5799-eeeb544d130d-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-07-01 16:54 ` Hans Verkuil 2020-07-01 16:54 ` Hans Verkuil [not found] ` <92f25457-f4e5-78ea-d453-2b5cf8f272e8-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> 2020-07-01 17:07 ` Sowjanya Komatineni 2020-07-01 17:07 ` Sowjanya Komatineni 2020-07-02 10:49 ` Hans Verkuil 2020-07-02 14:08 ` Hans Verkuil 2020-07-02 14:08 ` Hans Verkuil [not found] ` <68d5b863-2ff1-203c-bd30-9ad0dcdf76f7-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> 2020-07-02 21:21 ` Sowjanya Komatineni 2020-07-02 21:21 ` Sowjanya Komatineni 2020-06-17 1:41 ` [RFC PATCH v2 12/18] media: tegra-video: Add support for selection ioctl ops Sowjanya Komatineni 2020-06-17 1:41 ` Sowjanya Komatineni [not found] ` <1592358094-23459-13-git-send-email-skomatineni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-07-02 13:54 ` Hans Verkuil 2020-07-02 13:54 ` Hans Verkuil [not found] ` <efc84cff-76d5-78a2-e84e-0342459d3756-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> 2020-07-02 21:20 ` Sowjanya Komatineni 2020-07-02 21:20 ` Sowjanya Komatineni 2020-07-03 8:06 ` Hans Verkuil [not found] ` <a95717b6-e2ee-78df-5145-de265805b3d4-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> 2020-07-03 17:12 ` Sowjanya Komatineni 2020-07-03 17:12 ` Sowjanya Komatineni 2020-06-17 1:41 ` Sowjanya Komatineni [this message] 2020-06-17 1:41 ` [RFC PATCH v2 13/18] gpu: host1x: mipi: Update tegra_mipi_request() to be node based Sowjanya Komatineni [not found] ` <1592358094-23459-14-git-send-email-skomatineni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-06-18 0:27 ` Dmitry Osipenko 2020-06-18 0:27 ` Dmitry Osipenko 2020-06-17 1:41 ` [RFC PATCH v2 14/18] gpu: host1x: mipi: Split tegra_mipi_calibrate and tegra_mipi_wait Sowjanya Komatineni 2020-06-17 1:41 ` Sowjanya Komatineni [not found] ` <1592358094-23459-15-git-send-email-skomatineni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2020-06-18 0:35 ` Dmitry Osipenko 2020-06-18 0:35 ` Dmitry Osipenko 2020-06-17 1:41 ` [RFC PATCH v2 15/18] media: tegra-video: Add CSI MIPI pads calibration Sowjanya Komatineni 2020-06-17 1:41 ` Sowjanya Komatineni 2020-06-17 1:41 ` [RFC PATCH v2 16/18] media: tegra-video: Compute settle times based on the clock rate Sowjanya Komatineni 2020-06-17 1:41 ` Sowjanya Komatineni 2020-06-17 1:41 ` [RFC PATCH v2 17/18] arm64: tegra: jetson-tx1: Add camera supplies Sowjanya Komatineni 2020-06-17 1:41 ` Sowjanya Komatineni 2020-06-17 1:41 ` [RFC PATCH v2 18/18] arm64: tegra: Enable Tegra VI CSI support for Jetson Nano Sowjanya Komatineni 2020-06-17 1:41 ` Sowjanya Komatineni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1592358094-23459-14-git-send-email-skomatineni@nvidia.com \ --to=skomatineni@nvidia.com \ --cc=devicetree@vger.kernel.org \ --cc=digetx@gmail.com \ --cc=frankc@nvidia.com \ --cc=gregkh@linuxfoundation.org \ --cc=helen.koike@collabora.com \ --cc=hverkuil@xs4all.nl \ --cc=jonathanh@nvidia.com \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=sakari.ailus@iki.fi \ --cc=sboyd@kernel.org \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.