All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sound: usb: quirks: add quirk for Samsung USBC Headset (AKG)
@ 2020-06-23 11:03 ` Macpaul Lin
  0 siblings, 0 replies; 4+ messages in thread
From: Macpaul Lin @ 2020-06-23 11:03 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai, Matthias Brugger, Alexander Tsoy,
	Jussi Laako, Nick Kossifidis, Dmitry Panchenko, Chris Wulff,
	Jesus Ramos, alsa-devel, linux-kernel, linux-arm-kernel,
	linux-mediatek
  Cc: Mediatek WSD Upstream, Macpaul Lin, Macpaul Lin, linux-usb,
	Chihhao Chen, stable

We've found Samsung USBC Headset (AKG) (VID: 0x04e8, PID: 0xa051)
need a tiny delay after each class compliant request.
Otherwise the device might not be able to be recognized each times.

Signed-off-by: Chihhao Chen <chihhao.chen@mediatek.com>
Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
Cc: stable@vger.kernel.org
---
 sound/usb/quirks.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index bca0179..ebba29a 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1673,6 +1673,14 @@ void snd_usb_ctl_msg_quirk(struct usb_device *dev, unsigned int pipe,
 	     chip->usb_id == USB_ID(0x0951, 0x16ad)) &&
 	    (requesttype & USB_TYPE_MASK) == USB_TYPE_CLASS)
 		usleep_range(1000, 2000);
+
+	/*
+	 * Samsung USBC Headset (AKG) need a tiny delay after each
+	 * class compliant request. (Model number: AAM625R or AAM627R)
+	 */
+	if (chip->usb_id == USB_ID(0x04e8, 0xa051) &&
+	    (requesttype & USB_TYPE_MASK) == USB_TYPE_CLASS)
+		usleep_range(5000, 6000);
 }
 
 /*
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] sound: usb: quirks: add quirk for Samsung USBC Headset (AKG)
@ 2020-06-23 11:03 ` Macpaul Lin
  0 siblings, 0 replies; 4+ messages in thread
From: Macpaul Lin @ 2020-06-23 11:03 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai, Matthias Brugger, Alexander Tsoy,
	Jussi Laako, Nick Kossifidis, Dmitry Panchenko, Chris Wulff,
	Jesus Ramos, alsa-devel, linux-kernel, linux-arm-kernel,
	linux-mediatek
  Cc: Mediatek WSD Upstream, linux-usb, stable, Chihhao Chen,
	Macpaul Lin, Macpaul Lin

We've found Samsung USBC Headset (AKG) (VID: 0x04e8, PID: 0xa051)
need a tiny delay after each class compliant request.
Otherwise the device might not be able to be recognized each times.

Signed-off-by: Chihhao Chen <chihhao.chen@mediatek.com>
Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
Cc: stable@vger.kernel.org
---
 sound/usb/quirks.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index bca0179..ebba29a 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1673,6 +1673,14 @@ void snd_usb_ctl_msg_quirk(struct usb_device *dev, unsigned int pipe,
 	     chip->usb_id == USB_ID(0x0951, 0x16ad)) &&
 	    (requesttype & USB_TYPE_MASK) == USB_TYPE_CLASS)
 		usleep_range(1000, 2000);
+
+	/*
+	 * Samsung USBC Headset (AKG) need a tiny delay after each
+	 * class compliant request. (Model number: AAM625R or AAM627R)
+	 */
+	if (chip->usb_id == USB_ID(0x04e8, 0xa051) &&
+	    (requesttype & USB_TYPE_MASK) == USB_TYPE_CLASS)
+		usleep_range(5000, 6000);
 }
 
 /*
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] sound: usb: quirks: add quirk for Samsung USBC Headset (AKG)
  2020-06-23 11:03 ` Macpaul Lin
@ 2020-06-23 14:14   ` Takashi Iwai
  -1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2020-06-23 14:14 UTC (permalink / raw)
  To: Macpaul Lin
  Cc: Jaroslav Kysela, Takashi Iwai, Matthias Brugger, Alexander Tsoy,
	Jussi Laako, Nick Kossifidis, Dmitry Panchenko, Chris Wulff,
	Jesus Ramos, alsa-devel, linux-kernel, linux-arm-kernel,
	linux-mediatek, Mediatek WSD Upstream, linux-usb, stable,
	Chihhao Chen, Macpaul Lin

On Tue, 23 Jun 2020 13:03:23 +0200,
Macpaul Lin wrote:
> 
> We've found Samsung USBC Headset (AKG) (VID: 0x04e8, PID: 0xa051)
> need a tiny delay after each class compliant request.
> Otherwise the device might not be able to be recognized each times.
> 
> Signed-off-by: Chihhao Chen <chihhao.chen@mediatek.com>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> Cc: stable@vger.kernel.org

Thanks, applied.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] sound: usb: quirks: add quirk for Samsung USBC Headset (AKG)
@ 2020-06-23 14:14   ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2020-06-23 14:14 UTC (permalink / raw)
  To: Macpaul Lin
  Cc: Jussi Laako, linux-usb, Mediatek WSD Upstream, alsa-devel,
	linux-kernel, Chris Wulff, Takashi Iwai, stable, Chihhao Chen,
	Alexander Tsoy, linux-mediatek, Nick Kossifidis, Jesus Ramos,
	Matthias Brugger, Macpaul Lin, Dmitry Panchenko,
	linux-arm-kernel

On Tue, 23 Jun 2020 13:03:23 +0200,
Macpaul Lin wrote:
> 
> We've found Samsung USBC Headset (AKG) (VID: 0x04e8, PID: 0xa051)
> need a tiny delay after each class compliant request.
> Otherwise the device might not be able to be recognized each times.
> 
> Signed-off-by: Chihhao Chen <chihhao.chen@mediatek.com>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> Cc: stable@vger.kernel.org

Thanks, applied.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-23 14:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-23 11:03 [PATCH] sound: usb: quirks: add quirk for Samsung USBC Headset (AKG) Macpaul Lin
2020-06-23 11:03 ` Macpaul Lin
2020-06-23 14:14 ` Takashi Iwai
2020-06-23 14:14   ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.