* [PATCH] scripts/simplebench: compare write request performance
@ 2020-06-24 5:45 Andrey Shinkevich
2020-06-25 11:32 ` Andrey Shinkevich
0 siblings, 1 reply; 2+ messages in thread
From: Andrey Shinkevich @ 2020-06-24 5:45 UTC (permalink / raw)
To: qemu-block; +Cc: kwolf, vsementsov, qemu-devel, mreitz, andrey.shinkevich, den
The script 'bench_write_req.py' allows comparing performances of write
request for two qemu-img binary files.
Suggested-by: Denis V. Lunev <den@openvz.org>
Suggested-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
---
scripts/simplebench/bench_write_req.py | 150 +++++++++++++++++++++++++++++++++
1 file changed, 150 insertions(+)
create mode 100755 scripts/simplebench/bench_write_req.py
diff --git a/scripts/simplebench/bench_write_req.py b/scripts/simplebench/bench_write_req.py
new file mode 100755
index 0000000..e127dcc
--- /dev/null
+++ b/scripts/simplebench/bench_write_req.py
@@ -0,0 +1,150 @@
+#!/usr/bin/env python3
+#
+# Test to compare performance of write requests for two qemu-img binary files.
+#
+# Copyright (c) 2020 Virtuozzo International GmbH.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+#
+
+
+import sys
+import os
+import subprocess
+import simplebench
+
+
+def bench_func(env, case):
+ """ Handle one "cell" of benchmarking table. """
+ return bench_write_req(env['qemu_img'], env['image_name'],
+ case['block_size'], case['block_offset'],
+ case['requests'])
+
+
+def qemu_img_pipe(*args):
+ '''Run qemu-img and return its output'''
+ subp = subprocess.Popen(list(args),
+ stdout=subprocess.PIPE,
+ stderr=subprocess.STDOUT,
+ universal_newlines=True)
+ exitcode = subp.wait()
+ if exitcode < 0:
+ sys.stderr.write('qemu-img received signal %i: %s\n'
+ % (-exitcode, ' '.join(list(args))))
+ return subp.communicate()[0]
+
+
+def bench_write_req(qemu_img, image_name, block_size, block_offset, requests):
+ """Benchmark write requests
+
+ qemu_img -- path to qemu_img executable file
+ image_name -- QCOW2 image name to create
+ block_size -- size of a block to write to clusters
+ block_offset -- offset of the block in clusters
+
+ Returns {'seconds': int} on success and {'error': str} on failure.
+ Return value is compatible with simplebench lib.
+ """
+
+ if not os.path.isfile(qemu_img):
+ print('File not found: {}'.format(qemu_img))
+ sys.exit(1)
+
+ image_dir = os.path.dirname(os.path.abspath(image_name))
+ if not os.path.isdir(image_dir):
+ print('Path not found: {}'.format(image_name))
+ sys.exit(1)
+
+ cluster_size = 1024 * 1024
+ image_size = 1024 * cluster_size
+ count = requests * int(image_size / cluster_size)
+ image_size = str(image_size)
+
+ args_create = [qemu_img, 'create', '-f', 'qcow2', '-o',
+ 'cluster_size={}'.format(cluster_size),
+ image_name, image_size]
+
+ cluster_size = str(cluster_size)
+ offset = str(block_offset)
+ size = str(block_size)
+ cnt = str(count)
+ args_bench = [qemu_img, 'bench', '-c', cnt, '-w', '-t', 'none', '-s', size,
+ '-S', cluster_size, '-o', offset, '-f', 'qcow2', image_name]
+
+ try:
+ qemu_img_pipe(*args_create)
+ except OSError as e:
+ return {'error': 'qemu_img create failed: ' + str(e)}
+
+ try:
+ ret = qemu_img_pipe(*args_bench)
+ except OSError as e:
+ return {'error': 'qemu_img bench failed: ' + str(e)}
+ finally:
+ os.remove(image_name)
+ if not ret:
+ return {'error': 'qemu_img bench failed'}
+ if 'seconds' in ret:
+ ret = ret.split()
+ index = ret.index('seconds.')
+ return {'seconds': float(ret[index-1])}
+ else:
+ return {'error': 'qemu_img bench failed: ' + ret}
+
+
+if __name__ == '__main__':
+
+ if len(sys.argv) < 4:
+ print('USAGE: {} <path to qemu-img binary file> '
+ '<path to another qemu-img to compare performance with> '
+ '<full or relative name for 10G QCOW2 image to create>'
+ ''.format(os.path.basename(sys.argv[0])))
+ exit(1)
+
+ # Test-cases are "rows" in benchmark resulting table, 'id' is a caption
+ # for the row, other fields are handled by bench_func.
+ test_cases = [
+ {
+ 'id': '<cluster middle>',
+ 'block_size': 4096,
+ 'block_offset': 524288,
+ 'requests': 100
+ },
+ {
+ 'id': '<cluster overlap>',
+ 'block_size': 524288,
+ 'block_offset': 4096,
+ 'requests': 10
+ },
+ ]
+
+ # Test-envs are "columns" in benchmark resulting table, 'id is a caption
+ # for the column, other fields are handled by bench_func.
+ # Set the paths below to desired values
+ test_envs = [
+ {
+ 'id': '<qemu-img binary 1>',
+ 'qemu_img': '{}'.format(sys.argv[1]),
+ 'image_name': '{}'.format(sys.argv[3])
+ },
+ {
+ 'id': '<qemu-img binary 2>',
+ 'qemu_img': '{}'.format(sys.argv[2]),
+ 'image_name': '{}'.format(sys.argv[3])
+ },
+ ]
+
+ result = simplebench.bench(bench_func, test_envs, test_cases, count=3,
+ initial_run=False)
+ print(simplebench.ascii(result))
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scripts/simplebench: compare write request performance
2020-06-24 5:45 [PATCH] scripts/simplebench: compare write request performance Andrey Shinkevich
@ 2020-06-25 11:32 ` Andrey Shinkevich
0 siblings, 0 replies; 2+ messages in thread
From: Andrey Shinkevich @ 2020-06-25 11:32 UTC (permalink / raw)
To: qemu-block; +Cc: kwolf, vsementsov, qemu-devel, mreitz, den
[-- Attachment #1: Type: text/plain, Size: 4110 bytes --]
On 24.06.2020 08:45, Andrey Shinkevich wrote:
> The script 'bench_write_req.py' allows comparing performances of write
> request for two qemu-img binary files.
>
> Suggested-by: Denis V. Lunev <den@openvz.org>
> Suggested-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
> ---
> scripts/simplebench/bench_write_req.py | 150 +++++++++++++++++++++++++++++++++
> 1 file changed, 150 insertions(+)
> create mode 100755 scripts/simplebench/bench_write_req.py
>
> diff --git a/scripts/simplebench/bench_write_req.py b/scripts/simplebench/bench_write_req.py
> new file mode 100755
> index 0000000..e127dcc
> --- /dev/null
> +++ b/scripts/simplebench/bench_write_req.py
> @@ -0,0 +1,150 @@
> +#!/usr/bin/env python3
...
> + # Test-cases are "rows" in benchmark resulting table, 'id' is a caption
> + # for the row, other fields are handled by bench_func.
> + test_cases = [
> + {
> + 'id': '<cluster middle>',
> + 'block_size': 4096,
> + 'block_offset': 524288,
> + 'requests': 100
s/100/10/
> + },
> + {
> + 'id': '<cluster overlap>',
> + 'block_size': 524288,
> + 'block_offset': 4096,
> + 'requests': 10
s/10/2/
> + },
> + ]
I reduced the number of requests per the test case to make the script
runtime more reasonable for HDD device and got the following results:
qemu-img1 is the current version of QEMU
qemu-img2 is the current version but without the feature "[PATCH v14
1/1] qcow2: skip writing zero buffers to empty COW areas" (git commit
ID: c8bb23cbdbe32f5)
SSD:
$ time ./scripts/simplebench/bench_write_req.py ./qemu-img1 ./qemu-img2
image.qcow2
Testing 1/4: <qemu-img binary 1> :: <cluster middle>
#run 1
{'seconds': 0.377}
#run 2
{'seconds': 0.382}
#run 3
{'seconds': 0.376}
Testing 2/4: <qemu-img binary 1> :: <cluster overlap>
#run 1
{'seconds': 6.836}
#run 2
{'seconds': 8.513}
#run 3
{'seconds': 6.843}
Testing 3/4: <qemu-img binary 2> :: <cluster middle>
#run 1
{'seconds': 11.46}
#run 2
{'seconds': 8.734}
#run 3
{'seconds': 8.579}
Testing 4/4: <qemu-img binary 2> :: <cluster overlap>
#run 1
{'seconds': 11.848}
#run 2
{'seconds': 17.8}
#run 3
{'seconds': 19.822}
Done
----------------- ------------------- -------------------
<qemu-img binary 1> <qemu-img binary 2>
<cluster middle> 0.38 +- 0.00 9.59 +- 1.87
<cluster overlap> 7.40 +- 1.12 16.49 +- 4.64
----------------- ------------------- -------------------
real 1m43.769s
user 0m1.881s
sys 0m4.677s
HDD:
$ sudo time ./scripts/simplebench/bench_write_req.py ./qemu-img1
./qemu-img2 /vz/tmp/image.qcow2
Testing 1/4: <qemu-img binary 1> :: <cluster middle>
#run 1
{'seconds': 54.738}
#run 2
{'seconds': 57.049}
#run 3
{'seconds': 58.199}
Testing 2/4: <qemu-img binary 1> :: <cluster overlap>
#run 1
{'seconds': 12.846}
#run 2
{'seconds': 11.015}
#run 3
{'seconds': 11.11}
Testing 3/4: <qemu-img binary 2> :: <cluster middle>
#run 1
{'seconds': 53.969}
#run 2
{'seconds': 58.22}
#run 3
{'seconds': 61.413}
Testing 4/4: <qemu-img binary 2> :: <cluster overlap>
#run 1
{'seconds': 15.702}
#run 2
{'seconds': 12.627}
#run 3
{'seconds': 11.879}
Done
----------------- ------------------- -------------------
<qemu-img binary 1> <qemu-img binary 2>
<cluster middle> 56.66 +- 1.92 57.87 +- 3.90
<cluster overlap> 11.66 +- 1.19 13.40 +- 2.30
----------------- ------------------- -------------------
3.31user 7.93system 7:03.13elapsed 2%CPU (0avgtext+0avgdata
78280maxresident)k
50240inputs+22659372outputs (0major+965543minor)pagefaults 0swaps
Andrey
[-- Attachment #2: Type: text/html, Size: 7830 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-25 11:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-24 5:45 [PATCH] scripts/simplebench: compare write request performance Andrey Shinkevich
2020-06-25 11:32 ` Andrey Shinkevich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.