From: Fenghua Yu <fenghua.yu@intel.com> To: "Thomas Gleixner" <tglx@linutronix.de>, "Joerg Roedel" <joro@8bytes.org>, "Ingo Molnar" <mingo@redhat.com>, "Borislav Petkov" <bp@alien8.de>, "Peter Zijlstra" <peterz@infradead.org>, "H Peter Anvin" <hpa@zytor.com>, "David Woodhouse" <dwmw2@infradead.org>, "Lu Baolu" <baolu.lu@linux.intel.com>, "Dave Hansen" <dave.hansen@intel.com>, "Tony Luck" <tony.luck@intel.com>, "Jean-Philippe Brucker" <jean-philippe@linaro.org>, "Christoph Hellwig" <hch@infradeed.org>, "Ashok Raj" <ashok.raj@intel.com>, "Jacob Jun Pan" <jacob.jun.pan@intel.com>, "Dave Jiang" <dave.jiang@intel.com>, "Sohil Mehta" <sohil.mehta@intel.com>, "Ravi V Shankar" <ravi.v.shankar@intel.com> Cc: "linux-kernel" <linux-kernel@vger.kernel.org>, "x86" <x86@kernel.org>, iommu@lists.linux-foundation.org, Fenghua Yu <fenghua.yu@intel.com> Subject: [PATCH v4 02/12] iommu/vt-d: Change flags type to unsigned int in binding mm Date: Thu, 25 Jun 2020 13:17:12 -0700 [thread overview] Message-ID: <1593116242-31507-3-git-send-email-fenghua.yu@intel.com> (raw) In-Reply-To: <1593116242-31507-1-git-send-email-fenghua.yu@intel.com> "flags" passed to intel_svm_bind_mm() is a bit mask and should be defined as "unsigned int" instead of "int". Change its type to "unsigned int". Suggested-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com> Reviewed-by: Tony Luck <tony.luck@intel.com> --- v2: - Add this new patch per Thomas' comment. drivers/iommu/intel/svm.c | 7 ++++--- include/linux/intel-iommu.h | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c index 778089d198eb..8a0cf2f0dd54 100644 --- a/drivers/iommu/intel/svm.c +++ b/drivers/iommu/intel/svm.c @@ -427,7 +427,8 @@ int intel_svm_unbind_gpasid(struct device *dev, u32 pasid) /* Caller must hold pasid_mutex, mm reference */ static int -intel_svm_bind_mm(struct device *dev, int flags, struct svm_dev_ops *ops, +intel_svm_bind_mm(struct device *dev, unsigned int flags, + struct svm_dev_ops *ops, struct mm_struct *mm, struct intel_svm_dev **sd) { struct intel_iommu *iommu = intel_svm_device_to_iommu(dev); @@ -954,7 +955,7 @@ intel_svm_bind(struct device *dev, struct mm_struct *mm, void *drvdata) { struct iommu_sva *sva = ERR_PTR(-EINVAL); struct intel_svm_dev *sdev = NULL; - int flags = 0; + unsigned int flags = 0; int ret; /* @@ -963,7 +964,7 @@ intel_svm_bind(struct device *dev, struct mm_struct *mm, void *drvdata) * and intel_svm etc. */ if (drvdata) - flags = *(int *)drvdata; + flags = *(unsigned int *)drvdata; mutex_lock(&pasid_mutex); ret = intel_svm_bind_mm(dev, flags, NULL, mm, &sdev); if (ret) diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h index 314a95870e47..4d20f93a5e2d 100644 --- a/include/linux/intel-iommu.h +++ b/include/linux/intel-iommu.h @@ -759,7 +759,7 @@ struct intel_svm { struct mm_struct *mm; struct intel_iommu *iommu; - int flags; + unsigned int flags; u32 pasid; int gpasid; /* In case that guest PASID is different from host PASID */ struct list_head devs; -- 2.19.1
WARNING: multiple messages have this Message-ID (diff)
From: Fenghua Yu <fenghua.yu@intel.com> To: "Thomas Gleixner" <tglx@linutronix.de>, "Joerg Roedel" <joro@8bytes.org>, "Ingo Molnar" <mingo@redhat.com>, "Borislav Petkov" <bp@alien8.de>, "Peter Zijlstra" <peterz@infradead.org>, "H Peter Anvin" <hpa@zytor.com>, "David Woodhouse" <dwmw2@infradead.org>, "Lu Baolu" <baolu.lu@linux.intel.com>, "Dave Hansen" <dave.hansen@intel.com>, "Tony Luck" <tony.luck@intel.com>, "Jean-Philippe Brucker" <jean-philippe@linaro.org>, "Christoph Hellwig" <hch@infradeed.org>, "Ashok Raj" <ashok.raj@intel.com>, "Jacob Jun Pan" <jacob.jun.pan@intel.com>, "Dave Jiang" <dave.jiang@intel.com>, "Sohil Mehta" <sohil.mehta@intel.com>, "Ravi V Shankar" <ravi.v.shankar@intel.com> Cc: Fenghua Yu <fenghua.yu@intel.com>, iommu@lists.linux-foundation.org, x86 <x86@kernel.org>, linux-kernel <linux-kernel@vger.kernel.org> Subject: [PATCH v4 02/12] iommu/vt-d: Change flags type to unsigned int in binding mm Date: Thu, 25 Jun 2020 13:17:12 -0700 [thread overview] Message-ID: <1593116242-31507-3-git-send-email-fenghua.yu@intel.com> (raw) In-Reply-To: <1593116242-31507-1-git-send-email-fenghua.yu@intel.com> "flags" passed to intel_svm_bind_mm() is a bit mask and should be defined as "unsigned int" instead of "int". Change its type to "unsigned int". Suggested-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com> Reviewed-by: Tony Luck <tony.luck@intel.com> --- v2: - Add this new patch per Thomas' comment. drivers/iommu/intel/svm.c | 7 ++++--- include/linux/intel-iommu.h | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c index 778089d198eb..8a0cf2f0dd54 100644 --- a/drivers/iommu/intel/svm.c +++ b/drivers/iommu/intel/svm.c @@ -427,7 +427,8 @@ int intel_svm_unbind_gpasid(struct device *dev, u32 pasid) /* Caller must hold pasid_mutex, mm reference */ static int -intel_svm_bind_mm(struct device *dev, int flags, struct svm_dev_ops *ops, +intel_svm_bind_mm(struct device *dev, unsigned int flags, + struct svm_dev_ops *ops, struct mm_struct *mm, struct intel_svm_dev **sd) { struct intel_iommu *iommu = intel_svm_device_to_iommu(dev); @@ -954,7 +955,7 @@ intel_svm_bind(struct device *dev, struct mm_struct *mm, void *drvdata) { struct iommu_sva *sva = ERR_PTR(-EINVAL); struct intel_svm_dev *sdev = NULL; - int flags = 0; + unsigned int flags = 0; int ret; /* @@ -963,7 +964,7 @@ intel_svm_bind(struct device *dev, struct mm_struct *mm, void *drvdata) * and intel_svm etc. */ if (drvdata) - flags = *(int *)drvdata; + flags = *(unsigned int *)drvdata; mutex_lock(&pasid_mutex); ret = intel_svm_bind_mm(dev, flags, NULL, mm, &sdev); if (ret) diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h index 314a95870e47..4d20f93a5e2d 100644 --- a/include/linux/intel-iommu.h +++ b/include/linux/intel-iommu.h @@ -759,7 +759,7 @@ struct intel_svm { struct mm_struct *mm; struct intel_iommu *iommu; - int flags; + unsigned int flags; u32 pasid; int gpasid; /* In case that guest PASID is different from host PASID */ struct list_head devs; -- 2.19.1 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-06-25 20:18 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-25 20:17 [PATCH v4 00/12] x86: tag application address space for devices Fenghua Yu 2020-06-25 20:17 ` Fenghua Yu 2020-06-25 20:17 ` [PATCH v4 01/12] iommu: Change type of pasid to u32 Fenghua Yu 2020-06-25 20:17 ` Fenghua Yu 2020-06-26 1:13 ` Lu Baolu 2020-06-26 1:13 ` Lu Baolu 2020-06-25 20:17 ` Fenghua Yu [this message] 2020-06-25 20:17 ` [PATCH v4 02/12] iommu/vt-d: Change flags type to unsigned int in binding mm Fenghua Yu 2020-06-26 1:14 ` Lu Baolu 2020-06-26 1:14 ` Lu Baolu 2020-06-25 20:17 ` [PATCH v4 03/12] docs: x86: Add documentation for SVA (Shared Virtual Addressing) Fenghua Yu 2020-06-25 20:17 ` Fenghua Yu 2020-06-25 20:17 ` [PATCH v4 04/12] x86/cpufeatures: Enumerate ENQCMD and ENQCMDS instructions Fenghua Yu 2020-06-25 20:17 ` Fenghua Yu 2020-06-25 20:17 ` [PATCH v4 05/12] x86/fpu/xstate: Add supervisor PASID state for ENQCMD feature Fenghua Yu 2020-06-25 20:17 ` Fenghua Yu 2020-06-25 20:17 ` [PATCH v4 06/12] x86/msr-index: Define IA32_PASID MSR Fenghua Yu 2020-06-25 20:17 ` Fenghua Yu 2020-06-25 20:17 ` [PATCH v4 07/12] mm: Define pasid in mm Fenghua Yu 2020-06-25 20:17 ` Fenghua Yu 2020-06-25 20:17 ` [PATCH v4 08/12] fork: Clear PASID for new mm Fenghua Yu 2020-06-25 20:17 ` Fenghua Yu 2020-06-25 20:17 ` [PATCH v4 09/12] x86/process: Clear PASID state for a newly forked/cloned thread Fenghua Yu 2020-06-25 20:17 ` Fenghua Yu 2020-06-25 20:17 ` [PATCH v4 10/12] x86/mmu: Allocate/free PASID Fenghua Yu 2020-06-25 20:17 ` Fenghua Yu 2020-06-26 1:42 ` Lu Baolu 2020-06-26 1:42 ` Lu Baolu 2020-06-25 20:17 ` [PATCH v4 11/12] sched: Define and initialize a flag to identify valid PASID in the task Fenghua Yu 2020-06-25 20:17 ` Fenghua Yu 2020-06-25 20:17 ` [PATCH v4 12/12] x86/traps: Fix up invalid PASID Fenghua Yu 2020-06-25 20:17 ` Fenghua Yu 2020-06-26 1:46 ` Lu Baolu 2020-06-26 1:46 ` Lu Baolu 2020-06-26 9:44 ` Peter Zijlstra 2020-06-26 9:44 ` Peter Zijlstra 2020-06-26 18:10 ` Luck, Tony 2020-06-26 18:10 ` Luck, Tony 2020-06-26 18:15 ` Borislav Petkov 2020-06-26 18:15 ` Borislav Petkov 2020-06-26 18:23 ` Dave Hansen 2020-06-26 18:23 ` Dave Hansen 2020-06-26 18:35 ` Fenghua Yu 2020-06-26 18:35 ` Fenghua Yu 2020-06-26 18:16 ` Fenghua Yu 2020-06-26 18:16 ` Fenghua Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1593116242-31507-3-git-send-email-fenghua.yu@intel.com \ --to=fenghua.yu@intel.com \ --cc=ashok.raj@intel.com \ --cc=baolu.lu@linux.intel.com \ --cc=bp@alien8.de \ --cc=dave.hansen@intel.com \ --cc=dave.jiang@intel.com \ --cc=dwmw2@infradead.org \ --cc=hch@infradeed.org \ --cc=hpa@zytor.com \ --cc=iommu@lists.linux-foundation.org \ --cc=jacob.jun.pan@intel.com \ --cc=jean-philippe@linaro.org \ --cc=joro@8bytes.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=ravi.v.shankar@intel.com \ --cc=sohil.mehta@intel.com \ --cc=tglx@linutronix.de \ --cc=tony.luck@intel.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.