Re: [PATCH v12 00/31] Speculative page faults

From: Chinwen Chang <chinwen.chang@mediatek.com>
To: Laurent Dufour <ldufour@linux.ibm.com>
Cc: Haiyan Song <haiyanx.song@intel.com>, <akpm@linux-foundation.org>,
	<mhocko@kernel.org>, <peterz@infradead.org>,
	<kirill@shutemov.name>, <ak@linux.intel.com>, <dave@stgolabs.net>,
	<jack@suse.cz>, Matthew Wilcox <willy@infradead.org>,
	<aneesh.kumar@linux.ibm.com>, <benh@kernel.crashing.org>,
	<mpe@ellerman.id.au>, <paulus@samba.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, <hpa@zytor.com>,
	Will Deacon <will.deacon@arm.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	<sergey.senozhatsky.work@gmail.com>,
	"Andrea Arcangeli" <aarcange@redhat.com>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	<kemi.wang@intel.com>, Daniel Jordan <daniel.m.jordan@oracle.com>,
	David Rientjes <rientjes@google.com>,
	"Jerome Glisse" <jglisse@redhat.com>,
	Ganesh Mahendran <opensource.ganesh@gmail.com>,
	Minchan Kim <minchan@kernel.org>,
	"Punit Agrawal" <punitagrawal@gmail.com>,
	vinayak menon <vinayakm.list@gmail.com>,
	Yang Shi <yang.shi@linux.alibaba.com>,
	zhong jiang <zhongjiang@huawei.com>,
	Balbir Singh <bsingharora@gmail.com>, <sj38.park@gmail.com>,
	"Michel Lespinasse" <walken@google.com>,
	Mike Rapoport <rppt@linux.ibm.com>,
	<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
	<haren@linux.vnet.ibm.com>, <npiggin@gmail.com>,
	<paulmck@linux.vnet.ibm.com>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	<linuxppc-dev@lists.ozlabs.org>, <x86@kernel.org>,
	<miles.chen@mediatek.com>
Subject: Re: [PATCH v12 00/31] Speculative page faults
Date: Tue, 7 Jul 2020 13:31:37 +0800	[thread overview]
Message-ID: <1594099897.30360.58.camel@mtkswgap22> (raw)
In-Reply-To: <490c0811-50cd-0802-2cbc-9c031ef309f6@linux.ibm.com>

On Mon, 2020-07-06 at 14:27 +0200, Laurent Dufour wrote:
> Le 06/07/2020 à 11:25, Chinwen Chang a écrit :
> > On Thu, 2019-06-20 at 16:19 +0800, Haiyan Song wrote:
> >> Hi Laurent,
> >>
> >> I downloaded your script and run it on Intel 2s skylake platform with spf-v12 patch
> >> serials.
> >>
> >> Here attached the output results of this script.
> >>
> >> The following comparison result is statistics from the script outputs.
> >>
> >> a). Enable THP
> >>                                              SPF_0          change       SPF_1
> >> will-it-scale.page_fault2.per_thread_ops    2664190.8      -11.7%       2353637.6
> >> will-it-scale.page_fault3.per_thread_ops    4480027.2      -14.7%       3819331.9
> >>
> >>
> >> b). Disable THP
> >>                                              SPF_0           change      SPF_1
> >> will-it-scale.page_fault2.per_thread_ops    2653260.7       -10%        2385165.8
> >> will-it-scale.page_fault3.per_thread_ops    4436330.1       -12.4%      3886734.2
> >>
> >>
> >> Thanks,
> >> Haiyan Song
> >>
> >>
> >> On Fri, Jun 14, 2019 at 10:44:47AM +0200, Laurent Dufour wrote:
> >>> Le 14/06/2019 à 10:37, Laurent Dufour a écrit :
> >>>> Please find attached the script I run to get these numbers.
> >>>> This would be nice if you could give it a try on your victim node and share the result.
> >>>
> >>> Sounds that the Intel mail fitering system doesn't like the attached shell script.
> >>> Please find it there: https://urldefense.com/v3/__https://gist.github.com/ldu4/a5cc1a93f293108ea387d43d5d5e7f44__;!!CTRNKA9wMg0ARbw!0lux2FMCbIFxFEl824CdSuSQqT0IVWsvyUqfDVJNEVb9gTWyRltm7cpPZg70N_XhXmMZ$ 
> >>>
> >>> Thanks,
> >>> Laurent.
> >>>
> > 
> > Hi Laurent,
> > 
> > We merged SPF v11 and some patches from v12 into our platforms. After
> > several experiments, we observed SPF has obvious improvements on the
> > launch time of applications, especially for those high-TLP ones,
> > 
> > # launch time of applications(s):
> > 
> > package           version      w/ SPF      w/o SPF      improve(%)
> > ------------------------------------------------------------------
> > Baidu maps        10.13.3      0.887       0.98         9.49
> > Taobao            8.4.0.35     1.227       1.293        5.10
> > Meituan           9.12.401     1.107       1.543        28.26
> > WeChat            7.0.3        2.353       2.68         12.20
> > Honor of Kings    1.43.1.6     6.63        6.713        1.24
> 
> That's great news, thanks for reporting this!
> 
> > 
> > By the way, we have verified our platforms with those patches and
> > achieved the goal of mass production.
> 
> Another good news!
> For my information, what is your targeted hardware?
> 
> Cheers,
> Laurent.

Hi Laurent,

Our targeted hardware belongs to ARM64 multi-core series.

Thanks.
Chinwen
> 