All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/display: Fix initial fb to use resource_size_t
@ 2020-07-07 17:15 Chris Wilson
  2020-07-07 17:34 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 10+ messages in thread
From: Chris Wilson @ 2020-07-07 17:15 UTC (permalink / raw)
  To: intel-gfx; +Cc: Matthew Auld, Chris Wilson

We lookup up the physical address of the inherited framebuffer, and
presume that is an offset into the stolen memory region. As we are
dealing with physical resources and their addresses, we need to use
resource_size_t and not assume everything fits within a plain u32 [based
on prior assumptions that we were simpling handling offsets into the
GGTT not physical memory].

We made the switch to using resource_size_t for stolen in commit
b7128ef125b4 ("drm/i915: prefer resource_size_t for everything stolen")

Reported-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
References: b7128ef125b4 ("drm/i915: prefer resource_size_t for everything stolen")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index dff7c17f3d2b..6bfe3148f927 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -3409,7 +3409,8 @@ initial_plane_vma(struct drm_i915_private *i915,
 {
 	struct drm_i915_gem_object *obj;
 	struct i915_vma *vma;
-	u32 base, size;
+	resource_size_t base;
+	resource_size_t size;
 
 	if (plane_config->size == 0)
 		return NULL;
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-07-07 22:17 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-07 17:15 [Intel-gfx] [PATCH] drm/i915/display: Fix initial fb to use resource_size_t Chris Wilson
2020-07-07 17:34 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-07-07 17:48 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
2020-07-07 18:00   ` Chris Wilson
2020-07-07 17:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-07-07 18:09 ` [Intel-gfx] [PATCH v2] " Chris Wilson
2020-07-07 18:27 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Fix initial fb to use resource_size_t (rev2) Patchwork
2020-07-07 18:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-07-07 22:10 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix initial fb to use resource_size_t Patchwork
2020-07-07 22:17 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix initial fb to use resource_size_t (rev2) Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.