From: Lu Wei <luwei32@huawei.com> To: <alex.hung@canonical.com>, <dvhart@infradead.org>, <andy@infradead.org>, <platform-driver-x86@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <acelan.kao@canonical.com>, <andy.shevchenko@gmail.com>, <luwei32@huawei.com> Subject: [PATCH v3 0/2] Fix return value check Date: Fri, 10 Jul 2020 17:30:16 +0800 [thread overview] Message-ID: <1594373418-24833-1-git-send-email-luwei32@huawei.com> (raw) In the function check_acpi_dev(), if it fails to create platform device, the return value is ERR_PTR() or NULL. Thus it must use IS_ERR_OR_NULL to check return value. --- v2->v3 - Modify format v3->v4 - Change commit number to 12 characters Lu Wei (2): intel-hid: Fix return value check in check_acpi_dev() intel-vbtn: Fix return value check in check_acpi_dev() drivers/platform/x86/intel-hid.c | 2 +- drivers/platform/x86/intel-vbtn.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Lu Wei <luwei32@huawei.com> To: alex.hung@canonical.com, dvhart@infradead.org, andy@infradead.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, acelan.kao@canonical.com, andy.shevchenko@gmail.com, luwei32@huawei.com Subject: [PATCH v3 0/2] Fix return value check Date: Fri, 10 Jul 2020 17:30:16 +0800 [thread overview] Message-ID: <1594373418-24833-1-git-send-email-luwei32@huawei.com> (raw) In the function check_acpi_dev(), if it fails to create platform device, the return value is ERR_PTR() or NULL. Thus it must use IS_ERR_OR_NULL to check return value. --- v2->v3 - Modify format v3->v4 - Change commit number to 12 characters Lu Wei (2): intel-hid: Fix return value check in check_acpi_dev() intel-vbtn: Fix return value check in check_acpi_dev() drivers/platform/x86/intel-hid.c | 2 +- drivers/platform/x86/intel-vbtn.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.7.4
next reply other threads:[~2020-07-10 9:28 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-10 9:30 Lu Wei [this message] 2020-07-10 9:30 ` [PATCH v3 0/2] Fix return value check Lu Wei 2020-07-10 9:30 ` [PATCH v3 1/2] intel-hid: Fix return value check in check_acpi_dev() Lu Wei 2020-07-10 9:30 ` Lu Wei 2020-07-10 9:30 ` [PATCH v3 2/2] intel-vbtn: " Lu Wei 2020-07-10 9:30 ` Lu Wei 2020-07-10 20:37 ` [PATCH v3 0/2] Fix return value check Andy Shevchenko -- strict thread matches above, loose matches on Subject: below -- 2020-07-10 9:04 Lu Wei 2020-07-10 9:04 ` Lu Wei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1594373418-24833-1-git-send-email-luwei32@huawei.com \ --to=luwei32@huawei.com \ --cc=acelan.kao@canonical.com \ --cc=alex.hung@canonical.com \ --cc=andy.shevchenko@gmail.com \ --cc=andy@infradead.org \ --cc=dvhart@infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=platform-driver-x86@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.