From: Stanley Chu <stanley.chu@mediatek.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: <linux-scsi@vger.kernel.org>, <martin.petersen@oracle.com>,
<avri.altman@wdc.com>, <alim.akhtar@samsung.com>,
<jejb@linux.ibm.com>, <beanhuo@micron.com>, <cang@codeaurora.org>,
<satyat@google.com>, <matthias.bgg@gmail.com>,
<linux-mediatek@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-fscrypt@vger.kernel.org>,
<kuohong.wang@mediatek.com>, <peter.wang@mediatek.com>,
<chun-hung.wu@mediatek.com>, <andy.teng@mediatek.com>,
<light.hsieh@mediatek.com>
Subject: Re: [RFC PATCH v2] scsi: ufs-mediatek: add inline encryption support
Date: Sun, 12 Jul 2020 08:34:45 +0800 [thread overview]
Message-ID: <1594514085.10600.5.camel@mtkswgap22> (raw)
In-Reply-To: <20200710063920.GD2805@sol.localdomain>
Hi Eric,
On Thu, 2020-07-09 at 23:39 -0700, Eric Biggers wrote:
> Hi Stanley,
>
> On Wed, Mar 04, 2020 at 10:21:02AM +0800, Stanley Chu wrote:
> > Add inline encryption support to ufs-mediatek.
> >
> > The standards-compliant parts, such as querying the crypto capabilities
> > and enabling crypto for individual UFS requests, are already handled by
> > ufshcd-crypto.c, which itself is wired into the blk-crypto framework.
> >
> > However MediaTek UFS host requires a vendor-specific hce_enable operation
> > to allow crypto-related registers being accessed normally in kernel.
> > After this step, MediaTek UFS host can work as standard-compliant host
> > for inline-encryption related functions.
> >
> > This patch is rebased to below repo and tag:
> > Repo: https://urldefense.com/v3/__https://git.kernel.org/pub/scm/fs/fscrypt/fscrypt.git__;!!CTRNKA9wMg0ARbw!x8Kltcu8AQhdtlIDXASWjd_ANrBtcYzidIXMsu-fQloEqgvrDDBU9yD9GumtKLIcd_c$
> > Tag: inline-encryption-v7
> >
> > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> > ---
> > drivers/scsi/ufs/ufs-mediatek.c | 27 ++++++++++++++++++++++++++-
> > drivers/scsi/ufs/ufs-mediatek.h | 1 +
> > 2 files changed, 27 insertions(+), 1 deletion(-)
>
> Now that the ufshcd-crypto patches this depends on are in 5.9/scsi-queue, could
> you retest and resend this patch? It would be nice to have 5.9 support some
> real hardware already. (I'm going to resend my patchset for ufs-qcom too.)
Sure. Now this patch is resent as v3, please see
https://patchwork.kernel.org/patch/11657987/
Thanks,
Stanley Chu
WARNING: multiple messages have this Message-ID (diff)
From: Stanley Chu <stanley.chu@mediatek.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
andy.teng@mediatek.com, jejb@linux.ibm.com,
chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com,
linux-kernel@vger.kernel.org, light.hsieh@mediatek.com,
satyat@google.com, avri.altman@wdc.com,
linux-fscrypt@vger.kernel.org, cang@codeaurora.org,
linux-mediatek@lists.infradead.org, peter.wang@mediatek.com,
alim.akhtar@samsung.com, matthias.bgg@gmail.com,
linux-arm-kernel@lists.infradead.org, beanhuo@micron.com
Subject: Re: [RFC PATCH v2] scsi: ufs-mediatek: add inline encryption support
Date: Sun, 12 Jul 2020 08:34:45 +0800 [thread overview]
Message-ID: <1594514085.10600.5.camel@mtkswgap22> (raw)
In-Reply-To: <20200710063920.GD2805@sol.localdomain>
Hi Eric,
On Thu, 2020-07-09 at 23:39 -0700, Eric Biggers wrote:
> Hi Stanley,
>
> On Wed, Mar 04, 2020 at 10:21:02AM +0800, Stanley Chu wrote:
> > Add inline encryption support to ufs-mediatek.
> >
> > The standards-compliant parts, such as querying the crypto capabilities
> > and enabling crypto for individual UFS requests, are already handled by
> > ufshcd-crypto.c, which itself is wired into the blk-crypto framework.
> >
> > However MediaTek UFS host requires a vendor-specific hce_enable operation
> > to allow crypto-related registers being accessed normally in kernel.
> > After this step, MediaTek UFS host can work as standard-compliant host
> > for inline-encryption related functions.
> >
> > This patch is rebased to below repo and tag:
> > Repo: https://urldefense.com/v3/__https://git.kernel.org/pub/scm/fs/fscrypt/fscrypt.git__;!!CTRNKA9wMg0ARbw!x8Kltcu8AQhdtlIDXASWjd_ANrBtcYzidIXMsu-fQloEqgvrDDBU9yD9GumtKLIcd_c$
> > Tag: inline-encryption-v7
> >
> > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> > ---
> > drivers/scsi/ufs/ufs-mediatek.c | 27 ++++++++++++++++++++++++++-
> > drivers/scsi/ufs/ufs-mediatek.h | 1 +
> > 2 files changed, 27 insertions(+), 1 deletion(-)
>
> Now that the ufshcd-crypto patches this depends on are in 5.9/scsi-queue, could
> you retest and resend this patch? It would be nice to have 5.9 support some
> real hardware already. (I'm going to resend my patchset for ufs-qcom too.)
Sure. Now this patch is resent as v3, please see
https://patchwork.kernel.org/patch/11657987/
Thanks,
Stanley Chu
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Stanley Chu <stanley.chu@mediatek.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
andy.teng@mediatek.com, jejb@linux.ibm.com,
chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com,
linux-kernel@vger.kernel.org, light.hsieh@mediatek.com,
satyat@google.com, avri.altman@wdc.com,
linux-fscrypt@vger.kernel.org, cang@codeaurora.org,
linux-mediatek@lists.infradead.org, peter.wang@mediatek.com,
alim.akhtar@samsung.com, matthias.bgg@gmail.com,
linux-arm-kernel@lists.infradead.org, beanhuo@micron.com
Subject: Re: [RFC PATCH v2] scsi: ufs-mediatek: add inline encryption support
Date: Sun, 12 Jul 2020 08:34:45 +0800 [thread overview]
Message-ID: <1594514085.10600.5.camel@mtkswgap22> (raw)
In-Reply-To: <20200710063920.GD2805@sol.localdomain>
Hi Eric,
On Thu, 2020-07-09 at 23:39 -0700, Eric Biggers wrote:
> Hi Stanley,
>
> On Wed, Mar 04, 2020 at 10:21:02AM +0800, Stanley Chu wrote:
> > Add inline encryption support to ufs-mediatek.
> >
> > The standards-compliant parts, such as querying the crypto capabilities
> > and enabling crypto for individual UFS requests, are already handled by
> > ufshcd-crypto.c, which itself is wired into the blk-crypto framework.
> >
> > However MediaTek UFS host requires a vendor-specific hce_enable operation
> > to allow crypto-related registers being accessed normally in kernel.
> > After this step, MediaTek UFS host can work as standard-compliant host
> > for inline-encryption related functions.
> >
> > This patch is rebased to below repo and tag:
> > Repo: https://urldefense.com/v3/__https://git.kernel.org/pub/scm/fs/fscrypt/fscrypt.git__;!!CTRNKA9wMg0ARbw!x8Kltcu8AQhdtlIDXASWjd_ANrBtcYzidIXMsu-fQloEqgvrDDBU9yD9GumtKLIcd_c$
> > Tag: inline-encryption-v7
> >
> > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> > ---
> > drivers/scsi/ufs/ufs-mediatek.c | 27 ++++++++++++++++++++++++++-
> > drivers/scsi/ufs/ufs-mediatek.h | 1 +
> > 2 files changed, 27 insertions(+), 1 deletion(-)
>
> Now that the ufshcd-crypto patches this depends on are in 5.9/scsi-queue, could
> you retest and resend this patch? It would be nice to have 5.9 support some
> real hardware already. (I'm going to resend my patchset for ufs-qcom too.)
Sure. Now this patch is resent as v3, please see
https://patchwork.kernel.org/patch/11657987/
Thanks,
Stanley Chu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-12 0:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 2:21 [RFC PATCH v2] scsi: ufs-mediatek: add inline encryption support Stanley Chu
2020-03-04 2:21 ` Stanley Chu
2020-03-04 2:21 ` Stanley Chu
2020-07-10 6:39 ` Eric Biggers
2020-07-10 6:39 ` Eric Biggers
2020-07-10 6:39 ` Eric Biggers
2020-07-12 0:34 ` Stanley Chu [this message]
2020-07-12 0:34 ` Stanley Chu
2020-07-12 0:34 ` Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1594514085.10600.5.camel@mtkswgap22 \
--to=stanley.chu@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cang@codeaurora.org \
--cc=chun-hung.wu@mediatek.com \
--cc=ebiggers@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=kuohong.wang@mediatek.com \
--cc=light.hsieh@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.