From: Liu Yi L <yi.l.liu@intel.com> To: alex.williamson@redhat.com, eric.auger@redhat.com, baolu.lu@linux.intel.com, joro@8bytes.org Cc: kevin.tian@intel.com, jacob.jun.pan@linux.intel.com, ashok.raj@intel.com, yi.l.liu@intel.com, jun.j.tian@intel.com, yi.y.sun@intel.com, jean-philippe@linaro.org, peterx@redhat.com, hao.wu@intel.com, stefanha@gmail.com, iommu@lists.linux-foundation.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 08/15] iommu: Pass domain to sva_unbind_gpasid() Date: Sun, 12 Jul 2020 04:21:03 -0700 [thread overview] Message-ID: <1594552870-55687-9-git-send-email-yi.l.liu@intel.com> (raw) In-Reply-To: <1594552870-55687-1-git-send-email-yi.l.liu@intel.com> From: Yi Sun <yi.y.sun@intel.com> Current interface is good enough for SVA virtualization on an assigned physical PCI device, but when it comes to mediated devices, a physical device may attached with multiple aux-domains. Also, for guest unbind, the PASID to be unbind should be allocated to the VM. This check requires to know the ioasid_set which is associated with the domain. So this interface needs to pass in domain info. Then the iommu driver is able to know which domain will be used for the 2nd stage translation of the nesting mode and also be able to do PASID ownership check. This patch passes @domain per the above reason. Cc: Kevin Tian <kevin.tian@intel.com> CC: Jacob Pan <jacob.jun.pan@linux.intel.com> Cc: Alex Williamson <alex.williamson@redhat.com> Cc: Eric Auger <eric.auger@redhat.com> Cc: Jean-Philippe Brucker <jean-philippe@linaro.org> Cc: Joerg Roedel <joro@8bytes.org> Cc: Lu Baolu <baolu.lu@linux.intel.com> Signed-off-by: Yi Sun <yi.y.sun@intel.com> Signed-off-by: Liu Yi L <yi.l.liu@intel.com> --- v2 -> v3: *) pass in domain info only *) use ioasid_t for pasid instead of int type v1 -> v2: *) added in v2. --- drivers/iommu/intel/svm.c | 3 ++- drivers/iommu/iommu.c | 2 +- include/linux/intel-iommu.h | 3 ++- include/linux/iommu.h | 3 ++- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c index b9a9c55..d2c0e1a 100644 --- a/drivers/iommu/intel/svm.c +++ b/drivers/iommu/intel/svm.c @@ -432,7 +432,8 @@ int intel_svm_bind_gpasid(struct iommu_domain *domain, struct device *dev, return ret; } -int intel_svm_unbind_gpasid(struct device *dev, int pasid) +int intel_svm_unbind_gpasid(struct iommu_domain *domain, + struct device *dev, ioasid_t pasid) { struct intel_iommu *iommu = intel_svm_device_to_iommu(dev); struct intel_svm_dev *sdev; diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 7910249..d3e554c 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -2151,7 +2151,7 @@ int __iommu_sva_unbind_gpasid(struct iommu_domain *domain, struct device *dev, if (unlikely(!domain->ops->sva_unbind_gpasid)) return -ENODEV; - return domain->ops->sva_unbind_gpasid(dev, data->hpasid); + return domain->ops->sva_unbind_gpasid(domain, dev, data->hpasid); } EXPORT_SYMBOL_GPL(__iommu_sva_unbind_gpasid); diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h index 0d0ab32..18f292e 100644 --- a/include/linux/intel-iommu.h +++ b/include/linux/intel-iommu.h @@ -738,7 +738,8 @@ extern int intel_svm_enable_prq(struct intel_iommu *iommu); extern int intel_svm_finish_prq(struct intel_iommu *iommu); int intel_svm_bind_gpasid(struct iommu_domain *domain, struct device *dev, struct iommu_gpasid_bind_data *data); -int intel_svm_unbind_gpasid(struct device *dev, int pasid); +int intel_svm_unbind_gpasid(struct iommu_domain *domain, + struct device *dev, ioasid_t pasid); struct iommu_sva *intel_svm_bind(struct device *dev, struct mm_struct *mm, void *drvdata); void intel_svm_unbind(struct iommu_sva *handle); diff --git a/include/linux/iommu.h b/include/linux/iommu.h index e84a1d5..ca5edd8 100644 --- a/include/linux/iommu.h +++ b/include/linux/iommu.h @@ -303,7 +303,8 @@ struct iommu_ops { int (*sva_bind_gpasid)(struct iommu_domain *domain, struct device *dev, struct iommu_gpasid_bind_data *data); - int (*sva_unbind_gpasid)(struct device *dev, int pasid); + int (*sva_unbind_gpasid)(struct iommu_domain *domain, + struct device *dev, ioasid_t pasid); int (*def_domain_type)(struct device *dev); -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Liu Yi L <yi.l.liu@intel.com> To: alex.williamson@redhat.com, eric.auger@redhat.com, baolu.lu@linux.intel.com, joro@8bytes.org Cc: jean-philippe@linaro.org, kevin.tian@intel.com, ashok.raj@intel.com, kvm@vger.kernel.org, stefanha@gmail.com, jun.j.tian@intel.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, yi.y.sun@intel.com, hao.wu@intel.com Subject: [PATCH v5 08/15] iommu: Pass domain to sva_unbind_gpasid() Date: Sun, 12 Jul 2020 04:21:03 -0700 [thread overview] Message-ID: <1594552870-55687-9-git-send-email-yi.l.liu@intel.com> (raw) In-Reply-To: <1594552870-55687-1-git-send-email-yi.l.liu@intel.com> From: Yi Sun <yi.y.sun@intel.com> Current interface is good enough for SVA virtualization on an assigned physical PCI device, but when it comes to mediated devices, a physical device may attached with multiple aux-domains. Also, for guest unbind, the PASID to be unbind should be allocated to the VM. This check requires to know the ioasid_set which is associated with the domain. So this interface needs to pass in domain info. Then the iommu driver is able to know which domain will be used for the 2nd stage translation of the nesting mode and also be able to do PASID ownership check. This patch passes @domain per the above reason. Cc: Kevin Tian <kevin.tian@intel.com> CC: Jacob Pan <jacob.jun.pan@linux.intel.com> Cc: Alex Williamson <alex.williamson@redhat.com> Cc: Eric Auger <eric.auger@redhat.com> Cc: Jean-Philippe Brucker <jean-philippe@linaro.org> Cc: Joerg Roedel <joro@8bytes.org> Cc: Lu Baolu <baolu.lu@linux.intel.com> Signed-off-by: Yi Sun <yi.y.sun@intel.com> Signed-off-by: Liu Yi L <yi.l.liu@intel.com> --- v2 -> v3: *) pass in domain info only *) use ioasid_t for pasid instead of int type v1 -> v2: *) added in v2. --- drivers/iommu/intel/svm.c | 3 ++- drivers/iommu/iommu.c | 2 +- include/linux/intel-iommu.h | 3 ++- include/linux/iommu.h | 3 ++- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c index b9a9c55..d2c0e1a 100644 --- a/drivers/iommu/intel/svm.c +++ b/drivers/iommu/intel/svm.c @@ -432,7 +432,8 @@ int intel_svm_bind_gpasid(struct iommu_domain *domain, struct device *dev, return ret; } -int intel_svm_unbind_gpasid(struct device *dev, int pasid) +int intel_svm_unbind_gpasid(struct iommu_domain *domain, + struct device *dev, ioasid_t pasid) { struct intel_iommu *iommu = intel_svm_device_to_iommu(dev); struct intel_svm_dev *sdev; diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 7910249..d3e554c 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -2151,7 +2151,7 @@ int __iommu_sva_unbind_gpasid(struct iommu_domain *domain, struct device *dev, if (unlikely(!domain->ops->sva_unbind_gpasid)) return -ENODEV; - return domain->ops->sva_unbind_gpasid(dev, data->hpasid); + return domain->ops->sva_unbind_gpasid(domain, dev, data->hpasid); } EXPORT_SYMBOL_GPL(__iommu_sva_unbind_gpasid); diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h index 0d0ab32..18f292e 100644 --- a/include/linux/intel-iommu.h +++ b/include/linux/intel-iommu.h @@ -738,7 +738,8 @@ extern int intel_svm_enable_prq(struct intel_iommu *iommu); extern int intel_svm_finish_prq(struct intel_iommu *iommu); int intel_svm_bind_gpasid(struct iommu_domain *domain, struct device *dev, struct iommu_gpasid_bind_data *data); -int intel_svm_unbind_gpasid(struct device *dev, int pasid); +int intel_svm_unbind_gpasid(struct iommu_domain *domain, + struct device *dev, ioasid_t pasid); struct iommu_sva *intel_svm_bind(struct device *dev, struct mm_struct *mm, void *drvdata); void intel_svm_unbind(struct iommu_sva *handle); diff --git a/include/linux/iommu.h b/include/linux/iommu.h index e84a1d5..ca5edd8 100644 --- a/include/linux/iommu.h +++ b/include/linux/iommu.h @@ -303,7 +303,8 @@ struct iommu_ops { int (*sva_bind_gpasid)(struct iommu_domain *domain, struct device *dev, struct iommu_gpasid_bind_data *data); - int (*sva_unbind_gpasid)(struct device *dev, int pasid); + int (*sva_unbind_gpasid)(struct iommu_domain *domain, + struct device *dev, ioasid_t pasid); int (*def_domain_type)(struct device *dev); -- 2.7.4 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-07-12 11:14 UTC|newest] Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-12 11:20 [PATCH v5 00/15] vfio: expose virtual Shared Virtual Addressing to VMs Liu Yi L 2020-07-12 11:20 ` Liu Yi L 2020-07-12 11:20 ` [PATCH v5 01/15] vfio/type1: Refactor vfio_iommu_type1_ioctl() Liu Yi L 2020-07-12 11:20 ` Liu Yi L 2020-07-12 11:20 ` [PATCH v5 02/15] iommu: Report domain nesting info Liu Yi L 2020-07-12 11:20 ` Liu Yi L 2020-07-17 16:29 ` Auger Eric 2020-07-17 16:29 ` Auger Eric 2020-07-20 7:20 ` Liu, Yi L 2020-07-20 7:20 ` Liu, Yi L 2020-07-12 11:20 ` [PATCH v5 03/15] iommu/smmu: Report empty " Liu Yi L 2020-07-12 11:20 ` Liu Yi L 2020-07-13 13:14 ` Will Deacon 2020-07-13 13:14 ` Will Deacon 2020-07-14 10:12 ` Liu, Yi L 2020-07-14 10:12 ` Liu, Yi L 2020-07-16 15:39 ` Jean-Philippe Brucker 2020-07-16 15:39 ` Jean-Philippe Brucker 2020-07-16 20:38 ` Auger Eric 2020-07-16 20:38 ` Auger Eric 2020-07-17 9:09 ` Jean-Philippe Brucker 2020-07-17 9:09 ` Jean-Philippe Brucker 2020-07-17 10:28 ` Auger Eric 2020-07-17 10:28 ` Auger Eric 2020-07-23 9:44 ` Liu, Yi L 2020-07-23 9:44 ` Liu, Yi L 2020-07-23 9:40 ` Liu, Yi L 2020-07-23 9:40 ` Liu, Yi L 2020-07-17 17:18 ` Auger Eric 2020-07-17 17:18 ` Auger Eric 2020-07-20 7:26 ` Liu, Yi L 2020-07-20 7:26 ` Liu, Yi L 2020-07-12 11:20 ` [PATCH v5 04/15] vfio/type1: Report iommu nesting info to userspace Liu Yi L 2020-07-12 11:20 ` Liu Yi L 2020-07-17 17:34 ` Auger Eric 2020-07-17 17:34 ` Auger Eric 2020-07-20 7:51 ` Liu, Yi L 2020-07-20 7:51 ` Liu, Yi L 2020-07-20 8:33 ` Auger Eric 2020-07-20 8:33 ` Auger Eric 2020-07-20 8:51 ` Liu, Yi L 2020-07-20 8:51 ` Liu, Yi L 2020-07-12 11:21 ` [PATCH v5 05/15] vfio: Add PASID allocation/free support Liu Yi L 2020-07-12 11:21 ` Liu Yi L 2020-07-19 15:38 ` Auger Eric 2020-07-19 15:38 ` Auger Eric 2020-07-20 8:03 ` Liu, Yi L 2020-07-20 8:03 ` Liu, Yi L 2020-07-20 8:26 ` Auger Eric 2020-07-20 8:26 ` Auger Eric 2020-07-20 8:49 ` Liu, Yi L 2020-07-20 8:49 ` Liu, Yi L 2020-07-12 11:21 ` [PATCH v5 06/15] iommu/vt-d: Support setting ioasid set to domain Liu Yi L 2020-07-12 11:21 ` Liu Yi L 2020-07-19 15:38 ` Auger Eric 2020-07-19 15:38 ` Auger Eric 2020-07-20 8:11 ` Liu, Yi L 2020-07-20 8:11 ` Liu, Yi L 2020-07-12 11:21 ` [PATCH v5 07/15] vfio/type1: Add VFIO_IOMMU_PASID_REQUEST (alloc/free) Liu Yi L 2020-07-12 11:21 ` Liu Yi L 2020-07-19 15:38 ` Auger Eric 2020-07-19 15:38 ` Auger Eric 2020-07-20 8:56 ` Liu, Yi L 2020-07-20 8:56 ` Liu, Yi L 2020-07-12 11:21 ` Liu Yi L [this message] 2020-07-12 11:21 ` [PATCH v5 08/15] iommu: Pass domain to sva_unbind_gpasid() Liu Yi L 2020-07-19 15:37 ` Auger Eric 2020-07-19 15:37 ` Auger Eric 2020-07-20 9:06 ` Liu, Yi L 2020-07-20 9:06 ` Liu, Yi L 2020-07-12 11:21 ` [PATCH v5 09/15] iommu/vt-d: Check ownership for PASIDs from user-space Liu Yi L 2020-07-12 11:21 ` Liu Yi L 2020-07-19 16:06 ` Auger Eric 2020-07-19 16:06 ` Auger Eric 2020-07-20 10:18 ` Liu, Yi L 2020-07-20 10:18 ` Liu, Yi L 2020-07-20 12:37 ` Auger Eric 2020-07-20 12:37 ` Auger Eric 2020-07-20 12:55 ` Liu, Yi L 2020-07-20 12:55 ` Liu, Yi L 2020-07-12 11:21 ` [PATCH v5 10/15] vfio/type1: Support binding guest page tables to PASID Liu Yi L 2020-07-12 11:21 ` Liu Yi L 2020-07-20 9:37 ` Auger Eric 2020-07-20 9:37 ` Auger Eric 2020-07-20 10:37 ` Liu, Yi L 2020-07-20 10:37 ` Liu, Yi L 2020-07-12 11:21 ` [PATCH v5 11/15] vfio/type1: Allow invalidating first-level/stage IOMMU cache Liu Yi L 2020-07-12 11:21 ` Liu Yi L 2020-07-20 9:41 ` Auger Eric 2020-07-20 9:41 ` Auger Eric 2020-07-20 10:42 ` Liu, Yi L 2020-07-20 10:42 ` Liu, Yi L 2020-07-12 11:21 ` [PATCH v5 12/15] vfio/type1: Add vSVA support for IOMMU-backed mdevs Liu Yi L 2020-07-12 11:21 ` Liu Yi L 2020-07-20 12:22 ` Auger Eric 2020-07-20 12:22 ` Auger Eric 2020-07-23 12:05 ` Liu, Yi L 2020-07-23 12:05 ` Liu, Yi L 2020-07-12 11:21 ` [PATCH v5 13/15] vfio/pci: Expose PCIe PASID capability to guest Liu Yi L 2020-07-12 11:21 ` Liu Yi L 2020-07-20 12:35 ` Auger Eric 2020-07-20 12:35 ` Auger Eric 2020-07-20 13:00 ` Liu, Yi L 2020-07-20 13:00 ` Liu, Yi L 2020-07-12 11:21 ` [PATCH v5 14/15] vfio: Document dual stage control Liu Yi L 2020-07-12 11:21 ` Liu Yi L 2020-07-18 13:39 ` Auger Eric 2020-07-18 13:39 ` Auger Eric 2020-07-25 8:54 ` Liu, Yi L 2020-07-25 8:54 ` Liu, Yi L 2020-07-12 11:21 ` [PATCH v5 15/15] iommu/vt-d: Support reporting nesting capability info Liu Yi L 2020-07-12 11:21 ` Liu Yi L 2020-07-17 17:14 ` Auger Eric 2020-07-17 17:14 ` Auger Eric 2020-07-20 13:33 ` Liu, Yi L 2020-07-20 13:33 ` Liu, Yi L
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1594552870-55687-9-git-send-email-yi.l.liu@intel.com \ --to=yi.l.liu@intel.com \ --cc=alex.williamson@redhat.com \ --cc=ashok.raj@intel.com \ --cc=baolu.lu@linux.intel.com \ --cc=eric.auger@redhat.com \ --cc=hao.wu@intel.com \ --cc=iommu@lists.linux-foundation.org \ --cc=jacob.jun.pan@linux.intel.com \ --cc=jean-philippe@linaro.org \ --cc=joro@8bytes.org \ --cc=jun.j.tian@intel.com \ --cc=kevin.tian@intel.com \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=peterx@redhat.com \ --cc=stefanha@gmail.com \ --cc=yi.y.sun@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.