All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gene Chen <gene.chen.richtek@gmail.com>
To: lee.jones@linaro.org, matthias.bgg@gmail.com
Cc: linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	gene_chen@richtek.com, benjamin.chao@mediatek.com,
	shufan_lee@richtek.com, cy_huang@richtek.com
Subject: [PATCH v2 7/9] mfd: mt6360: Remove handle_post_irq callback function
Date: Fri, 17 Jul 2020 19:03:29 +0800	[thread overview]
Message-ID: <1594983811-25908-8-git-send-email-gene.chen.richtek@gmail.com> (raw)
In-Reply-To: <1594983811-25908-1-git-send-email-gene.chen.richtek@gmail.com>

From: Gene Chen <gene_chen@richtek.com>

Remove handle_post_irq which is used to retrigger irq.
Set irq level low trigger in dtsi to keep irq always be handled.

Signed-off-by: Gene Chen <gene_chen@richtek.com>
---
 drivers/mfd/mt6360-core.c  | 16 +++-------------
 include/linux/mfd/mt6360.h |  2 +-
 2 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c
index 5dfc13e..5a68228 100644
--- a/drivers/mfd/mt6360-core.c
+++ b/drivers/mfd/mt6360-core.c
@@ -208,15 +208,8 @@ static const struct regmap_irq mt6360_irqs[] =  {
 	REGMAP_IRQ_REG_LINE(MT6360_LDO7_PGB_EVT, 8),
 };
 
-static int mt6360_pmu_handle_post_irq(void *irq_drv_data)
-{
-	struct mt6360_data *data = irq_drv_data;
-
-	return regmap_update_bits(data->regmap,
-		MT6360_PMU_IRQ_SET, MT6360_IRQ_RETRIG, MT6360_IRQ_RETRIG);
-}
-
-static struct regmap_irq_chip mt6360_irq_chip = {
+static const struct regmap_irq_chip mt6360_irq_chip = {
+	.name = "mt6360_irqs",
 	.irqs = mt6360_irqs,
 	.num_irqs = ARRAY_SIZE(mt6360_irqs),
 	.num_regs = MT6360_PMU_IRQ_REGNUM,
@@ -225,7 +218,6 @@ static struct regmap_irq_chip mt6360_irq_chip = {
 	.ack_base = MT6360_PMU_CHG_IRQ1,
 	.init_ack_masked = true,
 	.use_ack = true,
-	.handle_post_irq = mt6360_pmu_handle_post_irq,
 };
 
 static const struct regmap_config mt6360_pmu_regmap_config = {
@@ -339,10 +331,8 @@ static int mt6360_probe(struct i2c_client *client)
 		return -ENODEV;
 	}
 
-	mt6360_irq_chip.irq_drv_data = data;
 	ret = devm_regmap_add_irq_chip(&client->dev, data->regmap, client->irq,
-				       IRQF_TRIGGER_FALLING, 0,
-				       &mt6360_irq_chip, &data->irq_data);
+				       0, 0, &mt6360_irq_chip, &data->irq_data);
 	if (ret) {
 		dev_err(&client->dev, "Failed to add Regmap IRQ Chip\n");
 		return ret;
diff --git a/include/linux/mfd/mt6360.h b/include/linux/mfd/mt6360.h
index fbe106c..da0fb5c 100644
--- a/include/linux/mfd/mt6360.h
+++ b/include/linux/mfd/mt6360.h
@@ -230,7 +230,7 @@ struct mt6360_data {
 #define MT6360_PMU_MAXREG			MT6360_PMU_LDO_MASK2
 
 /* MT6360_PMU_IRQ_SET */
-#define MT6360_PMU_IRQ_REGNUM	(MT6360_PMU_LDO_IRQ2 - MT6360_PMU_CHG_IRQ1 + 1)
+#define MT6360_PMU_IRQ_REGNUM	16
 #define MT6360_IRQ_RETRIG	BIT(2)
 
 #define CHIP_VEN_MASK				0xF0
-- 
2.7.4


WARNING: multiple messages have this Message-ID (diff)
From: Gene Chen <gene.chen.richtek@gmail.com>
To: lee.jones@linaro.org, matthias.bgg@gmail.com
Cc: gene_chen@richtek.com, linux-kernel@vger.kernel.org,
	cy_huang@richtek.com, benjamin.chao@mediatek.com,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, shufan_lee@richtek.com
Subject: [PATCH v2 7/9] mfd: mt6360: Remove handle_post_irq callback function
Date: Fri, 17 Jul 2020 19:03:29 +0800	[thread overview]
Message-ID: <1594983811-25908-8-git-send-email-gene.chen.richtek@gmail.com> (raw)
In-Reply-To: <1594983811-25908-1-git-send-email-gene.chen.richtek@gmail.com>

From: Gene Chen <gene_chen@richtek.com>

Remove handle_post_irq which is used to retrigger irq.
Set irq level low trigger in dtsi to keep irq always be handled.

Signed-off-by: Gene Chen <gene_chen@richtek.com>
---
 drivers/mfd/mt6360-core.c  | 16 +++-------------
 include/linux/mfd/mt6360.h |  2 +-
 2 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c
index 5dfc13e..5a68228 100644
--- a/drivers/mfd/mt6360-core.c
+++ b/drivers/mfd/mt6360-core.c
@@ -208,15 +208,8 @@ static const struct regmap_irq mt6360_irqs[] =  {
 	REGMAP_IRQ_REG_LINE(MT6360_LDO7_PGB_EVT, 8),
 };
 
-static int mt6360_pmu_handle_post_irq(void *irq_drv_data)
-{
-	struct mt6360_data *data = irq_drv_data;
-
-	return regmap_update_bits(data->regmap,
-		MT6360_PMU_IRQ_SET, MT6360_IRQ_RETRIG, MT6360_IRQ_RETRIG);
-}
-
-static struct regmap_irq_chip mt6360_irq_chip = {
+static const struct regmap_irq_chip mt6360_irq_chip = {
+	.name = "mt6360_irqs",
 	.irqs = mt6360_irqs,
 	.num_irqs = ARRAY_SIZE(mt6360_irqs),
 	.num_regs = MT6360_PMU_IRQ_REGNUM,
@@ -225,7 +218,6 @@ static struct regmap_irq_chip mt6360_irq_chip = {
 	.ack_base = MT6360_PMU_CHG_IRQ1,
 	.init_ack_masked = true,
 	.use_ack = true,
-	.handle_post_irq = mt6360_pmu_handle_post_irq,
 };
 
 static const struct regmap_config mt6360_pmu_regmap_config = {
@@ -339,10 +331,8 @@ static int mt6360_probe(struct i2c_client *client)
 		return -ENODEV;
 	}
 
-	mt6360_irq_chip.irq_drv_data = data;
 	ret = devm_regmap_add_irq_chip(&client->dev, data->regmap, client->irq,
-				       IRQF_TRIGGER_FALLING, 0,
-				       &mt6360_irq_chip, &data->irq_data);
+				       0, 0, &mt6360_irq_chip, &data->irq_data);
 	if (ret) {
 		dev_err(&client->dev, "Failed to add Regmap IRQ Chip\n");
 		return ret;
diff --git a/include/linux/mfd/mt6360.h b/include/linux/mfd/mt6360.h
index fbe106c..da0fb5c 100644
--- a/include/linux/mfd/mt6360.h
+++ b/include/linux/mfd/mt6360.h
@@ -230,7 +230,7 @@ struct mt6360_data {
 #define MT6360_PMU_MAXREG			MT6360_PMU_LDO_MASK2
 
 /* MT6360_PMU_IRQ_SET */
-#define MT6360_PMU_IRQ_REGNUM	(MT6360_PMU_LDO_IRQ2 - MT6360_PMU_CHG_IRQ1 + 1)
+#define MT6360_PMU_IRQ_REGNUM	16
 #define MT6360_IRQ_RETRIG	BIT(2)
 
 #define CHIP_VEN_MASK				0xF0
-- 
2.7.4


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Gene Chen <gene.chen.richtek@gmail.com>
To: lee.jones@linaro.org, matthias.bgg@gmail.com
Cc: gene_chen@richtek.com, linux-kernel@vger.kernel.org,
	cy_huang@richtek.com, benjamin.chao@mediatek.com,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, shufan_lee@richtek.com
Subject: [PATCH v2 7/9] mfd: mt6360: Remove handle_post_irq callback function
Date: Fri, 17 Jul 2020 19:03:29 +0800	[thread overview]
Message-ID: <1594983811-25908-8-git-send-email-gene.chen.richtek@gmail.com> (raw)
In-Reply-To: <1594983811-25908-1-git-send-email-gene.chen.richtek@gmail.com>

From: Gene Chen <gene_chen@richtek.com>

Remove handle_post_irq which is used to retrigger irq.
Set irq level low trigger in dtsi to keep irq always be handled.

Signed-off-by: Gene Chen <gene_chen@richtek.com>
---
 drivers/mfd/mt6360-core.c  | 16 +++-------------
 include/linux/mfd/mt6360.h |  2 +-
 2 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c
index 5dfc13e..5a68228 100644
--- a/drivers/mfd/mt6360-core.c
+++ b/drivers/mfd/mt6360-core.c
@@ -208,15 +208,8 @@ static const struct regmap_irq mt6360_irqs[] =  {
 	REGMAP_IRQ_REG_LINE(MT6360_LDO7_PGB_EVT, 8),
 };
 
-static int mt6360_pmu_handle_post_irq(void *irq_drv_data)
-{
-	struct mt6360_data *data = irq_drv_data;
-
-	return regmap_update_bits(data->regmap,
-		MT6360_PMU_IRQ_SET, MT6360_IRQ_RETRIG, MT6360_IRQ_RETRIG);
-}
-
-static struct regmap_irq_chip mt6360_irq_chip = {
+static const struct regmap_irq_chip mt6360_irq_chip = {
+	.name = "mt6360_irqs",
 	.irqs = mt6360_irqs,
 	.num_irqs = ARRAY_SIZE(mt6360_irqs),
 	.num_regs = MT6360_PMU_IRQ_REGNUM,
@@ -225,7 +218,6 @@ static struct regmap_irq_chip mt6360_irq_chip = {
 	.ack_base = MT6360_PMU_CHG_IRQ1,
 	.init_ack_masked = true,
 	.use_ack = true,
-	.handle_post_irq = mt6360_pmu_handle_post_irq,
 };
 
 static const struct regmap_config mt6360_pmu_regmap_config = {
@@ -339,10 +331,8 @@ static int mt6360_probe(struct i2c_client *client)
 		return -ENODEV;
 	}
 
-	mt6360_irq_chip.irq_drv_data = data;
 	ret = devm_regmap_add_irq_chip(&client->dev, data->regmap, client->irq,
-				       IRQF_TRIGGER_FALLING, 0,
-				       &mt6360_irq_chip, &data->irq_data);
+				       0, 0, &mt6360_irq_chip, &data->irq_data);
 	if (ret) {
 		dev_err(&client->dev, "Failed to add Regmap IRQ Chip\n");
 		return ret;
diff --git a/include/linux/mfd/mt6360.h b/include/linux/mfd/mt6360.h
index fbe106c..da0fb5c 100644
--- a/include/linux/mfd/mt6360.h
+++ b/include/linux/mfd/mt6360.h
@@ -230,7 +230,7 @@ struct mt6360_data {
 #define MT6360_PMU_MAXREG			MT6360_PMU_LDO_MASK2
 
 /* MT6360_PMU_IRQ_SET */
-#define MT6360_PMU_IRQ_REGNUM	(MT6360_PMU_LDO_IRQ2 - MT6360_PMU_CHG_IRQ1 + 1)
+#define MT6360_PMU_IRQ_REGNUM	16
 #define MT6360_IRQ_RETRIG	BIT(2)
 
 #define CHIP_VEN_MASK				0xF0
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-07-17 11:04 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-17 11:03 [PATCH v2 0/9] mfd: mt6360: Merge different sub-devices i2c read/write Gene Chen
2020-07-17 11:03 ` Gene Chen
2020-07-17 11:03 ` Gene Chen
2020-07-17 11:03 ` [PATCH v2 1/9] mfd: mt6360: Rearrange include file Gene Chen
2020-07-17 11:03   ` Gene Chen
2020-07-17 11:03   ` Gene Chen
2020-07-27 11:08   ` Lee Jones
2020-07-27 11:08     ` Lee Jones
2020-07-27 11:08     ` Lee Jones
2020-07-27 18:16     ` Gene Chen
2020-07-27 18:16       ` Gene Chen
2020-07-27 18:16       ` Gene Chen
2020-07-28  6:56       ` Lee Jones
2020-07-28  6:56         ` Lee Jones
2020-07-28  6:56         ` Lee Jones
2020-07-17 11:03 ` [PATCH v2 2/9] mfd: mt6360: Remove redundant brackets around raw numbers Gene Chen
2020-07-17 11:03   ` Gene Chen
2020-07-17 11:03   ` Gene Chen
2020-07-27 11:09   ` Lee Jones
2020-07-27 11:09     ` Lee Jones
2020-07-27 11:09     ` Lee Jones
2020-07-17 11:03 ` [PATCH v2 3/9] mfd: mt6360: Indicate sub-dev compatible name by using "-" Gene Chen
2020-07-17 11:03   ` Gene Chen
2020-07-17 11:03   ` Gene Chen
2020-07-27 11:18   ` Lee Jones
2020-07-27 11:18     ` Lee Jones
2020-07-27 11:18     ` Lee Jones
2020-07-17 11:03 ` [PATCH v2 4/9] mfd: mt6360: Combine mt6360 pmic/ldo resouces into mt6360 regulator resources Gene Chen
2020-07-17 11:03   ` Gene Chen
2020-07-17 11:03   ` Gene Chen
2020-07-27 11:29   ` Lee Jones
2020-07-27 11:29     ` Lee Jones
2020-07-27 11:29     ` Lee Jones
2020-07-27 18:28     ` Gene Chen
2020-07-27 18:28       ` Gene Chen
2020-07-27 18:28       ` Gene Chen
2020-07-28  6:54       ` Lee Jones
2020-07-28  6:54         ` Lee Jones
2020-07-28  6:54         ` Lee Jones
2020-07-31  2:58         ` Gene Chen
2020-07-31  2:58           ` Gene Chen
2020-07-31  2:58           ` Gene Chen
2020-07-31 11:12           ` Lee Jones
2020-07-31 11:12             ` Lee Jones
2020-07-31 11:12             ` Lee Jones
2020-07-17 11:03 ` [PATCH v2 5/9] mfd: mt6360: Rename mt6360_pmu_data by mt6360_data Gene Chen
2020-07-17 11:03   ` Gene Chen
2020-07-17 11:03   ` Gene Chen
2020-07-27 12:06   ` Lee Jones
2020-07-27 12:06     ` Lee Jones
2020-07-27 12:06     ` Lee Jones
2020-07-17 11:03 ` [PATCH v2 6/9] mfd: mt6360: Rename mt6360_pmu by mt6360 Gene Chen
2020-07-17 11:03   ` Gene Chen
2020-07-17 11:03   ` Gene Chen
2020-07-27 12:21   ` Lee Jones
2020-07-27 12:21     ` Lee Jones
2020-07-27 12:21     ` Lee Jones
2020-07-17 11:03 ` Gene Chen [this message]
2020-07-17 11:03   ` [PATCH v2 7/9] mfd: mt6360: Remove handle_post_irq callback function Gene Chen
2020-07-17 11:03   ` Gene Chen
2020-07-27 12:23   ` Lee Jones
2020-07-27 12:23     ` Lee Jones
2020-07-27 12:23     ` Lee Jones
2020-07-17 11:03 ` [PATCH v2 8/9] mfd: mt6360: Fix flow which is used to check ic exist Gene Chen
2020-07-17 11:03   ` Gene Chen
2020-07-17 11:03   ` Gene Chen
2020-07-27 12:26   ` Lee Jones
2020-07-27 12:26     ` Lee Jones
2020-07-27 12:26     ` Lee Jones
2020-07-17 11:03 ` [PATCH v2 9/9] mfd: mt6360: Merge different sub-devices i2c read/write Gene Chen
2020-07-17 11:03   ` Gene Chen
2020-07-17 11:03   ` Gene Chen
2020-07-27 12:43   ` Lee Jones
2020-07-27 12:43     ` Lee Jones
2020-07-27 12:43     ` Lee Jones
2020-07-29  0:51     ` Gene Chen
2020-07-29  0:51       ` Gene Chen
2020-07-29  0:51       ` Gene Chen
2020-07-29 10:12       ` Lee Jones
2020-07-29 10:12         ` Lee Jones
2020-07-29 10:12         ` Lee Jones
2020-07-30  2:56         ` Gene Chen
2020-07-30  2:56           ` Gene Chen
2020-07-30  2:56           ` Gene Chen
2020-07-31  0:51           ` Gene Chen
2020-07-31  0:51             ` Gene Chen
2020-07-31  0:51             ` Gene Chen
2020-07-31  9:06             ` Lee Jones
2020-07-31  9:06               ` Lee Jones
2020-07-31  9:06               ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1594983811-25908-8-git-send-email-gene.chen.richtek@gmail.com \
    --to=gene.chen.richtek@gmail.com \
    --cc=benjamin.chao@mediatek.com \
    --cc=cy_huang@richtek.com \
    --cc=gene_chen@richtek.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=shufan_lee@richtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.