* [PATCH] xarray: update document for error space returned by xarray normal API
@ 2020-07-20 3:43 Wang Long
0 siblings, 0 replies; 3+ messages in thread
From: Wang Long @ 2020-07-20 3:43 UTC (permalink / raw)
To: willy; +Cc: linux-kernel, linux-fsdevel
In the current xarray code, the negative value -1 and -4095 represented
as an error.
xa_is_error(xa_mk_internal(-4095)) and xa_is_error(xa_mk_internal(-1))
are all return true.
This patch update the document.
Signed-off-by: Wang Long <w@laoqinren.net>
---
include/linux/xarray.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/xarray.h b/include/linux/xarray.h
index b4d70e7..0588fb9 100644
--- a/include/linux/xarray.h
+++ b/include/linux/xarray.h
@@ -36,7 +36,7 @@
* 257: Zero entry
*
* Errors are also represented as internal entries, but use the negative
- * space (-4094 to -2). They're never stored in the slots array; only
+ * space (-4095 to -1). They're never stored in the slots array; only
* returned by the normal API.
*/
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xarray: update document for error space returned by xarray normal API
2020-07-20 3:57 Wang Long
@ 2020-07-20 4:06 ` Chaitanya Kulkarni
0 siblings, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2020-07-20 4:06 UTC (permalink / raw)
To: Wang Long, willy; +Cc: linux-kernel, linux-fsdevel
On 7/19/20 20:58, Wang Long wrote:
> xa_is_error(xa_mk_internal(-4095)) and xa_is_error(xa_mk_internal(-1))
> are all return true.
's/xa_is_error()/xa_is_err()/` ?
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] xarray: update document for error space returned by xarray normal API
@ 2020-07-20 3:57 Wang Long
2020-07-20 4:06 ` Chaitanya Kulkarni
0 siblings, 1 reply; 3+ messages in thread
From: Wang Long @ 2020-07-20 3:57 UTC (permalink / raw)
To: willy; +Cc: w, linux-kernel, linux-fsdevel
In the current xarray code, the negative value -1 and -4095 represented
as an error.
xa_is_error(xa_mk_internal(-4095)) and xa_is_error(xa_mk_internal(-1))
are all return true.
This patch update the document.
Signed-off-by: Wang Long <w@laoqinren.net>
---
include/linux/xarray.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/xarray.h b/include/linux/xarray.h
index b4d70e7..0588fb9 100644
--- a/include/linux/xarray.h
+++ b/include/linux/xarray.h
@@ -36,7 +36,7 @@
* 257: Zero entry
*
* Errors are also represented as internal entries, but use the negative
- * space (-4094 to -2). They're never stored in the slots array; only
+ * space (-4095 to -1). They're never stored in the slots array; only
* returned by the normal API.
*/
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-20 4:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-20 3:43 [PATCH] xarray: update document for error space returned by xarray normal API Wang Long
2020-07-20 3:57 Wang Long
2020-07-20 4:06 ` Chaitanya Kulkarni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.