* [dpdk-dev] [PATCH 1/2] net/sfc/base: improve headers independence
@ 2020-07-21 8:57 Andrew Rybchenko
2020-07-21 8:57 ` [dpdk-dev] [PATCH 2/2] net/sfc: remove inclusion of unused headers Andrew Rybchenko
2020-07-21 16:37 ` [dpdk-dev] [PATCH 1/2] net/sfc/base: improve headers independence Ferruh Yigit
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Rybchenko @ 2020-07-21 8:57 UTC (permalink / raw)
To: dev
efx_types.h uses defines from efx_annote.h, but does not include the
header. As the result if efx_types.h is included by a driver first,
build fails.
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/base/efx_types.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/sfc/base/efx_types.h b/drivers/net/sfc/base/efx_types.h
index 4fddbbcdc4..ae8a1031df 100644
--- a/drivers/net/sfc/base/efx_types.h
+++ b/drivers/net/sfc/base/efx_types.h
@@ -10,6 +10,7 @@
#define _SYS_EFX_TYPES_H
#include "efsys.h"
+#include "efx_annote.h"
#ifdef __cplusplus
extern "C" {
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [dpdk-dev] [PATCH 2/2] net/sfc: remove inclusion of unused headers
2020-07-21 8:57 [dpdk-dev] [PATCH 1/2] net/sfc/base: improve headers independence Andrew Rybchenko
@ 2020-07-21 8:57 ` Andrew Rybchenko
2020-07-21 16:37 ` [dpdk-dev] [PATCH 1/2] net/sfc/base: improve headers independence Ferruh Yigit
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Rybchenko @ 2020-07-21 8:57 UTC (permalink / raw)
To: dev
Defines and functions from rte_mbuf_ptype.h are not used.
Only libefx types and EF10 register definitions are used.
Native datapaths should be independent from main libefx interface.
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/sfc_ef10_essb_rx.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/sfc/sfc_ef10_essb_rx.c b/drivers/net/sfc/sfc_ef10_essb_rx.c
index 3bc136e040..13b2b824e3 100644
--- a/drivers/net/sfc/sfc_ef10_essb_rx.c
+++ b/drivers/net/sfc/sfc_ef10_essb_rx.c
@@ -12,13 +12,10 @@
#include <stdbool.h>
#include <rte_byteorder.h>
-#include <rte_mbuf_ptype.h>
#include <rte_mbuf.h>
#include <rte_io.h>
-#include "efx.h"
#include "efx_types.h"
-#include "efx_regs.h"
#include "efx_regs_ef10.h"
#include "sfc_tweak.h"
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] net/sfc/base: improve headers independence
2020-07-21 8:57 [dpdk-dev] [PATCH 1/2] net/sfc/base: improve headers independence Andrew Rybchenko
2020-07-21 8:57 ` [dpdk-dev] [PATCH 2/2] net/sfc: remove inclusion of unused headers Andrew Rybchenko
@ 2020-07-21 16:37 ` Ferruh Yigit
1 sibling, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2020-07-21 16:37 UTC (permalink / raw)
To: Andrew Rybchenko, dev
On 7/21/2020 9:57 AM, Andrew Rybchenko wrote:
> efx_types.h uses defines from efx_annote.h, but does not include the
> header. As the result if efx_types.h is included by a driver first,
> build fails.
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Series applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-21 16:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 8:57 [dpdk-dev] [PATCH 1/2] net/sfc/base: improve headers independence Andrew Rybchenko
2020-07-21 8:57 ` [dpdk-dev] [PATCH 2/2] net/sfc: remove inclusion of unused headers Andrew Rybchenko
2020-07-21 16:37 ` [dpdk-dev] [PATCH 1/2] net/sfc/base: improve headers independence Ferruh Yigit
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.