* [PATCH net] dev: Defer free of skbs in flush_backlog
@ 2020-07-23 17:31 Subash Abhinov Kasiviswanathan
2020-07-25 3:00 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Subash Abhinov Kasiviswanathan @ 2020-07-23 17:31 UTC (permalink / raw)
To: pabeni, davem, stranche, netdev; +Cc: Subash Abhinov Kasiviswanathan
IRQs are disabled when freeing skbs in input queue.
Use the IRQ safe variant to free skbs here.
Fixes: 145dd5f9c88f ("net: flush the softnet backlog in process context")
Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
---
net/core/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 90b59fc..7a774eb 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -5601,7 +5601,7 @@ static void flush_backlog(struct work_struct *work)
skb_queue_walk_safe(&sd->input_pkt_queue, skb, tmp) {
if (skb->dev->reg_state == NETREG_UNREGISTERING) {
__skb_unlink(skb, &sd->input_pkt_queue);
- kfree_skb(skb);
+ dev_kfree_skb_irq(skb);
input_queue_head_incr(sd);
}
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] dev: Defer free of skbs in flush_backlog
2020-07-23 17:31 [PATCH net] dev: Defer free of skbs in flush_backlog Subash Abhinov Kasiviswanathan
@ 2020-07-25 3:00 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-07-25 3:00 UTC (permalink / raw)
To: subashab; +Cc: pabeni, stranche, netdev
From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Date: Thu, 23 Jul 2020 11:31:48 -0600
> IRQs are disabled when freeing skbs in input queue.
> Use the IRQ safe variant to free skbs here.
>
> Fixes: 145dd5f9c88f ("net: flush the softnet backlog in process context")
> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Applied and queued up for -stable, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-25 3:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-23 17:31 [PATCH net] dev: Defer free of skbs in flush_backlog Subash Abhinov Kasiviswanathan
2020-07-25 3:00 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.