All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dong Aisheng <aisheng.dong@nxp.com>
To: linux-clk@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, sboyd@kernel.org,
	mturquette@baylibre.com, shawnguo@kernel.org,
	fabio.estevam@nxp.com, linux-imx@nxp.com, kernel@pengutronix.de,
	Dong Aisheng <aisheng.dong@nxp.com>
Subject: [PATCH v7 10/11] clk: imx: clk-imx8qxp-lpcg: add runtime pm support
Date: Wed, 29 Jul 2020 16:00:17 +0800	[thread overview]
Message-ID: <1596009618-25516-11-git-send-email-aisheng.dong@nxp.com> (raw)
In-Reply-To: <1596009618-25516-1-git-send-email-aisheng.dong@nxp.com>

add runtime pm support

Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
ChangeLog:
v5->v7:
 * no changes
v4->v5:
 * minor err check fix
v3->v4:
 * disable rpm when error out
v3: new patch
---
 drivers/clk/imx/clk-imx8qxp-lpcg.c | 24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)

diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c
index 1881d7f3ccec..3385de76f6c7 100644
--- a/drivers/clk/imx/clk-imx8qxp-lpcg.c
+++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c
@@ -12,6 +12,7 @@
 #include <linux/of_address.h>
 #include <linux/of_device.h>
 #include <linux/platform_device.h>
+#include <linux/pm_runtime.h>
 #include <linux/slab.h>
 
 #include "clk-scu.h"
@@ -239,6 +240,12 @@ static int imx_lpcg_parse_clks_from_dt(struct platform_device *pdev,
 		return -EINVAL;
 	}
 
+	pm_runtime_get_noresume(&pdev->dev);
+	pm_runtime_set_active(&pdev->dev);
+	pm_runtime_set_autosuspend_delay(&pdev->dev, 500);
+	pm_runtime_use_autosuspend(&pdev->dev);
+	pm_runtime_enable(&pdev->dev);
+
 	for (i = 0; i < count; i++) {
 		idx = bit_offset[i] / 4;
 		if (idx > IMX_LPCG_MAX_CLKS) {
@@ -248,9 +255,9 @@ static int imx_lpcg_parse_clks_from_dt(struct platform_device *pdev,
 			goto unreg;
 		}
 
-		clk_hws[idx] = imx_clk_lpcg_scu(output_names[i],
-						parent_names[i], 0, base,
-						bit_offset[i], false);
+		clk_hws[idx] = imx_clk_lpcg_scu_dev(&pdev->dev, output_names[i],
+						    parent_names[i], 0, base,
+						    bit_offset[i], false);
 		if (IS_ERR(clk_hws[idx])) {
 			dev_warn(&pdev->dev, "failed to register clock %d\n",
 				 idx);
@@ -261,8 +268,13 @@ static int imx_lpcg_parse_clks_from_dt(struct platform_device *pdev,
 
 	ret = devm_of_clk_add_hw_provider(&pdev->dev, imx_lpcg_of_clk_src_get,
 					  clk_data);
-	if (!ret)
-		return 0;
+	if (ret)
+		goto unreg;
+
+	pm_runtime_mark_last_busy(&pdev->dev);
+	pm_runtime_put_autosuspend(&pdev->dev);
+
+	return 0;
 
 unreg:
 	while (--i >= 0) {
@@ -271,6 +283,8 @@ static int imx_lpcg_parse_clks_from_dt(struct platform_device *pdev,
 			imx_clk_lpcg_scu_unregister(clk_hws[idx]);
 	}
 
+	pm_runtime_disable(&pdev->dev);
+
 	return ret;
 }
 
-- 
2.23.0


WARNING: multiple messages have this Message-ID (diff)
From: Dong Aisheng <aisheng.dong@nxp.com>
To: linux-clk@vger.kernel.org
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
	sboyd@kernel.org, mturquette@baylibre.com, linux-imx@nxp.com,
	kernel@pengutronix.de, fabio.estevam@nxp.com,
	shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 10/11] clk: imx: clk-imx8qxp-lpcg: add runtime pm support
Date: Wed, 29 Jul 2020 16:00:17 +0800	[thread overview]
Message-ID: <1596009618-25516-11-git-send-email-aisheng.dong@nxp.com> (raw)
In-Reply-To: <1596009618-25516-1-git-send-email-aisheng.dong@nxp.com>

add runtime pm support

Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
ChangeLog:
v5->v7:
 * no changes
v4->v5:
 * minor err check fix
v3->v4:
 * disable rpm when error out
v3: new patch
---
 drivers/clk/imx/clk-imx8qxp-lpcg.c | 24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)

diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c
index 1881d7f3ccec..3385de76f6c7 100644
--- a/drivers/clk/imx/clk-imx8qxp-lpcg.c
+++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c
@@ -12,6 +12,7 @@
 #include <linux/of_address.h>
 #include <linux/of_device.h>
 #include <linux/platform_device.h>
+#include <linux/pm_runtime.h>
 #include <linux/slab.h>
 
 #include "clk-scu.h"
@@ -239,6 +240,12 @@ static int imx_lpcg_parse_clks_from_dt(struct platform_device *pdev,
 		return -EINVAL;
 	}
 
+	pm_runtime_get_noresume(&pdev->dev);
+	pm_runtime_set_active(&pdev->dev);
+	pm_runtime_set_autosuspend_delay(&pdev->dev, 500);
+	pm_runtime_use_autosuspend(&pdev->dev);
+	pm_runtime_enable(&pdev->dev);
+
 	for (i = 0; i < count; i++) {
 		idx = bit_offset[i] / 4;
 		if (idx > IMX_LPCG_MAX_CLKS) {
@@ -248,9 +255,9 @@ static int imx_lpcg_parse_clks_from_dt(struct platform_device *pdev,
 			goto unreg;
 		}
 
-		clk_hws[idx] = imx_clk_lpcg_scu(output_names[i],
-						parent_names[i], 0, base,
-						bit_offset[i], false);
+		clk_hws[idx] = imx_clk_lpcg_scu_dev(&pdev->dev, output_names[i],
+						    parent_names[i], 0, base,
+						    bit_offset[i], false);
 		if (IS_ERR(clk_hws[idx])) {
 			dev_warn(&pdev->dev, "failed to register clock %d\n",
 				 idx);
@@ -261,8 +268,13 @@ static int imx_lpcg_parse_clks_from_dt(struct platform_device *pdev,
 
 	ret = devm_of_clk_add_hw_provider(&pdev->dev, imx_lpcg_of_clk_src_get,
 					  clk_data);
-	if (!ret)
-		return 0;
+	if (ret)
+		goto unreg;
+
+	pm_runtime_mark_last_busy(&pdev->dev);
+	pm_runtime_put_autosuspend(&pdev->dev);
+
+	return 0;
 
 unreg:
 	while (--i >= 0) {
@@ -271,6 +283,8 @@ static int imx_lpcg_parse_clks_from_dt(struct platform_device *pdev,
 			imx_clk_lpcg_scu_unregister(clk_hws[idx]);
 	}
 
+	pm_runtime_disable(&pdev->dev);
+
 	return ret;
 }
 
-- 
2.23.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-07-29  8:04 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29  8:00 [PATCH v7 00/11] clk: imx8: add new clock binding for better pm support Dong Aisheng
2020-07-29  8:00 ` Dong Aisheng
2020-07-29  8:00 ` [PATCH v7 01/11] dt-bindings: firmware: imx-scu: new binding to parse clocks from device tree Dong Aisheng
2020-07-29  8:00   ` Dong Aisheng
2020-07-29  8:00 ` [PATCH v7 02/11] dt-bindings: clock: imx-lpcg: add support " Dong Aisheng
2020-07-29  8:00   ` Dong Aisheng
2020-07-29  8:06   ` Dong Aisheng
2020-07-29  8:06     ` Dong Aisheng
2020-07-31 21:28   ` Rob Herring
2020-07-31 21:28     ` Rob Herring
2020-10-14  0:41   ` Stephen Boyd
2020-10-14  0:41     ` Stephen Boyd
2020-07-29  8:00 ` [PATCH v7 03/11] clk: imx: scu: add two cells binding support Dong Aisheng
2020-07-29  8:00   ` Dong Aisheng
2020-10-14  0:40   ` Stephen Boyd
2020-10-14  0:40     ` Stephen Boyd
2020-10-30  1:06   ` Nathan Chancellor
2020-10-30  1:06     ` Nathan Chancellor
2020-10-30  3:22     ` Aisheng Dong
2020-10-30  3:22       ` Aisheng Dong
2020-10-30 15:58       ` Aisheng Dong
2020-10-30 15:58         ` Aisheng Dong
2020-07-29  8:00 ` [PATCH v7 04/11] clk: imx: scu: bypass cpu power domains Dong Aisheng
2020-07-29  8:00   ` Dong Aisheng
2020-07-29  8:00 ` [PATCH v7 05/11] clk: imx: scu: allow scu clk to take device pointer Dong Aisheng
2020-07-29  8:00   ` Dong Aisheng
2020-07-29  8:00 ` [PATCH v7 06/11] clk: imx: scu: add runtime pm support Dong Aisheng
2020-07-29  8:00   ` Dong Aisheng
2020-07-29  8:00 ` [PATCH v7 07/11] clk: imx: scu: add suspend/resume support Dong Aisheng
2020-07-29  8:00   ` Dong Aisheng
2020-07-29  8:00 ` [PATCH v7 08/11] clk: imx: imx8qxp-lpcg: add parsing clocks from device tree Dong Aisheng
2020-07-29  8:00   ` Dong Aisheng
2020-07-29  8:00 ` [PATCH v7 09/11] clk: imx: lpcg: allow lpcg clk to take device pointer Dong Aisheng
2020-07-29  8:00   ` Dong Aisheng
2020-07-29  8:00 ` Dong Aisheng [this message]
2020-07-29  8:00   ` [PATCH v7 10/11] clk: imx: clk-imx8qxp-lpcg: add runtime pm support Dong Aisheng
2020-07-29  8:00 ` [PATCH v7 11/11] clk: imx: lpcg: add suspend/resume support Dong Aisheng
2020-07-29  8:00   ` Dong Aisheng
2020-07-29  8:04 ` [PATCH v7 00/11] clk: imx8: add new clock binding for better pm support Dong Aisheng
2020-07-29  8:04   ` Dong Aisheng
2020-08-17  7:42   ` Dong Aisheng
2020-08-17  7:42     ` Dong Aisheng
2020-09-02  6:35     ` Dong Aisheng
2020-09-02  6:35       ` Dong Aisheng
2020-09-27  4:13       ` Aisheng Dong
2020-09-27  4:13         ` Aisheng Dong
2020-10-12 19:28         ` Stephen Boyd
2020-10-12 19:28           ` Stephen Boyd
2020-10-13  9:27           ` Dong Aisheng
2020-10-13  9:27             ` Dong Aisheng
2020-10-14  0:41             ` Stephen Boyd
2020-10-14  0:41               ` Stephen Boyd
2020-10-15  6:51               ` Dong Aisheng
2020-10-15  6:51                 ` Dong Aisheng
2020-10-26  2:55 ` Shawn Guo
2020-10-26  2:55   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1596009618-25516-11-git-send-email-aisheng.dong@nxp.com \
    --to=aisheng.dong@nxp.com \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.