From: Frankie Chang <Frankie.Chang@mediatek.com> To: Todd Kjos <tkjos@google.com> Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Joel Fernandes" <joel@joelfernandes.org>, "Martijn Coenen" <maco@android.com>, "Arve Hjønnevåg" <arve@android.com>, "Christian Brauner" <christian@brauner.io>, LKML <linux-kernel@vger.kernel.org>, linux-mediatek@lists.infradead.org, wsd_upstream <wsd_upstream@mediatek.com>, "Jian-Min Liu" <Jian-Min.Liu@mediatek.com> Subject: Re: [PATCH v6 2/3] binder: add trace at free transaction. Date: Mon, 3 Aug 2020 11:11:16 +0800 [thread overview] Message-ID: <1596424276.5207.13.camel@mtkswgap22> (raw) In-Reply-To: <CAHRSSEwqbbTZgaE-KLC0-AMHzRVU3O2AwUzW9i5u54tVmkFAQA@mail.gmail.com> On Fri, 2020-07-31 at 11:50 -0700, Todd Kjos wrote: > On Mon, Jul 27, 2020 at 8:28 PM Frankie Chang > <Frankie.Chang@mediatek.com> wrote: > > > > From: "Frankie.Chang" <Frankie.Chang@mediatek.com> > > > > Since the original trace_binder_transaction_received cannot > > precisely present the real finished time of transaction, adding a > > trace_binder_txn_latency_free at the point of free transaction > > may be more close to it. > > > > Signed-off-by: Frankie.Chang <Frankie.Chang@mediatek.com> > > --- > > drivers/android/binder.c | 6 ++++++ > > drivers/android/binder_trace.h | 27 +++++++++++++++++++++++++++ > > 2 files changed, 33 insertions(+) > > > > diff --git a/drivers/android/binder.c b/drivers/android/binder.c > > index 2df146f..1e6fc40 100644 > > --- a/drivers/android/binder.c > > +++ b/drivers/android/binder.c > > @@ -1522,6 +1522,9 @@ static void binder_free_transaction(struct binder_transaction *t) > > * If the transaction has no target_proc, then > > * t->buffer->transaction has already been cleared. > > */ > > + spin_lock(&t->lock); > > + trace_binder_txn_latency_free(t); > > + spin_unlock(&t->lock); > > Hmm. I don't prefer taking the lock just to call a trace. It doesn't > make clear why the lock has to be taken. I'd prefer something like: > > if (trace_binder_txn_latency_free_enabled()) { c > } > > And then the trace would use the passed-in values instead of accessing > via t->to_proc/to_thread. > Then we still add lock protection in the hook function, when trace is disable ? Or we also pass these to hook function, no matter the trace is enable or not.I think this way is more clear that the lock protects @from, @to_proc and @to_thread.Then, there is no need to add the lock in hook function. int from_proc, from_thread, to_proc, to_thread; spin_lock(&t->lock); from_proc = t->from ? t->from->proc->pid : 0; from_thread = t->from ? t->from->pid :0; to_proc = t->to_proc ? t->to_proc->pid : 0; to_thread = t->to_thread ? t->to_thread->pid : 0; spin_unlock(&t->lock); trace_binder_txn_latency_free(t, from_proc, from_thread, to_proc, to_pid); > > binder_free_txn_fixups(t); > > kfree(t); > > binder_stats_deleted(BINDER_STAT_TRANSACTION); > > @@ -3093,6 +3096,9 @@ static void binder_transaction(struct binder_proc *proc, > > kfree(tcomplete); > > binder_stats_deleted(BINDER_STAT_TRANSACTION_COMPLETE); > > err_alloc_tcomplete_failed: > > + spin_lock(&t->lock); > > + trace_binder_txn_latency_free(t); > > + spin_unlock(&t->lock); > > kfree(t); > > binder_stats_deleted(BINDER_STAT_TRANSACTION); > > err_alloc_t_failed: > > diff --git a/drivers/android/binder_trace.h b/drivers/android/binder_trace.h > > index 6731c3c..8ac87d1 100644 > > --- a/drivers/android/binder_trace.h > > +++ b/drivers/android/binder_trace.h > > @@ -95,6 +95,33 @@ > > __entry->thread_todo) > > ); > > > > +TRACE_EVENT(binder_txn_latency_free, > > + TP_PROTO(struct binder_transaction *t), > > + TP_ARGS(t), > > + TP_STRUCT__entry( > > + __field(int, debug_id) > > + __field(int, from_proc) > > + __field(int, from_thread) > > + __field(int, to_proc) > > + __field(int, to_thread) > > + __field(unsigned int, code) > > + __field(unsigned int, flags) > > + ), > > + TP_fast_assign( > > + __entry->debug_id = t->debug_id; > > + __entry->from_proc = t->from ? t->from->proc->pid : 0; > > + __entry->from_thread = t->from ? t->from->pid : 0; > > + __entry->to_proc = t->to_proc ? t->to_proc->pid : 0; > > + __entry->to_thread = t->to_thread ? t->to_thread->pid : 0; > > + __entry->code = t->code; > > + __entry->flags = t->flags; > > + ), > > + TP_printk("transaction=%d from %d:%d to %d:%d flags=0x%x code=0x%x", > > + __entry->debug_id, __entry->from_proc, __entry->from_thread, > > + __entry->to_proc, __entry->to_thread, __entry->code, > > + __entry->flags) > > +); > > + > > TRACE_EVENT(binder_transaction, > > TP_PROTO(bool reply, struct binder_transaction *t, > > struct binder_node *target_node), > > -- > > 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Frankie Chang <Frankie.Chang@mediatek.com> To: Todd Kjos <tkjos@google.com> Cc: wsd_upstream <wsd_upstream@mediatek.com>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, LKML <linux-kernel@vger.kernel.org>, "Arve Hjønnevåg" <arve@android.com>, "Jian-Min Liu" <Jian-Min.Liu@mediatek.com>, linux-mediatek@lists.infradead.org, "Joel Fernandes" <joel@joelfernandes.org>, "Martijn Coenen" <maco@android.com>, "Christian Brauner" <christian@brauner.io> Subject: Re: [PATCH v6 2/3] binder: add trace at free transaction. Date: Mon, 3 Aug 2020 11:11:16 +0800 [thread overview] Message-ID: <1596424276.5207.13.camel@mtkswgap22> (raw) In-Reply-To: <CAHRSSEwqbbTZgaE-KLC0-AMHzRVU3O2AwUzW9i5u54tVmkFAQA@mail.gmail.com> On Fri, 2020-07-31 at 11:50 -0700, Todd Kjos wrote: > On Mon, Jul 27, 2020 at 8:28 PM Frankie Chang > <Frankie.Chang@mediatek.com> wrote: > > > > From: "Frankie.Chang" <Frankie.Chang@mediatek.com> > > > > Since the original trace_binder_transaction_received cannot > > precisely present the real finished time of transaction, adding a > > trace_binder_txn_latency_free at the point of free transaction > > may be more close to it. > > > > Signed-off-by: Frankie.Chang <Frankie.Chang@mediatek.com> > > --- > > drivers/android/binder.c | 6 ++++++ > > drivers/android/binder_trace.h | 27 +++++++++++++++++++++++++++ > > 2 files changed, 33 insertions(+) > > > > diff --git a/drivers/android/binder.c b/drivers/android/binder.c > > index 2df146f..1e6fc40 100644 > > --- a/drivers/android/binder.c > > +++ b/drivers/android/binder.c > > @@ -1522,6 +1522,9 @@ static void binder_free_transaction(struct binder_transaction *t) > > * If the transaction has no target_proc, then > > * t->buffer->transaction has already been cleared. > > */ > > + spin_lock(&t->lock); > > + trace_binder_txn_latency_free(t); > > + spin_unlock(&t->lock); > > Hmm. I don't prefer taking the lock just to call a trace. It doesn't > make clear why the lock has to be taken. I'd prefer something like: > > if (trace_binder_txn_latency_free_enabled()) { c > } > > And then the trace would use the passed-in values instead of accessing > via t->to_proc/to_thread. > Then we still add lock protection in the hook function, when trace is disable ? Or we also pass these to hook function, no matter the trace is enable or not.I think this way is more clear that the lock protects @from, @to_proc and @to_thread.Then, there is no need to add the lock in hook function. int from_proc, from_thread, to_proc, to_thread; spin_lock(&t->lock); from_proc = t->from ? t->from->proc->pid : 0; from_thread = t->from ? t->from->pid :0; to_proc = t->to_proc ? t->to_proc->pid : 0; to_thread = t->to_thread ? t->to_thread->pid : 0; spin_unlock(&t->lock); trace_binder_txn_latency_free(t, from_proc, from_thread, to_proc, to_pid); > > binder_free_txn_fixups(t); > > kfree(t); > > binder_stats_deleted(BINDER_STAT_TRANSACTION); > > @@ -3093,6 +3096,9 @@ static void binder_transaction(struct binder_proc *proc, > > kfree(tcomplete); > > binder_stats_deleted(BINDER_STAT_TRANSACTION_COMPLETE); > > err_alloc_tcomplete_failed: > > + spin_lock(&t->lock); > > + trace_binder_txn_latency_free(t); > > + spin_unlock(&t->lock); > > kfree(t); > > binder_stats_deleted(BINDER_STAT_TRANSACTION); > > err_alloc_t_failed: > > diff --git a/drivers/android/binder_trace.h b/drivers/android/binder_trace.h > > index 6731c3c..8ac87d1 100644 > > --- a/drivers/android/binder_trace.h > > +++ b/drivers/android/binder_trace.h > > @@ -95,6 +95,33 @@ > > __entry->thread_todo) > > ); > > > > +TRACE_EVENT(binder_txn_latency_free, > > + TP_PROTO(struct binder_transaction *t), > > + TP_ARGS(t), > > + TP_STRUCT__entry( > > + __field(int, debug_id) > > + __field(int, from_proc) > > + __field(int, from_thread) > > + __field(int, to_proc) > > + __field(int, to_thread) > > + __field(unsigned int, code) > > + __field(unsigned int, flags) > > + ), > > + TP_fast_assign( > > + __entry->debug_id = t->debug_id; > > + __entry->from_proc = t->from ? t->from->proc->pid : 0; > > + __entry->from_thread = t->from ? t->from->pid : 0; > > + __entry->to_proc = t->to_proc ? t->to_proc->pid : 0; > > + __entry->to_thread = t->to_thread ? t->to_thread->pid : 0; > > + __entry->code = t->code; > > + __entry->flags = t->flags; > > + ), > > + TP_printk("transaction=%d from %d:%d to %d:%d flags=0x%x code=0x%x", > > + __entry->debug_id, __entry->from_proc, __entry->from_thread, > > + __entry->to_proc, __entry->to_thread, __entry->code, > > + __entry->flags) > > +); > > + > > TRACE_EVENT(binder_transaction, > > TP_PROTO(bool reply, struct binder_transaction *t, > > struct binder_node *target_node), > > -- > > 1.7.9.5 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-08-03 3:11 UTC|newest] Thread overview: 146+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-05 6:52 [PATCH v1 1/1] binder: transaction latency tracking for user build Frankie Chang 2020-02-05 6:52 ` Frankie Chang 2020-02-05 9:36 ` Greg Kroah-Hartman 2020-02-05 9:36 ` Greg Kroah-Hartman 2020-02-05 15:49 ` Joel Fernandes 2020-02-05 15:49 ` Joel Fernandes 2020-02-07 3:10 ` Frankie Chang 2020-02-07 3:10 ` Frankie Chang 2020-02-07 3:17 ` Joel Fernandes 2020-02-07 3:17 ` Joel Fernandes 2020-02-07 6:28 ` Frankie Chang 2020-02-07 6:28 ` Frankie Chang 2020-02-07 13:26 ` Joel Fernandes 2020-02-07 13:26 ` Joel Fernandes 2020-04-13 6:24 ` Frankie Chang 2020-04-13 6:24 ` Frankie Chang 2020-04-15 5:37 ` [PATCH v2] " Frankie Chang 2020-04-15 5:37 ` Frankie Chang 2020-04-15 5:37 ` [PATCH v2 1/1] " Frankie Chang 2020-04-15 5:37 ` Frankie Chang 2020-04-15 22:25 ` Todd Kjos 2020-04-15 22:25 ` Todd Kjos 2020-04-29 8:32 ` Frankie Chang 2020-04-29 8:32 ` Frankie Chang 2020-04-30 8:13 ` Frankie Chang 2020-04-30 8:13 ` Frankie Chang 2020-04-30 8:13 ` [PATCH v3 1/1] " Frankie Chang 2020-04-30 8:13 ` Frankie Chang 2020-04-30 8:50 ` Greg Kroah-Hartman 2020-04-30 8:50 ` Greg Kroah-Hartman 2020-04-30 8:51 ` Greg Kroah-Hartman 2020-04-30 8:51 ` Greg Kroah-Hartman 2020-05-07 8:10 ` Frankie Chang 2020-05-07 8:10 ` Frankie Chang 2020-05-07 8:10 ` [PATCH v4 1/3] binder: move structs from core file to header file Frankie Chang 2020-05-07 8:10 ` [PATCH v4 2/3] binder: add trace at free transaction Frankie Chang 2020-05-07 8:10 ` [PATCH v4 3/3] binder: add transaction latency tracer Frankie Chang 2020-05-07 8:55 ` Greg Kroah-Hartman 2020-05-07 8:55 ` Greg Kroah-Hartman 2020-05-11 12:32 ` Frankie Chang 2020-05-11 12:32 ` Frankie Chang 2020-06-10 12:23 ` [PATCH v5] binder: transaction latency tracking for user build Frankie Chang 2020-06-10 12:23 ` Frankie Chang 2020-06-10 12:23 ` [PATCH v5 1/3] binder: move structs from core file to header file Frankie Chang 2020-06-10 12:23 ` [PATCH v5 2/3] binder: add trace at free transaction Frankie Chang 2020-07-20 18:23 ` Todd Kjos 2020-07-20 18:23 ` Todd Kjos 2020-07-23 2:47 ` Frankie Chang 2020-07-23 2:47 ` Frankie Chang 2020-06-10 12:23 ` [PATCH v5 3/3] binder: add transaction latency tracer Frankie Chang 2020-07-20 18:56 ` Todd Kjos 2020-07-20 18:56 ` Todd Kjos 2020-07-23 3:01 ` Frankie Chang 2020-07-23 3:01 ` Frankie Chang 2020-07-02 13:25 ` [PATCH v5] binder: transaction latency tracking for user build Frankie Chang 2020-07-02 13:25 ` Frankie Chang 2020-07-20 13:40 ` Frankie Chang 2020-07-20 13:40 ` Frankie Chang 2020-07-28 3:19 ` [PATCH v6] " Frankie Chang 2020-07-28 3:19 ` Frankie Chang 2020-07-28 3:19 ` [PATCH v6 1/3] binder: move structs from core file to header file Frankie Chang 2020-07-28 3:19 ` Frankie Chang 2020-07-28 3:20 ` [PATCH v6 2/3] binder: add trace at free transaction Frankie Chang 2020-07-28 3:20 ` Frankie Chang 2020-07-31 18:50 ` Todd Kjos 2020-07-31 18:50 ` Todd Kjos 2020-08-03 3:11 ` Frankie Chang [this message] 2020-08-03 3:11 ` Frankie Chang 2020-08-03 15:12 ` Todd Kjos 2020-08-03 15:12 ` Todd Kjos 2020-08-04 2:45 ` Frankie Chang 2020-08-04 2:45 ` Frankie Chang 2020-08-04 13:59 ` [PATCH v7] binder: transaction latency tracking for user build Frankie Chang 2020-08-04 13:59 ` Frankie Chang 2020-08-04 13:59 ` [PATCH v7 1/3] binder: move structs from core file to header file Frankie Chang 2020-08-04 13:59 ` Frankie Chang 2020-08-04 15:24 ` Todd Kjos 2020-08-04 15:24 ` Todd Kjos 2020-08-04 13:59 ` [PATCH v7 2/3] binder: add trace at free transaction Frankie Chang 2020-08-04 13:59 ` Frankie Chang 2020-08-04 15:26 ` Todd Kjos 2020-08-04 15:26 ` Todd Kjos 2020-08-04 13:59 ` [PATCH v7 3/3] binder: add transaction latency tracer Frankie Chang 2020-08-04 13:59 ` Frankie Chang 2020-08-04 15:28 ` Todd Kjos 2020-08-04 15:28 ` Todd Kjos 2020-09-07 14:41 ` peter enderborg 2020-09-07 14:41 ` peter enderborg 2020-09-03 16:21 ` [PATCH v7] binder: transaction latency tracking for user build Greg Kroah-Hartman 2020-09-03 16:21 ` Greg Kroah-Hartman 2020-09-07 6:49 ` Frankie Chang 2020-09-07 6:49 ` Frankie Chang 2020-09-07 7:00 ` Greg Kroah-Hartman 2020-09-07 7:00 ` Greg Kroah-Hartman 2020-09-07 12:00 ` [PATCH v8] " Frankie Chang 2020-09-07 12:00 ` Frankie Chang 2020-09-07 12:00 ` [PATCH v8 1/3] binder: move structs from core file to header file Frankie Chang 2020-09-07 12:00 ` [PATCH v8 2/3] binder: add trace at free transaction Frankie Chang 2020-09-07 12:00 ` [PATCH v8 3/3] binder: add transaction latency tracer Frankie Chang 2020-09-07 12:25 ` Greg Kroah-Hartman 2020-09-07 12:25 ` Greg Kroah-Hartman 2020-09-07 13:51 ` Frankie Chang 2020-09-07 13:51 ` Frankie Chang 2020-09-07 14:09 ` Greg Kroah-Hartman 2020-09-07 14:09 ` Greg Kroah-Hartman 2020-09-08 5:38 ` Frankie Chang 2020-09-08 5:38 ` Frankie Chang 2020-09-08 14:06 ` [PATCH v9] binder: transaction latency tracking for user build Frankie Chang 2020-09-08 14:06 ` Frankie Chang 2020-09-08 14:06 ` [PATCH v9 1/3] binder: move structs from core file to header file Frankie Chang 2020-09-08 14:06 ` [PATCH v9 2/3] binder: add trace at free transaction Frankie Chang 2020-09-08 14:06 ` [PATCH v9 3/3] binder: add transaction latency tracer Frankie Chang 2020-09-16 17:38 ` Greg Kroah-Hartman 2020-09-16 17:38 ` Greg Kroah-Hartman 2020-10-15 17:02 ` [PATCH v10 " Frankie Chang 2020-10-15 17:02 ` Frankie Chang 2020-10-15 17:02 ` [PATCH v10 1/3] binder: move structs from core file to header file Frankie Chang 2020-10-15 17:02 ` [PATCH v10 2/3] binder: add trace at free transaction Frankie Chang 2020-10-15 17:02 ` [PATCH v10 3/3] binder: add transaction latency tracer Frankie Chang 2020-10-29 16:08 ` Frankie Chang 2020-11-09 17:46 ` Greg Kroah-Hartman 2020-11-10 7:33 ` Frankie Chang 2020-11-10 7:52 ` Greg Kroah-Hartman 2020-11-10 7:53 ` Greg Kroah-Hartman 2020-11-10 8:05 ` Frankie Chang 2020-11-10 14:19 ` [PATCH v12] " Frankie Chang [not found] ` <1605017955-18027-3-git-send-email-Frankie.Chang@mediatek.com> 2020-11-10 15:13 ` [PATCH v12 2/3] Since the original trace_binder_transaction_received cannot precisely present the real finished time of transaction, adding a trace_binder_txn_latency_free at the point of free transaction may be more close to it Greg Kroah-Hartman 2020-11-11 3:02 ` [PATCH v13] binder: add transaction latency tracer Frankie Chang [not found] ` <1605063764-12930-4-git-send-email-Frankie.Chang@mediatek.com> 2020-11-11 7:34 ` [PATCH v13 3/3] " Greg Kroah-Hartman 2020-11-11 15:02 ` [PATCH v14] " Frankie Chang [not found] ` <1605106964-25838-2-git-send-email-Frankie.Chang@mediatek.com> 2020-11-11 15:12 ` [PATCH v14 1/3] binder: move structs from core file to header file Greg Kroah-Hartman 2020-11-11 15:58 ` Frankie Chang [not found] ` <1605106986.11768.14.camel@mtkswgap22> 2020-11-11 15:12 ` [PATCH v13 3/3] binder: add transaction latency tracer Greg Kroah-Hartman 2020-11-11 15:59 ` Frankie Chang 2020-11-13 15:45 ` Greg Kroah-Hartman 2020-11-11 7:34 ` [PATCH v13] " Greg Kroah-Hartman 2020-09-16 15:29 ` [PATCH v9] binder: transaction latency tracking for user build Greg Kroah-Hartman 2020-09-16 15:29 ` Greg Kroah-Hartman 2020-09-07 12:24 ` [PATCH v8] " Greg Kroah-Hartman 2020-09-07 12:24 ` Greg Kroah-Hartman 2020-07-28 3:20 ` [PATCH v6 3/3] binder: add transaction latency tracer Frankie Chang 2020-07-28 3:20 ` Frankie Chang 2020-05-07 18:21 ` [PATCH v4 " Todd Kjos 2020-05-07 18:21 ` Todd Kjos 2020-05-11 12:35 ` Frankie Chang 2020-05-11 12:35 ` Frankie Chang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1596424276.5207.13.camel@mtkswgap22 \ --to=frankie.chang@mediatek.com \ --cc=Jian-Min.Liu@mediatek.com \ --cc=arve@android.com \ --cc=christian@brauner.io \ --cc=gregkh@linuxfoundation.org \ --cc=joel@joelfernandes.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=maco@android.com \ --cc=tkjos@google.com \ --cc=wsd_upstream@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.