[Cluster-devel] [PATCH] gfs2: Remove a missed rcu_read_unlock() in gfs2_glock_get()

[Cluster-devel] [PATCH] gfs2: Remove a missed rcu_read_unlock() in gfs2_glock_get()

[Andrew Price]

Commit 64b8e0b83eaa "gfs2: gfs2_glock_get: Wait on freeing glocks"
missed removing the final rcu_read_unlock() call.

Signed-off-by: Andrew Price <anprice@redhat.com>
---
 fs/gfs2/glock.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index fcbe478480f7..5ad757f0ce60 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -881,7 +881,6 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number,
 	atomic_dec(&sdp->sd_glock_disposal);
 
 out:
-	rcu_read_unlock();
 	return ret;
 }
 
-- 
2.13.3

[Cluster-devel] [PATCH] gfs2: Remove a missed rcu_read_unlock() in gfs2_glock_get()

[Andreas Gruenbacher]

On Fri, Aug 4, 2017 at 12:39 PM, Andrew Price <anprice@redhat.com> wrote:
> Commit 64b8e0b83eaa "gfs2: gfs2_glock_get: Wait on freeing glocks"
> missed removing the final rcu_read_unlock() call.
>
> Signed-off-by: Andrew Price <anprice@redhat.com>
> ---
>  fs/gfs2/glock.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
> index fcbe478480f7..5ad757f0ce60 100644
> --- a/fs/gfs2/glock.c
> +++ b/fs/gfs2/glock.c
> @@ -881,7 +881,6 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number,
>         atomic_dec(&sdp->sd_glock_disposal);
>
>  out:
> -       rcu_read_unlock();
>         return ret;
>  }

It seems this fails on preemptible kernels only, so we didn't see it
in our previous testing.

Reviewed-by: Andreas Gruenbacher <agruenba@redhat.com>

Thanks,
Andreas

[Cluster-devel] [PATCH] gfs2: Remove a missed rcu_read_unlock() in gfs2_glock_get()

[Bob Peterson]

----- Original Message -----
| Commit 64b8e0b83eaa "gfs2: gfs2_glock_get: Wait on freeing glocks"
| missed removing the final rcu_read_unlock() call.
| 
| Signed-off-by: Andrew Price <anprice@redhat.com>
| ---

Hi,

Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=7bfd81576ec4d6b7d463cae3dd4a43ac1323cc30

Regards,

Bob Peterson
Red Hat File Systems