* [Intel-gfx] [PATCH i-g-t] lib: Use unsigned gen for forward compatible tests
@ 2020-08-06 14:45 ` Chris Wilson
0 siblings, 0 replies; 12+ messages in thread
From: Chris Wilson @ 2020-08-06 14:45 UTC (permalink / raw)
To: igt-dev; +Cc: intel-gfx, Chris Wilson
Unknown, so future, gen are marked as -1 which we want to treat as -1u
so that always pass >= gen checks.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2298
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
lib/intel_batchbuffer.c | 10 +++++-----
lib/intel_batchbuffer.h | 10 ++++++----
2 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
index 99c2e1489..375f11962 100644
--- a/lib/intel_batchbuffer.c
+++ b/lib/intel_batchbuffer.c
@@ -412,7 +412,7 @@ intel_blt_copy(struct intel_batchbuffer *batch,
drm_intel_bo *dst_bo, int dst_x1, int dst_y1, int dst_pitch,
int width, int height, int bpp)
{
- const int gen = batch->gen;
+ const unsigned int gen = batch->gen;
uint32_t src_tiling, dst_tiling, swizzle;
uint32_t cmd_bits = 0;
uint32_t br13_bits;
@@ -551,7 +551,7 @@ unsigned igt_buf_height(const struct igt_buf *buf)
* Returns:
* The width of the ccs buffer data.
*/
-unsigned int igt_buf_intel_ccs_width(int gen, const struct igt_buf *buf)
+unsigned int igt_buf_intel_ccs_width(unsigned int gen, const struct igt_buf *buf)
{
/*
* GEN12+: The CCS unit size is 64 bytes mapping 4 main surface
@@ -574,7 +574,7 @@ unsigned int igt_buf_intel_ccs_width(int gen, const struct igt_buf *buf)
* Returns:
* The height of the ccs buffer data.
*/
-unsigned int igt_buf_intel_ccs_height(int gen, const struct igt_buf *buf)
+unsigned int igt_buf_intel_ccs_height(unsigned int gen, const struct igt_buf *buf)
{
/*
* GEN12+: The CCS unit size is 64 bytes mapping 4 main surface
@@ -701,7 +701,7 @@ fill_object(struct drm_i915_gem_exec_object2 *obj, uint32_t gem_handle,
static void exec_blit(int fd,
struct drm_i915_gem_exec_object2 *objs, uint32_t count,
- int gen)
+ unsigned int gen)
{
struct drm_i915_gem_execbuffer2 exec = {
.buffers_ptr = to_user_pointer(objs),
@@ -2024,7 +2024,7 @@ void intel_bb_emit_blt_copy(struct intel_bb *ibb,
int dst_x1, int dst_y1, int dst_pitch,
int width, int height, int bpp)
{
- const int gen = ibb->gen;
+ const unsigned int gen = ibb->gen;
uint32_t cmd_bits = 0;
uint32_t br13_bits;
uint32_t mask;
diff --git a/lib/intel_batchbuffer.h b/lib/intel_batchbuffer.h
index a69fffd8d..cfe743edc 100644
--- a/lib/intel_batchbuffer.h
+++ b/lib/intel_batchbuffer.h
@@ -15,7 +15,7 @@
struct intel_batchbuffer {
drm_intel_bufmgr *bufmgr;
uint32_t devid;
- int gen;
+ unsigned int gen;
drm_intel_context *ctx;
drm_intel_bo *bo;
@@ -263,8 +263,10 @@ static inline bool igt_buf_compressed(const struct igt_buf *buf)
unsigned igt_buf_width(const struct igt_buf *buf);
unsigned igt_buf_height(const struct igt_buf *buf);
-unsigned int igt_buf_intel_ccs_width(int gen, const struct igt_buf *buf);
-unsigned int igt_buf_intel_ccs_height(int gen, const struct igt_buf *buf);
+unsigned int igt_buf_intel_ccs_width(unsigned int gen,
+ const struct igt_buf *buf);
+unsigned int igt_buf_intel_ccs_height(unsigned int gen,
+ const struct igt_buf *buf);
void igt_blitter_src_copy(int fd,
/* src */
@@ -431,7 +433,7 @@ igt_media_spinfunc_t igt_get_media_spinfunc(int devid);
*/
struct intel_bb {
int i915;
- int gen;
+ unsigned int gen;
bool debug;
bool enforce_relocs;
uint32_t devid;
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [igt-dev] [PATCH i-g-t] lib: Use unsigned gen for forward compatible tests
@ 2020-08-06 14:45 ` Chris Wilson
0 siblings, 0 replies; 12+ messages in thread
From: Chris Wilson @ 2020-08-06 14:45 UTC (permalink / raw)
To: igt-dev; +Cc: intel-gfx, Chris Wilson
Unknown, so future, gen are marked as -1 which we want to treat as -1u
so that always pass >= gen checks.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2298
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
lib/intel_batchbuffer.c | 10 +++++-----
lib/intel_batchbuffer.h | 10 ++++++----
2 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
index 99c2e1489..375f11962 100644
--- a/lib/intel_batchbuffer.c
+++ b/lib/intel_batchbuffer.c
@@ -412,7 +412,7 @@ intel_blt_copy(struct intel_batchbuffer *batch,
drm_intel_bo *dst_bo, int dst_x1, int dst_y1, int dst_pitch,
int width, int height, int bpp)
{
- const int gen = batch->gen;
+ const unsigned int gen = batch->gen;
uint32_t src_tiling, dst_tiling, swizzle;
uint32_t cmd_bits = 0;
uint32_t br13_bits;
@@ -551,7 +551,7 @@ unsigned igt_buf_height(const struct igt_buf *buf)
* Returns:
* The width of the ccs buffer data.
*/
-unsigned int igt_buf_intel_ccs_width(int gen, const struct igt_buf *buf)
+unsigned int igt_buf_intel_ccs_width(unsigned int gen, const struct igt_buf *buf)
{
/*
* GEN12+: The CCS unit size is 64 bytes mapping 4 main surface
@@ -574,7 +574,7 @@ unsigned int igt_buf_intel_ccs_width(int gen, const struct igt_buf *buf)
* Returns:
* The height of the ccs buffer data.
*/
-unsigned int igt_buf_intel_ccs_height(int gen, const struct igt_buf *buf)
+unsigned int igt_buf_intel_ccs_height(unsigned int gen, const struct igt_buf *buf)
{
/*
* GEN12+: The CCS unit size is 64 bytes mapping 4 main surface
@@ -701,7 +701,7 @@ fill_object(struct drm_i915_gem_exec_object2 *obj, uint32_t gem_handle,
static void exec_blit(int fd,
struct drm_i915_gem_exec_object2 *objs, uint32_t count,
- int gen)
+ unsigned int gen)
{
struct drm_i915_gem_execbuffer2 exec = {
.buffers_ptr = to_user_pointer(objs),
@@ -2024,7 +2024,7 @@ void intel_bb_emit_blt_copy(struct intel_bb *ibb,
int dst_x1, int dst_y1, int dst_pitch,
int width, int height, int bpp)
{
- const int gen = ibb->gen;
+ const unsigned int gen = ibb->gen;
uint32_t cmd_bits = 0;
uint32_t br13_bits;
uint32_t mask;
diff --git a/lib/intel_batchbuffer.h b/lib/intel_batchbuffer.h
index a69fffd8d..cfe743edc 100644
--- a/lib/intel_batchbuffer.h
+++ b/lib/intel_batchbuffer.h
@@ -15,7 +15,7 @@
struct intel_batchbuffer {
drm_intel_bufmgr *bufmgr;
uint32_t devid;
- int gen;
+ unsigned int gen;
drm_intel_context *ctx;
drm_intel_bo *bo;
@@ -263,8 +263,10 @@ static inline bool igt_buf_compressed(const struct igt_buf *buf)
unsigned igt_buf_width(const struct igt_buf *buf);
unsigned igt_buf_height(const struct igt_buf *buf);
-unsigned int igt_buf_intel_ccs_width(int gen, const struct igt_buf *buf);
-unsigned int igt_buf_intel_ccs_height(int gen, const struct igt_buf *buf);
+unsigned int igt_buf_intel_ccs_width(unsigned int gen,
+ const struct igt_buf *buf);
+unsigned int igt_buf_intel_ccs_height(unsigned int gen,
+ const struct igt_buf *buf);
void igt_blitter_src_copy(int fd,
/* src */
@@ -431,7 +433,7 @@ igt_media_spinfunc_t igt_get_media_spinfunc(int devid);
*/
struct intel_bb {
int i915;
- int gen;
+ unsigned int gen;
bool debug;
bool enforce_relocs;
uint32_t devid;
--
2.28.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib: Use unsigned gen for forward compatible tests
2020-08-06 14:45 ` [igt-dev] " Chris Wilson
(?)
@ 2020-08-06 15:19 ` Patchwork
-1 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-08-06 15:19 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 6978 bytes --]
== Series Details ==
Series: lib: Use unsigned gen for forward compatible tests
URL : https://patchwork.freedesktop.org/series/80349/
State : success
== Summary ==
CI Bug Log - changes from IGT_5762 -> IGTPW_4862
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_4862:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_pm_rpm@module-reload:
- {fi-kbl-7560u}: [WARN][1] ([i915#2249]) -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/fi-kbl-7560u/igt@i915_pm_rpm@module-reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/fi-kbl-7560u/igt@i915_pm_rpm@module-reload.html
Known issues
------------
Here are the changes found in IGTPW_4862 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_tiled_blits@basic:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/fi-tgl-y/igt@gem_tiled_blits@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/fi-tgl-y/igt@gem_tiled_blits@basic.html
* igt@i915_pm_rpm@module-reload:
- fi-tgl-y: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/fi-tgl-y/igt@i915_pm_rpm@module-reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/fi-tgl-y/igt@i915_pm_rpm@module-reload.html
- fi-byt-j1900: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-apl-guc: [DMESG-WARN][9] ([i915#1635] / [i915#1982]) -> [PASS][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/fi-apl-guc/igt@i915_module_load@reload.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/fi-apl-guc/igt@i915_module_load@reload.html
* igt@i915_selftest@live@coherency:
- fi-gdg-551: [DMESG-FAIL][11] ([i915#1748]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/fi-gdg-551/igt@i915_selftest@live@coherency.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/fi-gdg-551/igt@i915_selftest@live@coherency.html
* igt@i915_selftest@live@execlists:
- fi-icl-y: [INCOMPLETE][13] ([i915#2276]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/fi-icl-y/igt@i915_selftest@live@execlists.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/fi-icl-y/igt@i915_selftest@live@execlists.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- {fi-kbl-7560u}: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/fi-kbl-7560u/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/fi-kbl-7560u/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
- fi-icl-u2: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
* igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2:
- fi-skl-guc: [DMESG-WARN][19] ([i915#2203]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/fi-skl-guc/igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/fi-skl-guc/igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2.html
* igt@prime_self_import@basic-with_two_bos:
- fi-tgl-y: [DMESG-WARN][21] ([i915#402]) -> [PASS][22] +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
#### Warnings ####
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][23] ([i915#62] / [i915#92]) -> [DMESG-WARN][24] ([i915#62] / [i915#92] / [i915#95]) +4 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
* igt@kms_flip@basic-flip-vs-modeset@a-dp1:
- fi-kbl-x1275: [DMESG-WARN][25] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][26] ([i915#62] / [i915#92]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1748]: https://gitlab.freedesktop.org/drm/intel/issues/1748
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#2249]: https://gitlab.freedesktop.org/drm/intel/issues/2249
[i915#2276]: https://gitlab.freedesktop.org/drm/intel/issues/2276
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (45 -> 38)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5762 -> IGTPW_4862
CI-20190529: 20190529
CI_DRM_8848: f39035176cb854c6d620af7614a60a485ee26818 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4862: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/index.html
IGT_5762: ec3d9a843686a618612016de9249117dd8d862a8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/index.html
[-- Attachment #1.2: Type: text/html, Size: 8681 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for lib: Use unsigned gen for forward compatible tests
2020-08-06 14:45 ` [igt-dev] " Chris Wilson
(?)
(?)
@ 2020-08-06 20:22 ` Patchwork
-1 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-08-06 20:22 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 20165 bytes --]
== Series Details ==
Series: lib: Use unsigned gen for forward compatible tests
URL : https://patchwork.freedesktop.org/series/80349/
State : success
== Summary ==
CI Bug Log - changes from IGT_5762_full -> IGTPW_4862_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/index.html
Known issues
------------
Here are the changes found in IGTPW_4862_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@preservation-s3@rcs0:
- shard-kbl: [PASS][1] -> [DMESG-WARN][2] ([i915#165])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-kbl7/igt@gem_ctx_isolation@preservation-s3@rcs0.html
* igt@gem_exec_balancer@bonded-early:
- shard-kbl: [PASS][3] -> [FAIL][4] ([i915#2079])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-kbl4/igt@gem_exec_balancer@bonded-early.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-kbl7/igt@gem_exec_balancer@bonded-early.html
* igt@gem_exec_schedule@pi-ringfull@bcs0:
- shard-apl: [PASS][5] -> [INCOMPLETE][6] ([i915#1635])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-apl8/igt@gem_exec_schedule@pi-ringfull@bcs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-apl8/igt@gem_exec_schedule@pi-ringfull@bcs0.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-tglb: [PASS][7] -> [SKIP][8] ([i915#1904])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-tglb7/igt@i915_pm_dc@dc3co-vpb-simulation.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-tglb3/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([i915#180]) +10 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-tglb: [PASS][11] -> [DMESG-WARN][12] ([i915#128])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-tglb7/igt@kms_cursor_legacy@pipe-d-torture-bo.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-tglb2/igt@kms_cursor_legacy@pipe-d-torture-bo.html
* igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled:
- shard-apl: [PASS][13] -> [DMESG-WARN][14] ([i915#1635] / [i915#1982]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-apl8/igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-apl4/igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled.html
* igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
- shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([i915#1982]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-tglb: [PASS][17] -> [DMESG-WARN][18] ([i915#1982]) +4 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-tglb3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-pwrite.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-tglb1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [PASS][19] -> [SKIP][20] ([i915#433])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-tglb7/igt@kms_hdmi_inject@inject-audio.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-tglb6/igt@kms_hdmi_inject@inject-audio.html
- shard-iclb: [PASS][21] -> [SKIP][22] ([i915#433])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-iclb2/igt@kms_hdmi_inject@inject-audio.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-iclb7/igt@kms_hdmi_inject@inject-audio.html
* igt@kms_plane@plane-panning-bottom-right-pipe-a-planes:
- shard-glk: [PASS][23] -> [FAIL][24] ([i915#1036])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-glk1/igt@kms_plane@plane-panning-bottom-right-pipe-a-planes.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-glk7/igt@kms_plane@plane-panning-bottom-right-pipe-a-planes.html
* igt@kms_plane_cursor@pipe-b-primary-size-256:
- shard-glk: [PASS][25] -> [FAIL][26] ([i915#1559])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-glk6/igt@kms_plane_cursor@pipe-b-primary-size-256.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-glk7/igt@kms_plane_cursor@pipe-b-primary-size-256.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109642] / [fdo#111068])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-iclb3/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr2_su@page_flip:
- shard-tglb: [PASS][29] -> [SKIP][30] ([i915#1911])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-tglb3/igt@kms_psr2_su@page_flip.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-tglb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109441]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-iclb5/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@kms_vblank@pipe-b-ts-continuation-idle-hang:
- shard-snb: [PASS][33] -> [TIMEOUT][34] ([i915#1958]) +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-snb6/igt@kms_vblank@pipe-b-ts-continuation-idle-hang.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-snb4/igt@kms_vblank@pipe-b-ts-continuation-idle-hang.html
* igt@perf@blocking-parameterized:
- shard-iclb: [PASS][35] -> [FAIL][36] ([i915#1542])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-iclb7/igt@perf@blocking-parameterized.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-iclb2/igt@perf@blocking-parameterized.html
* igt@prime_busy@after-wait@vcs0:
- shard-hsw: [PASS][37] -> [FAIL][38] ([i915#2258]) +4 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-hsw4/igt@prime_busy@after-wait@vcs0.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-hsw7/igt@prime_busy@after-wait@vcs0.html
* igt@prime_self_import@basic-with_two_bos:
- shard-hsw: [PASS][39] -> [TIMEOUT][40] ([i915#1958]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-hsw7/igt@prime_self_import@basic-with_two_bos.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-hsw4/igt@prime_self_import@basic-with_two_bos.html
#### Possible fixes ####
* igt@device_reset@unbind-reset-rebind:
- shard-iclb: [DMESG-WARN][41] ([i915#1982]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-iclb3/igt@device_reset@unbind-reset-rebind.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-iclb6/igt@device_reset@unbind-reset-rebind.html
* igt@gem_exec_whisper@basic-queues-priority:
- shard-glk: [DMESG-WARN][43] ([i915#118] / [i915#95]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-glk4/igt@gem_exec_whisper@basic-queues-priority.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-glk4/igt@gem_exec_whisper@basic-queues-priority.html
* igt@i915_pm_dc@dc5-psr:
- shard-iclb: [FAIL][45] ([i915#1899]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-iclb5/igt@i915_pm_dc@dc5-psr.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-iclb2/igt@i915_pm_dc@dc5-psr.html
- shard-tglb: [FAIL][47] ([i915#1899]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-tglb3/igt@i915_pm_dc@dc5-psr.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-tglb5/igt@i915_pm_dc@dc5-psr.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- shard-glk: [DMESG-FAIL][49] ([i915#118] / [i915#95]) -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-glk8/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-glk6/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
* igt@kms_color@pipe-a-ctm-max:
- shard-kbl: [FAIL][51] ([i915#168]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-kbl2/igt@kms_color@pipe-a-ctm-max.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-kbl7/igt@kms_color@pipe-a-ctm-max.html
- shard-apl: [FAIL][53] ([i915#1635] / [i915#168]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-apl3/igt@kms_color@pipe-a-ctm-max.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-apl3/igt@kms_color@pipe-a-ctm-max.html
* igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a2:
- shard-glk: [FAIL][55] ([i915#79]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-glk6/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a2.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-glk6/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a2.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-pwrite:
- shard-glk: [FAIL][57] ([i915#49]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-pwrite.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-glk: [DMESG-WARN][59] ([i915#1982]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-glk1/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-glk2/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-tglb: [DMESG-WARN][61] ([i915#1982]) -> [PASS][62] +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [DMESG-WARN][63] ([i915#180]) -> [PASS][64] +3 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-kbl2/igt@kms_hdr@bpc-switch-suspend.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-kbl1/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_panel_fitting@atomic-fastset:
- shard-tglb: [FAIL][65] ([i915#83]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-tglb2/igt@kms_panel_fitting@atomic-fastset.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-tglb3/igt@kms_panel_fitting@atomic-fastset.html
- shard-iclb: [FAIL][67] ([i915#83]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-iclb7/igt@kms_panel_fitting@atomic-fastset.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-iclb6/igt@kms_panel_fitting@atomic-fastset.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [SKIP][69] ([fdo#109441]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-iclb7/igt@kms_psr@psr2_cursor_plane_move.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_setmode@basic:
- shard-kbl: [FAIL][71] ([i915#31]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-kbl2/igt@kms_setmode@basic.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-kbl1/igt@kms_setmode@basic.html
* igt@kms_universal_plane@universal-plane-pipe-c-functional:
- shard-hsw: [TIMEOUT][73] ([i915#1958]) -> [PASS][74] +2 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-hsw4/igt@kms_universal_plane@universal-plane-pipe-c-functional.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-hsw2/igt@kms_universal_plane@universal-plane-pipe-c-functional.html
* igt@kms_vblank@pipe-a-ts-continuation-modeset-hang:
- shard-hsw: [INCOMPLETE][75] -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-hsw7/igt@kms_vblank@pipe-a-ts-continuation-modeset-hang.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-hsw1/igt@kms_vblank@pipe-a-ts-continuation-modeset-hang.html
* igt@kms_vblank@pipe-b-ts-continuation-modeset-hang:
- shard-apl: [DMESG-WARN][77] ([i915#1635] / [i915#1982]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-apl8/igt@kms_vblank@pipe-b-ts-continuation-modeset-hang.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-apl6/igt@kms_vblank@pipe-b-ts-continuation-modeset-hang.html
* igt@prime_busy@before-wait@vecs0:
- shard-hsw: [FAIL][79] ([i915#2258]) -> [PASS][80] +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-hsw6/igt@prime_busy@before-wait@vecs0.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-hsw1/igt@prime_busy@before-wait@vecs0.html
#### Warnings ####
* igt@gem_exec_reloc@basic-concurrent16:
- shard-snb: [FAIL][81] ([i915#1930]) -> [TIMEOUT][82] ([i915#1958])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-snb5/igt@gem_exec_reloc@basic-concurrent16.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-snb4/igt@gem_exec_reloc@basic-concurrent16.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][83] ([i915#588]) -> [SKIP][84] ([i915#658])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-iclb6/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@kms_chamelium@common-hpd-after-suspend:
- shard-hsw: [TIMEOUT][85] ([i915#1958]) -> [SKIP][86] ([fdo#109271] / [fdo#111827])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-hsw4/igt@kms_chamelium@common-hpd-after-suspend.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-hsw2/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-cpu:
- shard-hsw: [SKIP][87] ([fdo#109271]) -> [TIMEOUT][88] ([i915#1958])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-hsw4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-cpu.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-hsw4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-cpu.html
- shard-snb: [SKIP][89] ([fdo#109271]) -> [TIMEOUT][90] ([i915#1958]) +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-snb5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-cpu.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-snb4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-cpu.html
* igt@perf@polling-parameterized:
- shard-hsw: [FAIL][91] ([i915#1542]) -> [INCOMPLETE][92] ([i915#1958])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-hsw6/igt@perf@polling-parameterized.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-hsw4/igt@perf@polling-parameterized.html
* igt@runner@aborted:
- shard-apl: [FAIL][93] ([fdo#109271] / [i915#1635] / [i915#716]) -> ([FAIL][94], [FAIL][95]) ([fdo#109271] / [i915#1610] / [i915#1635] / [i915#716])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5762/shard-apl7/igt@runner@aborted.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-apl8/igt@runner@aborted.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/shard-apl2/igt@runner@aborted.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1036]: https://gitlab.freedesktop.org/drm/intel/issues/1036
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#128]: https://gitlab.freedesktop.org/drm/intel/issues/128
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1559]: https://gitlab.freedesktop.org/drm/intel/issues/1559
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#168]: https://gitlab.freedesktop.org/drm/intel/issues/168
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1899]: https://gitlab.freedesktop.org/drm/intel/issues/1899
[i915#1904]: https://gitlab.freedesktop.org/drm/intel/issues/1904
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1930]: https://gitlab.freedesktop.org/drm/intel/issues/1930
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2079]: https://gitlab.freedesktop.org/drm/intel/issues/2079
[i915#2258]: https://gitlab.freedesktop.org/drm/intel/issues/2258
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#83]: https://gitlab.freedesktop.org/drm/intel/issues/83
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (8 -> 8)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5762 -> IGTPW_4862
CI-20190529: 20190529
CI_DRM_8848: f39035176cb854c6d620af7614a60a485ee26818 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4862: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/index.html
IGT_5762: ec3d9a843686a618612016de9249117dd8d862a8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4862/index.html
[-- Attachment #1.2: Type: text/html, Size: 24093 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] lib: Use unsigned gen for forward compatible tests
2020-08-06 14:45 ` [igt-dev] " Chris Wilson
@ 2020-08-10 8:09 ` Zbigniew Kempczyński
-1 siblings, 0 replies; 12+ messages in thread
From: Zbigniew Kempczyński @ 2020-08-10 8:09 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx
On Thu, Aug 06, 2020 at 03:45:29PM +0100, Chris Wilson wrote:
> Unknown, so future, gen are marked as -1 which we want to treat as -1u
> so that always pass >= gen checks.
Do we really want to enable the tests when platform is not fully
enabled in IGT?
--
Zbigniew
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2298
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> ---
> lib/intel_batchbuffer.c | 10 +++++-----
> lib/intel_batchbuffer.h | 10 ++++++----
> 2 files changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
> index 99c2e1489..375f11962 100644
> --- a/lib/intel_batchbuffer.c
> +++ b/lib/intel_batchbuffer.c
> @@ -412,7 +412,7 @@ intel_blt_copy(struct intel_batchbuffer *batch,
> drm_intel_bo *dst_bo, int dst_x1, int dst_y1, int dst_pitch,
> int width, int height, int bpp)
> {
> - const int gen = batch->gen;
> + const unsigned int gen = batch->gen;
> uint32_t src_tiling, dst_tiling, swizzle;
> uint32_t cmd_bits = 0;
> uint32_t br13_bits;
> @@ -551,7 +551,7 @@ unsigned igt_buf_height(const struct igt_buf *buf)
> * Returns:
> * The width of the ccs buffer data.
> */
> -unsigned int igt_buf_intel_ccs_width(int gen, const struct igt_buf *buf)
> +unsigned int igt_buf_intel_ccs_width(unsigned int gen, const struct igt_buf *buf)
> {
> /*
> * GEN12+: The CCS unit size is 64 bytes mapping 4 main surface
> @@ -574,7 +574,7 @@ unsigned int igt_buf_intel_ccs_width(int gen, const struct igt_buf *buf)
> * Returns:
> * The height of the ccs buffer data.
> */
> -unsigned int igt_buf_intel_ccs_height(int gen, const struct igt_buf *buf)
> +unsigned int igt_buf_intel_ccs_height(unsigned int gen, const struct igt_buf *buf)
> {
> /*
> * GEN12+: The CCS unit size is 64 bytes mapping 4 main surface
> @@ -701,7 +701,7 @@ fill_object(struct drm_i915_gem_exec_object2 *obj, uint32_t gem_handle,
>
> static void exec_blit(int fd,
> struct drm_i915_gem_exec_object2 *objs, uint32_t count,
> - int gen)
> + unsigned int gen)
> {
> struct drm_i915_gem_execbuffer2 exec = {
> .buffers_ptr = to_user_pointer(objs),
> @@ -2024,7 +2024,7 @@ void intel_bb_emit_blt_copy(struct intel_bb *ibb,
> int dst_x1, int dst_y1, int dst_pitch,
> int width, int height, int bpp)
> {
> - const int gen = ibb->gen;
> + const unsigned int gen = ibb->gen;
> uint32_t cmd_bits = 0;
> uint32_t br13_bits;
> uint32_t mask;
> diff --git a/lib/intel_batchbuffer.h b/lib/intel_batchbuffer.h
> index a69fffd8d..cfe743edc 100644
> --- a/lib/intel_batchbuffer.h
> +++ b/lib/intel_batchbuffer.h
> @@ -15,7 +15,7 @@
> struct intel_batchbuffer {
> drm_intel_bufmgr *bufmgr;
> uint32_t devid;
> - int gen;
> + unsigned int gen;
>
> drm_intel_context *ctx;
> drm_intel_bo *bo;
> @@ -263,8 +263,10 @@ static inline bool igt_buf_compressed(const struct igt_buf *buf)
>
> unsigned igt_buf_width(const struct igt_buf *buf);
> unsigned igt_buf_height(const struct igt_buf *buf);
> -unsigned int igt_buf_intel_ccs_width(int gen, const struct igt_buf *buf);
> -unsigned int igt_buf_intel_ccs_height(int gen, const struct igt_buf *buf);
> +unsigned int igt_buf_intel_ccs_width(unsigned int gen,
> + const struct igt_buf *buf);
> +unsigned int igt_buf_intel_ccs_height(unsigned int gen,
> + const struct igt_buf *buf);
>
> void igt_blitter_src_copy(int fd,
> /* src */
> @@ -431,7 +433,7 @@ igt_media_spinfunc_t igt_get_media_spinfunc(int devid);
> */
> struct intel_bb {
> int i915;
> - int gen;
> + unsigned int gen;
> bool debug;
> bool enforce_relocs;
> uint32_t devid;
> --
> 2.28.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib: Use unsigned gen for forward compatible tests
@ 2020-08-10 8:09 ` Zbigniew Kempczyński
0 siblings, 0 replies; 12+ messages in thread
From: Zbigniew Kempczyński @ 2020-08-10 8:09 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx
On Thu, Aug 06, 2020 at 03:45:29PM +0100, Chris Wilson wrote:
> Unknown, so future, gen are marked as -1 which we want to treat as -1u
> so that always pass >= gen checks.
Do we really want to enable the tests when platform is not fully
enabled in IGT?
--
Zbigniew
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2298
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> ---
> lib/intel_batchbuffer.c | 10 +++++-----
> lib/intel_batchbuffer.h | 10 ++++++----
> 2 files changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
> index 99c2e1489..375f11962 100644
> --- a/lib/intel_batchbuffer.c
> +++ b/lib/intel_batchbuffer.c
> @@ -412,7 +412,7 @@ intel_blt_copy(struct intel_batchbuffer *batch,
> drm_intel_bo *dst_bo, int dst_x1, int dst_y1, int dst_pitch,
> int width, int height, int bpp)
> {
> - const int gen = batch->gen;
> + const unsigned int gen = batch->gen;
> uint32_t src_tiling, dst_tiling, swizzle;
> uint32_t cmd_bits = 0;
> uint32_t br13_bits;
> @@ -551,7 +551,7 @@ unsigned igt_buf_height(const struct igt_buf *buf)
> * Returns:
> * The width of the ccs buffer data.
> */
> -unsigned int igt_buf_intel_ccs_width(int gen, const struct igt_buf *buf)
> +unsigned int igt_buf_intel_ccs_width(unsigned int gen, const struct igt_buf *buf)
> {
> /*
> * GEN12+: The CCS unit size is 64 bytes mapping 4 main surface
> @@ -574,7 +574,7 @@ unsigned int igt_buf_intel_ccs_width(int gen, const struct igt_buf *buf)
> * Returns:
> * The height of the ccs buffer data.
> */
> -unsigned int igt_buf_intel_ccs_height(int gen, const struct igt_buf *buf)
> +unsigned int igt_buf_intel_ccs_height(unsigned int gen, const struct igt_buf *buf)
> {
> /*
> * GEN12+: The CCS unit size is 64 bytes mapping 4 main surface
> @@ -701,7 +701,7 @@ fill_object(struct drm_i915_gem_exec_object2 *obj, uint32_t gem_handle,
>
> static void exec_blit(int fd,
> struct drm_i915_gem_exec_object2 *objs, uint32_t count,
> - int gen)
> + unsigned int gen)
> {
> struct drm_i915_gem_execbuffer2 exec = {
> .buffers_ptr = to_user_pointer(objs),
> @@ -2024,7 +2024,7 @@ void intel_bb_emit_blt_copy(struct intel_bb *ibb,
> int dst_x1, int dst_y1, int dst_pitch,
> int width, int height, int bpp)
> {
> - const int gen = ibb->gen;
> + const unsigned int gen = ibb->gen;
> uint32_t cmd_bits = 0;
> uint32_t br13_bits;
> uint32_t mask;
> diff --git a/lib/intel_batchbuffer.h b/lib/intel_batchbuffer.h
> index a69fffd8d..cfe743edc 100644
> --- a/lib/intel_batchbuffer.h
> +++ b/lib/intel_batchbuffer.h
> @@ -15,7 +15,7 @@
> struct intel_batchbuffer {
> drm_intel_bufmgr *bufmgr;
> uint32_t devid;
> - int gen;
> + unsigned int gen;
>
> drm_intel_context *ctx;
> drm_intel_bo *bo;
> @@ -263,8 +263,10 @@ static inline bool igt_buf_compressed(const struct igt_buf *buf)
>
> unsigned igt_buf_width(const struct igt_buf *buf);
> unsigned igt_buf_height(const struct igt_buf *buf);
> -unsigned int igt_buf_intel_ccs_width(int gen, const struct igt_buf *buf);
> -unsigned int igt_buf_intel_ccs_height(int gen, const struct igt_buf *buf);
> +unsigned int igt_buf_intel_ccs_width(unsigned int gen,
> + const struct igt_buf *buf);
> +unsigned int igt_buf_intel_ccs_height(unsigned int gen,
> + const struct igt_buf *buf);
>
> void igt_blitter_src_copy(int fd,
> /* src */
> @@ -431,7 +433,7 @@ igt_media_spinfunc_t igt_get_media_spinfunc(int devid);
> */
> struct intel_bb {
> int i915;
> - int gen;
> + unsigned int gen;
> bool debug;
> bool enforce_relocs;
> uint32_t devid;
> --
> 2.28.0
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] lib: Use unsigned gen for forward compatible tests
2020-08-10 8:09 ` [igt-dev] " Zbigniew Kempczyński
@ 2020-08-10 8:22 ` Petri Latvala
-1 siblings, 0 replies; 12+ messages in thread
From: Petri Latvala @ 2020-08-10 8:22 UTC (permalink / raw)
To: Zbigniew Kempczyński; +Cc: igt-dev, intel-gfx, Chris Wilson
On Mon, Aug 10, 2020 at 10:09:46AM +0200, Zbigniew Kempczyński wrote:
> On Thu, Aug 06, 2020 at 03:45:29PM +0100, Chris Wilson wrote:
> > Unknown, so future, gen are marked as -1 which we want to treat as -1u
> > so that always pass >= gen checks.
>
> Do we really want to enable the tests when platform is not fully
> enabled in IGT?
What does "fully enabled" mean?
If the test is checking for just "gen > x", the test should work
already. If the test is also checking for "gen < y" then we get a
spurious failure, but either way CI is going to tell you that
something is not passing. Without this it will be a skip, along with
skipping in the case that should just work already without actual test
changes.
--
Petri Latvala
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib: Use unsigned gen for forward compatible tests
@ 2020-08-10 8:22 ` Petri Latvala
0 siblings, 0 replies; 12+ messages in thread
From: Petri Latvala @ 2020-08-10 8:22 UTC (permalink / raw)
To: Zbigniew Kempczyński; +Cc: igt-dev, intel-gfx, Chris Wilson
On Mon, Aug 10, 2020 at 10:09:46AM +0200, Zbigniew Kempczyński wrote:
> On Thu, Aug 06, 2020 at 03:45:29PM +0100, Chris Wilson wrote:
> > Unknown, so future, gen are marked as -1 which we want to treat as -1u
> > so that always pass >= gen checks.
>
> Do we really want to enable the tests when platform is not fully
> enabled in IGT?
What does "fully enabled" mean?
If the test is checking for just "gen > x", the test should work
already. If the test is also checking for "gen < y" then we get a
spurious failure, but either way CI is going to tell you that
something is not passing. Without this it will be a skip, along with
skipping in the case that should just work already without actual test
changes.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] lib: Use unsigned gen for forward compatible tests
2020-08-10 8:22 ` Petri Latvala
@ 2020-08-10 8:56 ` Chris Wilson
-1 siblings, 0 replies; 12+ messages in thread
From: Chris Wilson @ 2020-08-10 8:56 UTC (permalink / raw)
To: Petri Latvala, Zbigniew Kempczyński; +Cc: igt-dev, intel-gfx
Quoting Petri Latvala (2020-08-10 09:22:42)
> On Mon, Aug 10, 2020 at 10:09:46AM +0200, Zbigniew Kempczyński wrote:
> > On Thu, Aug 06, 2020 at 03:45:29PM +0100, Chris Wilson wrote:
> > > Unknown, so future, gen are marked as -1 which we want to treat as -1u
> > > so that always pass >= gen checks.
> >
> > Do we really want to enable the tests when platform is not fully
> > enabled in IGT?
>
> What does "fully enabled" mean?
>
> If the test is checking for just "gen > x", the test should work
> already. If the test is also checking for "gen < y" then we get a
> spurious failure, but either way CI is going to tell you that
> something is not passing. Without this it will be a skip, along with
> skipping in the case that should just work already without actual test
> changes.
And for a very large fraction of tests, the behaviour of next gen
follows current gen. Those that do not are very interesting, and will be
a much smaller number than the volume of skips we have to process.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib: Use unsigned gen for forward compatible tests
@ 2020-08-10 8:56 ` Chris Wilson
0 siblings, 0 replies; 12+ messages in thread
From: Chris Wilson @ 2020-08-10 8:56 UTC (permalink / raw)
To: Petri Latvala, zbigniew.kempczynski; +Cc: igt-dev, intel-gfx
Quoting Petri Latvala (2020-08-10 09:22:42)
> On Mon, Aug 10, 2020 at 10:09:46AM +0200, Zbigniew Kempczyński wrote:
> > On Thu, Aug 06, 2020 at 03:45:29PM +0100, Chris Wilson wrote:
> > > Unknown, so future, gen are marked as -1 which we want to treat as -1u
> > > so that always pass >= gen checks.
> >
> > Do we really want to enable the tests when platform is not fully
> > enabled in IGT?
>
> What does "fully enabled" mean?
>
> If the test is checking for just "gen > x", the test should work
> already. If the test is also checking for "gen < y" then we get a
> spurious failure, but either way CI is going to tell you that
> something is not passing. Without this it will be a skip, along with
> skipping in the case that should just work already without actual test
> changes.
And for a very large fraction of tests, the behaviour of next gen
follows current gen. Those that do not are very interesting, and will be
a much smaller number than the volume of skips we have to process.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] lib: Use unsigned gen for forward compatible tests
2020-08-10 8:56 ` Chris Wilson
@ 2020-08-28 12:37 ` Zbigniew Kempczyński
-1 siblings, 0 replies; 12+ messages in thread
From: Zbigniew Kempczyński @ 2020-08-28 12:37 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx
On Mon, Aug 10, 2020 at 09:56:34AM +0100, Chris Wilson wrote:
> Quoting Petri Latvala (2020-08-10 09:22:42)
> > On Mon, Aug 10, 2020 at 10:09:46AM +0200, Zbigniew Kempczyński wrote:
> > > On Thu, Aug 06, 2020 at 03:45:29PM +0100, Chris Wilson wrote:
> > > > Unknown, so future, gen are marked as -1 which we want to treat as -1u
> > > > so that always pass >= gen checks.
> > >
> > > Do we really want to enable the tests when platform is not fully
> > > enabled in IGT?
> >
> > What does "fully enabled" mean?
> >
> > If the test is checking for just "gen > x", the test should work
> > already. If the test is also checking for "gen < y" then we get a
> > spurious failure, but either way CI is going to tell you that
> > something is not passing. Without this it will be a skip, along with
> > skipping in the case that should just work already without actual test
> > changes.
>
> And for a very large fraction of tests, the behaviour of next gen
> follows current gen. Those that do not are very interesting, and will be
> a much smaller number than the volume of skips we have to process.
> -Chris
So patch only defers in time adding explicit platform definition.
For each tests which requires exact gen test will fail anyway, but
other will likely work. If they won't we'll know it from CI.
I see no big risk but let Petri decide, from my side:
Acked-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib: Use unsigned gen for forward compatible tests
@ 2020-08-28 12:37 ` Zbigniew Kempczyński
0 siblings, 0 replies; 12+ messages in thread
From: Zbigniew Kempczyński @ 2020-08-28 12:37 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx, Petri Latvala
On Mon, Aug 10, 2020 at 09:56:34AM +0100, Chris Wilson wrote:
> Quoting Petri Latvala (2020-08-10 09:22:42)
> > On Mon, Aug 10, 2020 at 10:09:46AM +0200, Zbigniew Kempczyński wrote:
> > > On Thu, Aug 06, 2020 at 03:45:29PM +0100, Chris Wilson wrote:
> > > > Unknown, so future, gen are marked as -1 which we want to treat as -1u
> > > > so that always pass >= gen checks.
> > >
> > > Do we really want to enable the tests when platform is not fully
> > > enabled in IGT?
> >
> > What does "fully enabled" mean?
> >
> > If the test is checking for just "gen > x", the test should work
> > already. If the test is also checking for "gen < y" then we get a
> > spurious failure, but either way CI is going to tell you that
> > something is not passing. Without this it will be a skip, along with
> > skipping in the case that should just work already without actual test
> > changes.
>
> And for a very large fraction of tests, the behaviour of next gen
> follows current gen. Those that do not are very interesting, and will be
> a much smaller number than the volume of skips we have to process.
> -Chris
So patch only defers in time adding explicit platform definition.
For each tests which requires exact gen test will fail anyway, but
other will likely work. If they won't we'll know it from CI.
I see no big risk but let Petri decide, from my side:
Acked-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-08-28 12:37 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-06 14:45 [Intel-gfx] [PATCH i-g-t] lib: Use unsigned gen for forward compatible tests Chris Wilson
2020-08-06 14:45 ` [igt-dev] " Chris Wilson
2020-08-06 15:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-08-06 20:22 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2020-08-10 8:09 ` [Intel-gfx] [PATCH i-g-t] " Zbigniew Kempczyński
2020-08-10 8:09 ` [igt-dev] " Zbigniew Kempczyński
2020-08-10 8:22 ` [Intel-gfx] " Petri Latvala
2020-08-10 8:22 ` Petri Latvala
2020-08-10 8:56 ` [Intel-gfx] " Chris Wilson
2020-08-10 8:56 ` Chris Wilson
2020-08-28 12:37 ` [Intel-gfx] " Zbigniew Kempczyński
2020-08-28 12:37 ` Zbigniew Kempczyński
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.