[PATCH] MIPS: Fix compile warnnings in kexec-elf-mips.c

[PATCH] MIPS: Fix compile warnnings in kexec-elf-mips.c

[Youling Tang]

Fix the following warnings:

kexec/arch/mips/kexec-elf-mips.c:161:41: warning: passing argument 3 of
‘dtb_set_initrd’ makes integer from pointer without a cast
dtb_set_initrd(&dtb_buf, &dtb_length, initrd_buf, initrd_buf + initrd_size);
                                         ^
In file included from kexec/arch/mips/kexec-elf-mips.c:33:0:
kexec/arch/mips/../../dt-ops.h:6:5: note: expected ‘off_t’ but argument is
of type ‘char *’
int dtb_set_initrd(char **dtb, off_t *dtb_size, off_t start, off_t end);
     ^

kexec/arch/mips/kexec-elf-mips.c:161:53: warning: passing argument 4 of
‘dtb_set_initrd’ makes integer from pointer without a cast
dtb_set_initrd(&dtb_buf, &dtb_length, initrd_buf, initrd_buf + initrd_size);
                                                     ^
In file included from kexec/arch/mips/kexec-elf-mips.c:33:0:
kexec/arch/mips/../../dt-ops.h:6:5: note: expected ‘off_t’ but argument is
of type ‘char *’
int dtb_set_initrd(char **dtb, off_t *dtb_size, off_t start, off_t end);
     ^

Signed-off-by: Youling Tang <tangyouling@loongson.cn>
---
 kexec/arch/mips/kexec-elf-mips.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kexec/arch/mips/kexec-elf-mips.c b/kexec/arch/mips/kexec-elf-mips.c
index cf90879..a2d11fc 100644
--- a/kexec/arch/mips/kexec-elf-mips.c
+++ b/kexec/arch/mips/kexec-elf-mips.c
@@ -161,7 +161,7 @@ int elf_mips_load(int argc, char **argv, const char *buf, off_t len,
 
 		/* Create initrd entries in dtb - although at this time
 		 * they would not point to the correct location */
-		dtb_set_initrd(&dtb_buf, &dtb_length, initrd_buf, initrd_buf + initrd_size);
+		dtb_set_initrd(&dtb_buf, &dtb_length, (off_t)initrd_buf, (off_t)initrd_buf + initrd_size);
 
 		initrd_base = add_buffer(info, initrd_buf, initrd_size,
 					initrd_size, sizeof(void *),
-- 
2.1.0


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH] MIPS: Fix compile warnnings in kexec-elf-mips.c

[Simon Horman]

On Thu, Aug 13, 2020 at 01:31:52PM +0800, Youling Tang wrote:
> Fix the following warnings:
> 
> kexec/arch/mips/kexec-elf-mips.c:161:41: warning: passing argument 3 of
> ‘dtb_set_initrd’ makes integer from pointer without a cast
> dtb_set_initrd(&dtb_buf, &dtb_length, initrd_buf, initrd_buf + initrd_size);
>                                          ^
> In file included from kexec/arch/mips/kexec-elf-mips.c:33:0:
> kexec/arch/mips/../../dt-ops.h:6:5: note: expected ‘off_t’ but argument is
> of type ‘char *’
> int dtb_set_initrd(char **dtb, off_t *dtb_size, off_t start, off_t end);
>      ^
> 
> kexec/arch/mips/kexec-elf-mips.c:161:53: warning: passing argument 4 of
> ‘dtb_set_initrd’ makes integer from pointer without a cast
> dtb_set_initrd(&dtb_buf, &dtb_length, initrd_buf, initrd_buf + initrd_size);
>                                                      ^
> In file included from kexec/arch/mips/kexec-elf-mips.c:33:0:
> kexec/arch/mips/../../dt-ops.h:6:5: note: expected ‘off_t’ but argument is
> of type ‘char *’
> int dtb_set_initrd(char **dtb, off_t *dtb_size, off_t start, off_t end);
>      ^
> 
> Signed-off-by: Youling Tang <tangyouling@loongson.cn>

Thanks, applied.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec