All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
	Sylwester Nawrocki <snawrocki@kernel.org>
Cc: linux-clk@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Lukasz Luba <lukasz.luba@arm.com>
Subject: Re: [PATCH v2] clk: samsung: Keep top BPLL mux on Exynos542x enabled
Date: Tue, 18 Aug 2020 20:12:28 -0700	[thread overview]
Message-ID: <159780674861.334488.4319979250253283002@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <2ab29b37-5e7f-1a7a-e29c-f20f95aec1a9@kernel.org>

Quoting Sylwester Nawrocki (2020-08-11 04:31:30)
> On 8/7/20 15:31, Marek Szyprowski wrote:
> > BPLL clock must not be disabled because it is needed for proper DRAM
> > operation. This is normally handled by respective memory devfreq driver,
> > but when that driver is not yet probed or its probe has been deferred the
> > clock might got disabled what causes board hang. Fix this by calling
> > clk_prepare_enable() directly from the clock provider driver.
> > 
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
> > Tested-by: Lukasz Luba <lukasz.luba@arm.com>
> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> Should we add a "Fixes" tag so this commit gets backported down do the 
> kernels where the DMC driver was introduced?
> 
> Fixes: 6e7674c3c6df ("memory: Add DMC driver for Exynos5422") ?

I've recently discovered that stable trees aren't checking for Fixes
tags. So we have to put both a Fixes tag and a Cc stable on the patch
to make sure it gets applied to stable trees. Otherwise it's up to the
robot to figure out that a Fixes tag means maybe this is important.

  reply	other threads:[~2020-08-19  3:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200807133152eucas1p1d83611a984f5c5d875192d08e2f5711f@eucas1p1.samsung.com>
2020-08-07 13:31 ` [PATCH v2] clk: samsung: Keep top BPLL mux on Exynos542x enabled Marek Szyprowski
2020-08-10  2:58   ` Chanwoo Choi
2020-08-11  8:49   ` [clk] a2499eff4b: BUG:kernel_NULL_pointer_dereference,address kernel test robot
2020-08-11  8:49     ` kernel test robot
2020-08-19  3:13     ` Stephen Boyd
2020-08-19  3:13       ` [clk] a2499eff4b: BUG:kernel_NULL_pointer_dereference, address Stephen Boyd
2020-08-20  5:03       ` [clk] a2499eff4b: BUG:kernel_NULL_pointer_dereference,address Rong Chen
2020-08-20  5:03         ` [clk] a2499eff4b: BUG:kernel_NULL_pointer_dereference, address Rong Chen
2020-08-11 11:31   ` [PATCH v2] clk: samsung: Keep top BPLL mux on Exynos542x enabled Sylwester Nawrocki
2020-08-19  3:12     ` Stephen Boyd [this message]
2020-08-19  3:14   ` Stephen Boyd
2020-08-23 10:12     ` Sylwester Nawrocki
2020-08-24 10:28       ` Sylwester Nawrocki
2020-08-24 10:31         ` Krzysztof Kozlowski
2020-09-02  9:24           ` Sylwester Nawrocki
2020-09-15 12:43             ` Sylwester Nawrocki
2020-09-15 16:17               ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=159780674861.334488.4319979250253283002@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=krzk@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=m.szyprowski@samsung.com \
    --cc=snawrocki@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.