All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sylwester Nawrocki <snawrocki@kernel.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
	linux-samsung-soc@vger.kernel.org,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	linux-clk@vger.kernel.org, linux-pm@vger.kernel.org,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Lukasz Luba <lukasz.luba@arm.com>
Subject: Re: [PATCH v2] clk: samsung: Keep top BPLL mux on Exynos542x enabled
Date: Mon, 24 Aug 2020 12:31:23 +0200	[thread overview]
Message-ID: <20200824103123.GD25860@kozik-lap> (raw)
In-Reply-To: <fff07b05-f1f6-5333-a056-69ba6995ed4f@kernel.org>

On Mon, Aug 24, 2020 at 12:28:51PM +0200, Sylwester Nawrocki wrote:
> On 8/23/20 12:12, Sylwester Nawrocki wrote:
> > On 8/19/20 05:14, Stephen Boyd wrote:
> > > Quoting Marek Szyprowski (2020-08-07 06:31:43)
> > > > BPLL clock must not be disabled because it is needed for proper DRAM
> > > > operation. This is normally handled by respective memory devfreq driver,
> > > > but when that driver is not yet probed or its probe has been
> > > > deferred the
> > > > clock might got disabled what causes board hang. Fix this by calling
> > > > clk_prepare_enable() directly from the clock provider driver.
> > > > 
> > > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > > > Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
> > > > Tested-by: Lukasz Luba <lukasz.luba@arm.com>
> > > > Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > > ---
> > > 
> > > Can I pick this up for clk-fixes?
> > 
> > Sure, thanks for taking care of this.
> 
> OTOH, I planned to queue that patch for next merged window, together with a
> patch that depends on that one, since the fix is not for an issue
> introduced in the last merge window.
> I guess it's better to avoid pulling (part of) the clk-fixes branch to
> the clk/samsung tree for next merge window?

All current multi_v7 and some of exynos defconfig boots fail on Odroid
XU3-family, starting from v5.9-rc1. On kernelci and my boot systems. If
I understand correctly, this is a fix for this issue, so it should go as
fast as possible to v5.9 cycle.

Otherwise we cannot test anything. The current v5.9 RC is then simply broken.

Best regards,
Krzysztof


  reply	other threads:[~2020-08-24 10:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200807133152eucas1p1d83611a984f5c5d875192d08e2f5711f@eucas1p1.samsung.com>
2020-08-07 13:31 ` [PATCH v2] clk: samsung: Keep top BPLL mux on Exynos542x enabled Marek Szyprowski
2020-08-10  2:58   ` Chanwoo Choi
2020-08-11  8:49   ` [clk] a2499eff4b: BUG:kernel_NULL_pointer_dereference,address kernel test robot
2020-08-11  8:49     ` kernel test robot
2020-08-19  3:13     ` Stephen Boyd
2020-08-19  3:13       ` [clk] a2499eff4b: BUG:kernel_NULL_pointer_dereference, address Stephen Boyd
2020-08-20  5:03       ` [clk] a2499eff4b: BUG:kernel_NULL_pointer_dereference,address Rong Chen
2020-08-20  5:03         ` [clk] a2499eff4b: BUG:kernel_NULL_pointer_dereference, address Rong Chen
2020-08-11 11:31   ` [PATCH v2] clk: samsung: Keep top BPLL mux on Exynos542x enabled Sylwester Nawrocki
2020-08-19  3:12     ` Stephen Boyd
2020-08-19  3:14   ` Stephen Boyd
2020-08-23 10:12     ` Sylwester Nawrocki
2020-08-24 10:28       ` Sylwester Nawrocki
2020-08-24 10:31         ` Krzysztof Kozlowski [this message]
2020-09-02  9:24           ` Sylwester Nawrocki
2020-09-15 12:43             ` Sylwester Nawrocki
2020-09-15 16:17               ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200824103123.GD25860@kozik-lap \
    --to=krzk@kernel.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=m.szyprowski@samsung.com \
    --cc=sboyd@kernel.org \
    --cc=snawrocki@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.