[LTP] [PATCH] travis: Add centos7 build

[LTP] [PATCH] travis: Add centos7 build

[Yang Xu]

I have this idea when I meet ALG_SET_AEAD_ASSOCLEN undefined error on centos7.
Add centos7 travis target, it is more friendly for centos7 user and it is more
meaningful than centos6.

I have tested this patch on my ltp fork:
https://travis-ci.org/github/xuyang0410/ltp/jobs/720541105

Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
 .travis.yml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.travis.yml b/.travis.yml
index e8e3189af..281ec9e96 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -47,6 +47,10 @@ matrix:
           env: DISTRO=centos:6 TREE=out
           compiler: gcc
 
+        - os: linux
+          env: DISTRO=centos:7 TREE=out
+          compiler: gcc
+
         - os: linux
           env: DISTRO=debian:testing
           compiler: gcc
-- 
2.23.0

[LTP] [PATCH] travis: Add centos7 build

[Petr Vorel]

Hi Xu,

> I have this idea when I meet ALG_SET_AEAD_ASSOCLEN undefined error on centos7.
> Add centos7 travis target, it is more friendly for centos7 user and it is more
> meaningful than centos6.

OK, how about replacing CentOS 6 with CentOS 7?

Kind regards,
Petr

> I have tested this patch on my ltp fork:
> https://travis-ci.org/github/xuyang0410/ltp/jobs/720541105

> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> ---
>  .travis.yml | 4 ++++
>  1 file changed, 4 insertions(+)

> diff --git a/.travis.yml b/.travis.yml
> index e8e3189af..281ec9e96 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -47,6 +47,10 @@ matrix:
>            env: DISTRO=centos:6 TREE=out
>            compiler: gcc

> +        - os: linux
> +          env: DISTRO=centos:7 TREE=out
> +          compiler: gcc
> +
>          - os: linux
>            env: DISTRO=debian:testing
>            compiler: gcc

[LTP] [PATCH] travis: Add centos7 build

[Yang Xu]

Hi Petr


> Hi Xu,
> 
>> I have this idea when I meet ALG_SET_AEAD_ASSOCLEN undefined error on centos7.
>> Add centos7 travis target, it is more friendly for centos7 user and it is more
>> meaningful than centos6.
> 
> OK, how about replacing CentOS 6 with CentOS 7?
I have no objection about this because my kernel test team only uses 
centos7/8 to test and doesn't use centos6 for a long time.

But I think ltp community should reach a consensus that minimal 
glibc/kernel/gcc(clang) version , so we can drop the corresponding code 
in travis or m4.

Also, we can raise "Define minimal supported kernel and (g)libc version" 
topic again.

Best Regards
Yang Xu
> 
> Kind regards,
> Petr
> 
>> I have tested this patch on my ltp fork:
>> https://travis-ci.org/github/xuyang0410/ltp/jobs/720541105
> 
>> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
>> ---
>>   .travis.yml | 4 ++++
>>   1 file changed, 4 insertions(+)
> 
>> diff --git a/.travis.yml b/.travis.yml
>> index e8e3189af..281ec9e96 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -47,6 +47,10 @@ matrix:
>>             env: DISTRO=centos:6 TREE=out
>>             compiler: gcc
> 
>> +        - os: linux
>> +          env: DISTRO=centos:7 TREE=out
>> +          compiler: gcc
>> +
>>           - os: linux
>>             env: DISTRO=debian:testing
>>             compiler: gcc
> 
> 

[LTP] [PATCH] travis: Add centos7 build

[Petr Vorel]

Hi Xu,

> > > I have this idea when I meet ALG_SET_AEAD_ASSOCLEN undefined error on centos7.
> > > Add centos7 travis target, it is more friendly for centos7 user and it is more
> > > meaningful than centos6.

> > OK, how about replacing CentOS 6 with CentOS 7?
> I have no objection about this because my kernel test team only uses
> centos7/8 to test and doesn't use centos6 for a long time.
OK. I don't have either, although I hesitated to sent this patch.

> But I think ltp community should reach a consensus that minimal
> glibc/kernel/gcc(clang) version , so we can drop the corresponding code in
> travis or m4.

> Also, we can raise "Define minimal supported kernel and (g)libc version"
> topic again.
Well, last time I remember we decide to drop CentOS 6 after the release. But I
haven't done it. I also planned to create wiki pagge "Supported kernel and
libc", but haven't done it. Feel free to send a patch for any of these two.
But I'd prefer to do the replacement (7 instead of 6) instead of adding it,
because travis already run for quite long.

Kind regards,
Petr

[LTP] [PATCH] travis: Add centos7 build

[Yang Xu]

Hi Petr


> Hi Xu,
> 
>>>> I have this idea when I meet ALG_SET_AEAD_ASSOCLEN undefined error on centos7.
>>>> Add centos7 travis target, it is more friendly for centos7 user and it is more
>>>> meaningful than centos6.
> 
>>> OK, how about replacing CentOS 6 with CentOS 7?
>> I have no objection about this because my kernel test team only uses
>> centos7/8 to test and doesn't use centos6 for a long time.
> OK. I don't have either, although I hesitated to sent this patch.
> 
>> But I think ltp community should reach a consensus that minimal
>> glibc/kernel/gcc(clang) version , so we can drop the corresponding code in
>> travis or m4.
> 
>> Also, we can raise "Define minimal supported kernel and (g)libc version"
>> topic again.
> Well, last time I remember we decide to drop CentOS 6 after the release. But I
> haven't done it. I also planned to create wiki pagge "Supported kernel and
> libc", but haven't done it. Feel free to send a patch for any of these two.
> But I'd prefer to do the replacement (7 instead of 6) instead of adding it,
> because travis already run for quite long.
OK. I will send a v2 patch to replace centos6 with centos7 in travis.

Best Regards
Yang Xu
> 
> Kind regards,
> Petr
> 
> 

[LTP] [PATCH v2] travis: Use centos:7 instead of centos:6

[Yang Xu]

I have this idea when I meet ALG_SET_AEAD_ASSOCLEN undefined error on centos7.
It is more friendly for centos7 user and more meaningful. centos6 is outdated
and we should drop it.

Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index e8e3189af..3c5ff99b7 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -44,7 +44,7 @@ matrix:
           compiler: clang
 
         - os: linux
-          env: DISTRO=centos:6 TREE=out
+          env: DISTRO=centos:7 TREE=out
           compiler: gcc
 
         - os: linux
-- 
2.23.0

[LTP] [PATCH v2] travis: Use centos:7 instead of centos:6

[Li Wang]

On Tue, Aug 25, 2020 at 3:14 PM Yang Xu <xuyang2018.jy@cn.fujitsu.com>
wrote:

> I have this idea when I meet ALG_SET_AEAD_ASSOCLEN undefined error on
> centos7.
> It is more friendly for centos7 user and more meaningful. centos6 is
> outdated
> and we should drop it.
>
> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
>
Acked-by: Li Wang <liwang@redhat.com>


> ---
>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index e8e3189af..3c5ff99b7 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -44,7 +44,7 @@ matrix:
>            compiler: clang
>
>          - os: linux
> -          env: DISTRO=centos:6 TREE=out
> +          env: DISTRO=centos:7 TREE=out
>            compiler: gcc
>
>          - os: linux
> --
> 2.23.0
>
>
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>
>

-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20200825/cbab8248/attachment.htm>

[LTP] [PATCH v2] travis: Use centos:7 instead of centos:6

[Yang Xu]

Hi Li, Petr

Does have anything block this patch? Or, we should listen some advise 
from Jan and Cyril?

ps: Also, ALG_SET_AEAD_ASSOCLEN undefined error patch needs to be reviewed.

Best Regards
Yang Xu
> 
> 
> On Tue, Aug 25, 2020 at 3:14 PM Yang Xu <xuyang2018.jy@cn.fujitsu.com 
> <mailto:xuyang2018.jy@cn.fujitsu.com>> wrote:
> 
>     I have this idea when I meet ALG_SET_AEAD_ASSOCLEN undefined error
>     on centos7.
>     It is more friendly for centos7 user and more meaningful. centos6 is
>     outdated
>     and we should drop it.
> 
>     Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com
>     <mailto:xuyang2018.jy@cn.fujitsu.com>>
> 
> Acked-by: Li Wang <liwang@redhat.com <mailto:liwang@redhat.com>>
> 
>     ---
>      ?.travis.yml | 2 +-
>      ?1 file changed, 1 insertion(+), 1 deletion(-)
> 
>     diff --git a/.travis.yml b/.travis.yml
>     index e8e3189af..3c5ff99b7 100644
>     --- a/.travis.yml
>     +++ b/.travis.yml
>     @@ -44,7 +44,7 @@ matrix:
>      ? ? ? ? ? ?compiler: clang
> 
>      ? ? ? ? ?- os: linux
>     -? ? ? ? ? env: DISTRO=centos:6 TREE=out
>     +? ? ? ? ? env: DISTRO=centos:7 TREE=out
>      ? ? ? ? ? ?compiler: gcc
> 
>      ? ? ? ? ?- os: linux
>     -- 
>     2.23.0
> 
> 
> 
> 
>     -- 
>     Mailing list info: https://lists.linux.it/listinfo/ltp
> 
> 
> 
> -- 
> Regards,
> Li Wang

[LTP] [PATCH v2] travis: Use centos:7 instead of centos:6

[Li Wang]

Hi Xu,

Sorry for the delay. I guess many Developers(European or North America) are
busy with the LPC(Linux Plumbers Conference) recently. please
keep patience:).

Btw, there is a new build error on CentOS7(seems unrelated to your patch):

  /usr/src/ltp/lib/tst_af_alg.c:205:21: error: 'ALG_SET_AEAD_ASSOCLEN'
undeclared (first use in this function)
  2084 cmsg->cmsg_type = ALG_SET_AEAD_ASSOCLEN;

https://travis-ci.com/github/wangli5665/ltp/jobs/378677988


On Fri, Aug 28, 2020 at 11:22 AM Yang Xu <xuyang2018.jy@cn.fujitsu.com>
wrote:

> Hi Li, Petr
>
> Does have anything block this patch? Or, we should listen some advise
> from Jan and Cyril?
>
> ps: Also, ALG_SET_AEAD_ASSOCLEN undefined error patch needs to be reviewed.
>
> Best Regards
> Yang Xu
> >
> >
> > On Tue, Aug 25, 2020 at 3:14 PM Yang Xu <xuyang2018.jy@cn.fujitsu.com
> > <mailto:xuyang2018.jy@cn.fujitsu.com>> wrote:
> >
> >     I have this idea when I meet ALG_SET_AEAD_ASSOCLEN undefined error
> >     on centos7.
> >     It is more friendly for centos7 user and more meaningful. centos6 is
> >     outdated
> >     and we should drop it.
> >
> >     Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com
> >     <mailto:xuyang2018.jy@cn.fujitsu.com>>
> >
> > Acked-by: Li Wang <liwang@redhat.com <mailto:liwang@redhat.com>>
> >
> >     ---
> >       .travis.yml | 2 +-
> >       1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >     diff --git a/.travis.yml b/.travis.yml
> >     index e8e3189af..3c5ff99b7 100644
> >     --- a/.travis.yml
> >     +++ b/.travis.yml
> >     @@ -44,7 +44,7 @@ matrix:
> >                 compiler: clang
> >
> >               - os: linux
> >     -          env: DISTRO=centos:6 TREE=out
> >     +          env: DISTRO=centos:7 TREE=out
> >                 compiler: gcc
> >
> >               - os: linux
> >     --
> >     2.23.0
> >
> >
> >
> >
> >     --
> >     Mailing list info: https://lists.linux.it/listinfo/ltp
> >
> >
> >
> > --
> > Regards,
> > Li Wang
>
>
>

-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20200828/a14a5dcb/attachment.htm>

[LTP] [PATCH v2] travis: Use centos:7 instead of centos:6

[Li Wang]

On Fri, Aug 28, 2020 at 2:40 PM Li Wang <liwang@redhat.com> wrote:

> Hi Xu,
>
> Sorry for the delay. I guess many Developers(European or North
> America) are busy with the LPC(Linux Plumbers Conference) recently. please
> keep patience:).
>
> Btw, there is a new build error on CentOS7(seems unrelated to your patch):
>
>   /usr/src/ltp/lib/tst_af_alg.c:205:21: error: 'ALG_SET_AEAD_ASSOCLEN'
> undeclared (first use in this function)
>   2084 cmsg->cmsg_type = ALG_SET_AEAD_ASSOCLEN;
>

Ah, seems you have sent a patch for that, I will help to review soon.
http://lists.linux.it/pipermail/ltp/2020-August/018651.html

-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20200828/8fc91712/attachment.htm>

[LTP] [PATCH v2] travis: Use centos:7 instead of centos:6

[Petr Vorel]

Hi,

> On Fri, Aug 28, 2020 at 2:40 PM Li Wang <liwang@redhat.com> wrote:

> > Hi Xu,

> > Sorry for the delay. I guess many Developers(European or North
> > America) are busy with the LPC(Linux Plumbers Conference) recently. please
> > keep patience:).
+1 :)

> > Btw, there is a new build error on CentOS7(seems unrelated to your patch):

> >   /usr/src/ltp/lib/tst_af_alg.c:205:21: error: 'ALG_SET_AEAD_ASSOCLEN'
> > undeclared (first use in this function)
> >   2084 cmsg->cmsg_type = ALG_SET_AEAD_ASSOCLEN;


> Ah, seems you have sent a patch for that, I will help to review soon.
> http://lists.linux.it/pipermail/ltp/2020-August/018651.html
Looking into that.

Kind regards,
Petr

[LTP] [PATCH v2] travis: Use centos:7 instead of centos:6

[Petr Vorel]

> I have this idea when I meet ALG_SET_AEAD_ASSOCLEN undefined error on centos7.
> It is more friendly for centos7 user and more meaningful. centos6 is outdated
> and we should drop it.

> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

> ---
>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/.travis.yml b/.travis.yml
> index e8e3189af..3c5ff99b7 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -44,7 +44,7 @@ matrix:
>            compiler: clang

>          - os: linux
> -          env: DISTRO=centos:6 TREE=out
> +          env: DISTRO=centos:7 TREE=out
>            compiler: gcc

>          - os: linux

[LTP] [PATCH v2] travis: Use centos:7 instead of centos:6

[Cyril Hrubis]

Hi!
> Does have anything block this patch? Or, we should listen some advise 
> from Jan and Cyril?

I would be for dropping centos 6 (if nobody objects) after next release,
which will happen in a couple of weeks anyways.

So for now on I would be for adding centos 7, so that the next release
compiles cleanly both on centos 6 and 7.

Then we can work on our minimal requirements and drop obsolete code.

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] [PATCH v2] travis: Use centos:7 instead of centos:6

[Petr Vorel]

Hi,

> Hi!
> > Does have anything block this patch? Or, we should listen some advise 
> > from Jan and Cyril?

> I would be for dropping centos 6 (if nobody objects) after next release,
> which will happen in a couple of weeks anyways.

> So for now on I would be for adding centos 7, so that the next release
> compiles cleanly both on centos 6 and 7.

> Then we can work on our minimal requirements and drop obsolete code.
Make sense. So I merged the original patch.

Kind regards,
Petr