* [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 @ 2020-08-26 5:21 ` Kai-Heng Feng 0 siblings, 0 replies; 17+ messages in thread From: Kai-Heng Feng @ 2020-08-26 5:21 UTC (permalink / raw) To: jani.nikula Cc: Kai-Heng Feng, Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter, Ville Syrjälä, Uma Shankar, Lucas De Marchi, Maarten Lankhorst, Gwan-gyeong Mun, intel-gfx, open list:DRM DRIVERS, open list LSPCON only supports 8 bpc for RGB/YCbCr444. Set the correct bpp otherwise it renders blank screen. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2195 Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> --- drivers/gpu/drm/i915/display/intel_lspcon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c index b781bf469644..c7a44fcaade8 100644 --- a/drivers/gpu/drm/i915/display/intel_lspcon.c +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c @@ -196,7 +196,8 @@ void lspcon_ycbcr420_config(struct drm_connector *connector, crtc_state->port_clock /= 2; crtc_state->output_format = INTEL_OUTPUT_FORMAT_YCBCR444; crtc_state->lspcon_downsampling = true; - } + } else + crtc_state->pipe_bpp = 24; } static bool lspcon_probe(struct intel_lspcon *lspcon) -- 2.17.1 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 @ 2020-08-26 5:21 ` Kai-Heng Feng 0 siblings, 0 replies; 17+ messages in thread From: Kai-Heng Feng @ 2020-08-26 5:21 UTC (permalink / raw) To: jani.nikula Cc: David Airlie, intel-gfx, Lucas De Marchi, open list, open list:DRM DRIVERS, Kai-Heng Feng LSPCON only supports 8 bpc for RGB/YCbCr444. Set the correct bpp otherwise it renders blank screen. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2195 Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> --- drivers/gpu/drm/i915/display/intel_lspcon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c index b781bf469644..c7a44fcaade8 100644 --- a/drivers/gpu/drm/i915/display/intel_lspcon.c +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c @@ -196,7 +196,8 @@ void lspcon_ycbcr420_config(struct drm_connector *connector, crtc_state->port_clock /= 2; crtc_state->output_format = INTEL_OUTPUT_FORMAT_YCBCR444; crtc_state->lspcon_downsampling = true; - } + } else + crtc_state->pipe_bpp = 24; } static bool lspcon_probe(struct intel_lspcon *lspcon) -- 2.17.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 @ 2020-08-26 5:21 ` Kai-Heng Feng 0 siblings, 0 replies; 17+ messages in thread From: Kai-Heng Feng @ 2020-08-26 5:21 UTC (permalink / raw) To: jani.nikula Cc: David Airlie, intel-gfx, Lucas De Marchi, open list, open list:DRM DRIVERS, Gwan-gyeong Mun, Kai-Heng Feng, Rodrigo Vivi, Uma Shankar LSPCON only supports 8 bpc for RGB/YCbCr444. Set the correct bpp otherwise it renders blank screen. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2195 Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> --- drivers/gpu/drm/i915/display/intel_lspcon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c index b781bf469644..c7a44fcaade8 100644 --- a/drivers/gpu/drm/i915/display/intel_lspcon.c +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c @@ -196,7 +196,8 @@ void lspcon_ycbcr420_config(struct drm_connector *connector, crtc_state->port_clock /= 2; crtc_state->output_format = INTEL_OUTPUT_FORMAT_YCBCR444; crtc_state->lspcon_downsampling = true; - } + } else + crtc_state->pipe_bpp = 24; } static bool lspcon_probe(struct intel_lspcon *lspcon) -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 2020-08-26 5:21 ` Kai-Heng Feng (?) (?) @ 2020-08-26 5:39 ` Patchwork -1 siblings, 0 replies; 17+ messages in thread From: Patchwork @ 2020-08-26 5:39 UTC (permalink / raw) To: Kai-Heng Feng; +Cc: intel-gfx == Series Details == Series: drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 URL : https://patchwork.freedesktop.org/series/81004/ State : warning == Summary == $ dim checkpatch origin/drm-tip a73a2592d427 drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 -:22: CHECK:BRACES: Unbalanced braces around else statement #22: FILE: drivers/gpu/drm/i915/display/intel_lspcon.c:199: + } else total: 0 errors, 0 warnings, 1 checks, 9 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 2020-08-26 5:21 ` Kai-Heng Feng ` (2 preceding siblings ...) (?) @ 2020-08-26 5:57 ` Patchwork -1 siblings, 0 replies; 17+ messages in thread From: Patchwork @ 2020-08-26 5:57 UTC (permalink / raw) To: Kai-Heng Feng; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 6208 bytes --] == Series Details == Series: drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 URL : https://patchwork.freedesktop.org/series/81004/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8925 -> Patchwork_18405 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_18405 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_18405, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18405/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_18405: ### IGT changes ### #### Possible regressions #### * igt@gem_exec_parallel@engines@basic: - fi-icl-u2: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-icl-u2/igt@gem_exec_parallel@engines@basic.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18405/fi-icl-u2/igt@gem_exec_parallel@engines@basic.html * igt@runner@aborted: - fi-icl-u2: NOTRUN -> [FAIL][3] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18405/fi-icl-u2/igt@runner@aborted.html Known issues ------------ Here are the changes found in Patchwork_18405 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s0: - fi-tgl-u2: [PASS][4] -> [FAIL][5] ([i915#1888]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18405/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html * igt@i915_module_load@reload: - fi-apl-guc: [PASS][6] -> [DMESG-WARN][7] ([i915#1635] / [i915#1982]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-apl-guc/igt@i915_module_load@reload.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18405/fi-apl-guc/igt@i915_module_load@reload.html * igt@kms_busy@basic@flip: - fi-kbl-x1275: [PASS][8] -> [DMESG-WARN][9] ([i915#62] / [i915#92] / [i915#95]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-kbl-x1275/igt@kms_busy@basic@flip.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18405/fi-kbl-x1275/igt@kms_busy@basic@flip.html #### Possible fixes #### * igt@i915_pm_rpm@basic-pci-d3-state: - fi-bsw-kefka: [DMESG-WARN][10] ([i915#1982]) -> [PASS][11] [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18405/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@i915_selftest@live@execlists: - fi-icl-y: [INCOMPLETE][12] ([i915#2276]) -> [PASS][13] [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-icl-y/igt@i915_selftest@live@execlists.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18405/fi-icl-y/igt@i915_selftest@live@execlists.html #### Warnings #### * igt@debugfs_test@read_all_entries: - fi-kbl-x1275: [DMESG-WARN][14] ([i915#62] / [i915#92]) -> [DMESG-WARN][15] ([i915#62] / [i915#92] / [i915#95]) +1 similar issue [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18405/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html * igt@gem_exec_suspend@basic-s0: - fi-kbl-x1275: [DMESG-WARN][16] ([i915#62] / [i915#92]) -> [DMESG-WARN][17] ([i915#1982] / [i915#62] / [i915#92]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18405/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html * igt@i915_pm_rpm@module-reload: - fi-kbl-x1275: [DMESG-FAIL][18] ([i915#62] / [i915#95]) -> [DMESG-FAIL][19] ([i915#62]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18405/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html * igt@kms_force_connector_basic@prune-stale-modes: - fi-kbl-x1275: [DMESG-WARN][20] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][21] ([i915#62] / [i915#92]) +4 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8925/fi-kbl-x1275/igt@kms_force_connector_basic@prune-stale-modes.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18405/fi-kbl-x1275/igt@kms_force_connector_basic@prune-stale-modes.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2276]: https://gitlab.freedesktop.org/drm/intel/issues/2276 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (37 -> 34) ------------------------------ Missing (3): fi-byt-clapper fi-byt-squawks fi-bsw-cyan Build changes ------------- * Linux: CI_DRM_8925 -> Patchwork_18405 CI-20190529: 20190529 CI_DRM_8925: b0f0c5e0b08e7d93135a27141919e765db3aaeef @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5771: f1d0c240ea2e631dfb9f493f37f8fb61cb2b1cf2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_18405: a73a2592d427d68ccd0cd8737a47964b65b210b6 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == a73a2592d427 drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18405/index.html [-- Attachment #1.2: Type: text/html, Size: 8333 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 2020-08-26 5:21 ` Kai-Heng Feng (?) @ 2020-08-26 16:24 ` Ville Syrjälä -1 siblings, 0 replies; 17+ messages in thread From: Ville Syrjälä @ 2020-08-26 16:24 UTC (permalink / raw) To: Kai-Heng Feng Cc: jani.nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter, Uma Shankar, Lucas De Marchi, Maarten Lankhorst, Gwan-gyeong Mun, intel-gfx, open list:DRM DRIVERS, open list On Wed, Aug 26, 2020 at 01:21:15PM +0800, Kai-Heng Feng wrote: > LSPCON only supports 8 bpc for RGB/YCbCr444. > > Set the correct bpp otherwise it renders blank screen. Hmm. Does git://github.com/vsyrjala/linux.git dp_downstream_ports_5 work? Actually better make that dp_downstream_ports_5^^^^^^^^^^^ aka. 54d846ce62a2 ("drm/i915: Do YCbCr 444->420 conversion via DP protocol converters") to avoid the experiments and hacks I have sitting on top. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2195 > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > --- > drivers/gpu/drm/i915/display/intel_lspcon.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c > index b781bf469644..c7a44fcaade8 100644 > --- a/drivers/gpu/drm/i915/display/intel_lspcon.c > +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c > @@ -196,7 +196,8 @@ void lspcon_ycbcr420_config(struct drm_connector *connector, > crtc_state->port_clock /= 2; > crtc_state->output_format = INTEL_OUTPUT_FORMAT_YCBCR444; > crtc_state->lspcon_downsampling = true; > - } > + } else > + crtc_state->pipe_bpp = 24; > } > > static bool lspcon_probe(struct intel_lspcon *lspcon) > -- > 2.17.1 -- Ville Syrjälä Intel ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 @ 2020-08-26 16:24 ` Ville Syrjälä 0 siblings, 0 replies; 17+ messages in thread From: Ville Syrjälä @ 2020-08-26 16:24 UTC (permalink / raw) To: Kai-Heng Feng Cc: David Airlie, intel-gfx, Lucas De Marchi, open list, open list:DRM DRIVERS On Wed, Aug 26, 2020 at 01:21:15PM +0800, Kai-Heng Feng wrote: > LSPCON only supports 8 bpc for RGB/YCbCr444. > > Set the correct bpp otherwise it renders blank screen. Hmm. Does git://github.com/vsyrjala/linux.git dp_downstream_ports_5 work? Actually better make that dp_downstream_ports_5^^^^^^^^^^^ aka. 54d846ce62a2 ("drm/i915: Do YCbCr 444->420 conversion via DP protocol converters") to avoid the experiments and hacks I have sitting on top. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2195 > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > --- > drivers/gpu/drm/i915/display/intel_lspcon.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c > index b781bf469644..c7a44fcaade8 100644 > --- a/drivers/gpu/drm/i915/display/intel_lspcon.c > +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c > @@ -196,7 +196,8 @@ void lspcon_ycbcr420_config(struct drm_connector *connector, > crtc_state->port_clock /= 2; > crtc_state->output_format = INTEL_OUTPUT_FORMAT_YCBCR444; > crtc_state->lspcon_downsampling = true; > - } > + } else > + crtc_state->pipe_bpp = 24; > } > > static bool lspcon_probe(struct intel_lspcon *lspcon) > -- > 2.17.1 -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 @ 2020-08-26 16:24 ` Ville Syrjälä 0 siblings, 0 replies; 17+ messages in thread From: Ville Syrjälä @ 2020-08-26 16:24 UTC (permalink / raw) To: Kai-Heng Feng Cc: David Airlie, intel-gfx, Lucas De Marchi, open list, Gwan-gyeong Mun, Uma Shankar, open list:DRM DRIVERS, Rodrigo Vivi On Wed, Aug 26, 2020 at 01:21:15PM +0800, Kai-Heng Feng wrote: > LSPCON only supports 8 bpc for RGB/YCbCr444. > > Set the correct bpp otherwise it renders blank screen. Hmm. Does git://github.com/vsyrjala/linux.git dp_downstream_ports_5 work? Actually better make that dp_downstream_ports_5^^^^^^^^^^^ aka. 54d846ce62a2 ("drm/i915: Do YCbCr 444->420 conversion via DP protocol converters") to avoid the experiments and hacks I have sitting on top. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2195 > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > --- > drivers/gpu/drm/i915/display/intel_lspcon.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c > index b781bf469644..c7a44fcaade8 100644 > --- a/drivers/gpu/drm/i915/display/intel_lspcon.c > +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c > @@ -196,7 +196,8 @@ void lspcon_ycbcr420_config(struct drm_connector *connector, > crtc_state->port_clock /= 2; > crtc_state->output_format = INTEL_OUTPUT_FORMAT_YCBCR444; > crtc_state->lspcon_downsampling = true; > - } > + } else > + crtc_state->pipe_bpp = 24; > } > > static bool lspcon_probe(struct intel_lspcon *lspcon) > -- > 2.17.1 -- Ville Syrjälä Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 2020-08-26 16:24 ` Ville Syrjälä (?) @ 2020-08-27 5:04 ` Kai Heng Feng -1 siblings, 0 replies; 17+ messages in thread From: Kai Heng Feng @ 2020-08-27 5:04 UTC (permalink / raw) To: Ville Syrjälä Cc: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter, Uma Shankar, Lucas De Marchi, Maarten Lankhorst, Gwan-gyeong Mun, intel-gfx, open list:DRM DRIVERS, open list Hi Ville, > On Aug 27, 2020, at 12:24 AM, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > > On Wed, Aug 26, 2020 at 01:21:15PM +0800, Kai-Heng Feng wrote: >> LSPCON only supports 8 bpc for RGB/YCbCr444. >> >> Set the correct bpp otherwise it renders blank screen. > > Hmm. Does > git://github.com/vsyrjala/linux.git dp_downstream_ports_5 > work? > > Actually better make that dp_downstream_ports_5^^^^^^^^^^^ aka. > 54d846ce62a2 ("drm/i915: Do YCbCr 444->420 conversion via DP protocol > converters") to avoid the experiments and hacks I have sitting on top. Can you please rebase it to mainline master or drm-tip? I am getting errors on the branch: DESCEND objtool CALL scripts/atomic/check-atomics.sh CALL scripts/checksyscalls.sh CHK include/generated/compile.h Building modules, stage 2. MODPOST 166 modules LD arch/x86/boot/compressed/vmlinux ld: arch/x86/boot/compressed/pgtable_64.o:(.bss+0x0): multiple definition of `__force_order'; arch/x86/boot/compressed/kaslr_64.o:(.bss+0x0): first defined here ld: arch/x86/boot/compressed/head_64.o: warning: relocation in read-only section `.head.text' ld: warning: creating DT_TEXTREL in a PIE make[2]: *** [arch/x86/boot/compressed/Makefile:119: arch/x86/boot/compressed/vmlinux] Error 1 make[1]: *** [arch/x86/boot/Makefile:113: arch/x86/boot/compressed/vmlinux] Error 2 make: *** [arch/x86/Makefile:284: bzImage] Error 2 make: *** Waiting for unfinished jobs.... Kai-Heng > >> >> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2195 >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> >> --- >> drivers/gpu/drm/i915/display/intel_lspcon.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c >> index b781bf469644..c7a44fcaade8 100644 >> --- a/drivers/gpu/drm/i915/display/intel_lspcon.c >> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c >> @@ -196,7 +196,8 @@ void lspcon_ycbcr420_config(struct drm_connector *connector, >> crtc_state->port_clock /= 2; >> crtc_state->output_format = INTEL_OUTPUT_FORMAT_YCBCR444; >> crtc_state->lspcon_downsampling = true; >> - } >> + } else >> + crtc_state->pipe_bpp = 24; >> } >> >> static bool lspcon_probe(struct intel_lspcon *lspcon) >> -- >> 2.17.1 > > -- > Ville Syrjälä > Intel ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 @ 2020-08-27 5:04 ` Kai Heng Feng 0 siblings, 0 replies; 17+ messages in thread From: Kai Heng Feng @ 2020-08-27 5:04 UTC (permalink / raw) To: Ville Syrjälä Cc: David Airlie, intel-gfx, Lucas De Marchi, open list, open list:DRM DRIVERS Hi Ville, > On Aug 27, 2020, at 12:24 AM, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > > On Wed, Aug 26, 2020 at 01:21:15PM +0800, Kai-Heng Feng wrote: >> LSPCON only supports 8 bpc for RGB/YCbCr444. >> >> Set the correct bpp otherwise it renders blank screen. > > Hmm. Does > git://github.com/vsyrjala/linux.git dp_downstream_ports_5 > work? > > Actually better make that dp_downstream_ports_5^^^^^^^^^^^ aka. > 54d846ce62a2 ("drm/i915: Do YCbCr 444->420 conversion via DP protocol > converters") to avoid the experiments and hacks I have sitting on top. Can you please rebase it to mainline master or drm-tip? I am getting errors on the branch: DESCEND objtool CALL scripts/atomic/check-atomics.sh CALL scripts/checksyscalls.sh CHK include/generated/compile.h Building modules, stage 2. MODPOST 166 modules LD arch/x86/boot/compressed/vmlinux ld: arch/x86/boot/compressed/pgtable_64.o:(.bss+0x0): multiple definition of `__force_order'; arch/x86/boot/compressed/kaslr_64.o:(.bss+0x0): first defined here ld: arch/x86/boot/compressed/head_64.o: warning: relocation in read-only section `.head.text' ld: warning: creating DT_TEXTREL in a PIE make[2]: *** [arch/x86/boot/compressed/Makefile:119: arch/x86/boot/compressed/vmlinux] Error 1 make[1]: *** [arch/x86/boot/Makefile:113: arch/x86/boot/compressed/vmlinux] Error 2 make: *** [arch/x86/Makefile:284: bzImage] Error 2 make: *** Waiting for unfinished jobs.... Kai-Heng > >> >> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2195 >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> >> --- >> drivers/gpu/drm/i915/display/intel_lspcon.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c >> index b781bf469644..c7a44fcaade8 100644 >> --- a/drivers/gpu/drm/i915/display/intel_lspcon.c >> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c >> @@ -196,7 +196,8 @@ void lspcon_ycbcr420_config(struct drm_connector *connector, >> crtc_state->port_clock /= 2; >> crtc_state->output_format = INTEL_OUTPUT_FORMAT_YCBCR444; >> crtc_state->lspcon_downsampling = true; >> - } >> + } else >> + crtc_state->pipe_bpp = 24; >> } >> >> static bool lspcon_probe(struct intel_lspcon *lspcon) >> -- >> 2.17.1 > > -- > Ville Syrjälä > Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 @ 2020-08-27 5:04 ` Kai Heng Feng 0 siblings, 0 replies; 17+ messages in thread From: Kai Heng Feng @ 2020-08-27 5:04 UTC (permalink / raw) To: Ville Syrjälä Cc: David Airlie, intel-gfx, Lucas De Marchi, open list, Gwan-gyeong Mun, Uma Shankar, open list:DRM DRIVERS, Rodrigo Vivi Hi Ville, > On Aug 27, 2020, at 12:24 AM, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > > On Wed, Aug 26, 2020 at 01:21:15PM +0800, Kai-Heng Feng wrote: >> LSPCON only supports 8 bpc for RGB/YCbCr444. >> >> Set the correct bpp otherwise it renders blank screen. > > Hmm. Does > git://github.com/vsyrjala/linux.git dp_downstream_ports_5 > work? > > Actually better make that dp_downstream_ports_5^^^^^^^^^^^ aka. > 54d846ce62a2 ("drm/i915: Do YCbCr 444->420 conversion via DP protocol > converters") to avoid the experiments and hacks I have sitting on top. Can you please rebase it to mainline master or drm-tip? I am getting errors on the branch: DESCEND objtool CALL scripts/atomic/check-atomics.sh CALL scripts/checksyscalls.sh CHK include/generated/compile.h Building modules, stage 2. MODPOST 166 modules LD arch/x86/boot/compressed/vmlinux ld: arch/x86/boot/compressed/pgtable_64.o:(.bss+0x0): multiple definition of `__force_order'; arch/x86/boot/compressed/kaslr_64.o:(.bss+0x0): first defined here ld: arch/x86/boot/compressed/head_64.o: warning: relocation in read-only section `.head.text' ld: warning: creating DT_TEXTREL in a PIE make[2]: *** [arch/x86/boot/compressed/Makefile:119: arch/x86/boot/compressed/vmlinux] Error 1 make[1]: *** [arch/x86/boot/Makefile:113: arch/x86/boot/compressed/vmlinux] Error 2 make: *** [arch/x86/Makefile:284: bzImage] Error 2 make: *** Waiting for unfinished jobs.... Kai-Heng > >> >> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2195 >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> >> --- >> drivers/gpu/drm/i915/display/intel_lspcon.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c >> index b781bf469644..c7a44fcaade8 100644 >> --- a/drivers/gpu/drm/i915/display/intel_lspcon.c >> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c >> @@ -196,7 +196,8 @@ void lspcon_ycbcr420_config(struct drm_connector *connector, >> crtc_state->port_clock /= 2; >> crtc_state->output_format = INTEL_OUTPUT_FORMAT_YCBCR444; >> crtc_state->lspcon_downsampling = true; >> - } >> + } else >> + crtc_state->pipe_bpp = 24; >> } >> >> static bool lspcon_probe(struct intel_lspcon *lspcon) >> -- >> 2.17.1 > > -- > Ville Syrjälä > Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 2020-08-27 5:04 ` Kai Heng Feng (?) @ 2020-08-31 19:48 ` Ville Syrjälä -1 siblings, 0 replies; 17+ messages in thread From: Ville Syrjälä @ 2020-08-31 19:48 UTC (permalink / raw) To: Kai Heng Feng Cc: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter, Uma Shankar, Lucas De Marchi, Maarten Lankhorst, Gwan-gyeong Mun, intel-gfx, open list:DRM DRIVERS, open list On Thu, Aug 27, 2020 at 01:04:54PM +0800, Kai Heng Feng wrote: > Hi Ville, > > > On Aug 27, 2020, at 12:24 AM, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > > > > On Wed, Aug 26, 2020 at 01:21:15PM +0800, Kai-Heng Feng wrote: > >> LSPCON only supports 8 bpc for RGB/YCbCr444. > >> > >> Set the correct bpp otherwise it renders blank screen. > > > > Hmm. Does > > git://github.com/vsyrjala/linux.git dp_downstream_ports_5 > > work? > > > > Actually better make that dp_downstream_ports_5^^^^^^^^^^^ aka. > > 54d846ce62a2 ("drm/i915: Do YCbCr 444->420 conversion via DP protocol > > converters") to avoid the experiments and hacks I have sitting on top. > > Can you please rebase it to mainline master or drm-tip? git://github.com/vsyrjala/linux.git dp_downstream_ports_6 I threw out the hacks/experimental stuff. > > I am getting errors on the branch: > > DESCEND objtool > CALL scripts/atomic/check-atomics.sh > CALL scripts/checksyscalls.sh > CHK include/generated/compile.h > Building modules, stage 2. > MODPOST 166 modules > LD arch/x86/boot/compressed/vmlinux > ld: arch/x86/boot/compressed/pgtable_64.o:(.bss+0x0): multiple definition of `__force_order'; arch/x86/boot/compressed/kaslr_64.o:(.bss+0x0): first defined here > ld: arch/x86/boot/compressed/head_64.o: warning: relocation in read-only section `.head.text' > ld: warning: creating DT_TEXTREL in a PIE > make[2]: *** [arch/x86/boot/compressed/Makefile:119: arch/x86/boot/compressed/vmlinux] Error 1 > make[1]: *** [arch/x86/boot/Makefile:113: arch/x86/boot/compressed/vmlinux] Error 2 > make: *** [arch/x86/Makefile:284: bzImage] Error 2 > make: *** Waiting for unfinished jobs.... > > Kai-Heng > > > > >> > >> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2195 > >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > >> --- > >> drivers/gpu/drm/i915/display/intel_lspcon.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c > >> index b781bf469644..c7a44fcaade8 100644 > >> --- a/drivers/gpu/drm/i915/display/intel_lspcon.c > >> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c > >> @@ -196,7 +196,8 @@ void lspcon_ycbcr420_config(struct drm_connector *connector, > >> crtc_state->port_clock /= 2; > >> crtc_state->output_format = INTEL_OUTPUT_FORMAT_YCBCR444; > >> crtc_state->lspcon_downsampling = true; > >> - } > >> + } else > >> + crtc_state->pipe_bpp = 24; > >> } > >> > >> static bool lspcon_probe(struct intel_lspcon *lspcon) > >> -- > >> 2.17.1 > > > > -- > > Ville Syrjälä > > Intel -- Ville Syrjälä Intel ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 @ 2020-08-31 19:48 ` Ville Syrjälä 0 siblings, 0 replies; 17+ messages in thread From: Ville Syrjälä @ 2020-08-31 19:48 UTC (permalink / raw) To: Kai Heng Feng Cc: David Airlie, intel-gfx, Lucas De Marchi, open list, open list:DRM DRIVERS On Thu, Aug 27, 2020 at 01:04:54PM +0800, Kai Heng Feng wrote: > Hi Ville, > > > On Aug 27, 2020, at 12:24 AM, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > > > > On Wed, Aug 26, 2020 at 01:21:15PM +0800, Kai-Heng Feng wrote: > >> LSPCON only supports 8 bpc for RGB/YCbCr444. > >> > >> Set the correct bpp otherwise it renders blank screen. > > > > Hmm. Does > > git://github.com/vsyrjala/linux.git dp_downstream_ports_5 > > work? > > > > Actually better make that dp_downstream_ports_5^^^^^^^^^^^ aka. > > 54d846ce62a2 ("drm/i915: Do YCbCr 444->420 conversion via DP protocol > > converters") to avoid the experiments and hacks I have sitting on top. > > Can you please rebase it to mainline master or drm-tip? git://github.com/vsyrjala/linux.git dp_downstream_ports_6 I threw out the hacks/experimental stuff. > > I am getting errors on the branch: > > DESCEND objtool > CALL scripts/atomic/check-atomics.sh > CALL scripts/checksyscalls.sh > CHK include/generated/compile.h > Building modules, stage 2. > MODPOST 166 modules > LD arch/x86/boot/compressed/vmlinux > ld: arch/x86/boot/compressed/pgtable_64.o:(.bss+0x0): multiple definition of `__force_order'; arch/x86/boot/compressed/kaslr_64.o:(.bss+0x0): first defined here > ld: arch/x86/boot/compressed/head_64.o: warning: relocation in read-only section `.head.text' > ld: warning: creating DT_TEXTREL in a PIE > make[2]: *** [arch/x86/boot/compressed/Makefile:119: arch/x86/boot/compressed/vmlinux] Error 1 > make[1]: *** [arch/x86/boot/Makefile:113: arch/x86/boot/compressed/vmlinux] Error 2 > make: *** [arch/x86/Makefile:284: bzImage] Error 2 > make: *** Waiting for unfinished jobs.... > > Kai-Heng > > > > >> > >> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2195 > >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > >> --- > >> drivers/gpu/drm/i915/display/intel_lspcon.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c > >> index b781bf469644..c7a44fcaade8 100644 > >> --- a/drivers/gpu/drm/i915/display/intel_lspcon.c > >> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c > >> @@ -196,7 +196,8 @@ void lspcon_ycbcr420_config(struct drm_connector *connector, > >> crtc_state->port_clock /= 2; > >> crtc_state->output_format = INTEL_OUTPUT_FORMAT_YCBCR444; > >> crtc_state->lspcon_downsampling = true; > >> - } > >> + } else > >> + crtc_state->pipe_bpp = 24; > >> } > >> > >> static bool lspcon_probe(struct intel_lspcon *lspcon) > >> -- > >> 2.17.1 > > > > -- > > Ville Syrjälä > > Intel -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 @ 2020-08-31 19:48 ` Ville Syrjälä 0 siblings, 0 replies; 17+ messages in thread From: Ville Syrjälä @ 2020-08-31 19:48 UTC (permalink / raw) To: Kai Heng Feng Cc: David Airlie, intel-gfx, Lucas De Marchi, open list, Gwan-gyeong Mun, Uma Shankar, open list:DRM DRIVERS, Rodrigo Vivi On Thu, Aug 27, 2020 at 01:04:54PM +0800, Kai Heng Feng wrote: > Hi Ville, > > > On Aug 27, 2020, at 12:24 AM, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > > > > On Wed, Aug 26, 2020 at 01:21:15PM +0800, Kai-Heng Feng wrote: > >> LSPCON only supports 8 bpc for RGB/YCbCr444. > >> > >> Set the correct bpp otherwise it renders blank screen. > > > > Hmm. Does > > git://github.com/vsyrjala/linux.git dp_downstream_ports_5 > > work? > > > > Actually better make that dp_downstream_ports_5^^^^^^^^^^^ aka. > > 54d846ce62a2 ("drm/i915: Do YCbCr 444->420 conversion via DP protocol > > converters") to avoid the experiments and hacks I have sitting on top. > > Can you please rebase it to mainline master or drm-tip? git://github.com/vsyrjala/linux.git dp_downstream_ports_6 I threw out the hacks/experimental stuff. > > I am getting errors on the branch: > > DESCEND objtool > CALL scripts/atomic/check-atomics.sh > CALL scripts/checksyscalls.sh > CHK include/generated/compile.h > Building modules, stage 2. > MODPOST 166 modules > LD arch/x86/boot/compressed/vmlinux > ld: arch/x86/boot/compressed/pgtable_64.o:(.bss+0x0): multiple definition of `__force_order'; arch/x86/boot/compressed/kaslr_64.o:(.bss+0x0): first defined here > ld: arch/x86/boot/compressed/head_64.o: warning: relocation in read-only section `.head.text' > ld: warning: creating DT_TEXTREL in a PIE > make[2]: *** [arch/x86/boot/compressed/Makefile:119: arch/x86/boot/compressed/vmlinux] Error 1 > make[1]: *** [arch/x86/boot/Makefile:113: arch/x86/boot/compressed/vmlinux] Error 2 > make: *** [arch/x86/Makefile:284: bzImage] Error 2 > make: *** Waiting for unfinished jobs.... > > Kai-Heng > > > > >> > >> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2195 > >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > >> --- > >> drivers/gpu/drm/i915/display/intel_lspcon.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c > >> index b781bf469644..c7a44fcaade8 100644 > >> --- a/drivers/gpu/drm/i915/display/intel_lspcon.c > >> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c > >> @@ -196,7 +196,8 @@ void lspcon_ycbcr420_config(struct drm_connector *connector, > >> crtc_state->port_clock /= 2; > >> crtc_state->output_format = INTEL_OUTPUT_FORMAT_YCBCR444; > >> crtc_state->lspcon_downsampling = true; > >> - } > >> + } else > >> + crtc_state->pipe_bpp = 24; > >> } > >> > >> static bool lspcon_probe(struct intel_lspcon *lspcon) > >> -- > >> 2.17.1 > > > > -- > > Ville Syrjälä > > Intel -- Ville Syrjälä Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 2020-08-31 19:48 ` Ville Syrjälä (?) @ 2020-09-02 5:22 ` Kai-Heng Feng -1 siblings, 0 replies; 17+ messages in thread From: Kai-Heng Feng @ 2020-09-02 5:22 UTC (permalink / raw) To: Ville Syrjälä Cc: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter, Uma Shankar, Lucas De Marchi, Maarten Lankhorst, Gwan-gyeong Mun, intel-gfx, open list:DRM DRIVERS, open list > On Sep 1, 2020, at 03:48, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > > On Thu, Aug 27, 2020 at 01:04:54PM +0800, Kai Heng Feng wrote: >> Hi Ville, >> >>> On Aug 27, 2020, at 12:24 AM, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: >>> >>> On Wed, Aug 26, 2020 at 01:21:15PM +0800, Kai-Heng Feng wrote: >>>> LSPCON only supports 8 bpc for RGB/YCbCr444. >>>> >>>> Set the correct bpp otherwise it renders blank screen. >>> >>> Hmm. Does >>> git://github.com/vsyrjala/linux.git dp_downstream_ports_5 >>> work? >>> >>> Actually better make that dp_downstream_ports_5^^^^^^^^^^^ aka. >>> 54d846ce62a2 ("drm/i915: Do YCbCr 444->420 conversion via DP protocol >>> converters") to avoid the experiments and hacks I have sitting on top. >> >> Can you please rebase it to mainline master or drm-tip? > > git://github.com/vsyrjala/linux.git dp_downstream_ports_6 Yes this solves the issue. Thanks a lot! Any timeline this will get merged? Kai-Heng > > I threw out the hacks/experimental stuff. > >> >> I am getting errors on the branch: >> >> DESCEND objtool >> CALL scripts/atomic/check-atomics.sh >> CALL scripts/checksyscalls.sh >> CHK include/generated/compile.h >> Building modules, stage 2. >> MODPOST 166 modules >> LD arch/x86/boot/compressed/vmlinux >> ld: arch/x86/boot/compressed/pgtable_64.o:(.bss+0x0): multiple definition of `__force_order'; arch/x86/boot/compressed/kaslr_64.o:(.bss+0x0): first defined here >> ld: arch/x86/boot/compressed/head_64.o: warning: relocation in read-only section `.head.text' >> ld: warning: creating DT_TEXTREL in a PIE >> make[2]: *** [arch/x86/boot/compressed/Makefile:119: arch/x86/boot/compressed/vmlinux] Error 1 >> make[1]: *** [arch/x86/boot/Makefile:113: arch/x86/boot/compressed/vmlinux] Error 2 >> make: *** [arch/x86/Makefile:284: bzImage] Error 2 >> make: *** Waiting for unfinished jobs.... >> >> Kai-Heng >> >>> >>>> >>>> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2195 >>>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> >>>> --- >>>> drivers/gpu/drm/i915/display/intel_lspcon.c | 3 ++- >>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c >>>> index b781bf469644..c7a44fcaade8 100644 >>>> --- a/drivers/gpu/drm/i915/display/intel_lspcon.c >>>> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c >>>> @@ -196,7 +196,8 @@ void lspcon_ycbcr420_config(struct drm_connector *connector, >>>> crtc_state->port_clock /= 2; >>>> crtc_state->output_format = INTEL_OUTPUT_FORMAT_YCBCR444; >>>> crtc_state->lspcon_downsampling = true; >>>> - } >>>> + } else >>>> + crtc_state->pipe_bpp = 24; >>>> } >>>> >>>> static bool lspcon_probe(struct intel_lspcon *lspcon) >>>> -- >>>> 2.17.1 >>> >>> -- >>> Ville Syrjälä >>> Intel > > -- > Ville Syrjälä > Intel ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 @ 2020-09-02 5:22 ` Kai-Heng Feng 0 siblings, 0 replies; 17+ messages in thread From: Kai-Heng Feng @ 2020-09-02 5:22 UTC (permalink / raw) To: Ville Syrjälä Cc: David Airlie, intel-gfx, Lucas De Marchi, open list, open list:DRM DRIVERS > On Sep 1, 2020, at 03:48, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > > On Thu, Aug 27, 2020 at 01:04:54PM +0800, Kai Heng Feng wrote: >> Hi Ville, >> >>> On Aug 27, 2020, at 12:24 AM, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: >>> >>> On Wed, Aug 26, 2020 at 01:21:15PM +0800, Kai-Heng Feng wrote: >>>> LSPCON only supports 8 bpc for RGB/YCbCr444. >>>> >>>> Set the correct bpp otherwise it renders blank screen. >>> >>> Hmm. Does >>> git://github.com/vsyrjala/linux.git dp_downstream_ports_5 >>> work? >>> >>> Actually better make that dp_downstream_ports_5^^^^^^^^^^^ aka. >>> 54d846ce62a2 ("drm/i915: Do YCbCr 444->420 conversion via DP protocol >>> converters") to avoid the experiments and hacks I have sitting on top. >> >> Can you please rebase it to mainline master or drm-tip? > > git://github.com/vsyrjala/linux.git dp_downstream_ports_6 Yes this solves the issue. Thanks a lot! Any timeline this will get merged? Kai-Heng > > I threw out the hacks/experimental stuff. > >> >> I am getting errors on the branch: >> >> DESCEND objtool >> CALL scripts/atomic/check-atomics.sh >> CALL scripts/checksyscalls.sh >> CHK include/generated/compile.h >> Building modules, stage 2. >> MODPOST 166 modules >> LD arch/x86/boot/compressed/vmlinux >> ld: arch/x86/boot/compressed/pgtable_64.o:(.bss+0x0): multiple definition of `__force_order'; arch/x86/boot/compressed/kaslr_64.o:(.bss+0x0): first defined here >> ld: arch/x86/boot/compressed/head_64.o: warning: relocation in read-only section `.head.text' >> ld: warning: creating DT_TEXTREL in a PIE >> make[2]: *** [arch/x86/boot/compressed/Makefile:119: arch/x86/boot/compressed/vmlinux] Error 1 >> make[1]: *** [arch/x86/boot/Makefile:113: arch/x86/boot/compressed/vmlinux] Error 2 >> make: *** [arch/x86/Makefile:284: bzImage] Error 2 >> make: *** Waiting for unfinished jobs.... >> >> Kai-Heng >> >>> >>>> >>>> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2195 >>>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> >>>> --- >>>> drivers/gpu/drm/i915/display/intel_lspcon.c | 3 ++- >>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c >>>> index b781bf469644..c7a44fcaade8 100644 >>>> --- a/drivers/gpu/drm/i915/display/intel_lspcon.c >>>> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c >>>> @@ -196,7 +196,8 @@ void lspcon_ycbcr420_config(struct drm_connector *connector, >>>> crtc_state->port_clock /= 2; >>>> crtc_state->output_format = INTEL_OUTPUT_FORMAT_YCBCR444; >>>> crtc_state->lspcon_downsampling = true; >>>> - } >>>> + } else >>>> + crtc_state->pipe_bpp = 24; >>>> } >>>> >>>> static bool lspcon_probe(struct intel_lspcon *lspcon) >>>> -- >>>> 2.17.1 >>> >>> -- >>> Ville Syrjälä >>> Intel > > -- > Ville Syrjälä > Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 @ 2020-09-02 5:22 ` Kai-Heng Feng 0 siblings, 0 replies; 17+ messages in thread From: Kai-Heng Feng @ 2020-09-02 5:22 UTC (permalink / raw) To: Ville Syrjälä Cc: David Airlie, intel-gfx, Lucas De Marchi, open list, Gwan-gyeong Mun, Uma Shankar, open list:DRM DRIVERS, Rodrigo Vivi > On Sep 1, 2020, at 03:48, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > > On Thu, Aug 27, 2020 at 01:04:54PM +0800, Kai Heng Feng wrote: >> Hi Ville, >> >>> On Aug 27, 2020, at 12:24 AM, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: >>> >>> On Wed, Aug 26, 2020 at 01:21:15PM +0800, Kai-Heng Feng wrote: >>>> LSPCON only supports 8 bpc for RGB/YCbCr444. >>>> >>>> Set the correct bpp otherwise it renders blank screen. >>> >>> Hmm. Does >>> git://github.com/vsyrjala/linux.git dp_downstream_ports_5 >>> work? >>> >>> Actually better make that dp_downstream_ports_5^^^^^^^^^^^ aka. >>> 54d846ce62a2 ("drm/i915: Do YCbCr 444->420 conversion via DP protocol >>> converters") to avoid the experiments and hacks I have sitting on top. >> >> Can you please rebase it to mainline master or drm-tip? > > git://github.com/vsyrjala/linux.git dp_downstream_ports_6 Yes this solves the issue. Thanks a lot! Any timeline this will get merged? Kai-Heng > > I threw out the hacks/experimental stuff. > >> >> I am getting errors on the branch: >> >> DESCEND objtool >> CALL scripts/atomic/check-atomics.sh >> CALL scripts/checksyscalls.sh >> CHK include/generated/compile.h >> Building modules, stage 2. >> MODPOST 166 modules >> LD arch/x86/boot/compressed/vmlinux >> ld: arch/x86/boot/compressed/pgtable_64.o:(.bss+0x0): multiple definition of `__force_order'; arch/x86/boot/compressed/kaslr_64.o:(.bss+0x0): first defined here >> ld: arch/x86/boot/compressed/head_64.o: warning: relocation in read-only section `.head.text' >> ld: warning: creating DT_TEXTREL in a PIE >> make[2]: *** [arch/x86/boot/compressed/Makefile:119: arch/x86/boot/compressed/vmlinux] Error 1 >> make[1]: *** [arch/x86/boot/Makefile:113: arch/x86/boot/compressed/vmlinux] Error 2 >> make: *** [arch/x86/Makefile:284: bzImage] Error 2 >> make: *** Waiting for unfinished jobs.... >> >> Kai-Heng >> >>> >>>> >>>> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2195 >>>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> >>>> --- >>>> drivers/gpu/drm/i915/display/intel_lspcon.c | 3 ++- >>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c >>>> index b781bf469644..c7a44fcaade8 100644 >>>> --- a/drivers/gpu/drm/i915/display/intel_lspcon.c >>>> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c >>>> @@ -196,7 +196,8 @@ void lspcon_ycbcr420_config(struct drm_connector *connector, >>>> crtc_state->port_clock /= 2; >>>> crtc_state->output_format = INTEL_OUTPUT_FORMAT_YCBCR444; >>>> crtc_state->lspcon_downsampling = true; >>>> - } >>>> + } else >>>> + crtc_state->pipe_bpp = 24; >>>> } >>>> >>>> static bool lspcon_probe(struct intel_lspcon *lspcon) >>>> -- >>>> 2.17.1 >>> >>> -- >>> Ville Syrjälä >>> Intel > > -- > Ville Syrjälä > Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2020-09-02 7:08 UTC | newest] Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-08-26 5:21 [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444 Kai-Heng Feng 2020-08-26 5:21 ` [Intel-gfx] " Kai-Heng Feng 2020-08-26 5:21 ` Kai-Heng Feng 2020-08-26 5:39 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2020-08-26 5:57 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork 2020-08-26 16:24 ` [PATCH] " Ville Syrjälä 2020-08-26 16:24 ` [Intel-gfx] " Ville Syrjälä 2020-08-26 16:24 ` Ville Syrjälä 2020-08-27 5:04 ` Kai Heng Feng 2020-08-27 5:04 ` [Intel-gfx] " Kai Heng Feng 2020-08-27 5:04 ` Kai Heng Feng 2020-08-31 19:48 ` Ville Syrjälä 2020-08-31 19:48 ` [Intel-gfx] " Ville Syrjälä 2020-08-31 19:48 ` Ville Syrjälä 2020-09-02 5:22 ` Kai-Heng Feng 2020-09-02 5:22 ` [Intel-gfx] " Kai-Heng Feng 2020-09-02 5:22 ` Kai-Heng Feng
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.