All of lore.kernel.org
 help / color / mirror / Atom feed
* [Bug 1893010] [NEW] qemu linux-user doesn't support OFD fcntl locks
@ 2020-08-26  8:36 Mike Gelfand
  2020-08-26  8:43 ` [Bug 1893010] " Mike Gelfand
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Mike Gelfand @ 2020-08-26  8:36 UTC (permalink / raw)
  To: qemu-devel

Public bug reported:

"Open file description locks (non-POSIX)", as they are described in
fcntl(2) man page, aren't supported by qemu-user  and attempting to use
those results in EINVAL. I'm on Gentoo with latest QEMU version
currently available (5.0.0-r2), and trying to emulate ppc64 and s390x on
x86_64.

Looking at linux-user/syscall.c, I'm guessing the issue is in (at least)
`target_to_host_fcntl_cmd` where switch reaches the default clause as
there're no cases for F_OFD_SETLK / F_OFD_SETLKW / F_OFD_GETLK.

** Affects: qemu
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1893010

Title:
  qemu linux-user doesn't support OFD fcntl locks

Status in QEMU:
  New

Bug description:
  "Open file description locks (non-POSIX)", as they are described in
  fcntl(2) man page, aren't supported by qemu-user  and attempting to
  use those results in EINVAL. I'm on Gentoo with latest QEMU version
  currently available (5.0.0-r2), and trying to emulate ppc64 and s390x
  on x86_64.

  Looking at linux-user/syscall.c, I'm guessing the issue is in (at
  least) `target_to_host_fcntl_cmd` where switch reaches the default
  clause as there're no cases for F_OFD_SETLK / F_OFD_SETLKW /
  F_OFD_GETLK.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1893010/+subscriptions


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 1893010] Re: qemu linux-user doesn't support OFD fcntl locks
  2020-08-26  8:36 [Bug 1893010] [NEW] qemu linux-user doesn't support OFD fcntl locks Mike Gelfand
@ 2020-08-26  8:43 ` Mike Gelfand
  2020-08-27  8:39 ` Mike Gelfand
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Mike Gelfand @ 2020-08-26  8:43 UTC (permalink / raw)
  To: qemu-devel

** Summary changed:

- qemu-user doesn't support OFD fcntl locks
+ qemu linux-user doesn't support OFD fcntl locks

** Tags added: linux-user

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1893010

Title:
  qemu linux-user doesn't support OFD fcntl locks

Status in QEMU:
  New

Bug description:
  "Open file description locks (non-POSIX)", as they are described in
  fcntl(2) man page, aren't supported by qemu-user  and attempting to
  use those results in EINVAL. I'm on Gentoo with latest QEMU version
  currently available (5.0.0-r2), and trying to emulate ppc64 and s390x
  on x86_64.

  Looking at linux-user/syscall.c, I'm guessing the issue is in (at
  least) `target_to_host_fcntl_cmd` where switch reaches the default
  clause as there're no cases for F_OFD_SETLK / F_OFD_SETLKW /
  F_OFD_GETLK.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1893010/+subscriptions


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 1893010] Re: qemu linux-user doesn't support OFD fcntl locks
  2020-08-26  8:36 [Bug 1893010] [NEW] qemu linux-user doesn't support OFD fcntl locks Mike Gelfand
  2020-08-26  8:43 ` [Bug 1893010] " Mike Gelfand
@ 2020-08-27  8:39 ` Mike Gelfand
  2020-08-27 11:06 ` Mike Gelfand
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Mike Gelfand @ 2020-08-27  8:39 UTC (permalink / raw)
  To: qemu-devel

The attached patch fixes the issue for me.

** Patch added: "qemu-5.0.0-ofd-fcntl.patch"
   https://bugs.launchpad.net/qemu/+bug/1893010/+attachment/5405131/+files/qemu-5.0.0-ofd-fcntl.patch

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1893010

Title:
  qemu linux-user doesn't support OFD fcntl locks

Status in QEMU:
  New

Bug description:
  "Open file description locks (non-POSIX)", as they are described in
  fcntl(2) man page, aren't supported by qemu-user  and attempting to
  use those results in EINVAL. I'm on Gentoo with latest QEMU version
  currently available (5.0.0-r2), and trying to emulate ppc64 and s390x
  on x86_64.

  Looking at linux-user/syscall.c, I'm guessing the issue is in (at
  least) `target_to_host_fcntl_cmd` where switch reaches the default
  clause as there're no cases for F_OFD_SETLK / F_OFD_SETLKW /
  F_OFD_GETLK.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1893010/+subscriptions


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 1893010] Re: qemu linux-user doesn't support OFD fcntl locks
  2020-08-26  8:36 [Bug 1893010] [NEW] qemu linux-user doesn't support OFD fcntl locks Mike Gelfand
  2020-08-26  8:43 ` [Bug 1893010] " Mike Gelfand
  2020-08-27  8:39 ` Mike Gelfand
@ 2020-08-27 11:06 ` Mike Gelfand
  2020-08-29 13:50 ` Laurent Vivier
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Mike Gelfand @ 2020-08-27 11:06 UTC (permalink / raw)
  To: qemu-devel

New patch version: fix target_to_host_fcntl_cmd mapping, avoid do_fcntl
code duplication.

** Patch added: "qemu-5.0.0-ofd-fcntl-2.patch"
   https://bugs.launchpad.net/qemu/+bug/1893010/+attachment/5405156/+files/qemu-5.0.0-ofd-fcntl-2.patch

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1893010

Title:
  qemu linux-user doesn't support OFD fcntl locks

Status in QEMU:
  New

Bug description:
  "Open file description locks (non-POSIX)", as they are described in
  fcntl(2) man page, aren't supported by qemu-user  and attempting to
  use those results in EINVAL. I'm on Gentoo with latest QEMU version
  currently available (5.0.0-r2), and trying to emulate ppc64 and s390x
  on x86_64.

  Looking at linux-user/syscall.c, I'm guessing the issue is in (at
  least) `target_to_host_fcntl_cmd` where switch reaches the default
  clause as there're no cases for F_OFD_SETLK / F_OFD_SETLKW /
  F_OFD_GETLK.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1893010/+subscriptions


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 1893010] Re: qemu linux-user doesn't support OFD fcntl locks
  2020-08-26  8:36 [Bug 1893010] [NEW] qemu linux-user doesn't support OFD fcntl locks Mike Gelfand
                   ` (2 preceding siblings ...)
  2020-08-27 11:06 ` Mike Gelfand
@ 2020-08-29 13:50 ` Laurent Vivier
  2020-08-30  9:24 ` Mike Gelfand
  2020-08-31  8:34 ` Thomas Huth
  5 siblings, 0 replies; 7+ messages in thread
From: Laurent Vivier @ 2020-08-29 13:50 UTC (permalink / raw)
  To: qemu-devel

Please check qemu-5.1.0.

This has been fixed by:

  2d92c6827ca0 ("linux-user: implement OFD locks")
  https://git.qemu.org/?p=qemu.git;a=commitdiff;h=2d92c6827ca0

perhaps you can send a patch to the qemu-devel ML to add the strace
part.

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1893010

Title:
  qemu linux-user doesn't support OFD fcntl locks

Status in QEMU:
  New

Bug description:
  "Open file description locks (non-POSIX)", as they are described in
  fcntl(2) man page, aren't supported by qemu-user  and attempting to
  use those results in EINVAL. I'm on Gentoo with latest QEMU version
  currently available (5.0.0-r2), and trying to emulate ppc64 and s390x
  on x86_64.

  Looking at linux-user/syscall.c, I'm guessing the issue is in (at
  least) `target_to_host_fcntl_cmd` where switch reaches the default
  clause as there're no cases for F_OFD_SETLK / F_OFD_SETLKW /
  F_OFD_GETLK.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1893010/+subscriptions


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 1893010] Re: qemu linux-user doesn't support OFD fcntl locks
  2020-08-26  8:36 [Bug 1893010] [NEW] qemu linux-user doesn't support OFD fcntl locks Mike Gelfand
                   ` (3 preceding siblings ...)
  2020-08-29 13:50 ` Laurent Vivier
@ 2020-08-30  9:24 ` Mike Gelfand
  2020-08-31  8:34 ` Thomas Huth
  5 siblings, 0 replies; 7+ messages in thread
From: Mike Gelfand @ 2020-08-30  9:24 UTC (permalink / raw)
  To: qemu-devel

Thanks, the changes in 5.1.0 seem to work indeed.

> perhaps you can send a patch to the qemu-devel ML to add the strace
part

Done.

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1893010

Title:
  qemu linux-user doesn't support OFD fcntl locks

Status in QEMU:
  New

Bug description:
  "Open file description locks (non-POSIX)", as they are described in
  fcntl(2) man page, aren't supported by qemu-user  and attempting to
  use those results in EINVAL. I'm on Gentoo with latest QEMU version
  currently available (5.0.0-r2), and trying to emulate ppc64 and s390x
  on x86_64.

  Looking at linux-user/syscall.c, I'm guessing the issue is in (at
  least) `target_to_host_fcntl_cmd` where switch reaches the default
  clause as there're no cases for F_OFD_SETLK / F_OFD_SETLKW /
  F_OFD_GETLK.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1893010/+subscriptions


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 1893010] Re: qemu linux-user doesn't support OFD fcntl locks
  2020-08-26  8:36 [Bug 1893010] [NEW] qemu linux-user doesn't support OFD fcntl locks Mike Gelfand
                   ` (4 preceding siblings ...)
  2020-08-30  9:24 ` Mike Gelfand
@ 2020-08-31  8:34 ` Thomas Huth
  5 siblings, 0 replies; 7+ messages in thread
From: Thomas Huth @ 2020-08-31  8:34 UTC (permalink / raw)
  To: qemu-devel

** Changed in: qemu
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1893010

Title:
  qemu linux-user doesn't support OFD fcntl locks

Status in QEMU:
  Fix Released

Bug description:
  "Open file description locks (non-POSIX)", as they are described in
  fcntl(2) man page, aren't supported by qemu-user  and attempting to
  use those results in EINVAL. I'm on Gentoo with latest QEMU version
  currently available (5.0.0-r2), and trying to emulate ppc64 and s390x
  on x86_64.

  Looking at linux-user/syscall.c, I'm guessing the issue is in (at
  least) `target_to_host_fcntl_cmd` where switch reaches the default
  clause as there're no cases for F_OFD_SETLK / F_OFD_SETLKW /
  F_OFD_GETLK.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1893010/+subscriptions


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-08-31  8:46 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-26  8:36 [Bug 1893010] [NEW] qemu linux-user doesn't support OFD fcntl locks Mike Gelfand
2020-08-26  8:43 ` [Bug 1893010] " Mike Gelfand
2020-08-27  8:39 ` Mike Gelfand
2020-08-27 11:06 ` Mike Gelfand
2020-08-29 13:50 ` Laurent Vivier
2020-08-30  9:24 ` Mike Gelfand
2020-08-31  8:34 ` Thomas Huth

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.