* [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: refactoring cursor-alpha subtests
@ 2020-08-26 11:17 Melissa Wen
2020-08-26 12:02 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Melissa Wen @ 2020-08-26 11:17 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala, kernel-usp, twoerner
Considering just a fully opaque or fully transparent cursor is not enough
to check the composition of an ARGB cursor plane. For example, the cairo
ARGB32 format uses pre-multiplied alpha, and this representation may only
be evident when testing a translucent cursor.
Therefore, this patch refactors the cursor-alpha-opaque and
cursor-alpha-transparent subtests into just one subtest (cursor-alpha)
that checks the alpha blending of a white cursor, with different alpha
values, in the primary plane. This refactoring also generates some setup
stuffs savings.
Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
---
tests/kms_cursor_crc.c | 82 ++++++++++++++++++++----------------------
1 file changed, 39 insertions(+), 43 deletions(-)
diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
index e9491847..e200b0b5 100644
--- a/tests/kms_cursor_crc.c
+++ b/tests/kms_cursor_crc.c
@@ -478,65 +478,66 @@ static void prepare_crtc(data_t *data, igt_output_t *output,
igt_pipe_crc_start(data->pipe_crc);
}
-static void test_cursor_alpha(data_t *data, double a)
+static void test_cursor_alpha(data_t *data)
{
igt_display_t *display = &data->display;
igt_pipe_crc_t *pipe_crc = data->pipe_crc;
- igt_crc_t crc, ref_crc;
+ igt_crc_t crc[5], ref_crc;
cairo_t *cr;
uint32_t fb_id;
int curw = data->curw;
int curh = data->curh;
+ int i;
+ double alpha;
- /* Alpha cursor fb with white color */
+ /* Alpha cursor fb */
fb_id = igt_create_fb(data->drm_fd, curw, curh,
DRM_FORMAT_ARGB8888,
LOCAL_DRM_FORMAT_MOD_NONE,
&data->fb);
igt_assert(fb_id);
+
+ /*
+ * Hardware Test
+ * With the cursor enabled, get the PF CRCs from the composition with a
+ * white cursor with different alpha values.
+ */
cr = igt_get_cairo_ctx(data->drm_fd, &data->fb);
- igt_paint_color_alpha(cr, 0, 0, curw, curh, 1.0, 1.0, 1.0, a);
- igt_put_cairo_ctx(cr);
+ cairo_set_operator (cr, CAIRO_OPERATOR_SOURCE);
- /* Hardware Test - enable cursor and get PF CRC */
cursor_enable(data);
- igt_display_commit(display);
- igt_wait_for_vblank(data->drm_fd,
- display->pipes[data->pipe].crtc_offset);
- igt_pipe_crc_get_current(data->drm_fd, pipe_crc, &crc);
+ for (i = 0, alpha = 1.0; alpha >= 0.0; alpha -= 0.25, i++) {
+ igt_paint_color_alpha(cr, 0, 0, curw, curh, 1.0, 1.0, 1.0, alpha);
+
+ igt_display_commit(display);
+ igt_wait_for_vblank(data->drm_fd,
+ display->pipes[data->pipe].crtc_offset);
+ igt_pipe_crc_get_current(data->drm_fd, pipe_crc, &crc[i]);
+ }
+ igt_put_cairo_ctx(cr);
cursor_disable(data);
igt_remove_fb(data->drm_fd, &data->fb);
- /* Software Test - render cursor in software, drawn it directly on PF */
+ /* Software Test - render cursor in software, drawn it directly on PF*/
cr = igt_get_cairo_ctx(data->drm_fd, &data->primary_fb[FRONTBUFFER]);
- igt_paint_color_alpha(cr, 0, 0, curw, curh, 1.0, 1.0, 1.0, a);
- igt_put_cairo_ctx(cr);
- igt_display_commit(display);
- igt_wait_for_vblank(data->drm_fd,
- display->pipes[data->pipe].crtc_offset);
- igt_pipe_crc_get_current(data->drm_fd, pipe_crc, &ref_crc);
+ for (i = 0, alpha = 1.0; alpha >= 0.0; alpha -= 0.25, i++) {
+ igt_paint_color_alpha(cr, 0, 0, curw, curh, 1.0, 1.0, 1.0, alpha);
- /* Compare CRC from Hardware/Software tests */
- igt_assert_crc_equal(&crc, &ref_crc);
-
- /*Clear Screen*/
- cr = igt_get_cairo_ctx(data->drm_fd, &data->primary_fb[FRONTBUFFER]);
- igt_paint_color(cr, 0, 0, data->screenw, data->screenh,
- 0.0, 0.0, 0.0);
- igt_put_cairo_ctx(cr);
-}
-
-static void test_cursor_transparent(data_t *data)
-{
- test_cursor_alpha(data, 0.0);
+ igt_display_commit(display);
+ igt_wait_for_vblank(data->drm_fd,
+ display->pipes[data->pipe].crtc_offset);
+ igt_pipe_crc_get_current(data->drm_fd, pipe_crc, &ref_crc);
-}
+ /* Compare CRC from Hardware/Software tests */
+ igt_assert_crc_equal(&crc[i], &ref_crc);
-static void test_cursor_opaque(data_t *data)
-{
- test_cursor_alpha(data, 1.0);
+ /*Clear Screen*/
+ igt_paint_color(cr, 0, 0, data->screenw, data->screenh,
+ 0.0, 0.0, 0.0);
+ }
+ igt_put_cairo_ctx(cr);
}
static void run_test(data_t *data, void (*testfunc)(data_t *), int cursor_w, int cursor_h)
@@ -705,15 +706,10 @@ static void run_tests_on_pipe(data_t *data, enum pipe pipe)
run_test(data, test_cursor_size,
data->cursor_max_w, data->cursor_max_h);
- igt_describe("Validates the composition of a fully opaque cursor "
- "plane, i.e., alpha channel equal to 1.0.");
- igt_subtest_f("pipe-%s-cursor-alpha-opaque", kmstest_pipe_name(pipe))
- run_test(data, test_cursor_opaque, data->cursor_max_w, data->cursor_max_h);
-
- igt_describe("Validates the composition of a fully transparent cursor "
- "plane, i.e., alpha channel equal to 0.0.");
- igt_subtest_f("pipe-%s-cursor-alpha-transparent", kmstest_pipe_name(pipe))
- run_test(data, test_cursor_transparent, data->cursor_max_w, data->cursor_max_h);
+ igt_describe("Validates the composition of alpha cursor plane "
+ "from fully opaque to fully transparent alpha range");
+ igt_subtest_f("pipe-%s-cursor-alpha", kmstest_pipe_name(pipe))
+ run_test(data, test_cursor_alpha, data->cursor_max_w, data->cursor_max_h);
igt_fixture
create_cursor_fb(data, data->cursor_max_w, data->cursor_max_h);
--
2.28.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_cursor_crc: refactoring cursor-alpha subtests
2020-08-26 11:17 [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: refactoring cursor-alpha subtests Melissa Wen
@ 2020-08-26 12:02 ` Patchwork
2020-08-26 17:17 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2020-09-09 20:22 ` [igt-dev] [PATCH i-g-t] " Arkadiusz Hiler
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-08-26 12:02 UTC (permalink / raw)
To: Melissa Wen; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 5985 bytes --]
== Series Details ==
Series: tests/kms_cursor_crc: refactoring cursor-alpha subtests
URL : https://patchwork.freedesktop.org/series/81060/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8928 -> IGTPW_4907
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/index.html
Known issues
------------
Here are the changes found in IGTPW_4907 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload:
- fi-byt-j1900: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/fi-byt-j1900/igt@i915_module_load@reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/fi-byt-j1900/igt@i915_module_load@reload.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-icl-u2: [PASS][3] -> [FAIL][4] ([i915#1117])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html
#### Possible fixes ####
* igt@gem_exec_parallel@engines@basic:
- fi-bxt-dsi: [INCOMPLETE][5] ([i915#1635]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/fi-bxt-dsi/igt@gem_exec_parallel@engines@basic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/fi-bxt-dsi/igt@gem_exec_parallel@engines@basic.html
* igt@gem_exec_parallel@engines@fds:
- fi-cml-s: [INCOMPLETE][7] -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/fi-cml-s/igt@gem_exec_parallel@engines@fds.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/fi-cml-s/igt@gem_exec_parallel@engines@fds.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [DMESG-WARN][9] ([i915#1982]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_selftest@live@execlists:
- fi-icl-y: [INCOMPLETE][11] ([i915#2271] / [i915#2276]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/fi-icl-y/igt@i915_selftest@live@execlists.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/fi-icl-y/igt@i915_selftest@live@execlists.html
* igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2:
- fi-skl-guc: [DMESG-WARN][13] ([i915#2203]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/fi-skl-guc/igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/fi-skl-guc/igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2.html
#### Warnings ####
* igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
- fi-kbl-x1275: [DMESG-WARN][15] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][16] ([i915#62] / [i915#92]) +5 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][17] ([i915#62] / [i915#92]) -> [DMESG-WARN][18] ([i915#62] / [i915#92] / [i915#95]) +6 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
[i915#1117]: https://gitlab.freedesktop.org/drm/intel/issues/1117
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#2271]: https://gitlab.freedesktop.org/drm/intel/issues/2271
[i915#2276]: https://gitlab.freedesktop.org/drm/intel/issues/2276
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (37 -> 34)
------------------------------
Missing (3): fi-byt-clapper fi-byt-squawks fi-bsw-cyan
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5771 -> IGTPW_4907
CI-20190529: 20190529
CI_DRM_8928: 58f2939dbc6d2e11838ad8ef87250fcd1e3408ee @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4907: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/index.html
IGT_5771: f1d0c240ea2e631dfb9f493f37f8fb61cb2b1cf2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@kms_cursor_crc@pipe-a-cursor-alpha
+igt@kms_cursor_crc@pipe-b-cursor-alpha
+igt@kms_cursor_crc@pipe-c-cursor-alpha
+igt@kms_cursor_crc@pipe-d-cursor-alpha
+igt@kms_cursor_crc@pipe-e-cursor-alpha
+igt@kms_cursor_crc@pipe-f-cursor-alpha
-igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque
-igt@kms_cursor_crc@pipe-a-cursor-alpha-transparent
-igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque
-igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent
-igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque
-igt@kms_cursor_crc@pipe-c-cursor-alpha-transparent
-igt@kms_cursor_crc@pipe-d-cursor-alpha-opaque
-igt@kms_cursor_crc@pipe-d-cursor-alpha-transparent
-igt@kms_cursor_crc@pipe-e-cursor-alpha-opaque
-igt@kms_cursor_crc@pipe-e-cursor-alpha-transparent
-igt@kms_cursor_crc@pipe-f-cursor-alpha-opaque
-igt@kms_cursor_crc@pipe-f-cursor-alpha-transparent
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/index.html
[-- Attachment #1.2: Type: text/html, Size: 7428 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_cursor_crc: refactoring cursor-alpha subtests
2020-08-26 11:17 [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: refactoring cursor-alpha subtests Melissa Wen
2020-08-26 12:02 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-08-26 17:17 ` Patchwork
2020-09-09 20:22 ` [igt-dev] [PATCH i-g-t] " Arkadiusz Hiler
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-08-26 17:17 UTC (permalink / raw)
To: Melissa Wen; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 20234 bytes --]
== Series Details ==
Series: tests/kms_cursor_crc: refactoring cursor-alpha subtests
URL : https://patchwork.freedesktop.org/series/81060/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8928_full -> IGTPW_4907_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_4907_full:
### IGT changes ###
#### Possible regressions ####
* {igt@kms_cursor_crc@pipe-c-cursor-alpha} (NEW):
- shard-glk: NOTRUN -> [FAIL][1] +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-glk4/igt@kms_cursor_crc@pipe-c-cursor-alpha.html
New tests
---------
New tests have been introduced between CI_DRM_8928_full and IGTPW_4907_full:
### New IGT tests (4) ###
* igt@kms_cursor_crc@pipe-a-cursor-alpha:
- Statuses : 1 fail(s) 6 pass(s)
- Exec time: [0.54, 0.88] s
* igt@kms_cursor_crc@pipe-b-cursor-alpha:
- Statuses : 1 fail(s) 6 pass(s)
- Exec time: [0.70, 1.96] s
* igt@kms_cursor_crc@pipe-c-cursor-alpha:
- Statuses : 1 fail(s) 5 pass(s) 1 skip(s)
- Exec time: [0.0, 2.00] s
* igt@kms_cursor_crc@pipe-d-cursor-alpha:
- Statuses : 1 pass(s) 6 skip(s)
- Exec time: [0.0, 1.82] s
Known issues
------------
Here are the changes found in IGTPW_4907_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: [PASS][2] -> [DMESG-WARN][3] ([i915#180]) +4 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-kbl2/igt@gem_ctx_isolation@preservation-s3@vcs0.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-kbl4/igt@gem_ctx_isolation@preservation-s3@vcs0.html
* igt@gem_exec_nop@basic-sequential:
- shard-tglb: [PASS][4] -> [TIMEOUT][5] ([i915#1958]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-tglb1/igt@gem_exec_nop@basic-sequential.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-tglb8/igt@gem_exec_nop@basic-sequential.html
* igt@gem_exec_reloc@basic-concurrent0:
- shard-glk: [PASS][6] -> [TIMEOUT][7] ([i915#1958]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-glk3/igt@gem_exec_reloc@basic-concurrent0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-glk8/igt@gem_exec_reloc@basic-concurrent0.html
* igt@gem_exec_whisper@basic-fds-forked-all:
- shard-glk: [PASS][8] -> [DMESG-WARN][9] ([i915#118] / [i915#95])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-glk9/igt@gem_exec_whisper@basic-fds-forked-all.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-glk5/igt@gem_exec_whisper@basic-fds-forked-all.html
* igt@gem_exec_whisper@basic-queues:
- shard-apl: [PASS][10] -> [TIMEOUT][11] ([i915#1635] / [i915#1958])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-apl3/igt@gem_exec_whisper@basic-queues.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-apl8/igt@gem_exec_whisper@basic-queues.html
* igt@gem_sync@basic-store-all:
- shard-glk: [PASS][12] -> [FAIL][13] ([i915#2356])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-glk9/igt@gem_sync@basic-store-all.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-glk3/igt@gem_sync@basic-store-all.html
- shard-kbl: [PASS][14] -> [FAIL][15] ([i915#2356])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-kbl4/igt@gem_sync@basic-store-all.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-kbl4/igt@gem_sync@basic-store-all.html
* igt@kms_cursor_crc@pipe-a-cursor-64x64-random:
- shard-apl: [PASS][16] -> [FAIL][17] ([i915#1635] / [i915#54])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-apl3/igt@kms_cursor_crc@pipe-a-cursor-64x64-random.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-apl4/igt@kms_cursor_crc@pipe-a-cursor-64x64-random.html
- shard-glk: [PASS][18] -> [FAIL][19] ([i915#54])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-glk5/igt@kms_cursor_crc@pipe-a-cursor-64x64-random.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-glk4/igt@kms_cursor_crc@pipe-a-cursor-64x64-random.html
- shard-kbl: [PASS][20] -> [FAIL][21] ([i915#54])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-64x64-random.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-64x64-random.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [PASS][22] -> [FAIL][23] ([i915#2370])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-hsw8/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
- shard-glk: [PASS][24] -> [DMESG-WARN][25] ([i915#1982])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1:
- shard-hsw: [PASS][26] -> [INCOMPLETE][27] ([i915#2055])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-hsw7/igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-hsw2/igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-tglb: [PASS][28] -> [DMESG-WARN][29] ([i915#1982]) +3 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary:
- shard-kbl: [PASS][30] -> [FAIL][31] ([i915#49])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html
- shard-apl: [PASS][32] -> [FAIL][33] ([i915#1635] / [i915#49])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-apl6/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-apl4/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html
- shard-glk: [PASS][34] -> [FAIL][35] ([i915#49])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-glk8/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-glk4/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-wc:
- shard-kbl: [PASS][36] -> [DMESG-WARN][37] ([i915#1982])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-wc.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-wc.html
* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [PASS][38] -> [SKIP][39] ([i915#433])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-tglb3/igt@kms_hdmi_inject@inject-audio.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-tglb7/igt@kms_hdmi_inject@inject-audio.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][40] -> [SKIP][41] ([fdo#109441]) +3 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-iclb4/igt@kms_psr@psr2_cursor_render.html
* igt@kms_setmode@basic:
- shard-glk: [PASS][42] -> [FAIL][43] ([i915#31])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-glk9/igt@kms_setmode@basic.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-glk7/igt@kms_setmode@basic.html
* igt@perf@polling-parameterized:
- shard-kbl: [PASS][44] -> [FAIL][45] ([i915#1542])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-kbl4/igt@perf@polling-parameterized.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-kbl4/igt@perf@polling-parameterized.html
#### Possible fixes ####
* igt@gem_eio@kms:
- shard-hsw: [DMESG-WARN][46] ([i915#1982]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-hsw1/igt@gem_eio@kms.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-hsw7/igt@gem_eio@kms.html
* igt@gem_exec_whisper@basic-contexts-all:
- shard-glk: [TIMEOUT][48] ([i915#1958]) -> [PASS][49] +3 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-glk8/igt@gem_exec_whisper@basic-contexts-all.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-glk4/igt@gem_exec_whisper@basic-contexts-all.html
* igt@gem_exec_whisper@basic-fds:
- shard-iclb: [TIMEOUT][50] ([i915#1958]) -> [PASS][51] +2 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-iclb6/igt@gem_exec_whisper@basic-fds.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-iclb7/igt@gem_exec_whisper@basic-fds.html
* igt@gem_sync@basic-store-all:
- shard-apl: [FAIL][52] ([i915#1635] / [i915#2356]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-apl4/igt@gem_sync@basic-store-all.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-apl6/igt@gem_sync@basic-store-all.html
* igt@i915_pm_dc@dc5-psr:
- shard-tglb: [FAIL][54] ([i915#1899]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-tglb5/igt@i915_pm_dc@dc5-psr.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-tglb1/igt@i915_pm_dc@dc5-psr.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][56] ([i915#1899]) -> [PASS][57] +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-iclb4/igt@i915_pm_dc@dc6-psr.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-0:
- shard-glk: [DMESG-FAIL][58] ([i915#118] / [i915#95]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-glk8/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-glk4/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
* igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen:
- shard-apl: [FAIL][60] ([i915#1635] / [i915#54]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen.html
- shard-glk: [FAIL][62] ([i915#54]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-glk7/igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-glk5/igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen.html
- shard-kbl: [FAIL][64] ([i915#54]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen.html
* igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2:
- shard-glk: [FAIL][66] ([i915#79]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-glk7/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-glk6/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
* igt@kms_flip@modeset-vs-vblank-race@a-hdmi-a1:
- shard-glk: [FAIL][68] ([i915#407]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-glk2/igt@kms_flip@modeset-vs-vblank-race@a-hdmi-a1.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-glk6/igt@kms_flip@modeset-vs-vblank-race@a-hdmi-a1.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-kbl: [DMESG-WARN][70] ([i915#1982]) -> [PASS][71] +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-iclb: [DMESG-WARN][72] ([i915#1982]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [DMESG-WARN][74] ([i915#180]) -> [PASS][75] +6 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-tglb: [DMESG-WARN][76] ([i915#1982]) -> [PASS][77] +2 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-wc.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-glk: [FAIL][78] ([i915#53]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-glk9/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-glk2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][80] ([fdo#109441]) -> [PASS][81] +2 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-iclb8/igt@kms_psr@psr2_sprite_mmap_gtt.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@perf@blocking-parameterized:
- shard-iclb: [FAIL][82] ([i915#1542]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-iclb3/igt@perf@blocking-parameterized.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-iclb4/igt@perf@blocking-parameterized.html
* igt@perf@polling-parameterized:
- shard-tglb: [FAIL][84] ([i915#1542]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-tglb8/igt@perf@polling-parameterized.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-tglb5/igt@perf@polling-parameterized.html
* igt@sysfs_timeslice_duration@timeout@vecs0:
- shard-iclb: [FAIL][86] ([i915#1755]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-iclb2/igt@sysfs_timeslice_duration@timeout@vecs0.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-iclb5/igt@sysfs_timeslice_duration@timeout@vecs0.html
- shard-apl: [FAIL][88] ([i915#1635] / [i915#1755]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-apl6/igt@sysfs_timeslice_duration@timeout@vecs0.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-apl8/igt@sysfs_timeslice_duration@timeout@vecs0.html
- shard-kbl: [FAIL][90] ([i915#1755]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-kbl7/igt@sysfs_timeslice_duration@timeout@vecs0.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-kbl1/igt@sysfs_timeslice_duration@timeout@vecs0.html
- shard-tglb: [FAIL][92] ([i915#1755]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-tglb1/igt@sysfs_timeslice_duration@timeout@vecs0.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-tglb8/igt@sysfs_timeslice_duration@timeout@vecs0.html
#### Warnings ####
* igt@i915_pm_dc@dc6-psr:
- shard-tglb: [FAIL][94] ([i915#1899]) -> [FAIL][95] ([i915#454])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8928/shard-tglb3/igt@i915_pm_dc@dc6-psr.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shard-tglb1/igt@i915_pm_dc@dc6-psr.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1899]: https://gitlab.freedesktop.org/drm/intel/issues/1899
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2356]: https://gitlab.freedesktop.org/drm/intel/issues/2356
[i915#2370]: https://gitlab.freedesktop.org/drm/intel/issues/2370
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#407]: https://gitlab.freedesktop.org/drm/intel/issues/407
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 8)
------------------------------
Missing (2): pig-skl-6260u pig-glk-j5005
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5771 -> IGTPW_4907
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_8928: 58f2939dbc6d2e11838ad8ef87250fcd1e3408ee @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4907: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/index.html
IGT_5771: f1d0c240ea2e631dfb9f493f37f8fb61cb2b1cf2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/index.html
[-- Attachment #1.2: Type: text/html, Size: 24410 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: refactoring cursor-alpha subtests
2020-08-26 11:17 [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: refactoring cursor-alpha subtests Melissa Wen
2020-08-26 12:02 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-08-26 17:17 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2020-09-09 20:22 ` Arkadiusz Hiler
2020-10-21 9:14 ` Melissa Wen
2 siblings, 1 reply; 5+ messages in thread
From: Arkadiusz Hiler @ 2020-09-09 20:22 UTC (permalink / raw)
To: Melissa Wen; +Cc: Petri Latvala, kernel-usp, igt-dev, twoerner
On Wed, Aug 26, 2020 at 08:17:33AM -0300, Melissa Wen wrote:
> Considering just a fully opaque or fully transparent cursor is not enough
> to check the composition of an ARGB cursor plane. For example, the cairo
> ARGB32 format uses pre-multiplied alpha, and this representation may only
> be evident when testing a translucent cursor.
>
> Therefore, this patch refactors the cursor-alpha-opaque and
> cursor-alpha-transparent subtests into just one subtest (cursor-alpha)
> that checks the alpha blending of a white cursor, with different alpha
> values, in the primary plane. This refactoring also generates some setup
> stuffs savings.
>
> Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
> ---
> tests/kms_cursor_crc.c | 82 ++++++++++++++++++++----------------------
> 1 file changed, 39 insertions(+), 43 deletions(-)
>
> diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
> index e9491847..e200b0b5 100644
> --- a/tests/kms_cursor_crc.c
> +++ b/tests/kms_cursor_crc.c
> @@ -478,65 +478,66 @@ static void prepare_crtc(data_t *data, igt_output_t *output,
> igt_pipe_crc_start(data->pipe_crc);
> }
>
> -static void test_cursor_alpha(data_t *data, double a)
> +static void test_cursor_alpha(data_t *data)
> {
> igt_display_t *display = &data->display;
> igt_pipe_crc_t *pipe_crc = data->pipe_crc;
> - igt_crc_t crc, ref_crc;
> + igt_crc_t crc[5], ref_crc;
> cairo_t *cr;
> uint32_t fb_id;
> int curw = data->curw;
> int curh = data->curh;
> + int i;
> + double alpha;
>
> - /* Alpha cursor fb with white color */
> + /* Alpha cursor fb */
> fb_id = igt_create_fb(data->drm_fd, curw, curh,
> DRM_FORMAT_ARGB8888,
> LOCAL_DRM_FORMAT_MOD_NONE,
> &data->fb);
> igt_assert(fb_id);
> +
> + /*
> + * Hardware Test
> + * With the cursor enabled, get the PF CRCs from the composition with a
> + * white cursor with different alpha values.
> + */
> cr = igt_get_cairo_ctx(data->drm_fd, &data->fb);
> - igt_paint_color_alpha(cr, 0, 0, curw, curh, 1.0, 1.0, 1.0, a);
> - igt_put_cairo_ctx(cr);
> + cairo_set_operator (cr, CAIRO_OPERATOR_SOURCE);
>
> - /* Hardware Test - enable cursor and get PF CRC */
> cursor_enable(data);
> - igt_display_commit(display);
> - igt_wait_for_vblank(data->drm_fd,
> - display->pipes[data->pipe].crtc_offset);
> - igt_pipe_crc_get_current(data->drm_fd, pipe_crc, &crc);
> + for (i = 0, alpha = 1.0; alpha >= 0.0; alpha -= 0.25, i++) {
> + igt_paint_color_alpha(cr, 0, 0, curw, curh, 1.0, 1.0, 1.0, alpha);
> +
> + igt_display_commit(display);
> + igt_wait_for_vblank(data->drm_fd,
> + display->pipes[data->pipe].crtc_offset);
> + igt_pipe_crc_get_current(data->drm_fd, pipe_crc, &crc[i]);
> + }
> + igt_put_cairo_ctx(cr);
>
> cursor_disable(data);
> igt_remove_fb(data->drm_fd, &data->fb);
>
> - /* Software Test - render cursor in software, drawn it directly on PF */
> + /* Software Test - render cursor in software, drawn it directly on PF*/
> cr = igt_get_cairo_ctx(data->drm_fd, &data->primary_fb[FRONTBUFFER]);
> - igt_paint_color_alpha(cr, 0, 0, curw, curh, 1.0, 1.0, 1.0, a);
> - igt_put_cairo_ctx(cr);
>
> - igt_display_commit(display);
> - igt_wait_for_vblank(data->drm_fd,
> - display->pipes[data->pipe].crtc_offset);
> - igt_pipe_crc_get_current(data->drm_fd, pipe_crc, &ref_crc);
> + for (i = 0, alpha = 1.0; alpha >= 0.0; alpha -= 0.25, i++) {
> + igt_paint_color_alpha(cr, 0, 0, curw, curh, 1.0, 1.0, 1.0, alpha);
>
> - /* Compare CRC from Hardware/Software tests */
> - igt_assert_crc_equal(&crc, &ref_crc);
> -
> - /*Clear Screen*/
> - cr = igt_get_cairo_ctx(data->drm_fd, &data->primary_fb[FRONTBUFFER]);
> - igt_paint_color(cr, 0, 0, data->screenw, data->screenh,
> - 0.0, 0.0, 0.0);
> - igt_put_cairo_ctx(cr);
> -}
> -
> -static void test_cursor_transparent(data_t *data)
> -{
> - test_cursor_alpha(data, 0.0);
> + igt_display_commit(display);
> + igt_wait_for_vblank(data->drm_fd,
> + display->pipes[data->pipe].crtc_offset);
> + igt_pipe_crc_get_current(data->drm_fd, pipe_crc, &ref_crc);
>
> -}
> + /* Compare CRC from Hardware/Software tests */
> + igt_assert_crc_equal(&crc[i], &ref_crc);
Hey,
Sorry it took so long for me to review this. I was taking a bit of a
break from DRM work.
The change is sound, checking multiple alpha levels makes sense, and
looks like the test mostly passes on real HW - I was a bit afraid that
there may be some discrepancies between SW and HW implementation of
alpha blending.
On Intel's CI side - GLK is misbehaving a bit:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shards-all.html?testfilter=cursor-alpha
But that looks like it's a HW problem. It's for alpha=0.5, which wasn't
tested before and other generations of hardware are passing the test just
fine.
It would be nice to improve logging in the test a bit:
* don't fail the test early, always go through all of the alpha levels
* clearly state for which alpha levels we have failed, right now you
I have to count the number of "commits" in the debug logs
We've been doing similar improvements in other tests.
--
Cheers,
Arek
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: refactoring cursor-alpha subtests
2020-09-09 20:22 ` [igt-dev] [PATCH i-g-t] " Arkadiusz Hiler
@ 2020-10-21 9:14 ` Melissa Wen
0 siblings, 0 replies; 5+ messages in thread
From: Melissa Wen @ 2020-10-21 9:14 UTC (permalink / raw)
To: Arkadiusz Hiler; +Cc: Petri Latvala, kernel-usp, igt-dev, twoerner
On 09/09, Arkadiusz Hiler wrote:
> On Wed, Aug 26, 2020 at 08:17:33AM -0300, Melissa Wen wrote:
> > Considering just a fully opaque or fully transparent cursor is not enough
> > to check the composition of an ARGB cursor plane. For example, the cairo
> > ARGB32 format uses pre-multiplied alpha, and this representation may only
> > be evident when testing a translucent cursor.
> >
> > Therefore, this patch refactors the cursor-alpha-opaque and
> > cursor-alpha-transparent subtests into just one subtest (cursor-alpha)
> > that checks the alpha blending of a white cursor, with different alpha
> > values, in the primary plane. This refactoring also generates some setup
> > stuffs savings.
> >
> > Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
> > ---
> > tests/kms_cursor_crc.c | 82 ++++++++++++++++++++----------------------
> > 1 file changed, 39 insertions(+), 43 deletions(-)
> >
> > diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
> > index e9491847..e200b0b5 100644
> > --- a/tests/kms_cursor_crc.c
> > +++ b/tests/kms_cursor_crc.c
> > @@ -478,65 +478,66 @@ static void prepare_crtc(data_t *data, igt_output_t *output,
> > igt_pipe_crc_start(data->pipe_crc);
> > }
> >
> > -static void test_cursor_alpha(data_t *data, double a)
> > +static void test_cursor_alpha(data_t *data)
> > {
> > igt_display_t *display = &data->display;
> > igt_pipe_crc_t *pipe_crc = data->pipe_crc;
> > - igt_crc_t crc, ref_crc;
> > + igt_crc_t crc[5], ref_crc;
> > cairo_t *cr;
> > uint32_t fb_id;
> > int curw = data->curw;
> > int curh = data->curh;
> > + int i;
> > + double alpha;
> >
> > - /* Alpha cursor fb with white color */
> > + /* Alpha cursor fb */
> > fb_id = igt_create_fb(data->drm_fd, curw, curh,
> > DRM_FORMAT_ARGB8888,
> > LOCAL_DRM_FORMAT_MOD_NONE,
> > &data->fb);
> > igt_assert(fb_id);
> > +
> > + /*
> > + * Hardware Test
> > + * With the cursor enabled, get the PF CRCs from the composition with a
> > + * white cursor with different alpha values.
> > + */
> > cr = igt_get_cairo_ctx(data->drm_fd, &data->fb);
> > - igt_paint_color_alpha(cr, 0, 0, curw, curh, 1.0, 1.0, 1.0, a);
> > - igt_put_cairo_ctx(cr);
> > + cairo_set_operator (cr, CAIRO_OPERATOR_SOURCE);
> >
> > - /* Hardware Test - enable cursor and get PF CRC */
> > cursor_enable(data);
> > - igt_display_commit(display);
> > - igt_wait_for_vblank(data->drm_fd,
> > - display->pipes[data->pipe].crtc_offset);
> > - igt_pipe_crc_get_current(data->drm_fd, pipe_crc, &crc);
> > + for (i = 0, alpha = 1.0; alpha >= 0.0; alpha -= 0.25, i++) {
> > + igt_paint_color_alpha(cr, 0, 0, curw, curh, 1.0, 1.0, 1.0, alpha);
> > +
> > + igt_display_commit(display);
> > + igt_wait_for_vblank(data->drm_fd,
> > + display->pipes[data->pipe].crtc_offset);
> > + igt_pipe_crc_get_current(data->drm_fd, pipe_crc, &crc[i]);
> > + }
> > + igt_put_cairo_ctx(cr);
> >
> > cursor_disable(data);
> > igt_remove_fb(data->drm_fd, &data->fb);
> >
> > - /* Software Test - render cursor in software, drawn it directly on PF */
> > + /* Software Test - render cursor in software, drawn it directly on PF*/
> > cr = igt_get_cairo_ctx(data->drm_fd, &data->primary_fb[FRONTBUFFER]);
> > - igt_paint_color_alpha(cr, 0, 0, curw, curh, 1.0, 1.0, 1.0, a);
> > - igt_put_cairo_ctx(cr);
> >
> > - igt_display_commit(display);
> > - igt_wait_for_vblank(data->drm_fd,
> > - display->pipes[data->pipe].crtc_offset);
> > - igt_pipe_crc_get_current(data->drm_fd, pipe_crc, &ref_crc);
> > + for (i = 0, alpha = 1.0; alpha >= 0.0; alpha -= 0.25, i++) {
> > + igt_paint_color_alpha(cr, 0, 0, curw, curh, 1.0, 1.0, 1.0, alpha);
> >
> > - /* Compare CRC from Hardware/Software tests */
> > - igt_assert_crc_equal(&crc, &ref_crc);
> > -
> > - /*Clear Screen*/
> > - cr = igt_get_cairo_ctx(data->drm_fd, &data->primary_fb[FRONTBUFFER]);
> > - igt_paint_color(cr, 0, 0, data->screenw, data->screenh,
> > - 0.0, 0.0, 0.0);
> > - igt_put_cairo_ctx(cr);
> > -}
> > -
> > -static void test_cursor_transparent(data_t *data)
> > -{
> > - test_cursor_alpha(data, 0.0);
> > + igt_display_commit(display);
> > + igt_wait_for_vblank(data->drm_fd,
> > + display->pipes[data->pipe].crtc_offset);
> > + igt_pipe_crc_get_current(data->drm_fd, pipe_crc, &ref_crc);
> >
> > -}
> > + /* Compare CRC from Hardware/Software tests */
> > + igt_assert_crc_equal(&crc[i], &ref_crc);
>
> Hey,
>
> Sorry it took so long for me to review this. I was taking a bit of a
> break from DRM work.
>
> The change is sound, checking multiple alpha levels makes sense, and
> looks like the test mostly passes on real HW - I was a bit afraid that
> there may be some discrepancies between SW and HW implementation of
> alpha blending.
>
> On Intel's CI side - GLK is misbehaving a bit:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4907/shards-all.html?testfilter=cursor-alpha
>
> But that looks like it's a HW problem. It's for alpha=0.5, which wasn't
> tested before and other generations of hardware are passing the test just
> fine.
>
> It would be nice to improve logging in the test a bit:
> * don't fail the test early, always go through all of the alpha levels
> * clearly state for which alpha levels we have failed, right now you
> I have to count the number of "commits" in the debug logs
>
Hi Arek,
Thanks for the review.
Sorry for the delay, I left the context a little after GSoC and only now
I managed to wrap-up it.
I'm not sure if I got it right, when possible, could you give me
feedback on the v2 that I just sent?
Best regards,
Melissa
> We've been doing similar improvements in other tests.
>
> --
> Cheers,
> Arek
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-21 9:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-26 11:17 [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: refactoring cursor-alpha subtests Melissa Wen
2020-08-26 12:02 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-08-26 17:17 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2020-09-09 20:22 ` [igt-dev] [PATCH i-g-t] " Arkadiusz Hiler
2020-10-21 9:14 ` Melissa Wen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.