All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH v1] ARM64: dts: imx8mp: correct sdma1 clk setting
  2020-08-31 17:36 ` Robin Gong
@ 2020-08-31 11:11   ` Fabio Estevam
  -1 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2020-08-31 11:11 UTC (permalink / raw)
  To: Robin Gong
  Cc: Rob Herring, Shawn Guo, Sascha Hauer, Yongcai Huang,
	Sascha Hauer, NXP Linux Team,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	linux-kernel

Hi Robin,

On Mon, Aug 31, 2020 at 6:22 AM Robin Gong <yibin.gong@nxp.com> wrote:
>
> Correct sdma1 ahb clk, otherwise wrong 1:1 clk ratio will be chosed so
> that sdma1 function broken. sdma1 should use 1:2 clk, while sdma2/3 use
> 1:1.
>
> Signed-off-by: Robin Gong <yibin.gong@nxp.com>

Please add a Fixes tag.

Thanks

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v1] ARM64: dts: imx8mp: correct sdma1 clk setting
@ 2020-08-31 11:11   ` Fabio Estevam
  0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2020-08-31 11:11 UTC (permalink / raw)
  To: Robin Gong
  Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Yongcai Huang, Sascha Hauer, linux-kernel, Rob Herring,
	NXP Linux Team, Sascha Hauer, Shawn Guo,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

Hi Robin,

On Mon, Aug 31, 2020 at 6:22 AM Robin Gong <yibin.gong@nxp.com> wrote:
>
> Correct sdma1 ahb clk, otherwise wrong 1:1 clk ratio will be chosed so
> that sdma1 function broken. sdma1 should use 1:2 clk, while sdma2/3 use
> 1:1.
>
> Signed-off-by: Robin Gong <yibin.gong@nxp.com>

Please add a Fixes tag.

Thanks

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v1] ARM64: dts: imx8mp: correct sdma1 clk setting
@ 2020-08-31 17:36 ` Robin Gong
  0 siblings, 0 replies; 6+ messages in thread
From: Robin Gong @ 2020-08-31 17:36 UTC (permalink / raw)
  To: robh+dt, shawnguo, s.hauer, festevam, Anson.Huang
  Cc: kernel, linux-imx, devicetree, linux-arm-kernel, linux-kernel

Correct sdma1 ahb clk, otherwise wrong 1:1 clk ratio will be chosed so
that sdma1 function broken. sdma1 should use 1:2 clk, while sdma2/3 use
1:1.

Signed-off-by: Robin Gong <yibin.gong@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index cad2dd7..6038f66 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -702,7 +702,7 @@
 				reg = <0x30bd0000 0x10000>;
 				interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clk IMX8MP_CLK_SDMA1_ROOT>,
-					 <&clk IMX8MP_CLK_SDMA1_ROOT>;
+					 <&clk IMX8MP_CLK_AHB>;
 				clock-names = "ipg", "ahb";
 				#dma-cells = <3>;
 				fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin";
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH v1] ARM64: dts: imx8mp: correct sdma1 clk setting
@ 2020-08-31 17:36 ` Robin Gong
  0 siblings, 0 replies; 6+ messages in thread
From: Robin Gong @ 2020-08-31 17:36 UTC (permalink / raw)
  To: robh+dt, shawnguo, s.hauer, festevam, Anson.Huang
  Cc: linux-arm-kernel, devicetree, linux-imx, kernel, linux-kernel

Correct sdma1 ahb clk, otherwise wrong 1:1 clk ratio will be chosed so
that sdma1 function broken. sdma1 should use 1:2 clk, while sdma2/3 use
1:1.

Signed-off-by: Robin Gong <yibin.gong@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index cad2dd7..6038f66 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -702,7 +702,7 @@
 				reg = <0x30bd0000 0x10000>;
 				interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clk IMX8MP_CLK_SDMA1_ROOT>,
-					 <&clk IMX8MP_CLK_SDMA1_ROOT>;
+					 <&clk IMX8MP_CLK_AHB>;
 				clock-names = "ipg", "ahb";
 				#dma-cells = <3>;
 				fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin";
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* RE: [PATCH v1] ARM64: dts: imx8mp: correct sdma1 clk setting
  2020-08-31 11:11   ` Fabio Estevam
@ 2020-09-01  2:09     ` Robin Gong
  -1 siblings, 0 replies; 6+ messages in thread
From: Robin Gong @ 2020-09-01  2:09 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: Rob Herring, Shawn Guo, Sascha Hauer, Anson Huang, Sascha Hauer,
	dl-linux-imx,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	linux-kernel

On 2020/08/31 19:12 Fabio Estevam <festevam@gmail.com> wrote: 
> Hi Robin,
> 
> On Mon, Aug 31, 2020 at 6:22 AM Robin Gong <yibin.gong@nxp.com> wrote:
> >
> > Correct sdma1 ahb clk, otherwise wrong 1:1 clk ratio will be chosed so
> > that sdma1 function broken. sdma1 should use 1:2 clk, while sdma2/3
> > use 1:1.
> >
> > Signed-off-by: Robin Gong <yibin.gong@nxp.com>
> 
> Please add a Fixes tag.
Resent with tags, thanks.


^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [PATCH v1] ARM64: dts: imx8mp: correct sdma1 clk setting
@ 2020-09-01  2:09     ` Robin Gong
  0 siblings, 0 replies; 6+ messages in thread
From: Robin Gong @ 2020-09-01  2:09 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Anson Huang, Sascha Hauer, linux-kernel, Rob Herring,
	dl-linux-imx, Sascha Hauer, Shawn Guo,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

On 2020/08/31 19:12 Fabio Estevam <festevam@gmail.com> wrote: 
> Hi Robin,
> 
> On Mon, Aug 31, 2020 at 6:22 AM Robin Gong <yibin.gong@nxp.com> wrote:
> >
> > Correct sdma1 ahb clk, otherwise wrong 1:1 clk ratio will be chosed so
> > that sdma1 function broken. sdma1 should use 1:2 clk, while sdma2/3
> > use 1:1.
> >
> > Signed-off-by: Robin Gong <yibin.gong@nxp.com>
> 
> Please add a Fixes tag.
Resent with tags, thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-01  2:10 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-31 17:36 [PATCH v1] ARM64: dts: imx8mp: correct sdma1 clk setting Robin Gong
2020-08-31 17:36 ` Robin Gong
2020-08-31 11:11 ` Fabio Estevam
2020-08-31 11:11   ` Fabio Estevam
2020-09-01  2:09   ` Robin Gong
2020-09-01  2:09     ` Robin Gong

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.