* Re: [Intel-gfx] [PATCH] drm/i915/gvt: Fix NULL pointer dereference in intel_vgpu_reg_rw_edid()
@ 2020-09-08 15:47 ` Markus Elfring
0 siblings, 0 replies; 14+ messages in thread
From: Markus Elfring @ 2020-09-08 15:47 UTC (permalink / raw)
To: Alejandro W. Sior, dri-devel, intel-gfx, intel-gvt-dev
Cc: David Airlie, kernel-janitors, linux-kernel, Rodrigo Vivi, Zhi Wang
> In the function intel_vgpu_reg_rw_edid of gvt/kvmgt.c, pos can get equal to NULL for GPUs that do not
> properly support EDID. …
* I propose to reconsider the previous patch subject once more.
* Did the script “checkpatch.pl” point any adjustment possibilities out
for the change description?
> This patch solves this problem by …
Would an imperative wording be preferred for the commit message?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n151
> … to a nagative value, …
Please avoid a typo here.
I suggest to add the tag “Fixes” to the commit message.
Regards,
Markus
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gvt: Fix NULL pointer dereference in intel_vgpu_reg_rw_edid()
@ 2020-09-08 15:47 ` Markus Elfring
0 siblings, 0 replies; 14+ messages in thread
From: Markus Elfring @ 2020-09-08 15:47 UTC (permalink / raw)
To: Alejandro W. Sior, dri-devel, intel-gfx, intel-gvt-dev
Cc: David Airlie, kernel-janitors, linux-kernel
> In the function intel_vgpu_reg_rw_edid of gvt/kvmgt.c, pos can get equal to NULL for GPUs that do not
> properly support EDID. …
* I propose to reconsider the previous patch subject once more.
* Did the script “checkpatch.pl” point any adjustment possibilities out
for the change description?
> This patch solves this problem by …
Would an imperative wording be preferred for the commit message?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n151
> … to a nagative value, …
Please avoid a typo here.
I suggest to add the tag “Fixes” to the commit message.
Regards,
Markus
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx][PATCH v2] drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid()
2020-09-08 15:47 ` Markus Elfring
(?)
@ 2020-09-08 18:11 ` Alejandro Sior
-1 siblings, 0 replies; 14+ messages in thread
From: Alejandro Sior @ 2020-09-08 18:11 UTC (permalink / raw)
Cc: Alejandro Sior, Zhenyu Wang, Zhi Wang, Jani Nikula,
Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter,
intel-gvt-dev, intel-gfx, dri-devel, linux-kernel
In the function intel_vgpu_reg_rw_edid of kvmgt.c, pos can be equal
to NULL for GPUs that do not properly support EDID. In those cases, when
pos gets passed to the handle_edid functions, it gets added a short offset
then it's dereferenced in memcpy's, leading to NULL pointer
dereference kernel oops.
More concretely, that kernel oops renders some Broadwell GPUs users
unable to set up virtual machines with virtual GPU passthrough (virtual
machines hang indefinitely when trying to make use of the virtual GPU),
and make them unable to remove the virtual GPUs once the kernel oops has
happened (it hangs indefinitely, and notably too when the kernel tries to
shutdown). The issues that this causes and steps to reproduce are
discussed in more details in this github issue post:
https://github.com/intel/gvt-linux/issues/170#issuecomment-685806160
Check if pos is equal to NULL, and if it is, set ret to a negative
value, making the module simply indicate that the access to EDID region
has failed, without any fatal repercussion.
Signed-off-by: Alejandro Sior <aho@sior.be>
---
Changes in v2:
- removed middle name of author to comply with git name
- rephrased the patch description with imperative phrasing
- removed useless paragraph
- made a paragraph more concise
- fixed typos
- made individual lines shorter than 75 chars
drivers/gpu/drm/i915/gvt/kvmgt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
index ad8a9df49f29..49163363ba4a 100644
--- a/drivers/gpu/drm/i915/gvt/kvmgt.c
+++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
@@ -557,7 +557,9 @@ static size_t intel_vgpu_reg_rw_edid(struct intel_vgpu *vgpu, char *buf,
(struct vfio_edid_region *)kvmgt_vdev(vgpu)->region[i].data;
loff_t pos = *ppos & VFIO_PCI_OFFSET_MASK;
- if (pos < region->vfio_edid_regs.edid_offset) {
+ if (pos == NULL) {
+ ret = -EINVAL;
+ } else if (pos < region->vfio_edid_regs.edid_offset) {
ret = handle_edid_regs(vgpu, region, buf, count, pos, iswrite);
} else {
pos -= EDID_BLOB_OFFSET;
--
2.28.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx][PATCH v2] drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid()
@ 2020-09-08 18:11 ` Alejandro Sior
0 siblings, 0 replies; 14+ messages in thread
From: Alejandro Sior @ 2020-09-08 18:11 UTC (permalink / raw)
Cc: dri-devel, David Airlie, intel-gfx, linux-kernel, Alejandro Sior,
Rodrigo Vivi, intel-gvt-dev, Zhi Wang
In the function intel_vgpu_reg_rw_edid of kvmgt.c, pos can be equal
to NULL for GPUs that do not properly support EDID. In those cases, when
pos gets passed to the handle_edid functions, it gets added a short offset
then it's dereferenced in memcpy's, leading to NULL pointer
dereference kernel oops.
More concretely, that kernel oops renders some Broadwell GPUs users
unable to set up virtual machines with virtual GPU passthrough (virtual
machines hang indefinitely when trying to make use of the virtual GPU),
and make them unable to remove the virtual GPUs once the kernel oops has
happened (it hangs indefinitely, and notably too when the kernel tries to
shutdown). The issues that this causes and steps to reproduce are
discussed in more details in this github issue post:
https://github.com/intel/gvt-linux/issues/170#issuecomment-685806160
Check if pos is equal to NULL, and if it is, set ret to a negative
value, making the module simply indicate that the access to EDID region
has failed, without any fatal repercussion.
Signed-off-by: Alejandro Sior <aho@sior.be>
---
Changes in v2:
- removed middle name of author to comply with git name
- rephrased the patch description with imperative phrasing
- removed useless paragraph
- made a paragraph more concise
- fixed typos
- made individual lines shorter than 75 chars
drivers/gpu/drm/i915/gvt/kvmgt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
index ad8a9df49f29..49163363ba4a 100644
--- a/drivers/gpu/drm/i915/gvt/kvmgt.c
+++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
@@ -557,7 +557,9 @@ static size_t intel_vgpu_reg_rw_edid(struct intel_vgpu *vgpu, char *buf,
(struct vfio_edid_region *)kvmgt_vdev(vgpu)->region[i].data;
loff_t pos = *ppos & VFIO_PCI_OFFSET_MASK;
- if (pos < region->vfio_edid_regs.edid_offset) {
+ if (pos == NULL) {
+ ret = -EINVAL;
+ } else if (pos < region->vfio_edid_regs.edid_offset) {
ret = handle_edid_regs(vgpu, region, buf, count, pos, iswrite);
} else {
pos -= EDID_BLOB_OFFSET;
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH v2] drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid()
@ 2020-09-08 18:11 ` Alejandro Sior
0 siblings, 0 replies; 14+ messages in thread
From: Alejandro Sior @ 2020-09-08 18:11 UTC (permalink / raw)
Cc: dri-devel, David Airlie, intel-gfx, linux-kernel, intel-gvt-dev
In the function intel_vgpu_reg_rw_edid of kvmgt.c, pos can be equal
to NULL for GPUs that do not properly support EDID. In those cases, when
pos gets passed to the handle_edid functions, it gets added a short offset
then it's dereferenced in memcpy's, leading to NULL pointer
dereference kernel oops.
More concretely, that kernel oops renders some Broadwell GPUs users
unable to set up virtual machines with virtual GPU passthrough (virtual
machines hang indefinitely when trying to make use of the virtual GPU),
and make them unable to remove the virtual GPUs once the kernel oops has
happened (it hangs indefinitely, and notably too when the kernel tries to
shutdown). The issues that this causes and steps to reproduce are
discussed in more details in this github issue post:
https://github.com/intel/gvt-linux/issues/170#issuecomment-685806160
Check if pos is equal to NULL, and if it is, set ret to a negative
value, making the module simply indicate that the access to EDID region
has failed, without any fatal repercussion.
Signed-off-by: Alejandro Sior <aho@sior.be>
---
Changes in v2:
- removed middle name of author to comply with git name
- rephrased the patch description with imperative phrasing
- removed useless paragraph
- made a paragraph more concise
- fixed typos
- made individual lines shorter than 75 chars
drivers/gpu/drm/i915/gvt/kvmgt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
index ad8a9df49f29..49163363ba4a 100644
--- a/drivers/gpu/drm/i915/gvt/kvmgt.c
+++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
@@ -557,7 +557,9 @@ static size_t intel_vgpu_reg_rw_edid(struct intel_vgpu *vgpu, char *buf,
(struct vfio_edid_region *)kvmgt_vdev(vgpu)->region[i].data;
loff_t pos = *ppos & VFIO_PCI_OFFSET_MASK;
- if (pos < region->vfio_edid_regs.edid_offset) {
+ if (pos == NULL) {
+ ret = -EINVAL;
+ } else if (pos < region->vfio_edid_regs.edid_offset) {
ret = handle_edid_regs(vgpu, region, buf, count, pos, iswrite);
} else {
pos -= EDID_BLOB_OFFSET;
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid()
2020-09-08 15:47 ` Markus Elfring
(?)
(?)
@ 2020-09-08 18:25 ` Patchwork
-1 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2020-09-08 18:25 UTC (permalink / raw)
To: Alejandro Sior; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid()
URL : https://patchwork.freedesktop.org/series/81470/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
cc442c9d2d41 drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid()
-:37: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!pos"
#37: FILE: drivers/gpu/drm/i915/gvt/kvmgt.c:560:
+ if (pos == NULL) {
total: 0 errors, 0 warnings, 1 checks, 10 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid()
2020-09-08 15:47 ` Markus Elfring
` (2 preceding siblings ...)
(?)
@ 2020-09-08 18:42 ` Patchwork
-1 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2020-09-08 18:42 UTC (permalink / raw)
To: Alejandro Sior; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 12835 bytes --]
== Series Details ==
Series: drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid()
URL : https://patchwork.freedesktop.org/series/81470/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8982 -> Patchwork_18455
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/index.html
Known issues
------------
Here are the changes found in Patchwork_18455 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_gttfill@basic:
- fi-kbl-7500u: [PASS][1] -> [INCOMPLETE][2] ([i915#2439])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-kbl-7500u/igt@gem_exec_gttfill@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-kbl-7500u/igt@gem_exec_gttfill@basic.html
* igt@i915_selftest@live@gem_execbuf:
- fi-bsw-nick: [PASS][3] -> [INCOMPLETE][4] ([i915#2439])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-bsw-nick/igt@i915_selftest@live@gem_execbuf.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-bsw-nick/igt@i915_selftest@live@gem_execbuf.html
#### Possible fixes ####
* igt@gem_exec_gttfill@basic:
- fi-cfl-8109u: [INCOMPLETE][5] ([i915#2439]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-cfl-8109u/igt@gem_exec_gttfill@basic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-cfl-8109u/igt@gem_exec_gttfill@basic.html
- fi-bdw-5557u: [INCOMPLETE][7] ([i915#2439]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-bdw-5557u/igt@gem_exec_gttfill@basic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-bdw-5557u/igt@gem_exec_gttfill@basic.html
- fi-skl-6600u: [INCOMPLETE][9] ([i915#2439]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-skl-6600u/igt@gem_exec_gttfill@basic.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-skl-6600u/igt@gem_exec_gttfill@basic.html
- fi-elk-e7500: [INCOMPLETE][11] ([i915#66]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-elk-e7500/igt@gem_exec_gttfill@basic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-elk-e7500/igt@gem_exec_gttfill@basic.html
- fi-skl-lmem: [INCOMPLETE][13] ([i915#2439]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-skl-lmem/igt@gem_exec_gttfill@basic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-skl-lmem/igt@gem_exec_gttfill@basic.html
- fi-ilk-650: [INCOMPLETE][15] ([i915#2439]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-ilk-650/igt@gem_exec_gttfill@basic.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-ilk-650/igt@gem_exec_gttfill@basic.html
* igt@gem_exec_parallel@engines@basic:
- fi-bsw-kefka: [INCOMPLETE][17] ([i915#2439]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-bsw-kefka/igt@gem_exec_parallel@engines@basic.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-bsw-kefka/igt@gem_exec_parallel@engines@basic.html
- {fi-ehl-1}: [INCOMPLETE][19] ([i915#2439]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-ehl-1/igt@gem_exec_parallel@engines@basic.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-ehl-1/igt@gem_exec_parallel@engines@basic.html
* igt@i915_selftest@live@gem_execbuf:
- fi-gdg-551: [INCOMPLETE][21] ([i915#172]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-gdg-551/igt@i915_selftest@live@gem_execbuf.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-gdg-551/igt@i915_selftest@live@gem_execbuf.html
- fi-snb-2520m: [INCOMPLETE][23] ([i915#2439]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-snb-2520m/igt@i915_selftest@live@gem_execbuf.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-snb-2520m/igt@i915_selftest@live@gem_execbuf.html
#### Warnings ####
* igt@gem_exec_parallel@engines@basic:
- fi-bxt-dsi: [INCOMPLETE][25] ([i915#1635]) -> [INCOMPLETE][26] ([i915#1635] / [i915#2439])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-bxt-dsi/igt@gem_exec_parallel@engines@basic.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-bxt-dsi/igt@gem_exec_parallel@engines@basic.html
- fi-apl-guc: [INCOMPLETE][27] ([i915#1635]) -> [INCOMPLETE][28] ([i915#1635] / [i915#2439])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-apl-guc/igt@gem_exec_parallel@engines@basic.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-apl-guc/igt@gem_exec_parallel@engines@basic.html
* igt@runner@aborted:
- fi-kbl-x1275: [FAIL][29] ([i915#1186] / [i915#1784]) -> [FAIL][30] ([i915#1186] / [i915#1784] / [i915#2439])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-kbl-x1275/igt@runner@aborted.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-kbl-x1275/igt@runner@aborted.html
- fi-bsw-kefka: [FAIL][31] ([i915#2439]) -> [FAIL][32] ([i915#1436] / [i915#2109] / [i915#2439])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-bsw-kefka/igt@runner@aborted.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-bsw-kefka/igt@runner@aborted.html
- fi-bdw-gvtdvm: [FAIL][33] ([i915#483]) -> [FAIL][34] ([i915#2439] / [i915#483])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-bdw-gvtdvm/igt@runner@aborted.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-bdw-gvtdvm/igt@runner@aborted.html
- fi-cfl-8700k: [FAIL][35] ([i915#1186]) -> [FAIL][36] ([i915#1186] / [i915#2439])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-cfl-8700k/igt@runner@aborted.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-cfl-8700k/igt@runner@aborted.html
- fi-skl-6600u: [FAIL][37] ([i915#1186]) -> [FAIL][38] ([i915#2398] / [i915#2439])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-skl-6600u/igt@runner@aborted.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-skl-6600u/igt@runner@aborted.html
- fi-cfl-8109u: [FAIL][39] ([i915#1186]) -> [FAIL][40] ([i915#2398] / [i915#2439])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-cfl-8109u/igt@runner@aborted.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-cfl-8109u/igt@runner@aborted.html
- fi-icl-u2: [FAIL][41] ([i915#1186]) -> [FAIL][42] ([i915#1186] / [i915#2439])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-icl-u2/igt@runner@aborted.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-icl-u2/igt@runner@aborted.html
- fi-glk-dsi: [FAIL][43] ([i915#2398] / [k.org#202321]) -> [FAIL][44] ([i915#2398] / [i915#2439] / [k.org#202321])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-glk-dsi/igt@runner@aborted.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-glk-dsi/igt@runner@aborted.html
- fi-skl-lmem: [FAIL][45] ([i915#1186]) -> [FAIL][46] ([i915#2398] / [i915#2439])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-skl-lmem/igt@runner@aborted.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-skl-lmem/igt@runner@aborted.html
- fi-apl-guc: [FAIL][47] ([i915#1635] / [i915#2398] / [i915#337]) -> [FAIL][48] ([i915#1635] / [i915#2398] / [i915#2439] / [i915#337])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-apl-guc/igt@runner@aborted.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-apl-guc/igt@runner@aborted.html
- fi-kbl-r: [FAIL][49] ([i915#1186] / [i915#1784]) -> [FAIL][50] ([i915#1186] / [i915#2439])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-kbl-r/igt@runner@aborted.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-kbl-r/igt@runner@aborted.html
- fi-bdw-5557u: [FAIL][51] ([i915#483]) -> [FAIL][52] ([i915#2439] / [i915#483])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-bdw-5557u/igt@runner@aborted.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-bdw-5557u/igt@runner@aborted.html
- fi-kbl-7500u: [FAIL][53] ([i915#2398]) -> [FAIL][54] ([i915#1186] / [i915#1784] / [i915#2439])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-kbl-7500u/igt@runner@aborted.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-kbl-7500u/igt@runner@aborted.html
- fi-kbl-guc: [FAIL][55] ([i915#1186]) -> [FAIL][56] ([i915#1186] / [i915#1784] / [i915#2439])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-kbl-guc/igt@runner@aborted.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-kbl-guc/igt@runner@aborted.html
- fi-cml-u2: [FAIL][57] ([i915#1186]) -> [FAIL][58] ([i915#1186] / [i915#2082] / [i915#2439])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-cml-u2/igt@runner@aborted.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-cml-u2/igt@runner@aborted.html
- fi-bxt-dsi: [FAIL][59] ([i915#1635] / [i915#2398]) -> [FAIL][60] ([i915#1635] / [i915#2398] / [i915#2439])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-bxt-dsi/igt@runner@aborted.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-bxt-dsi/igt@runner@aborted.html
- fi-cml-s: [FAIL][61] ([i915#1186] / [i915#2082]) -> [FAIL][62] ([i915#1186] / [i915#2082] / [i915#2439])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-cml-s/igt@runner@aborted.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-cml-s/igt@runner@aborted.html
- fi-cfl-guc: [FAIL][63] ([i915#1186]) -> [FAIL][64] ([i915#1186] / [i915#2439])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-cfl-guc/igt@runner@aborted.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-cfl-guc/igt@runner@aborted.html
- fi-skl-guc: [FAIL][65] ([i915#1186]) -> [FAIL][66] ([i915#1186] / [i915#2439])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/fi-skl-guc/igt@runner@aborted.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/fi-skl-guc/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1186]: https://gitlab.freedesktop.org/drm/intel/issues/1186
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#172]: https://gitlab.freedesktop.org/drm/intel/issues/172
[i915#1784]: https://gitlab.freedesktop.org/drm/intel/issues/1784
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#2082]: https://gitlab.freedesktop.org/drm/intel/issues/2082
[i915#2109]: https://gitlab.freedesktop.org/drm/intel/issues/2109
[i915#2398]: https://gitlab.freedesktop.org/drm/intel/issues/2398
[i915#2417]: https://gitlab.freedesktop.org/drm/intel/issues/2417
[i915#2439]: https://gitlab.freedesktop.org/drm/intel/issues/2439
[i915#337]: https://gitlab.freedesktop.org/drm/intel/issues/337
[i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
[i915#66]: https://gitlab.freedesktop.org/drm/intel/issues/66
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (42 -> 36)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8982 -> Patchwork_18455
CI-20190529: 20190529
CI_DRM_8982: 666ff2a4ca80b0715a8709ef5462d16b8c92d8ef @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5779: f52bf19b5f02d52fc3e201c6467ec3f511227fba @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18455: cc442c9d2d41b46f6f59d8378d3013a12f5ca91e @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
cc442c9d2d41 drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/index.html
[-- Attachment #1.2: Type: text/html, Size: 18982 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid()
2020-09-08 15:47 ` Markus Elfring
` (3 preceding siblings ...)
(?)
@ 2020-09-08 19:41 ` Patchwork
-1 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2020-09-08 19:41 UTC (permalink / raw)
To: Alejandro Sior; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 28866 bytes --]
== Series Details ==
Series: drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid()
URL : https://patchwork.freedesktop.org/series/81470/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8982_full -> Patchwork_18455_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18455_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18455_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18455_full:
### IGT changes ###
#### Possible regressions ####
* igt@perf@enable-disable:
- shard-skl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl8/igt@perf@enable-disable.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl10/igt@perf@enable-disable.html
Known issues
------------
Here are the changes found in Patchwork_18455_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_reloc@basic-cpu-active:
- shard-skl: [PASS][3] -> [INCOMPLETE][4] ([i915#198] / [i915#2439])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl5/igt@gem_exec_reloc@basic-cpu-active.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl3/igt@gem_exec_reloc@basic-cpu-active.html
* igt@gem_exec_reloc@basic-cpu-gtt-active:
- shard-tglb: [PASS][5] -> [INCOMPLETE][6] ([i915#2439]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb7/igt@gem_exec_reloc@basic-cpu-gtt-active.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb7/igt@gem_exec_reloc@basic-cpu-gtt-active.html
- shard-snb: [PASS][7] -> [INCOMPLETE][8] ([i915#2439] / [i915#82]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-snb2/igt@gem_exec_reloc@basic-cpu-gtt-active.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-snb1/igt@gem_exec_reloc@basic-cpu-gtt-active.html
* igt@gem_exec_reloc@basic-wc-active:
- shard-iclb: [PASS][9] -> [INCOMPLETE][10] ([i915#2439]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-iclb5/igt@gem_exec_reloc@basic-wc-active.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-iclb8/igt@gem_exec_reloc@basic-wc-active.html
* igt@gem_exec_reloc@basic-wc-cpu-active:
- shard-apl: [PASS][11] -> [INCOMPLETE][12] ([i915#1635] / [i915#2439]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-apl7/igt@gem_exec_reloc@basic-wc-cpu-active.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-apl3/igt@gem_exec_reloc@basic-wc-cpu-active.html
* igt@gem_exec_reloc@basic-write-read-active:
- shard-glk: [PASS][13] -> [INCOMPLETE][14] ([i915#2439]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-glk7/igt@gem_exec_reloc@basic-write-read-active.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-glk1/igt@gem_exec_reloc@basic-write-read-active.html
* igt@gem_exec_schedule@deep@rcs0:
- shard-skl: [PASS][15] -> [INCOMPLETE][16] ([i915#2439]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl10/igt@gem_exec_schedule@deep@rcs0.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl5/igt@gem_exec_schedule@deep@rcs0.html
* igt@gem_exec_whisper@basic-contexts-all:
- shard-hsw: [PASS][17] -> [INCOMPLETE][18] ([i915#2439])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-hsw8/igt@gem_exec_whisper@basic-contexts-all.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-hsw1/igt@gem_exec_whisper@basic-contexts-all.html
* igt@gem_exec_whisper@basic-forked:
- shard-kbl: [PASS][19] -> [INCOMPLETE][20] ([i915#2439]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-kbl2/igt@gem_exec_whisper@basic-forked.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-kbl1/igt@gem_exec_whisper@basic-forked.html
* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-skl: [PASS][21] -> [TIMEOUT][22] ([i915#1958])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl3/igt@gem_userptr_blits@unsync-unmap-cycles.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl3/igt@gem_userptr_blits@unsync-unmap-cycles.html
* igt@i915_suspend@forcewake:
- shard-skl: [PASS][23] -> [INCOMPLETE][24] ([i915#636])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl1/igt@i915_suspend@forcewake.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl1/igt@i915_suspend@forcewake.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-0:
- shard-skl: [PASS][25] -> [DMESG-WARN][26] ([i915#1982]) +5 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl7/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl4/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-0:
- shard-apl: [PASS][27] -> [DMESG-WARN][28] ([i915#1635] / [i915#1982])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-apl7/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-apl2/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [PASS][29] -> [FAIL][30] ([i915#96])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-vga1:
- shard-hsw: [PASS][31] -> [INCOMPLETE][32] ([i915#2055])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-hsw1/igt@kms_flip@flip-vs-suspend-interruptible@b-vga1.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-hsw4/igt@kms_flip@flip-vs-suspend-interruptible@b-vga1.html
* igt@kms_flip@plain-flip-ts-check@c-dp1:
- shard-kbl: [PASS][33] -> [FAIL][34] ([i915#2122])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-kbl3/igt@kms_flip@plain-flip-ts-check@c-dp1.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-kbl6/igt@kms_flip@plain-flip-ts-check@c-dp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack:
- shard-iclb: [PASS][35] -> [DMESG-WARN][36] ([i915#1982])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack.html
* igt@kms_frontbuffer_tracking@fbc-farfromfence:
- shard-kbl: [PASS][37] -> [DMESG-WARN][38] ([i915#1982]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-farfromfence.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-farfromfence.html
- shard-tglb: [PASS][39] -> [DMESG-WARN][40] ([i915#1982])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-farfromfence.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-farfromfence.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][41] -> [FAIL][42] ([i915#1188])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl5/igt@kms_hdr@bpc-switch-dpms.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl3/igt@kms_hdr@bpc-switch-dpms.html
* igt@perf@polling-parameterized:
- shard-glk: [PASS][43] -> [FAIL][44] ([i915#1542])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-glk4/igt@perf@polling-parameterized.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-glk4/igt@perf@polling-parameterized.html
#### Possible fixes ####
* igt@gem_exec_reloc@basic-cpu-wc-active:
- shard-tglb: [INCOMPLETE][45] ([i915#2439]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb5/igt@gem_exec_reloc@basic-cpu-wc-active.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb1/igt@gem_exec_reloc@basic-cpu-wc-active.html
* igt@gem_exec_reloc@basic-gtt-read-active:
- shard-skl: [DMESG-FAIL][47] ([i915#2439]) -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl6/igt@gem_exec_reloc@basic-gtt-read-active.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl2/igt@gem_exec_reloc@basic-gtt-read-active.html
* igt@gem_exec_reloc@basic-gtt-wc-active:
- shard-apl: [INCOMPLETE][49] ([i915#1635] / [i915#2439]) -> [PASS][50] +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-apl2/igt@gem_exec_reloc@basic-gtt-wc-active.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-apl6/igt@gem_exec_reloc@basic-gtt-wc-active.html
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-skl: [INCOMPLETE][51] ([i915#2439]) -> [PASS][52] +3 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl5/igt@gem_exec_reloc@basic-many-active@rcs0.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl3/igt@gem_exec_reloc@basic-many-active@rcs0.html
* igt@gem_exec_reloc@basic-spin@vecs0:
- shard-glk: [INCOMPLETE][53] ([i915#2439]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-glk5/igt@gem_exec_reloc@basic-spin@vecs0.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-glk9/igt@gem_exec_reloc@basic-spin@vecs0.html
* igt@gem_exec_reloc@basic-wc-cpu-active:
- shard-hsw: [INCOMPLETE][55] ([i915#2439]) -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-hsw4/igt@gem_exec_reloc@basic-wc-cpu-active.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-hsw2/igt@gem_exec_reloc@basic-wc-cpu-active.html
* igt@gem_exec_reloc@basic-wc-gtt-active:
- shard-iclb: [INCOMPLETE][57] ([i915#2439]) -> [PASS][58] +4 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-iclb7/igt@gem_exec_reloc@basic-wc-gtt-active.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-iclb5/igt@gem_exec_reloc@basic-wc-gtt-active.html
* igt@gem_exec_reloc@basic-write-gtt-active:
- shard-snb: [INCOMPLETE][59] ([i915#2439] / [i915#82]) -> [PASS][60] +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-snb7/igt@gem_exec_reloc@basic-write-gtt-active.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-snb2/igt@gem_exec_reloc@basic-write-gtt-active.html
* igt@gem_exec_whisper@basic-queues-all:
- shard-kbl: [INCOMPLETE][61] ([i915#2439]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-kbl7/igt@gem_exec_whisper@basic-queues-all.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-kbl2/igt@gem_exec_whisper@basic-queues-all.html
* igt@i915_selftest@live@gem_execbuf:
- shard-skl: [INCOMPLETE][63] ([i915#2440]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl4/igt@i915_selftest@live@gem_execbuf.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl4/igt@i915_selftest@live@gem_execbuf.html
* igt@kms_big_fb@y-tiled-8bpp-rotate-0:
- shard-kbl: [DMESG-WARN][65] ([i915#1982]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-kbl4/igt@kms_big_fb@y-tiled-8bpp-rotate-0.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-kbl7/igt@kms_big_fb@y-tiled-8bpp-rotate-0.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
- shard-apl: [DMESG-WARN][67] ([i915#1635] / [i915#1982]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-apl4/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-apl4/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][69] ([i915#2122]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-glk3/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@bc-hdmi-a1-hdmi-a2.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-glk7/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@bc-hdmi-a1-hdmi-a2.html
* igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-vga1-hdmi-a1:
- shard-hsw: [INCOMPLETE][71] -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-hsw8/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-vga1-hdmi-a1.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-hsw6/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-vga1-hdmi-a1.html
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-kbl: [DMESG-WARN][73] ([i915#180]) -> [PASS][74] +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-kbl7/igt@kms_flip@flip-vs-suspend@a-dp1.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-kbl7/igt@kms_flip@flip-vs-suspend@a-dp1.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- shard-tglb: [DMESG-WARN][75] ([i915#1982]) -> [PASS][76] +2 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu:
- shard-skl: [FAIL][77] ([i915#49]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl9/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl10/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][79] ([fdo#108145] / [i915#265]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-skl: [DMESG-WARN][81] ([i915#1982]) -> [PASS][82] +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl10/igt@kms_plane_lowres@pipe-a-tiling-y.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl9/igt@kms_plane_lowres@pipe-a-tiling-y.html
* igt@sysfs_preempt_timeout@timeout@rcs0:
- shard-skl: [FAIL][83] ([i915#2060]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl7/igt@sysfs_preempt_timeout@timeout@rcs0.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl4/igt@sysfs_preempt_timeout@timeout@rcs0.html
#### Warnings ####
* igt@gem_exec_reloc@basic-wc-active:
- shard-hsw: [INCOMPLETE][85] ([i915#2439]) -> [DMESG-FAIL][86] ([i915#2439])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-hsw4/igt@gem_exec_reloc@basic-wc-active.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-hsw1/igt@gem_exec_reloc@basic-wc-active.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][87] ([i915#658]) -> [SKIP][88] ([i915#588])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-iclb4/igt@i915_pm_dc@dc3co-vpb-simulation.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@runner@aborted:
- shard-tglb: ([FAIL][89], [FAIL][90], [FAIL][91], [FAIL][92], [FAIL][93], [FAIL][94], [FAIL][95], [FAIL][96], [FAIL][97], [FAIL][98], [FAIL][99], [FAIL][100], [FAIL][101], [FAIL][102], [FAIL][103], [FAIL][104], [FAIL][105], [FAIL][106], [FAIL][107], [FAIL][108], [FAIL][109], [FAIL][110], [FAIL][111]) ([i915#1764] / [i915#2263] / [i915#2398] / [i915#2439]) -> ([FAIL][112], [FAIL][113], [FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122], [FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135]) ([i915#2263] / [i915#2398] / [i915#2439])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb3/igt@runner@aborted.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb7/igt@runner@aborted.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb6/igt@runner@aborted.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb2/igt@runner@aborted.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb1/igt@runner@aborted.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb6/igt@runner@aborted.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb5/igt@runner@aborted.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb8/igt@runner@aborted.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb3/igt@runner@aborted.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb6/igt@runner@aborted.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb1/igt@runner@aborted.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb8/igt@runner@aborted.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb2/igt@runner@aborted.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb2/igt@runner@aborted.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb5/igt@runner@aborted.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb3/igt@runner@aborted.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb5/igt@runner@aborted.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb8/igt@runner@aborted.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb5/igt@runner@aborted.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb2/igt@runner@aborted.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb2/igt@runner@aborted.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb6/igt@runner@aborted.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-tglb1/igt@runner@aborted.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb3/igt@runner@aborted.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb5/igt@runner@aborted.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb8/igt@runner@aborted.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb1/igt@runner@aborted.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb8/igt@runner@aborted.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb2/igt@runner@aborted.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb2/igt@runner@aborted.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb1/igt@runner@aborted.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb7/igt@runner@aborted.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb8/igt@runner@aborted.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb5/igt@runner@aborted.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb7/igt@runner@aborted.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb5/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb2/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb7/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb3/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb6/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb1/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb8/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb6/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb2/igt@runner@aborted.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb1/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb6/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-tglb3/igt@runner@aborted.html
- shard-skl: ([FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150], [FAIL][151]) ([i915#1436] / [i915#1611] / [i915#2263] / [i915#2439]) -> ([FAIL][152], [FAIL][153], [FAIL][154], [FAIL][155], [FAIL][156], [FAIL][157], [FAIL][158], [FAIL][159], [FAIL][160], [FAIL][161], [FAIL][162], [FAIL][163], [FAIL][164], [FAIL][165]) ([i915#1611] / [i915#2263] / [i915#2439])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl4/igt@runner@aborted.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl7/igt@runner@aborted.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl10/igt@runner@aborted.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl10/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl1/igt@runner@aborted.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl3/igt@runner@aborted.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl5/igt@runner@aborted.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl7/igt@runner@aborted.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl6/igt@runner@aborted.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl10/igt@runner@aborted.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl3/igt@runner@aborted.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl4/igt@runner@aborted.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl2/igt@runner@aborted.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl6/igt@runner@aborted.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl2/igt@runner@aborted.html
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8982/shard-skl8/igt@runner@aborted.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl8/igt@runner@aborted.html
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl5/igt@runner@aborted.html
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl1/igt@runner@aborted.html
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl3/igt@runner@aborted.html
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl8/igt@runner@aborted.html
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl3/igt@runner@aborted.html
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl9/igt@runner@aborted.html
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl5/igt@runner@aborted.html
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl3/igt@runner@aborted.html
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl7/igt@runner@aborted.html
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl4/igt@runner@aborted.html
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl10/igt@runner@aborted.html
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl6/igt@runner@aborted.html
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/shard-skl9/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1611]: https://gitlab.freedesktop.org/drm/intel/issues/1611
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1764]: https://gitlab.freedesktop.org/drm/intel/issues/1764
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2060]: https://gitlab.freedesktop.org/drm/intel/issues/2060
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2263]: https://gitlab.freedesktop.org/drm/intel/issues/2263
[i915#2398]: https://gitlab.freedesktop.org/drm/intel/issues/2398
[i915#2439]: https://gitlab.freedesktop.org/drm/intel/issues/2439
[i915#2440]: https://gitlab.freedesktop.org/drm/intel/issues/2440
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#636]: https://gitlab.freedesktop.org/drm/intel/issues/636
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8982 -> Patchwork_18455
CI-20190529: 20190529
CI_DRM_8982: 666ff2a4ca80b0715a8709ef5462d16b8c92d8ef @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5779: f52bf19b5f02d52fc3e201c6467ec3f511227fba @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18455: cc442c9d2d41b46f6f59d8378d3013a12f5ca91e @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18455/index.html
[-- Attachment #1.2: Type: text/html, Size: 33475 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx][PATCH v2] drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid()
2020-09-08 18:11 ` [Intel-gfx][PATCH " Alejandro Sior
@ 2020-09-11 5:39 ` Zhenyu Wang
-1 siblings, 0 replies; 14+ messages in thread
From: Zhenyu Wang @ 2020-09-11 5:39 UTC (permalink / raw)
To: Alejandro Sior
Cc: David Airlie, intel-gfx, linux-kernel, dri-devel, Rodrigo Vivi,
intel-gvt-dev, Zhi Wang
[-- Attachment #1.1: Type: text/plain, Size: 4173 bytes --]
On 2020.09.08 20:11:21 +0200, Alejandro Sior wrote:
> In the function intel_vgpu_reg_rw_edid of kvmgt.c, pos can be equal
> to NULL for GPUs that do not properly support EDID. In those cases, when
> pos gets passed to the handle_edid functions, it gets added a short offset
> then it's dereferenced in memcpy's, leading to NULL pointer
> dereference kernel oops.
>
> More concretely, that kernel oops renders some Broadwell GPUs users
> unable to set up virtual machines with virtual GPU passthrough (virtual
> machines hang indefinitely when trying to make use of the virtual GPU),
> and make them unable to remove the virtual GPUs once the kernel oops has
> happened (it hangs indefinitely, and notably too when the kernel tries to
> shutdown). The issues that this causes and steps to reproduce are
> discussed in more details in this github issue post:
> https://github.com/intel/gvt-linux/issues/170#issuecomment-685806160
>
> Check if pos is equal to NULL, and if it is, set ret to a negative
> value, making the module simply indicate that the access to EDID region
> has failed, without any fatal repercussion.
>
> Signed-off-by: Alejandro Sior <aho@sior.be>
>
> ---
> Changes in v2:
> - removed middle name of author to comply with git name
> - rephrased the patch description with imperative phrasing
> - removed useless paragraph
> - made a paragraph more concise
> - fixed typos
> - made individual lines shorter than 75 chars
>
> drivers/gpu/drm/i915/gvt/kvmgt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index ad8a9df49f29..49163363ba4a 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -557,7 +557,9 @@ static size_t intel_vgpu_reg_rw_edid(struct intel_vgpu *vgpu, char *buf,
> (struct vfio_edid_region *)kvmgt_vdev(vgpu)->region[i].data;
> loff_t pos = *ppos & VFIO_PCI_OFFSET_MASK;
>
> - if (pos < region->vfio_edid_regs.edid_offset) {
> + if (pos == NULL) {
> + ret = -EINVAL;
> + } else if (pos < region->vfio_edid_regs.edid_offset) {
> ret = handle_edid_regs(vgpu, region, buf, count, pos, iswrite);
> } else {
> pos -= EDID_BLOB_OFFSET;
Thanks for reporting this! Sorry that we failed to do sanity validation on older
platform when enabling vfio edid function for all platform.
Could you try below one to see if it fixes your problem? Instead of refusing
possible read of edid, this fixes port number for BDW.
From d5d9304b6bfdc31356fd2feb1ddbbf28073fe3d4 Mon Sep 17 00:00:00 2001
From: Zhenyu Wang <zhenyuw@linux.intel.com>
Date: Fri, 11 Sep 2020 13:50:20 +0800
Subject: [PATCH] drm/i915/gvt: Fix port number for BDW on EDID region setup
Current BDW virtual display port is initialized as PORT_B, so need
to use same port for VFIO EDID region, otherwise invalid EDID blob
pointer is assigned.
Fixes: 0178f4ce3c3b ("drm/i915/gvt: Enable vfio edid for all GVT supported platform")
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
---
drivers/gpu/drm/i915/gvt/vgpu.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt/vgpu.c
index 8fa9b31a2484..f6d7e33c7099 100644
--- a/drivers/gpu/drm/i915/gvt/vgpu.c
+++ b/drivers/gpu/drm/i915/gvt/vgpu.c
@@ -368,6 +368,7 @@ void intel_gvt_destroy_idle_vgpu(struct intel_vgpu *vgpu)
static struct intel_vgpu *__intel_gvt_create_vgpu(struct intel_gvt *gvt,
struct intel_vgpu_creation_params *param)
{
+ struct drm_i915_private *dev_priv = gvt->gt->i915;
struct intel_vgpu *vgpu;
int ret;
@@ -436,7 +437,10 @@ static struct intel_vgpu *__intel_gvt_create_vgpu(struct intel_gvt *gvt,
if (ret)
goto out_clean_sched_policy;
- ret = intel_gvt_hypervisor_set_edid(vgpu, PORT_D);
+ if (IS_BROADWELL(dev_priv))
+ ret = intel_gvt_hypervisor_set_edid(vgpu, PORT_B);
+ else
+ ret = intel_gvt_hypervisor_set_edid(vgpu, PORT_D);
if (ret)
goto out_clean_sched_policy;
--
2.28.0
--
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid()
@ 2020-09-11 5:39 ` Zhenyu Wang
0 siblings, 0 replies; 14+ messages in thread
From: Zhenyu Wang @ 2020-09-11 5:39 UTC (permalink / raw)
To: Alejandro Sior
Cc: David Airlie, intel-gfx, linux-kernel, dri-devel, intel-gvt-dev
[-- Attachment #1.1: Type: text/plain, Size: 4173 bytes --]
On 2020.09.08 20:11:21 +0200, Alejandro Sior wrote:
> In the function intel_vgpu_reg_rw_edid of kvmgt.c, pos can be equal
> to NULL for GPUs that do not properly support EDID. In those cases, when
> pos gets passed to the handle_edid functions, it gets added a short offset
> then it's dereferenced in memcpy's, leading to NULL pointer
> dereference kernel oops.
>
> More concretely, that kernel oops renders some Broadwell GPUs users
> unable to set up virtual machines with virtual GPU passthrough (virtual
> machines hang indefinitely when trying to make use of the virtual GPU),
> and make them unable to remove the virtual GPUs once the kernel oops has
> happened (it hangs indefinitely, and notably too when the kernel tries to
> shutdown). The issues that this causes and steps to reproduce are
> discussed in more details in this github issue post:
> https://github.com/intel/gvt-linux/issues/170#issuecomment-685806160
>
> Check if pos is equal to NULL, and if it is, set ret to a negative
> value, making the module simply indicate that the access to EDID region
> has failed, without any fatal repercussion.
>
> Signed-off-by: Alejandro Sior <aho@sior.be>
>
> ---
> Changes in v2:
> - removed middle name of author to comply with git name
> - rephrased the patch description with imperative phrasing
> - removed useless paragraph
> - made a paragraph more concise
> - fixed typos
> - made individual lines shorter than 75 chars
>
> drivers/gpu/drm/i915/gvt/kvmgt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index ad8a9df49f29..49163363ba4a 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -557,7 +557,9 @@ static size_t intel_vgpu_reg_rw_edid(struct intel_vgpu *vgpu, char *buf,
> (struct vfio_edid_region *)kvmgt_vdev(vgpu)->region[i].data;
> loff_t pos = *ppos & VFIO_PCI_OFFSET_MASK;
>
> - if (pos < region->vfio_edid_regs.edid_offset) {
> + if (pos == NULL) {
> + ret = -EINVAL;
> + } else if (pos < region->vfio_edid_regs.edid_offset) {
> ret = handle_edid_regs(vgpu, region, buf, count, pos, iswrite);
> } else {
> pos -= EDID_BLOB_OFFSET;
Thanks for reporting this! Sorry that we failed to do sanity validation on older
platform when enabling vfio edid function for all platform.
Could you try below one to see if it fixes your problem? Instead of refusing
possible read of edid, this fixes port number for BDW.
From d5d9304b6bfdc31356fd2feb1ddbbf28073fe3d4 Mon Sep 17 00:00:00 2001
From: Zhenyu Wang <zhenyuw@linux.intel.com>
Date: Fri, 11 Sep 2020 13:50:20 +0800
Subject: [PATCH] drm/i915/gvt: Fix port number for BDW on EDID region setup
Current BDW virtual display port is initialized as PORT_B, so need
to use same port for VFIO EDID region, otherwise invalid EDID blob
pointer is assigned.
Fixes: 0178f4ce3c3b ("drm/i915/gvt: Enable vfio edid for all GVT supported platform")
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
---
drivers/gpu/drm/i915/gvt/vgpu.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt/vgpu.c
index 8fa9b31a2484..f6d7e33c7099 100644
--- a/drivers/gpu/drm/i915/gvt/vgpu.c
+++ b/drivers/gpu/drm/i915/gvt/vgpu.c
@@ -368,6 +368,7 @@ void intel_gvt_destroy_idle_vgpu(struct intel_vgpu *vgpu)
static struct intel_vgpu *__intel_gvt_create_vgpu(struct intel_gvt *gvt,
struct intel_vgpu_creation_params *param)
{
+ struct drm_i915_private *dev_priv = gvt->gt->i915;
struct intel_vgpu *vgpu;
int ret;
@@ -436,7 +437,10 @@ static struct intel_vgpu *__intel_gvt_create_vgpu(struct intel_gvt *gvt,
if (ret)
goto out_clean_sched_policy;
- ret = intel_gvt_hypervisor_set_edid(vgpu, PORT_D);
+ if (IS_BROADWELL(dev_priv))
+ ret = intel_gvt_hypervisor_set_edid(vgpu, PORT_B);
+ else
+ ret = intel_gvt_hypervisor_set_edid(vgpu, PORT_D);
if (ret)
goto out_clean_sched_policy;
--
2.28.0
--
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid() (rev2)
2020-09-08 15:47 ` Markus Elfring
` (4 preceding siblings ...)
(?)
@ 2020-09-11 6:00 ` Patchwork
-1 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2020-09-11 6:00 UTC (permalink / raw)
To: Zhenyu Wang; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid() (rev2)
URL : https://patchwork.freedesktop.org/series/81470/
State : failure
== Summary ==
Patch is empty.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx][PATCH v2] drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid()
2020-09-11 5:39 ` [Intel-gfx] [PATCH " Zhenyu Wang
(?)
@ 2020-09-12 7:02 ` Aho Sior
-1 siblings, 0 replies; 14+ messages in thread
From: Aho Sior @ 2020-09-12 7:02 UTC (permalink / raw)
To: Zhenyu Wang
Cc: dri-devel, David Airlie, intel-gfx, Joonas Lahtinen,
linux-kernel, Jani Nikula, Daniel Vetter, Rodrigo Vivi,
intel-gvt-dev, Zhi Wang
Perfect!
I can confirm it resolves the issue as well, thank you very much.
Have a great day,
Alejandro Sior.
On Fri, 11 Sep 2020 at 07:58, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
>
> On 2020.09.08 20:11:21 +0200, Alejandro Sior wrote:
> > In the function intel_vgpu_reg_rw_edid of kvmgt.c, pos can be equal
> > to NULL for GPUs that do not properly support EDID. In those cases, when
> > pos gets passed to the handle_edid functions, it gets added a short offset
> > then it's dereferenced in memcpy's, leading to NULL pointer
> > dereference kernel oops.
> >
> > More concretely, that kernel oops renders some Broadwell GPUs users
> > unable to set up virtual machines with virtual GPU passthrough (virtual
> > machines hang indefinitely when trying to make use of the virtual GPU),
> > and make them unable to remove the virtual GPUs once the kernel oops has
> > happened (it hangs indefinitely, and notably too when the kernel tries to
> > shutdown). The issues that this causes and steps to reproduce are
> > discussed in more details in this github issue post:
> > https://github.com/intel/gvt-linux/issues/170#issuecomment-685806160
> >
> > Check if pos is equal to NULL, and if it is, set ret to a negative
> > value, making the module simply indicate that the access to EDID region
> > has failed, without any fatal repercussion.
> >
> > Signed-off-by: Alejandro Sior <aho@sior.be>
> >
> > ---
> > Changes in v2:
> > - removed middle name of author to comply with git name
> > - rephrased the patch description with imperative phrasing
> > - removed useless paragraph
> > - made a paragraph more concise
> > - fixed typos
> > - made individual lines shorter than 75 chars
> >
> > drivers/gpu/drm/i915/gvt/kvmgt.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> > index ad8a9df49f29..49163363ba4a 100644
> > --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> > +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> > @@ -557,7 +557,9 @@ static size_t intel_vgpu_reg_rw_edid(struct intel_vgpu *vgpu, char *buf,
> > (struct vfio_edid_region *)kvmgt_vdev(vgpu)->region[i].data;
> > loff_t pos = *ppos & VFIO_PCI_OFFSET_MASK;
> >
> > - if (pos < region->vfio_edid_regs.edid_offset) {
> > + if (pos == NULL) {
> > + ret = -EINVAL;
> > + } else if (pos < region->vfio_edid_regs.edid_offset) {
> > ret = handle_edid_regs(vgpu, region, buf, count, pos, iswrite);
> > } else {
> > pos -= EDID_BLOB_OFFSET;
>
> Thanks for reporting this! Sorry that we failed to do sanity validation on older
> platform when enabling vfio edid function for all platform.
>
> Could you try below one to see if it fixes your problem? Instead of refusing
> possible read of edid, this fixes port number for BDW.
>
> From d5d9304b6bfdc31356fd2feb1ddbbf28073fe3d4 Mon Sep 17 00:00:00 2001
> From: Zhenyu Wang <zhenyuw@linux.intel.com>
> Date: Fri, 11 Sep 2020 13:50:20 +0800
> Subject: [PATCH] drm/i915/gvt: Fix port number for BDW on EDID region setup
>
> Current BDW virtual display port is initialized as PORT_B, so need
> to use same port for VFIO EDID region, otherwise invalid EDID blob
> pointer is assigned.
>
> Fixes: 0178f4ce3c3b ("drm/i915/gvt: Enable vfio edid for all GVT supported platform")
> Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gvt/vgpu.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt/vgpu.c
> index 8fa9b31a2484..f6d7e33c7099 100644
> --- a/drivers/gpu/drm/i915/gvt/vgpu.c
> +++ b/drivers/gpu/drm/i915/gvt/vgpu.c
> @@ -368,6 +368,7 @@ void intel_gvt_destroy_idle_vgpu(struct intel_vgpu *vgpu)
> static struct intel_vgpu *__intel_gvt_create_vgpu(struct intel_gvt *gvt,
> struct intel_vgpu_creation_params *param)
> {
> + struct drm_i915_private *dev_priv = gvt->gt->i915;
> struct intel_vgpu *vgpu;
> int ret;
>
> @@ -436,7 +437,10 @@ static struct intel_vgpu *__intel_gvt_create_vgpu(struct intel_gvt *gvt,
> if (ret)
> goto out_clean_sched_policy;
>
> - ret = intel_gvt_hypervisor_set_edid(vgpu, PORT_D);
> + if (IS_BROADWELL(dev_priv))
> + ret = intel_gvt_hypervisor_set_edid(vgpu, PORT_B);
> + else
> + ret = intel_gvt_hypervisor_set_edid(vgpu, PORT_D);
> if (ret)
> goto out_clean_sched_policy;
>
> --
> 2.28.0
>
>
>
> --
>
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx][PATCH v2] drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid()
@ 2020-09-12 7:02 ` Aho Sior
0 siblings, 0 replies; 14+ messages in thread
From: Aho Sior @ 2020-09-12 7:02 UTC (permalink / raw)
To: Zhenyu Wang
Cc: David Airlie, intel-gfx, linux-kernel, dri-devel, Rodrigo Vivi,
intel-gvt-dev, Zhi Wang
Perfect!
I can confirm it resolves the issue as well, thank you very much.
Have a great day,
Alejandro Sior.
On Fri, 11 Sep 2020 at 07:58, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
>
> On 2020.09.08 20:11:21 +0200, Alejandro Sior wrote:
> > In the function intel_vgpu_reg_rw_edid of kvmgt.c, pos can be equal
> > to NULL for GPUs that do not properly support EDID. In those cases, when
> > pos gets passed to the handle_edid functions, it gets added a short offset
> > then it's dereferenced in memcpy's, leading to NULL pointer
> > dereference kernel oops.
> >
> > More concretely, that kernel oops renders some Broadwell GPUs users
> > unable to set up virtual machines with virtual GPU passthrough (virtual
> > machines hang indefinitely when trying to make use of the virtual GPU),
> > and make them unable to remove the virtual GPUs once the kernel oops has
> > happened (it hangs indefinitely, and notably too when the kernel tries to
> > shutdown). The issues that this causes and steps to reproduce are
> > discussed in more details in this github issue post:
> > https://github.com/intel/gvt-linux/issues/170#issuecomment-685806160
> >
> > Check if pos is equal to NULL, and if it is, set ret to a negative
> > value, making the module simply indicate that the access to EDID region
> > has failed, without any fatal repercussion.
> >
> > Signed-off-by: Alejandro Sior <aho@sior.be>
> >
> > ---
> > Changes in v2:
> > - removed middle name of author to comply with git name
> > - rephrased the patch description with imperative phrasing
> > - removed useless paragraph
> > - made a paragraph more concise
> > - fixed typos
> > - made individual lines shorter than 75 chars
> >
> > drivers/gpu/drm/i915/gvt/kvmgt.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> > index ad8a9df49f29..49163363ba4a 100644
> > --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> > +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> > @@ -557,7 +557,9 @@ static size_t intel_vgpu_reg_rw_edid(struct intel_vgpu *vgpu, char *buf,
> > (struct vfio_edid_region *)kvmgt_vdev(vgpu)->region[i].data;
> > loff_t pos = *ppos & VFIO_PCI_OFFSET_MASK;
> >
> > - if (pos < region->vfio_edid_regs.edid_offset) {
> > + if (pos == NULL) {
> > + ret = -EINVAL;
> > + } else if (pos < region->vfio_edid_regs.edid_offset) {
> > ret = handle_edid_regs(vgpu, region, buf, count, pos, iswrite);
> > } else {
> > pos -= EDID_BLOB_OFFSET;
>
> Thanks for reporting this! Sorry that we failed to do sanity validation on older
> platform when enabling vfio edid function for all platform.
>
> Could you try below one to see if it fixes your problem? Instead of refusing
> possible read of edid, this fixes port number for BDW.
>
> From d5d9304b6bfdc31356fd2feb1ddbbf28073fe3d4 Mon Sep 17 00:00:00 2001
> From: Zhenyu Wang <zhenyuw@linux.intel.com>
> Date: Fri, 11 Sep 2020 13:50:20 +0800
> Subject: [PATCH] drm/i915/gvt: Fix port number for BDW on EDID region setup
>
> Current BDW virtual display port is initialized as PORT_B, so need
> to use same port for VFIO EDID region, otherwise invalid EDID blob
> pointer is assigned.
>
> Fixes: 0178f4ce3c3b ("drm/i915/gvt: Enable vfio edid for all GVT supported platform")
> Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gvt/vgpu.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt/vgpu.c
> index 8fa9b31a2484..f6d7e33c7099 100644
> --- a/drivers/gpu/drm/i915/gvt/vgpu.c
> +++ b/drivers/gpu/drm/i915/gvt/vgpu.c
> @@ -368,6 +368,7 @@ void intel_gvt_destroy_idle_vgpu(struct intel_vgpu *vgpu)
> static struct intel_vgpu *__intel_gvt_create_vgpu(struct intel_gvt *gvt,
> struct intel_vgpu_creation_params *param)
> {
> + struct drm_i915_private *dev_priv = gvt->gt->i915;
> struct intel_vgpu *vgpu;
> int ret;
>
> @@ -436,7 +437,10 @@ static struct intel_vgpu *__intel_gvt_create_vgpu(struct intel_gvt *gvt,
> if (ret)
> goto out_clean_sched_policy;
>
> - ret = intel_gvt_hypervisor_set_edid(vgpu, PORT_D);
> + if (IS_BROADWELL(dev_priv))
> + ret = intel_gvt_hypervisor_set_edid(vgpu, PORT_B);
> + else
> + ret = intel_gvt_hypervisor_set_edid(vgpu, PORT_D);
> if (ret)
> goto out_clean_sched_policy;
>
> --
> 2.28.0
>
>
>
> --
>
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid()
@ 2020-09-12 7:02 ` Aho Sior
0 siblings, 0 replies; 14+ messages in thread
From: Aho Sior @ 2020-09-12 7:02 UTC (permalink / raw)
To: Zhenyu Wang
Cc: David Airlie, intel-gfx, linux-kernel, dri-devel, intel-gvt-dev
Perfect!
I can confirm it resolves the issue as well, thank you very much.
Have a great day,
Alejandro Sior.
On Fri, 11 Sep 2020 at 07:58, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
>
> On 2020.09.08 20:11:21 +0200, Alejandro Sior wrote:
> > In the function intel_vgpu_reg_rw_edid of kvmgt.c, pos can be equal
> > to NULL for GPUs that do not properly support EDID. In those cases, when
> > pos gets passed to the handle_edid functions, it gets added a short offset
> > then it's dereferenced in memcpy's, leading to NULL pointer
> > dereference kernel oops.
> >
> > More concretely, that kernel oops renders some Broadwell GPUs users
> > unable to set up virtual machines with virtual GPU passthrough (virtual
> > machines hang indefinitely when trying to make use of the virtual GPU),
> > and make them unable to remove the virtual GPUs once the kernel oops has
> > happened (it hangs indefinitely, and notably too when the kernel tries to
> > shutdown). The issues that this causes and steps to reproduce are
> > discussed in more details in this github issue post:
> > https://github.com/intel/gvt-linux/issues/170#issuecomment-685806160
> >
> > Check if pos is equal to NULL, and if it is, set ret to a negative
> > value, making the module simply indicate that the access to EDID region
> > has failed, without any fatal repercussion.
> >
> > Signed-off-by: Alejandro Sior <aho@sior.be>
> >
> > ---
> > Changes in v2:
> > - removed middle name of author to comply with git name
> > - rephrased the patch description with imperative phrasing
> > - removed useless paragraph
> > - made a paragraph more concise
> > - fixed typos
> > - made individual lines shorter than 75 chars
> >
> > drivers/gpu/drm/i915/gvt/kvmgt.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> > index ad8a9df49f29..49163363ba4a 100644
> > --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> > +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> > @@ -557,7 +557,9 @@ static size_t intel_vgpu_reg_rw_edid(struct intel_vgpu *vgpu, char *buf,
> > (struct vfio_edid_region *)kvmgt_vdev(vgpu)->region[i].data;
> > loff_t pos = *ppos & VFIO_PCI_OFFSET_MASK;
> >
> > - if (pos < region->vfio_edid_regs.edid_offset) {
> > + if (pos == NULL) {
> > + ret = -EINVAL;
> > + } else if (pos < region->vfio_edid_regs.edid_offset) {
> > ret = handle_edid_regs(vgpu, region, buf, count, pos, iswrite);
> > } else {
> > pos -= EDID_BLOB_OFFSET;
>
> Thanks for reporting this! Sorry that we failed to do sanity validation on older
> platform when enabling vfio edid function for all platform.
>
> Could you try below one to see if it fixes your problem? Instead of refusing
> possible read of edid, this fixes port number for BDW.
>
> From d5d9304b6bfdc31356fd2feb1ddbbf28073fe3d4 Mon Sep 17 00:00:00 2001
> From: Zhenyu Wang <zhenyuw@linux.intel.com>
> Date: Fri, 11 Sep 2020 13:50:20 +0800
> Subject: [PATCH] drm/i915/gvt: Fix port number for BDW on EDID region setup
>
> Current BDW virtual display port is initialized as PORT_B, so need
> to use same port for VFIO EDID region, otherwise invalid EDID blob
> pointer is assigned.
>
> Fixes: 0178f4ce3c3b ("drm/i915/gvt: Enable vfio edid for all GVT supported platform")
> Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gvt/vgpu.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt/vgpu.c
> index 8fa9b31a2484..f6d7e33c7099 100644
> --- a/drivers/gpu/drm/i915/gvt/vgpu.c
> +++ b/drivers/gpu/drm/i915/gvt/vgpu.c
> @@ -368,6 +368,7 @@ void intel_gvt_destroy_idle_vgpu(struct intel_vgpu *vgpu)
> static struct intel_vgpu *__intel_gvt_create_vgpu(struct intel_gvt *gvt,
> struct intel_vgpu_creation_params *param)
> {
> + struct drm_i915_private *dev_priv = gvt->gt->i915;
> struct intel_vgpu *vgpu;
> int ret;
>
> @@ -436,7 +437,10 @@ static struct intel_vgpu *__intel_gvt_create_vgpu(struct intel_gvt *gvt,
> if (ret)
> goto out_clean_sched_policy;
>
> - ret = intel_gvt_hypervisor_set_edid(vgpu, PORT_D);
> + if (IS_BROADWELL(dev_priv))
> + ret = intel_gvt_hypervisor_set_edid(vgpu, PORT_B);
> + else
> + ret = intel_gvt_hypervisor_set_edid(vgpu, PORT_D);
> if (ret)
> goto out_clean_sched_policy;
>
> --
> 2.28.0
>
>
>
> --
>
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2020-09-12 7:02 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-08 15:47 [Intel-gfx] [PATCH] drm/i915/gvt: Fix NULL pointer dereference in intel_vgpu_reg_rw_edid() Markus Elfring
2020-09-08 15:47 ` Markus Elfring
2020-09-08 18:11 ` [Intel-gfx][PATCH v2] drm/i915/gvt: Prevent " Alejandro Sior
2020-09-08 18:11 ` [Intel-gfx] [PATCH " Alejandro Sior
2020-09-08 18:11 ` [Intel-gfx][PATCH " Alejandro Sior
2020-09-11 5:39 ` Zhenyu Wang
2020-09-11 5:39 ` [Intel-gfx] [PATCH " Zhenyu Wang
2020-09-12 7:02 ` [Intel-gfx][PATCH " Aho Sior
2020-09-12 7:02 ` [Intel-gfx] [PATCH " Aho Sior
2020-09-12 7:02 ` [Intel-gfx][PATCH " Aho Sior
2020-09-08 18:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-09-08 18:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-09-08 19:41 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-09-11 6:00 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid() (rev2) Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.