All of lore.kernel.org
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno  <angelogioacchino.delregno@collabora.com>
To: linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Alexandre Courbot <acourbot@chromium.org>,
	kernel@collabora.com, dafna3@gmail.com, tiffany.lin@mediatek.com,
	andrew-ct.chen@mediatek.com, minghsiu.tsai@mediatek.com,
	houlong.wei@mediatek.com, mchehab@kernel.org,
	matthias.bgg@gmail.com, hverkuil@xs4all.nl
Subject: Re: [PATCH v4] media: mtk-vpu: Ensure alignment of 8 for DTCM buffer
Date: Tue, 15 Feb 2022 10:41:21 +0100	[thread overview]
Message-ID: <15a24b12-e296-9d4e-211f-55553ac8f7da@collabora.com> (raw)
In-Reply-To: <20210920170408.1561-1-dafna.hirschfeld@collabora.com>

Il 20/09/21 19:04, Dafna Hirschfeld ha scritto:
> From: Alexandre Courbot <acourbot@chromium.org>
> 
> When running memcpy_toio:
> memcpy_toio(send_obj->share_buf, buf, len);
> it was found that errors appear if len is not a multiple of 8:
> 
> [58.350841] mtk-mdp 14001000.rdma: processing failed: -22
> 
> This patch ensures the copy of a multiple of 8 size by calling
> round_up(len, 8) when copying
> 
> Fixes: e6599adfad30 ("media: mtk-vpu: avoid unaligned access to DTCM buffer.")
> Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> Reviewed-by: Houlong Wei <houlong.wei@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

I acknowledge that this patch is getting very old and stale, but after some
testing on MT8173, we were able to verify that it is essential for MediaTek MDP
functionality, along with some other patches.

Without this one, it won't work.

Keeping this in mind, I would propose to get this one picked before it gets
completely stale and requiring a rewrite.

Cheers,
Angelo

WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Alexandre Courbot <acourbot@chromium.org>,
	kernel@collabora.com, dafna3@gmail.com, tiffany.lin@mediatek.com,
	andrew-ct.chen@mediatek.com, minghsiu.tsai@mediatek.com,
	houlong.wei@mediatek.com, mchehab@kernel.org,
	matthias.bgg@gmail.com, hverkuil@xs4all.nl
Subject: Re: [PATCH v4] media: mtk-vpu: Ensure alignment of 8 for DTCM buffer
Date: Tue, 15 Feb 2022 10:41:21 +0100	[thread overview]
Message-ID: <15a24b12-e296-9d4e-211f-55553ac8f7da@collabora.com> (raw)
In-Reply-To: <20210920170408.1561-1-dafna.hirschfeld@collabora.com>

Il 20/09/21 19:04, Dafna Hirschfeld ha scritto:
> From: Alexandre Courbot <acourbot@chromium.org>
> 
> When running memcpy_toio:
> memcpy_toio(send_obj->share_buf, buf, len);
> it was found that errors appear if len is not a multiple of 8:
> 
> [58.350841] mtk-mdp 14001000.rdma: processing failed: -22
> 
> This patch ensures the copy of a multiple of 8 size by calling
> round_up(len, 8) when copying
> 
> Fixes: e6599adfad30 ("media: mtk-vpu: avoid unaligned access to DTCM buffer.")
> Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> Reviewed-by: Houlong Wei <houlong.wei@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

I acknowledge that this patch is getting very old and stale, but after some
testing on MT8173, we were able to verify that it is essential for MediaTek MDP
functionality, along with some other patches.

Without this one, it won't work.

Keeping this in mind, I would propose to get this one picked before it gets
completely stale and requiring a rewrite.

Cheers,
Angelo

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

  parent reply	other threads:[~2022-02-15  9:41 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-20 17:04 [PATCH v4] media: mtk-vpu: Ensure alignment of 8 for DTCM buffer Dafna Hirschfeld
2021-09-20 17:04 ` Dafna Hirschfeld
2021-10-04  9:37 ` Hans Verkuil
2021-10-04  9:37   ` Hans Verkuil
2021-10-18  1:16   ` Alexandre Courbot
2021-10-18  1:16     ` Alexandre Courbot
2021-10-18  7:07     ` Dafna Hirschfeld
2021-10-18  7:07       ` Dafna Hirschfeld
2021-11-03  8:03       ` houlong wei
2021-11-03  8:03         ` houlong wei
2021-11-03  9:19         ` Irui Wang
2021-11-03  9:19           ` Irui Wang
2021-11-03 11:04           ` Dafna Hirschfeld
2021-11-03 11:04             ` Dafna Hirschfeld
2021-11-09  8:46             ` Dafna Hirschfeld
2021-11-09  8:46               ` Dafna Hirschfeld
2021-11-10  3:11               ` Irui Wang
2021-11-10  3:11                 ` Irui Wang
2021-11-29  8:11                 ` Dafna Hirschfeld
2021-11-29  8:11                   ` Dafna Hirschfeld
2021-11-29 14:39     ` Dafna Hirschfeld
2021-11-29 14:39       ` Dafna Hirschfeld
2021-12-06  7:23       ` Alexandre Courbot
2021-12-06  7:23         ` Alexandre Courbot
2022-02-15  9:41 ` AngeloGioacchino Del Regno [this message]
2022-02-15  9:41   ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15a24b12-e296-9d4e-211f-55553ac8f7da@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=acourbot@chromium.org \
    --cc=andrew-ct.chen@mediatek.com \
    --cc=dafna3@gmail.com \
    --cc=houlong.wei@mediatek.com \
    --cc=hverkuil@xs4all.nl \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=minghsiu.tsai@mediatek.com \
    --cc=tiffany.lin@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.