* [Intel-gfx] [PATCH] drm/i915/psr: Fix PSR2 handling of multiplanar format
@ 2021-11-08 21:38 José Roberto de Souza
2021-11-08 22:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: José Roberto de Souza @ 2021-11-08 21:38 UTC (permalink / raw)
To: intel-gfx
When a plane with a multiplanar format is added to the state by
drm_atomic_add_affected_planes(), only the UV plane is
added, so a intel_atomic_get_new_plane_state() call to get the Y
plane state can return a null pointer.
To fix this, intel_atomic_get_plane_state() should be called and
the return needs to be checked for errors, as it could return a EAGAIN
as other atomic state could be holding the lock for the Y plane.
Other issue with the patch being fixed is that the Y plane is not
being committed to hardware because the corresponded plane bit is not
set in update_planes when UV and Y planes are added to the state by
drm_atomic_add_affected_planes().
Cc: Jouni Högander <jouni.hogander@intel.com>
Cc: Mika Kahola <mika.kahola@intel.com>
Fixes: 3809991ff5f4 ("drm/i915/display: Add initial selective fetch support for biplanar formats")
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/display/intel_psr.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 9d589d471e335..a1a663f362e7d 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1732,13 +1732,17 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,
* same area for Y plane as well.
*/
if (linked) {
- struct intel_plane_state *linked_new_plane_state =
- intel_atomic_get_new_plane_state(state, linked);
- struct drm_rect *linked_sel_fetch_area =
- &linked_new_plane_state->psr2_sel_fetch_area;
+ struct intel_plane_state *linked_new_plane_state;
+ struct drm_rect *linked_sel_fetch_area;
+ linked_new_plane_state = intel_atomic_get_plane_state(state, linked);
+ if (IS_ERR(linked_new_plane_state))
+ return PTR_ERR(linked_new_plane_state);
+
+ linked_sel_fetch_area = &linked_new_plane_state->psr2_sel_fetch_area;
linked_sel_fetch_area->y1 = sel_fetch_area->y1;
linked_sel_fetch_area->y2 = sel_fetch_area->y2;
+ crtc_state->update_planes |= BIT(linked->id);
}
}
--
2.33.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: Fix PSR2 handling of multiplanar format
2021-11-08 21:38 [Intel-gfx] [PATCH] drm/i915/psr: Fix PSR2 handling of multiplanar format José Roberto de Souza
@ 2021-11-08 22:48 ` Patchwork
2021-11-09 0:37 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-11-09 10:31 ` [Intel-gfx] [PATCH] " Hogander, Jouni
2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-11-08 22:48 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6340 bytes --]
== Series Details ==
Series: drm/i915/psr: Fix PSR2 handling of multiplanar format
URL : https://patchwork.freedesktop.org/series/96690/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10854 -> Patchwork_21539
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/index.html
Participating hosts (40 -> 35)
------------------------------
Additional (2): fi-icl-u2 fi-pnv-d510
Missing (7): fi-kbl-soraka bat-dg1-6 bat-dg1-5 fi-bsw-cyan bat-adlp-4 fi-ctg-p8600 fi-bdw-samus
Known issues
------------
Here are the changes found in Patchwork_21539 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@fork-gfx0:
- fi-icl-u2: NOTRUN -> [SKIP][1] ([fdo#109315]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/fi-icl-u2/igt@amdgpu/amd_cs_nop@fork-gfx0.html
* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-snb-2600: NOTRUN -> [SKIP][2] ([fdo#109271]) +17 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/fi-snb-2600/igt@amdgpu/amd_cs_nop@sync-fork-compute0.html
* igt@gem_exec_suspend@basic-s3:
- fi-bdw-5557u: [PASS][3] -> [INCOMPLETE][4] ([i915#146])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3.html
* igt@gem_huc_copy@huc-copy:
- fi-icl-u2: NOTRUN -> [SKIP][5] ([i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/fi-icl-u2/igt@gem_huc_copy@huc-copy.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][6] ([fdo#111827]) +8 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: NOTRUN -> [SKIP][7] ([fdo#109278]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-u2: NOTRUN -> [SKIP][8] ([fdo#109285])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/fi-icl-u2/igt@kms_force_connector_basic@force-load-detect.html
* igt@prime_vgem@basic-userptr:
- fi-pnv-d510: NOTRUN -> [SKIP][9] ([fdo#109271]) +53 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/fi-pnv-d510/igt@prime_vgem@basic-userptr.html
- fi-icl-u2: NOTRUN -> [SKIP][10] ([i915#3301])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/fi-icl-u2/igt@prime_vgem@basic-userptr.html
#### Possible fixes ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-skl-6600u: [FAIL][11] ([i915#3239]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/fi-skl-6600u/igt@i915_pm_rpm@basic-pci-d3-state.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/fi-skl-6600u/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_selftest@live@hangcheck:
- {fi-hsw-gt1}: [DMESG-WARN][13] ([i915#3303]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html
- fi-snb-2600: [INCOMPLETE][15] ([i915#3921]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
* igt@kms_frontbuffer_tracking@basic:
- {fi-hsw-gt1}: [DMESG-WARN][17] ([i915#4290]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/fi-hsw-gt1/igt@kms_frontbuffer_tracking@basic.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/fi-hsw-gt1/igt@kms_frontbuffer_tracking@basic.html
#### Warnings ####
* igt@kms_busy@basic:
- fi-kbl-guc: [SKIP][19] ([fdo#109271]) -> [SKIP][20] ([fdo#109271] / [i915#1845])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/fi-kbl-guc/igt@kms_busy@basic.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/fi-kbl-guc/igt@kms_busy@basic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3239]: https://gitlab.freedesktop.org/drm/intel/issues/3239
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4290]: https://gitlab.freedesktop.org/drm/intel/issues/4290
Build changes
-------------
* Linux: CI_DRM_10854 -> Patchwork_21539
CI-20190529: 20190529
CI_DRM_10854: 895fb34d3265137c84fe3e9dd48fb9ad2e00fd36 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6274: 569de51145fba197a8d93b2417348d47507bf485 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21539: bd4f2ce0e6b64b1ddb6992b921a1e0ad222f75a0 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
bd4f2ce0e6b6 drm/i915/psr: Fix PSR2 handling of multiplanar format
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/index.html
[-- Attachment #2: Type: text/html, Size: 7419 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr: Fix PSR2 handling of multiplanar format
2021-11-08 21:38 [Intel-gfx] [PATCH] drm/i915/psr: Fix PSR2 handling of multiplanar format José Roberto de Souza
2021-11-08 22:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2021-11-09 0:37 ` Patchwork
2021-11-09 10:31 ` [Intel-gfx] [PATCH] " Hogander, Jouni
2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-11-09 0:37 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30276 bytes --]
== Series Details ==
Series: drm/i915/psr: Fix PSR2 handling of multiplanar format
URL : https://patchwork.freedesktop.org/series/96690/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10854_full -> Patchwork_21539_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (11 -> 10)
------------------------------
Missing (1): pig-kbl-iris
New tests
---------
New tests have been introduced between CI_DRM_10854_full and Patchwork_21539_full:
### New IGT tests (19) ###
* igt@kms_atomic_interruptible@atomic-setmode@dp-1-pipe-a:
- Statuses : 2 pass(s)
- Exec time: [6.23, 6.34] s
* igt@kms_atomic_interruptible@atomic-setmode@hdmi-a-1-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [6.56] s
* igt@kms_atomic_interruptible@atomic-setmode@vga-1-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [6.15] s
* igt@kms_atomic_interruptible@legacy-cursor@dp-1-pipe-a:
- Statuses : 2 pass(s)
- Exec time: [6.25, 6.36] s
* igt@kms_atomic_interruptible@legacy-cursor@hdmi-a-1-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [6.59] s
* igt@kms_atomic_interruptible@legacy-cursor@vga-1-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [6.16] s
* igt@kms_atomic_interruptible@legacy-dpms@dp-1-pipe-a:
- Statuses : 2 pass(s)
- Exec time: [6.25, 6.38] s
* igt@kms_atomic_interruptible@legacy-dpms@hdmi-a-1-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [6.61] s
* igt@kms_atomic_interruptible@legacy-dpms@vga-1-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [6.16] s
* igt@kms_atomic_interruptible@legacy-pageflip@dp-1-pipe-a:
- Statuses : 2 pass(s)
- Exec time: [6.26, 6.36] s
* igt@kms_atomic_interruptible@legacy-pageflip@hdmi-a-1-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [6.60] s
* igt@kms_atomic_interruptible@legacy-pageflip@vga-1-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [6.17] s
* igt@kms_atomic_interruptible@legacy-setmode@dp-1-pipe-a:
- Statuses : 2 pass(s)
- Exec time: [6.25, 6.32] s
* igt@kms_atomic_interruptible@legacy-setmode@hdmi-a-1-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [6.55] s
* igt@kms_atomic_interruptible@legacy-setmode@vga-1-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [6.14] s
* igt@kms_atomic_interruptible@universal-setplane-primary@dp-1-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [6.23] s
* igt@kms_atomic_interruptible@universal-setplane-primary@hdmi-a-1-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [6.56] s
* igt@kms_atomic_interruptible@universal-setplane-primary@vga-1-pipe-a:
- Statuses : 1 pass(s)
- Exec time: [6.18] s
* igt@kms_prime@basic-crc:
- Statuses :
- Exec time: [None] s
Known issues
------------
Here are the changes found in Patchwork_21539_full that come from known issues:
### CI changes ###
#### Possible fixes ####
* boot:
- shard-snb: ([PASS][1], [PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [FAIL][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25]) ([i915#4338]) -> ([PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb7/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb7/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb7/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb7/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb7/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb6/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb6/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb6/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb6/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb5/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb5/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb5/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb5/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb5/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb5/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb4/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb4/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb4/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb4/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb4/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb2/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb2/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb2/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb2/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-snb2/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb7/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb7/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb7/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb7/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb7/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb6/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb6/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb6/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb6/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb6/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb5/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb5/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb5/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb5/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb5/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb5/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb4/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb4/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb4/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb4/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb4/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb2/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb2/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb2/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb2/boot.html
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@display-3x:
- shard-tglb: NOTRUN -> [SKIP][51] ([i915#1839])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb1/igt@feature_discovery@display-3x.html
* igt@gem_ctx_persistence@hostile:
- shard-snb: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#1099])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb7/igt@gem_ctx_persistence@hostile.html
* igt@gem_ctx_sseu@engines:
- shard-tglb: NOTRUN -> [SKIP][53] ([i915#280])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb8/igt@gem_ctx_sseu@engines.html
* igt@gem_eio@in-flight-contexts-10ms:
- shard-snb: NOTRUN -> [FAIL][54] ([i915#4409])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb7/igt@gem_eio@in-flight-contexts-10ms.html
* igt@gem_eio@unwedge-stress:
- shard-iclb: [PASS][55] -> [TIMEOUT][56] ([i915#2369] / [i915#2481] / [i915#3070])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-iclb6/igt@gem_eio@unwedge-stress.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb7/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_capture@pi@rcs0:
- shard-skl: [PASS][57] -> [INCOMPLETE][58] ([i915#2369])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-skl1/igt@gem_exec_capture@pi@rcs0.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-skl3/igt@gem_exec_capture@pi@rcs0.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][59] -> [FAIL][60] ([i915#2846])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-glk8/igt@gem_exec_fair@basic-deadline.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-glk3/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-tglb: NOTRUN -> [FAIL][61] ([i915#2842]) +10 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb5/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][62] ([i915#2842]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb2/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][63] -> [FAIL][64] ([i915#2842]) +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-kbl7/igt@gem_exec_fair@basic-pace@vecs0.html
- shard-iclb: [PASS][65] -> [FAIL][66] ([i915#2842])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-iclb8/igt@gem_exec_fair@basic-pace@vecs0.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb2/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [WARN][67] ([i915#2658])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-apl8/igt@gem_pread@exhaustion.html
* igt@gem_pxp@create-protected-buffer:
- shard-iclb: NOTRUN -> [SKIP][68] ([i915#4270]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb7/igt@gem_pxp@create-protected-buffer.html
* igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs:
- shard-iclb: NOTRUN -> [SKIP][69] ([i915#768])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb7/igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs.html
* igt@gem_softpin@noreloc-s3:
- shard-apl: [PASS][70] -> [INCOMPLETE][71] ([i915#4186])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-apl4/igt@gem_softpin@noreloc-s3.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-apl2/igt@gem_softpin@noreloc-s3.html
* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-tglb: NOTRUN -> [SKIP][72] ([i915#3297]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb2/igt@gem_userptr_blits@unsync-unmap-cycles.html
* igt@gen7_exec_parse@load-register-reg:
- shard-iclb: NOTRUN -> [SKIP][73] ([fdo#109289]) +2 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb4/igt@gen7_exec_parse@load-register-reg.html
* igt@gen9_exec_parse@batch-invalid-length:
- shard-tglb: NOTRUN -> [SKIP][74] ([i915#2856])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb8/igt@gen9_exec_parse@batch-invalid-length.html
* igt@gen9_exec_parse@bb-chained:
- shard-iclb: NOTRUN -> [SKIP][75] ([i915#2856])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb7/igt@gen9_exec_parse@bb-chained.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [PASS][76] -> [FAIL][77] ([i915#454])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-iclb6/igt@i915_pm_dc@dc6-dpms.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: NOTRUN -> [FAIL][78] ([i915#4275])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb7/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#1937])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-kbl1/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
* igt@i915_pm_rc6_residency@media-rc6-accuracy:
- shard-tglb: NOTRUN -> [SKIP][80] ([fdo#109289] / [fdo#111719])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb8/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-iclb: NOTRUN -> [SKIP][81] ([fdo#109293] / [fdo#109506])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb7/igt@i915_pm_rpm@modeset-pc8-residency-stress.html
* igt@i915_pm_sseu@full-enable:
- shard-iclb: NOTRUN -> [SKIP][82] ([i915#4387])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb4/igt@i915_pm_sseu@full-enable.html
* igt@i915_suspend@fence-restore-untiled:
- shard-tglb: [PASS][83] -> [INCOMPLETE][84] ([i915#456])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-tglb5/igt@i915_suspend@fence-restore-untiled.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb7/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_big_fb@linear-32bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][85] ([fdo#110725] / [fdo#111614]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb7/igt@kms_big_fb@linear-32bpp-rotate-90.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#3777])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-apl2/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
- shard-kbl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#3777])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-kbl6/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_big_fb@yf-tiled-32bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][88] ([fdo#111615]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb1/igt@kms_big_fb@yf-tiled-32bpp-rotate-270.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-iclb: NOTRUN -> [SKIP][89] ([fdo#110723]) +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb7/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_big_joiner@2x-modeset:
- shard-tglb: NOTRUN -> [SKIP][90] ([i915#2705])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb1/igt@kms_big_joiner@2x-modeset.html
* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][91] ([i915#3689]) +4 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb8/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_ccs.html
* igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][92] ([fdo#109278] / [i915#3886])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb7/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][93] ([i915#3689] / [i915#3886])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb8/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#3886]) +6 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-kbl6/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
- shard-apl: NOTRUN -> [SKIP][95] ([fdo#109271] / [i915#3886])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-apl2/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-random-ccs-data-yf_tiled_ccs:
- shard-iclb: NOTRUN -> [SKIP][96] ([fdo#109278]) +11 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb4/igt@kms_ccs@pipe-d-random-ccs-data-yf_tiled_ccs.html
* igt@kms_chamelium@hdmi-hpd:
- shard-tglb: NOTRUN -> [SKIP][97] ([fdo#109284] / [fdo#111827]) +2 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb1/igt@kms_chamelium@hdmi-hpd.html
* igt@kms_chamelium@hdmi-hpd-for-each-pipe:
- shard-kbl: NOTRUN -> [SKIP][98] ([fdo#109271] / [fdo#111827]) +4 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-kbl3/igt@kms_chamelium@hdmi-hpd-for-each-pipe.html
* igt@kms_chamelium@vga-hpd-with-enabled-mode:
- shard-iclb: NOTRUN -> [SKIP][99] ([fdo#109284] / [fdo#111827]) +3 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb7/igt@kms_chamelium@vga-hpd-with-enabled-mode.html
* igt@kms_color@pipe-b-ctm-0-5:
- shard-skl: [PASS][100] -> [DMESG-WARN][101] ([i915#1982])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-skl3/igt@kms_color@pipe-b-ctm-0-5.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-skl8/igt@kms_color@pipe-b-ctm-0-5.html
* igt@kms_color_chamelium@pipe-a-ctm-0-5:
- shard-apl: NOTRUN -> [SKIP][102] ([fdo#109271] / [fdo#111827]) +5 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-apl2/igt@kms_color_chamelium@pipe-a-ctm-0-5.html
* igt@kms_color_chamelium@pipe-b-ctm-max:
- shard-snb: NOTRUN -> [SKIP][103] ([fdo#109271] / [fdo#111827]) +2 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb7/igt@kms_color_chamelium@pipe-b-ctm-max.html
* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-tglb: NOTRUN -> [SKIP][104] ([i915#3116]) +1 similar issue
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb1/igt@kms_content_protection@dp-mst-lic-type-1.html
* igt@kms_content_protection@legacy:
- shard-iclb: NOTRUN -> [SKIP][105] ([fdo#109300] / [fdo#111066])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb7/igt@kms_content_protection@legacy.html
* igt@kms_cursor_crc@pipe-a-cursor-512x512-random:
- shard-tglb: NOTRUN -> [SKIP][106] ([fdo#109279] / [i915#3359])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb7/igt@kms_cursor_crc@pipe-a-cursor-512x512-random.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-tglb: [PASS][107] -> [INCOMPLETE][108] ([i915#2411] / [i915#2828] / [i915#456])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-tglb8/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-c-cursor-32x10-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][109] ([i915#3359]) +2 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb1/igt@kms_cursor_crc@pipe-c-cursor-32x10-rapid-movement.html
* igt@kms_cursor_crc@pipe-c-cursor-512x170-sliding:
- shard-iclb: NOTRUN -> [SKIP][110] ([fdo#109278] / [fdo#109279])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb7/igt@kms_cursor_crc@pipe-c-cursor-512x170-sliding.html
* igt@kms_cursor_crc@pipe-d-cursor-256x256-rapid-movement:
- shard-kbl: NOTRUN -> [SKIP][111] ([fdo#109271]) +84 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-kbl6/igt@kms_cursor_crc@pipe-d-cursor-256x256-rapid-movement.html
* igt@kms_cursor_crc@pipe-d-cursor-32x32-onscreen:
- shard-tglb: NOTRUN -> [SKIP][112] ([i915#3319])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb1/igt@kms_cursor_crc@pipe-d-cursor-32x32-onscreen.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [PASS][113] -> [FAIL][114] ([i915#2346])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@pipe-d-single-bo:
- shard-skl: NOTRUN -> [SKIP][115] ([fdo#109271] / [i915#533])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-skl7/igt@kms_cursor_legacy@pipe-d-single-bo.html
- shard-apl: NOTRUN -> [SKIP][116] ([fdo#109271] / [i915#533])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-apl1/igt@kms_cursor_legacy@pipe-d-single-bo.html
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle:
- shard-tglb: NOTRUN -> [SKIP][117] ([i915#4103])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb8/igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-tglb: NOTRUN -> [INCOMPLETE][118] ([i915#2411] / [i915#456])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb7/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-flip-vs-fences-interruptible:
- shard-iclb: NOTRUN -> [SKIP][119] ([fdo#109274])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb7/igt@kms_flip@2x-flip-vs-fences-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: NOTRUN -> [DMESG-WARN][120] ([i915#180]) +2 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [PASS][121] -> [DMESG-WARN][122] ([i915#180]) +3 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-apl3/igt@kms_flip@flip-vs-suspend@a-dp1.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-apl6/igt@kms_flip@flip-vs-suspend@a-dp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [PASS][123] -> [FAIL][124] ([i915#2122])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-skl6/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-skl7/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-apl: NOTRUN -> [SKIP][125] ([fdo#109271] / [i915#2672])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-apl8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_force_connector_basic@force-load-detect:
- shard-tglb: NOTRUN -> [SKIP][126] ([fdo#109285])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb1/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-cpu:
- shard-iclb: NOTRUN -> [SKIP][127] ([fdo#109280]) +7 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-blt:
- shard-skl: NOTRUN -> [SKIP][128] ([fdo#109271]) +2 similar issues
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-skl9/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-blt.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][129] -> [DMESG-WARN][130] ([i915#180]) +4 similar issues
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-suspend.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt:
- shard-apl: NOTRUN -> [SKIP][131] ([fdo#109271]) +59 similar issues
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-apl8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-pwrite:
- shard-tglb: NOTRUN -> [SKIP][132] ([fdo#111825]) +12 similar issues
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb1/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-pwrite.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][133] -> [FAIL][134] ([i915#1188])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-skl10/igt@kms_hdr@bpc-switch-dpms.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-skl10/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_hdr@static-toggle-dpms:
- shard-tglb: NOTRUN -> [SKIP][135] ([i915#1187])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb8/igt@kms_hdr@static-toggle-dpms.html
* igt@kms_pipe_b_c_ivb@disable-pipe-b-enable-pipe-c:
- shard-tglb: NOTRUN -> [SKIP][136] ([fdo#109289])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb5/igt@kms_pipe_b_c_ivb@disable-pipe-b-enable-pipe-c.html
* igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence:
- shard-snb: NOTRUN -> [SKIP][137] ([fdo#109271]) +70 similar issues
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-snb7/igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
- shard-skl: [PASS][138] -> [INCOMPLETE][139] ([i915#198])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-skl7/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-skl4/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
* igt@kms_plane_lowres@pipe-c-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][140] ([fdo#112054])
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb1/igt@kms_plane_lowres@pipe-c-tiling-yf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-kbl: NOTRUN -> [SKIP][141] ([fdo#109271] / [i915#658]) +1 similar issue
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-kbl4/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5:
- shard-apl: NOTRUN -> [SKIP][142] ([fdo#109271] / [i915#658])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-apl8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-2:
- shard-tglb: NOTRUN -> [SKIP][143] ([i915#2920]) +2 similar issues
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb8/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: NOTRUN -> [SKIP][144] ([fdo#109441]) +1 similar issue
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb7/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [PASS][145] -> [SKIP][146] ([fdo#109441])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10854/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-iclb1/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-tglb: NOTRUN -> [FAIL][147] ([i915#132] / [i915#3467]) +1 similar issue
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb5/igt@kms_psr@psr2_sprite_plane_onoff.html
* igt@kms_vrr@flip-suspend:
- shard-tglb: NOTRUN -> [SKIP][148] ([fdo#109502])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/shard-tglb1/igt@kms_vrr@flip-suspend.html
* igt@nouveau_crc@pipe-a-source-outp-inactive:
- shard-iclb: NOTRUN -> [SKIP][149] ([i915#2530])
[149]: https://intel-gfx-
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21539/index.html
[-- Attachment #2: Type: text/html, Size: 34284 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/psr: Fix PSR2 handling of multiplanar format
2021-11-08 21:38 [Intel-gfx] [PATCH] drm/i915/psr: Fix PSR2 handling of multiplanar format José Roberto de Souza
2021-11-08 22:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-11-09 0:37 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2021-11-09 10:31 ` Hogander, Jouni
2021-11-09 18:17 ` Souza, Jose
2 siblings, 1 reply; 8+ messages in thread
From: Hogander, Jouni @ 2021-11-09 10:31 UTC (permalink / raw)
To: intel-gfx, Souza, Jose
On Mon, 2021-11-08 at 13:38 -0800, José Roberto de Souza wrote:
> When a plane with a multiplanar format is added to the state by
> drm_atomic_add_affected_planes(), only the UV plane is
> added, so a intel_atomic_get_new_plane_state() call to get the Y
> plane state can return a null pointer.
I don't understand how this could happen only sometimes? Were you able
to reproduce this somehow?
Generally: checking linked_new_plane_state being valid pointer makes
sense. I'm just wondering how and when this could happen and how that
should be handled.
> To fix this, intel_atomic_get_plane_state() should be called and
> the return needs to be checked for errors, as it could return a
> EAGAIN
> as other atomic state could be holding the lock for the Y plane.
>
> Other issue with the patch being fixed is that the Y plane is not
> being committed to hardware because the corresponded plane bit is not
> set in update_planes when UV and Y planes are added to the state by
> drm_atomic_add_affected_planes().
To my understanding this one is already set in
intel_display.c:icl_check_nv12_planes.
>
> Cc: Jouni Högander <jouni.hogander@intel.com>
> Cc: Mika Kahola <mika.kahola@intel.com>
> Fixes: 3809991ff5f4 ("drm/i915/display: Add initial selective fetch
> support for biplanar formats")
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index 9d589d471e335..a1a663f362e7d 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -1732,13 +1732,17 @@ int intel_psr2_sel_fetch_update(struct
> intel_atomic_state *state,
> * same area for Y plane as well.
> */
> if (linked) {
> - struct intel_plane_state
> *linked_new_plane_state =
> - intel_atomic_get_new_plane_state(state,
> linked);
> - struct drm_rect *linked_sel_fetch_area =
> - &linked_new_plane_state->psr2_sel_fetch_area;
> + struct intel_plane_state
> *linked_new_plane_state;
> + struct drm_rect *linked_sel_fetch_area;
>
> + linked_new_plane_state =
> intel_atomic_get_plane_state(state, linked);
> + if (IS_ERR(linked_new_plane_state))
> + return PTR_ERR(linked_new_plane_state);
> +
> + linked_sel_fetch_area =
> &linked_new_plane_state->psr2_sel_fetch_area;
> linked_sel_fetch_area->y1 = sel_fetch_area->y1;
> linked_sel_fetch_area->y2 = sel_fetch_area->y2;
> + crtc_state->update_planes |= BIT(linked->id);
> }
> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/psr: Fix PSR2 handling of multiplanar format
2021-11-09 10:31 ` [Intel-gfx] [PATCH] " Hogander, Jouni
@ 2021-11-09 18:17 ` Souza, Jose
2021-11-10 16:05 ` Hogander, Jouni
0 siblings, 1 reply; 8+ messages in thread
From: Souza, Jose @ 2021-11-09 18:17 UTC (permalink / raw)
To: intel-gfx, Hogander, Jouni
On Tue, 2021-11-09 at 10:31 +0000, Hogander, Jouni wrote:
> On Mon, 2021-11-08 at 13:38 -0800, José Roberto de Souza wrote:
> > When a plane with a multiplanar format is added to the state by
> > drm_atomic_add_affected_planes(), only the UV plane is
> > added, so a intel_atomic_get_new_plane_state() call to get the Y
> > plane state can return a null pointer.
>
> I don't understand how this could happen only sometimes? Were you able
> to reproduce this somehow?
here a example:
plane 0 - primary plane with nv12 format
plane 1 - overlay with any format
plane 2 - primary slave
userspace does a flip to overlay, so state do not have the primary plane
but the primary and overlay planes overlap, so the primary is added by drm_atomic_add_affected_planes()...
>
> Generally: checking linked_new_plane_state being valid pointer makes
> sense. I'm just wondering how and when this could happen and how that
> should be handled.
>
> > To fix this, intel_atomic_get_plane_state() should be called and
> > the return needs to be checked for errors, as it could return a
> > EAGAIN
> > as other atomic state could be holding the lock for the Y plane.
> >
> > Other issue with the patch being fixed is that the Y plane is not
> > being committed to hardware because the corresponded plane bit is not
> > set in update_planes when UV and Y planes are added to the state by
> > drm_atomic_add_affected_planes().
>
> To my understanding this one is already set in
> intel_display.c:icl_check_nv12_planes.
primary plane will be added after this was executed.
>
> >
> > Cc: Jouni Högander <jouni.hogander@intel.com>
> > Cc: Mika Kahola <mika.kahola@intel.com>
> > Fixes: 3809991ff5f4 ("drm/i915/display: Add initial selective fetch
> > support for biplanar formats")
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_psr.c | 12 ++++++++----
> > 1 file changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > b/drivers/gpu/drm/i915/display/intel_psr.c
> > index 9d589d471e335..a1a663f362e7d 100644
> > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > @@ -1732,13 +1732,17 @@ int intel_psr2_sel_fetch_update(struct
> > intel_atomic_state *state,
> > * same area for Y plane as well.
> > */
> > if (linked) {
> > - struct intel_plane_state
> > *linked_new_plane_state =
> > - intel_atomic_get_new_plane_state(state,
> > linked);
> > - struct drm_rect *linked_sel_fetch_area =
> > - &linked_new_plane_state->psr2_sel_fetch_area;
> > + struct intel_plane_state
> > *linked_new_plane_state;
> > + struct drm_rect *linked_sel_fetch_area;
> >
> > + linked_new_plane_state =
> > intel_atomic_get_plane_state(state, linked);
> > + if (IS_ERR(linked_new_plane_state))
> > + return PTR_ERR(linked_new_plane_state);
> > +
> > + linked_sel_fetch_area =
> > &linked_new_plane_state->psr2_sel_fetch_area;
> > linked_sel_fetch_area->y1 = sel_fetch_area->y1;
> > linked_sel_fetch_area->y2 = sel_fetch_area->y2;
> > + crtc_state->update_planes |= BIT(linked->id);
> > }
> > }
> >
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/psr: Fix PSR2 handling of multiplanar format
2021-11-09 18:17 ` Souza, Jose
@ 2021-11-10 16:05 ` Hogander, Jouni
2021-11-10 18:16 ` Souza, Jose
0 siblings, 1 reply; 8+ messages in thread
From: Hogander, Jouni @ 2021-11-10 16:05 UTC (permalink / raw)
To: intel-gfx, Souza, Jose
On Tue, 2021-11-09 at 18:17 +0000, Souza, Jose wrote:
> On Tue, 2021-11-09 at 10:31 +0000, Hogander, Jouni wrote:
> > On Mon, 2021-11-08 at 13:38 -0800, José Roberto de Souza wrote:
> > > When a plane with a multiplanar format is added to the state by
> > > drm_atomic_add_affected_planes(), only the UV plane is
> > > added, so a intel_atomic_get_new_plane_state() call to get the Y
> > > plane state can return a null pointer.
> >
> > I don't understand how this could happen only sometimes? Were you
> > able
> > to reproduce this somehow?
>
> here a example:
> plane 0 - primary plane with nv12 format
> plane 1 - overlay with any format
> plane 2 - primary slave
>
> userspace does a flip to overlay, so state do not have the primary
> plane
> but the primary and overlay planes overlap, so the primary is added
> by drm_atomic_add_affected_planes()...
Ok, thank you for the explanation.
>
> > Generally: checking linked_new_plane_state being valid pointer
> > makes
> > sense. I'm just wondering how and when this could happen and how
> > that
> > should be handled.
> >
> > > To fix this, intel_atomic_get_plane_state() should be called and
> > > the return needs to be checked for errors, as it could return a
> > > EAGAIN
> > > as other atomic state could be holding the lock for the Y plane.
> > >
> > > Other issue with the patch being fixed is that the Y plane is not
> > > being committed to hardware because the corresponded plane bit is
> > > not
> > > set in update_planes when UV and Y planes are added to the state
> > > by
> > > drm_atomic_add_affected_planes().
> >
> > To my understanding this one is already set in
> > intel_display.c:icl_check_nv12_planes.
>
> primary plane will be added after this was executed.
Ok, but then isn't it a problem also when selective fetch is not in
use?
>
> > > Cc: Jouni Högander <jouni.hogander@intel.com>
> > > Cc: Mika Kahola <mika.kahola@intel.com>
> > > Fixes: 3809991ff5f4 ("drm/i915/display: Add initial selective
> > > fetch
> > > support for biplanar formats")
> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/display/intel_psr.c | 12 ++++++++----
> > > 1 file changed, 8 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > > b/drivers/gpu/drm/i915/display/intel_psr.c
> > > index 9d589d471e335..a1a663f362e7d 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > > @@ -1732,13 +1732,17 @@ int intel_psr2_sel_fetch_update(struct
> > > intel_atomic_state *state,
> > > * same area for Y plane as well.
> > > */
> > > if (linked) {
> > > - struct intel_plane_state
> > > *linked_new_plane_state =
> > > - intel_atomic_get_new_plane_state(state,
> > > linked);
> > > - struct drm_rect *linked_sel_fetch_area =
> > > - &linked_new_plane_state-
> > > >psr2_sel_fetch_area;
> > > + struct intel_plane_state
> > > *linked_new_plane_state;
> > > + struct drm_rect *linked_sel_fetch_area;
> > >
> > > + linked_new_plane_state =
> > > intel_atomic_get_plane_state(state, linked);
> > > + if (IS_ERR(linked_new_plane_state))
> > > + return
> > > PTR_ERR(linked_new_plane_state);
> > > +
> > > + linked_sel_fetch_area =
> > > &linked_new_plane_state->psr2_sel_fetch_area;
> > > linked_sel_fetch_area->y1 = sel_fetch_area-
> > > >y1;
> > > linked_sel_fetch_area->y2 = sel_fetch_area-
> > > >y2;
> > > + crtc_state->update_planes |= BIT(linked-
> > > >id);
> > > }
> > > }
> > >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/psr: Fix PSR2 handling of multiplanar format
2021-11-10 16:05 ` Hogander, Jouni
@ 2021-11-10 18:16 ` Souza, Jose
2021-11-11 18:43 ` Hogander, Jouni
0 siblings, 1 reply; 8+ messages in thread
From: Souza, Jose @ 2021-11-10 18:16 UTC (permalink / raw)
To: intel-gfx, Hogander, Jouni
On Wed, 2021-11-10 at 16:05 +0000, Hogander, Jouni wrote:
> On Tue, 2021-11-09 at 18:17 +0000, Souza, Jose wrote:
> > On Tue, 2021-11-09 at 10:31 +0000, Hogander, Jouni wrote:
> > > On Mon, 2021-11-08 at 13:38 -0800, José Roberto de Souza wrote:
> > > > When a plane with a multiplanar format is added to the state by
> > > > drm_atomic_add_affected_planes(), only the UV plane is
> > > > added, so a intel_atomic_get_new_plane_state() call to get the Y
> > > > plane state can return a null pointer.
> > >
> > > I don't understand how this could happen only sometimes? Were you
> > > able
> > > to reproduce this somehow?
> >
> > here a example:
> > plane 0 - primary plane with nv12 format
> > plane 1 - overlay with any format
> > plane 2 - primary slave
> >
> > userspace does a flip to overlay, so state do not have the primary
> > plane
> > but the primary and overlay planes overlap, so the primary is added
> > by drm_atomic_add_affected_planes()...
>
> Ok, thank you for the explanation.
>
> >
> > > Generally: checking linked_new_plane_state being valid pointer
> > > makes
> > > sense. I'm just wondering how and when this could happen and how
> > > that
> > > should be handled.
> > >
> > > > To fix this, intel_atomic_get_plane_state() should be called and
> > > > the return needs to be checked for errors, as it could return a
> > > > EAGAIN
> > > > as other atomic state could be holding the lock for the Y plane.
> > > >
> > > > Other issue with the patch being fixed is that the Y plane is not
> > > > being committed to hardware because the corresponded plane bit is
> > > > not
> > > > set in update_planes when UV and Y planes are added to the state
> > > > by
> > > > drm_atomic_add_affected_planes().
> > >
> > > To my understanding this one is already set in
> > > intel_display.c:icl_check_nv12_planes.
> >
> > primary plane will be added after this was executed.
>
> Ok, but then isn't it a problem also when selective fetch is not in
> use?
Yes but it is not common to call drm_atomic_add_affected_planes() or intel_atomic_get_plane_state() that late.
>
> >
> > > > Cc: Jouni Högander <jouni.hogander@intel.com>
> > > > Cc: Mika Kahola <mika.kahola@intel.com>
> > > > Fixes: 3809991ff5f4 ("drm/i915/display: Add initial selective
> > > > fetch
> > > > support for biplanar formats")
> > > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > > ---
> > > > drivers/gpu/drm/i915/display/intel_psr.c | 12 ++++++++----
> > > > 1 file changed, 8 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > > > b/drivers/gpu/drm/i915/display/intel_psr.c
> > > > index 9d589d471e335..a1a663f362e7d 100644
> > > > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > > > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > > > @@ -1732,13 +1732,17 @@ int intel_psr2_sel_fetch_update(struct
> > > > intel_atomic_state *state,
> > > > * same area for Y plane as well.
> > > > */
> > > > if (linked) {
> > > > - struct intel_plane_state
> > > > *linked_new_plane_state =
> > > > - intel_atomic_get_new_plane_state(state,
> > > > linked);
> > > > - struct drm_rect *linked_sel_fetch_area =
> > > > - &linked_new_plane_state-
> > > > > psr2_sel_fetch_area;
> > > > + struct intel_plane_state
> > > > *linked_new_plane_state;
> > > > + struct drm_rect *linked_sel_fetch_area;
> > > >
> > > > + linked_new_plane_state =
> > > > intel_atomic_get_plane_state(state, linked);
> > > > + if (IS_ERR(linked_new_plane_state))
> > > > + return
> > > > PTR_ERR(linked_new_plane_state);
> > > > +
> > > > + linked_sel_fetch_area =
> > > > &linked_new_plane_state->psr2_sel_fetch_area;
> > > > linked_sel_fetch_area->y1 = sel_fetch_area-
> > > > > y1;
> > > > linked_sel_fetch_area->y2 = sel_fetch_area-
> > > > > y2;
> > > > + crtc_state->update_planes |= BIT(linked-
> > > > > id);
> > > > }
> > > > }
> > > >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/psr: Fix PSR2 handling of multiplanar format
2021-11-10 18:16 ` Souza, Jose
@ 2021-11-11 18:43 ` Hogander, Jouni
0 siblings, 0 replies; 8+ messages in thread
From: Hogander, Jouni @ 2021-11-11 18:43 UTC (permalink / raw)
To: intel-gfx, Souza, Jose
Thank you for the clarification.
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
On Wed, 2021-11-10 at 18:16 +0000, Souza, Jose wrote:
> On Wed, 2021-11-10 at 16:05 +0000, Hogander, Jouni wrote:
> > On Tue, 2021-11-09 at 18:17 +0000, Souza, Jose wrote:
> > > On Tue, 2021-11-09 at 10:31 +0000, Hogander, Jouni wrote:
> > > > On Mon, 2021-11-08 at 13:38 -0800, José Roberto de Souza wrote:
> > > > > When a plane with a multiplanar format is added to the state
> > > > > by
> > > > > drm_atomic_add_affected_planes(), only the UV plane is
> > > > > added, so a intel_atomic_get_new_plane_state() call to get
> > > > > the Y
> > > > > plane state can return a null pointer.
> > > >
> > > > I don't understand how this could happen only sometimes? Were
> > > > you
> > > > able
> > > > to reproduce this somehow?
> > >
> > > here a example:
> > > plane 0 - primary plane with nv12 format
> > > plane 1 - overlay with any format
> > > plane 2 - primary slave
> > >
> > > userspace does a flip to overlay, so state do not have the
> > > primary
> > > plane
> > > but the primary and overlay planes overlap, so the primary is
> > > added
> > > by drm_atomic_add_affected_planes()...
> >
> > Ok, thank you for the explanation.
> >
> > > > Generally: checking linked_new_plane_state being valid pointer
> > > > makes
> > > > sense. I'm just wondering how and when this could happen and
> > > > how
> > > > that
> > > > should be handled.
> > > >
> > > > > To fix this, intel_atomic_get_plane_state() should be called
> > > > > and
> > > > > the return needs to be checked for errors, as it could return
> > > > > a
> > > > > EAGAIN
> > > > > as other atomic state could be holding the lock for the Y
> > > > > plane.
> > > > >
> > > > > Other issue with the patch being fixed is that the Y plane is
> > > > > not
> > > > > being committed to hardware because the corresponded plane
> > > > > bit is
> > > > > not
> > > > > set in update_planes when UV and Y planes are added to the
> > > > > state
> > > > > by
> > > > > drm_atomic_add_affected_planes().
> > > >
> > > > To my understanding this one is already set in
> > > > intel_display.c:icl_check_nv12_planes.
> > >
> > > primary plane will be added after this was executed.
> >
> > Ok, but then isn't it a problem also when selective fetch is not in
> > use?
>
> Yes but it is not common to call drm_atomic_add_affected_planes() or
> intel_atomic_get_plane_state() that late.
>
> > > > > Cc: Jouni Högander <jouni.hogander@intel.com>
> > > > > Cc: Mika Kahola <mika.kahola@intel.com>
> > > > > Fixes: 3809991ff5f4 ("drm/i915/display: Add initial selective
> > > > > fetch
> > > > > support for biplanar formats")
> > > > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > > > ---
> > > > > drivers/gpu/drm/i915/display/intel_psr.c | 12 ++++++++----
> > > > > 1 file changed, 8 insertions(+), 4 deletions(-)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > > > > b/drivers/gpu/drm/i915/display/intel_psr.c
> > > > > index 9d589d471e335..a1a663f362e7d 100644
> > > > > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > > > > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > > > > @@ -1732,13 +1732,17 @@ int
> > > > > intel_psr2_sel_fetch_update(struct
> > > > > intel_atomic_state *state,
> > > > > * same area for Y plane as well.
> > > > > */
> > > > > if (linked) {
> > > > > - struct intel_plane_state
> > > > > *linked_new_plane_state =
> > > > > - intel_atomic_get_new_plane_state(stat
> > > > > e,
> > > > > linked);
> > > > > - struct drm_rect *linked_sel_fetch_area
> > > > > =
> > > > > - &linked_new_plane_state-
> > > > > > psr2_sel_fetch_area;
> > > > > + struct intel_plane_state
> > > > > *linked_new_plane_state;
> > > > > + struct drm_rect *linked_sel_fetch_area;
> > > > >
> > > > > + linked_new_plane_state =
> > > > > intel_atomic_get_plane_state(state, linked);
> > > > > + if (IS_ERR(linked_new_plane_state))
> > > > > + return
> > > > > PTR_ERR(linked_new_plane_state);
> > > > > +
> > > > > + linked_sel_fetch_area =
> > > > > &linked_new_plane_state->psr2_sel_fetch_area;
> > > > > linked_sel_fetch_area->y1 =
> > > > > sel_fetch_area-
> > > > > > y1;
> > > > > linked_sel_fetch_area->y2 =
> > > > > sel_fetch_area-
> > > > > > y2;
> > > > > + crtc_state->update_planes |=
> > > > > BIT(linked-
> > > > > > id);
> > > > > }
> > > > > }
> > > > >
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-11-11 18:43 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-08 21:38 [Intel-gfx] [PATCH] drm/i915/psr: Fix PSR2 handling of multiplanar format José Roberto de Souza
2021-11-08 22:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-11-09 0:37 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-11-09 10:31 ` [Intel-gfx] [PATCH] " Hogander, Jouni
2021-11-09 18:17 ` Souza, Jose
2021-11-10 16:05 ` Hogander, Jouni
2021-11-10 18:16 ` Souza, Jose
2021-11-11 18:43 ` Hogander, Jouni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.