All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: BALATON Zoltan <balaton@eik.bme.hu>,
	qemu-devel@nongnu.org, alex.bennee@linaro.org,
	qemu-stable@nongnu.org
Subject: Re: [PATCH] target/sh4: Fix TB_FLAG_UNALIGN
Date: Wed, 31 Aug 2022 09:56:51 -0700	[thread overview]
Message-ID: <15b13606-f4c7-51b6-8fcf-5c0ebb8c1e82@linaro.org> (raw)
In-Reply-To: <874jxsddci.wl-ysato@users.sourceforge.jp>

On 8/31/22 01:30, Yoshinori Sato wrote:
> +/* gUSA information field in CPUArchState.flags */
> +/*
> +   b16 - b23: Exclusive region range (negative)
> +   b24: pc in exclusive region flag (use normal decode)
> +*/
> +#define GUSA_SHIFT             16
> +#define GUSA_EXCLUSIVE         (1 << 24)

No good.  These now overlap

     *flags = env->flags /* TB_FLAG_ENVFLAGS_MASK: bits 0-2, 4-12 */

             | (env->fpscr & (FPSCR_FR | FPSCR_SZ | FPSCR_PR))  /* Bits 19-21 */


the fpscr bits.


r~


      reply	other threads:[~2022-08-31 16:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-29  2:13 [PATCH] target/sh4: Fix TB_FLAG_UNALIGN Richard Henderson
2022-08-29  2:16 ` Richard Henderson
2022-08-29  9:05 ` BALATON Zoltan
2022-08-29 16:10   ` Richard Henderson
2022-08-31  1:30     ` Yoshinori Sato
2022-08-31 16:55       ` Richard Henderson
2022-08-31  8:30     ` Yoshinori Sato
2022-08-31 16:56       ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15b13606-f4c7-51b6-8fcf-5c0ebb8c1e82@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=balaton@eik.bme.hu \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.