From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: ysato@users.sourceforge.jp, alex.bennee@linaro.org,
qemu-stable@nongnu.org
Subject: Re: [PATCH] target/sh4: Fix TB_FLAG_UNALIGN
Date: Sun, 28 Aug 2022 19:16:17 -0700 [thread overview]
Message-ID: <21a694b6-e0fc-f20a-9a8c-a8ea993504c6@linaro.org> (raw)
In-Reply-To: <20220829021325.154978-1-richard.henderson@linaro.org>
On 8/28/22 19:13, Richard Henderson wrote:
> The value previously chosen overlaps GUSA_MASK.
... which meant that we didn't translate the gusa sequence
into an atomic operation, which meant the multi-threaded tests fail.
>
> Cc: qemu-stable@nongnu.org
> Fixes: 4da06fb3062 ("target/sh4: Implement prctl_unalign_sigbus")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/856
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/sh4/cpu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/sh4/cpu.h b/target/sh4/cpu.h
> index 9f15ef913c..e79cbc59e2 100644
> --- a/target/sh4/cpu.h
> +++ b/target/sh4/cpu.h
> @@ -84,7 +84,7 @@
> #define DELAY_SLOT_RTE (1 << 2)
>
> #define TB_FLAG_PENDING_MOVCA (1 << 3)
> -#define TB_FLAG_UNALIGN (1 << 4)
> +#define TB_FLAG_UNALIGN (1 << 13)
>
> #define GUSA_SHIFT 4
> #ifdef CONFIG_USER_ONLY
next prev parent reply other threads:[~2022-08-29 2:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 2:13 [PATCH] target/sh4: Fix TB_FLAG_UNALIGN Richard Henderson
2022-08-29 2:16 ` Richard Henderson [this message]
2022-08-29 9:05 ` BALATON Zoltan
2022-08-29 16:10 ` Richard Henderson
2022-08-31 1:30 ` Yoshinori Sato
2022-08-31 16:55 ` Richard Henderson
2022-08-31 8:30 ` Yoshinori Sato
2022-08-31 16:56 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21a694b6-e0fc-f20a-9a8c-a8ea993504c6@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.