All of lore.kernel.org
 help / color / mirror / Atom feed
* [Regression] hangs caused by commit 3202fa62fb (slub: relocate freelist pointer to middle of object)
@ 2020-07-21 14:55 ` Paul Menzel
  0 siblings, 0 replies; 4+ messages in thread
From: Paul Menzel @ 2020-07-21 14:55 UTC (permalink / raw)
  To: Kees Cook, Andrew Morton
  Cc: LKML, amd-gfx, Duncan, Anthony Ruhier, Vinicius, Thorsten Leemhuis

Dear Kees, dear Andrew,


No idea, if you are aware of it yet, but three people verified that 
commit 3202fa62fb (slub: relocate freelist pointer to middle of object) 
causes a regression on AMD hardware [1].

It’d be great, if you took a look, and advised if this commit (and 
follow-ups) should be reverted, until the issue is analyzed.


Kind regards,

Paul


[1]: https://bugzilla.kernel.org/show_bug.cgi?id=207383
      "[Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail"

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Regression] hangs caused by commit 3202fa62fb (slub: relocate freelist pointer to middle of object)
@ 2020-07-21 14:55 ` Paul Menzel
  0 siblings, 0 replies; 4+ messages in thread
From: Paul Menzel @ 2020-07-21 14:55 UTC (permalink / raw)
  To: Kees Cook, Andrew Morton
  Cc: Anthony Ruhier, Duncan, LKML, amd-gfx, Thorsten Leemhuis, Vinicius

Dear Kees, dear Andrew,


No idea, if you are aware of it yet, but three people verified that 
commit 3202fa62fb (slub: relocate freelist pointer to middle of object) 
causes a regression on AMD hardware [1].

It’d be great, if you took a look, and advised if this commit (and 
follow-ups) should be reverted, until the issue is analyzed.


Kind regards,

Paul


[1]: https://bugzilla.kernel.org/show_bug.cgi?id=207383
      "[Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail"
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Regression] hangs caused by commit 3202fa62fb (slub: relocate freelist pointer to middle of object)
  2020-07-21 14:55 ` Paul Menzel
@ 2020-07-21 19:00   ` Kees Cook
  -1 siblings, 0 replies; 4+ messages in thread
From: Kees Cook @ 2020-07-21 19:00 UTC (permalink / raw)
  To: Paul Menzel
  Cc: Andrew Morton, LKML, amd-gfx, Duncan, Anthony Ruhier, Vinicius,
	Thorsten Leemhuis

On Tue, Jul 21, 2020 at 04:55:12PM +0200, Paul Menzel wrote:
> No idea, if you are aware of it yet, but three people verified that commit
> 3202fa62fb (slub: relocate freelist pointer to middle of object) causes a
> regression on AMD hardware [1].

Hi, thanks for emailing; I don't get bugzilla notifications, so I hadn't
seen this yet.

> It’d be great, if you took a look, and advised if this commit (and
> follow-ups) should be reverted, until the issue is analyzed.

There have been a number of fixes to that commit (which I see are
mentioned in a quick skim of the bug), but they've mostly been around
additional slab debugging features. If it's causing a problem outside
of that, my instinct would be there might be a use-after-free happening,
but I'll go read the bug more closely now, and comment there (or here,
if needed).

Thanks!

-- 
Kees Cook

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Regression] hangs caused by commit 3202fa62fb (slub: relocate freelist pointer to middle of object)
@ 2020-07-21 19:00   ` Kees Cook
  0 siblings, 0 replies; 4+ messages in thread
From: Kees Cook @ 2020-07-21 19:00 UTC (permalink / raw)
  To: Paul Menzel
  Cc: Anthony Ruhier, Duncan, LKML, amd-gfx, Thorsten Leemhuis,
	Andrew Morton, Vinicius

On Tue, Jul 21, 2020 at 04:55:12PM +0200, Paul Menzel wrote:
> No idea, if you are aware of it yet, but three people verified that commit
> 3202fa62fb (slub: relocate freelist pointer to middle of object) causes a
> regression on AMD hardware [1].

Hi, thanks for emailing; I don't get bugzilla notifications, so I hadn't
seen this yet.

> It’d be great, if you took a look, and advised if this commit (and
> follow-ups) should be reverted, until the issue is analyzed.

There have been a number of fixes to that commit (which I see are
mentioned in a quick skim of the bug), but they've mostly been around
additional slab debugging features. If it's causing a problem outside
of that, my instinct would be there might be a use-after-free happening,
but I'll go read the bug more closely now, and comment there (or here,
if needed).

Thanks!

-- 
Kees Cook
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-07-21 19:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 14:55 [Regression] hangs caused by commit 3202fa62fb (slub: relocate freelist pointer to middle of object) Paul Menzel
2020-07-21 14:55 ` Paul Menzel
2020-07-21 19:00 ` Kees Cook
2020-07-21 19:00   ` Kees Cook

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.