* [PATCH] Fix systemd version detection
@ 2019-04-04 22:03 Benjamin Marzinski
2019-04-04 22:06 ` Martin Wilck
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Marzinski @ 2019-04-04 22:03 UTC (permalink / raw)
To: Christophe Varoqui; +Cc: Igor Gnatenko, device-mapper development, Martin Wilck
From: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
---
Makefile.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.inc b/Makefile.inc
index fc728ca..5b2f6d4 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -37,7 +37,7 @@ endif
ifndef SYSTEMD
ifeq ($(shell systemctl --version > /dev/null 2>&1 && echo 1), 1)
- SYSTEMD = $(shell systemctl --version 2> /dev/null | sed -n 's/systemd \([0-9]*\)/\1/p')
+ SYSTEMD = $(shell systemctl --version 2> /dev/null | sed -n 's/systemd \([0-9]*\).*/\1/p')
endif
endif
--
2.17.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix systemd version detection
2019-04-04 22:03 [PATCH] Fix systemd version detection Benjamin Marzinski
@ 2019-04-04 22:06 ` Martin Wilck
2019-04-05 0:28 ` Benjamin Marzinski
0 siblings, 1 reply; 3+ messages in thread
From: Martin Wilck @ 2019-04-04 22:06 UTC (permalink / raw)
To: Benjamin Marzinski, Christophe Varoqui
Cc: Igor Gnatenko, development, device-mapper
Hi Ben,
On Thu, 2019-04-04 at 17:03 -0500, Benjamin Marzinski wrote:
> From: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
>
> Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
> Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
I'd submitted a different patch last month:
"multipath-tools: Build: properly parse systemd's version"
https://www.redhat.com/archives/dm-devel/2019-March/msg00057.html
Did you disagree with that one?
Martin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix systemd version detection
2019-04-04 22:06 ` Martin Wilck
@ 2019-04-05 0:28 ` Benjamin Marzinski
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Marzinski @ 2019-04-05 0:28 UTC (permalink / raw)
To: Martin Wilck; +Cc: Igor Gnatenko, device-mapper development
On Fri, Apr 05, 2019 at 12:06:49AM +0200, Martin Wilck wrote:
> Hi Ben,
>
> On Thu, 2019-04-04 at 17:03 -0500, Benjamin Marzinski wrote:
> > From: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
> >
> > Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
> > Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
>
> I'd submitted a different patch last month:
>
> "multipath-tools: Build: properly parse systemd's version"
> https://www.redhat.com/archives/dm-devel/2019-March/msg00057.html
>
> Did you disagree with that one?
Actually, I totally forgot about that one. It's fine.
-Ben
> Martin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-05 0:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-04 22:03 [PATCH] Fix systemd version detection Benjamin Marzinski
2019-04-04 22:06 ` Martin Wilck
2019-04-05 0:28 ` Benjamin Marzinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.