All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH V2 1/2] irqchip/imx-intmux: Use dev_err_probe() to simplify error handling
@ 2020-08-11  6:16 ` Anson Huang
  0 siblings, 0 replies; 9+ messages in thread
From: Anson Huang @ 2020-08-11  6:16 UTC (permalink / raw)
  To: tglx, jason, maz, shawnguo, s.hauer, kernel, festevam,
	linux-kernel, linux-arm-kernel
  Cc: Linux-imx

dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
changes since V1:
	- remove redundant return value print.
---
 drivers/irqchip/irq-imx-intmux.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/irqchip/irq-imx-intmux.c b/drivers/irqchip/irq-imx-intmux.c
index e35b7b0..7709f97 100644
--- a/drivers/irqchip/irq-imx-intmux.c
+++ b/drivers/irqchip/irq-imx-intmux.c
@@ -226,12 +226,9 @@ static int imx_intmux_probe(struct platform_device *pdev)
 	}
 
 	data->ipg_clk = devm_clk_get(&pdev->dev, "ipg");
-	if (IS_ERR(data->ipg_clk)) {
-		ret = PTR_ERR(data->ipg_clk);
-		if (ret != -EPROBE_DEFER)
-			dev_err(&pdev->dev, "failed to get ipg clk: %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(data->ipg_clk))
+		return dev_err_probe(&pdev->dev, PTR_ERR(data->ipg_clk),
+				     "failed to get ipg clk\n");
 
 	data->channum = channum;
 	raw_spin_lock_init(&data->lock);
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH V2 1/2] irqchip/imx-intmux: Use dev_err_probe() to simplify error handling
@ 2020-08-11  6:16 ` Anson Huang
  0 siblings, 0 replies; 9+ messages in thread
From: Anson Huang @ 2020-08-11  6:16 UTC (permalink / raw)
  To: tglx, jason, maz, shawnguo, s.hauer, kernel, festevam,
	linux-kernel, linux-arm-kernel
  Cc: Linux-imx

dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
changes since V1:
	- remove redundant return value print.
---
 drivers/irqchip/irq-imx-intmux.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/irqchip/irq-imx-intmux.c b/drivers/irqchip/irq-imx-intmux.c
index e35b7b0..7709f97 100644
--- a/drivers/irqchip/irq-imx-intmux.c
+++ b/drivers/irqchip/irq-imx-intmux.c
@@ -226,12 +226,9 @@ static int imx_intmux_probe(struct platform_device *pdev)
 	}
 
 	data->ipg_clk = devm_clk_get(&pdev->dev, "ipg");
-	if (IS_ERR(data->ipg_clk)) {
-		ret = PTR_ERR(data->ipg_clk);
-		if (ret != -EPROBE_DEFER)
-			dev_err(&pdev->dev, "failed to get ipg clk: %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(data->ipg_clk))
+		return dev_err_probe(&pdev->dev, PTR_ERR(data->ipg_clk),
+				     "failed to get ipg clk\n");
 
 	data->channum = channum;
 	raw_spin_lock_init(&data->lock);
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH V2 2/2] irqchip/imx-irqsteer: Use dev_err_probe() to simplify error handling
  2020-08-11  6:16 ` Anson Huang
@ 2020-08-11  6:16   ` Anson Huang
  -1 siblings, 0 replies; 9+ messages in thread
From: Anson Huang @ 2020-08-11  6:16 UTC (permalink / raw)
  To: tglx, jason, maz, shawnguo, s.hauer, kernel, festevam,
	linux-kernel, linux-arm-kernel
  Cc: Linux-imx

dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
changes since V1:
	- remove redundant return value print.
---
 drivers/irqchip/irq-imx-irqsteer.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c
index 290531e..1edf769 100644
--- a/drivers/irqchip/irq-imx-irqsteer.c
+++ b/drivers/irqchip/irq-imx-irqsteer.c
@@ -158,12 +158,9 @@ static int imx_irqsteer_probe(struct platform_device *pdev)
 	}
 
 	data->ipg_clk = devm_clk_get(&pdev->dev, "ipg");
-	if (IS_ERR(data->ipg_clk)) {
-		ret = PTR_ERR(data->ipg_clk);
-		if (ret != -EPROBE_DEFER)
-			dev_err(&pdev->dev, "failed to get ipg clk: %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(data->ipg_clk))
+		return dev_err_probe(&pdev->dev, PTR_ERR(data->ipg_clk),
+				     "failed to get ipg clk\n");
 
 	raw_spin_lock_init(&data->lock);
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH V2 2/2] irqchip/imx-irqsteer: Use dev_err_probe() to simplify error handling
@ 2020-08-11  6:16   ` Anson Huang
  0 siblings, 0 replies; 9+ messages in thread
From: Anson Huang @ 2020-08-11  6:16 UTC (permalink / raw)
  To: tglx, jason, maz, shawnguo, s.hauer, kernel, festevam,
	linux-kernel, linux-arm-kernel
  Cc: Linux-imx

dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
changes since V1:
	- remove redundant return value print.
---
 drivers/irqchip/irq-imx-irqsteer.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c
index 290531e..1edf769 100644
--- a/drivers/irqchip/irq-imx-irqsteer.c
+++ b/drivers/irqchip/irq-imx-irqsteer.c
@@ -158,12 +158,9 @@ static int imx_irqsteer_probe(struct platform_device *pdev)
 	}
 
 	data->ipg_clk = devm_clk_get(&pdev->dev, "ipg");
-	if (IS_ERR(data->ipg_clk)) {
-		ret = PTR_ERR(data->ipg_clk);
-		if (ret != -EPROBE_DEFER)
-			dev_err(&pdev->dev, "failed to get ipg clk: %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(data->ipg_clk))
+		return dev_err_probe(&pdev->dev, PTR_ERR(data->ipg_clk),
+				     "failed to get ipg clk\n");
 
 	raw_spin_lock_init(&data->lock);
 
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH V2 1/2] irqchip/imx-intmux: Use dev_err_probe() to simplify error handling
  2020-08-11  6:16 ` Anson Huang
  (?)
@ 2020-09-13 17:05   ` Marc Zyngier
  -1 siblings, 0 replies; 9+ messages in thread
From: Marc Zyngier @ 2020-09-13 17:05 UTC (permalink / raw)
  To: kvmarm, Alexandru Elisei, linux-kernel, linux-arm-kernel, kernel,
	jason, tglx, s.hauer, shawnguo, Anson Huang, festevam
  Cc: will, catalin.marinas, Linux-imx

On Tue, 11 Aug 2020 14:16:15 +0800, Anson Huang wrote:
> dev_err_probe() can reduce code size, uniform error handling and record the
> defer probe reason etc., use it to simplify the code.

Applied to irq/irqchip-next, thanks!

[1/2] irqchip/imx-intmux: Use dev_err_probe() to simplify error handling
      commit: c201f4325588a3b0109ba552a20bd4d4b1b5c6c8
[2/2] irqchip/imx-irqsteer: Use dev_err_probe() to simplify error handling
      commit: e0c45b107fc94c5a7a230b25cdbecab004ab1ed5

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.



^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH V2 1/2] irqchip/imx-intmux: Use dev_err_probe() to simplify error handling
@ 2020-09-13 17:05   ` Marc Zyngier
  0 siblings, 0 replies; 9+ messages in thread
From: Marc Zyngier @ 2020-09-13 17:05 UTC (permalink / raw)
  To: kvmarm, Alexandru Elisei, linux-kernel, linux-arm-kernel, kernel,
	jason, tglx, s.hauer, shawnguo, Anson Huang, festevam
  Cc: catalin.marinas, will, Linux-imx

On Tue, 11 Aug 2020 14:16:15 +0800, Anson Huang wrote:
> dev_err_probe() can reduce code size, uniform error handling and record the
> defer probe reason etc., use it to simplify the code.

Applied to irq/irqchip-next, thanks!

[1/2] irqchip/imx-intmux: Use dev_err_probe() to simplify error handling
      commit: c201f4325588a3b0109ba552a20bd4d4b1b5c6c8
[2/2] irqchip/imx-irqsteer: Use dev_err_probe() to simplify error handling
      commit: e0c45b107fc94c5a7a230b25cdbecab004ab1ed5

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.


_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH V2 1/2] irqchip/imx-intmux: Use dev_err_probe() to simplify error handling
@ 2020-09-13 17:05   ` Marc Zyngier
  0 siblings, 0 replies; 9+ messages in thread
From: Marc Zyngier @ 2020-09-13 17:05 UTC (permalink / raw)
  To: kvmarm, Alexandru Elisei, linux-kernel, linux-arm-kernel, kernel,
	jason, tglx, s.hauer, shawnguo, Anson Huang, festevam
  Cc: catalin.marinas, will, Linux-imx

On Tue, 11 Aug 2020 14:16:15 +0800, Anson Huang wrote:
> dev_err_probe() can reduce code size, uniform error handling and record the
> defer probe reason etc., use it to simplify the code.

Applied to irq/irqchip-next, thanks!

[1/2] irqchip/imx-intmux: Use dev_err_probe() to simplify error handling
      commit: c201f4325588a3b0109ba552a20bd4d4b1b5c6c8
[2/2] irqchip/imx-irqsteer: Use dev_err_probe() to simplify error handling
      commit: e0c45b107fc94c5a7a230b25cdbecab004ab1ed5

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [tip: irq/core] irqchip/imx-irqsteer: Use dev_err_probe() to simplify error handling
  2020-08-11  6:16   ` Anson Huang
  (?)
@ 2020-10-11 17:57   ` tip-bot2 for Anson Huang
  -1 siblings, 0 replies; 9+ messages in thread
From: tip-bot2 for Anson Huang @ 2020-10-11 17:57 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: Anson Huang, Marc Zyngier, x86, LKML

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     e0c45b107fc94c5a7a230b25cdbecab004ab1ed5
Gitweb:        https://git.kernel.org/tip/e0c45b107fc94c5a7a230b25cdbecab004ab1ed5
Author:        Anson Huang <Anson.Huang@nxp.com>
AuthorDate:    Tue, 11 Aug 2020 14:16:16 +08:00
Committer:     Marc Zyngier <maz@kernel.org>
CommitterDate: Sun, 13 Sep 2020 17:38:52 +01:00

irqchip/imx-irqsteer: Use dev_err_probe() to simplify error handling

dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/1597126576-18383-2-git-send-email-Anson.Huang@nxp.com
---
 drivers/irqchip/irq-imx-irqsteer.c |  9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c
index 290531e..1edf769 100644
--- a/drivers/irqchip/irq-imx-irqsteer.c
+++ b/drivers/irqchip/irq-imx-irqsteer.c
@@ -158,12 +158,9 @@ static int imx_irqsteer_probe(struct platform_device *pdev)
 	}
 
 	data->ipg_clk = devm_clk_get(&pdev->dev, "ipg");
-	if (IS_ERR(data->ipg_clk)) {
-		ret = PTR_ERR(data->ipg_clk);
-		if (ret != -EPROBE_DEFER)
-			dev_err(&pdev->dev, "failed to get ipg clk: %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(data->ipg_clk))
+		return dev_err_probe(&pdev->dev, PTR_ERR(data->ipg_clk),
+				     "failed to get ipg clk\n");
 
 	raw_spin_lock_init(&data->lock);
 

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [tip: irq/core] irqchip/imx-intmux: Use dev_err_probe() to simplify error handling
  2020-08-11  6:16 ` Anson Huang
                   ` (2 preceding siblings ...)
  (?)
@ 2020-10-11 17:57 ` tip-bot2 for Anson Huang
  -1 siblings, 0 replies; 9+ messages in thread
From: tip-bot2 for Anson Huang @ 2020-10-11 17:57 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: Anson Huang, Marc Zyngier, x86, LKML

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     c201f4325588a3b0109ba552a20bd4d4b1b5c6c8
Gitweb:        https://git.kernel.org/tip/c201f4325588a3b0109ba552a20bd4d4b1b5c6c8
Author:        Anson Huang <Anson.Huang@nxp.com>
AuthorDate:    Tue, 11 Aug 2020 14:16:15 +08:00
Committer:     Marc Zyngier <maz@kernel.org>
CommitterDate: Sun, 13 Sep 2020 17:38:52 +01:00

irqchip/imx-intmux: Use dev_err_probe() to simplify error handling

dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/1597126576-18383-1-git-send-email-Anson.Huang@nxp.com
---
 drivers/irqchip/irq-imx-intmux.c |  9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/irqchip/irq-imx-intmux.c b/drivers/irqchip/irq-imx-intmux.c
index e35b7b0..7709f97 100644
--- a/drivers/irqchip/irq-imx-intmux.c
+++ b/drivers/irqchip/irq-imx-intmux.c
@@ -226,12 +226,9 @@ static int imx_intmux_probe(struct platform_device *pdev)
 	}
 
 	data->ipg_clk = devm_clk_get(&pdev->dev, "ipg");
-	if (IS_ERR(data->ipg_clk)) {
-		ret = PTR_ERR(data->ipg_clk);
-		if (ret != -EPROBE_DEFER)
-			dev_err(&pdev->dev, "failed to get ipg clk: %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(data->ipg_clk))
+		return dev_err_probe(&pdev->dev, PTR_ERR(data->ipg_clk),
+				     "failed to get ipg clk\n");
 
 	data->channum = channum;
 	raw_spin_lock_init(&data->lock);

^ permalink raw reply related	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-10-11 17:59 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-11  6:16 [PATCH V2 1/2] irqchip/imx-intmux: Use dev_err_probe() to simplify error handling Anson Huang
2020-08-11  6:16 ` Anson Huang
2020-08-11  6:16 ` [PATCH V2 2/2] irqchip/imx-irqsteer: " Anson Huang
2020-08-11  6:16   ` Anson Huang
2020-10-11 17:57   ` [tip: irq/core] " tip-bot2 for Anson Huang
2020-09-13 17:05 ` [PATCH V2 1/2] irqchip/imx-intmux: " Marc Zyngier
2020-09-13 17:05   ` Marc Zyngier
2020-09-13 17:05   ` Marc Zyngier
2020-10-11 17:57 ` [tip: irq/core] " tip-bot2 for Anson Huang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.