* [Intel-gfx] [CI 1/3] drm/i915/gem: Avoid implicit vmap for highmem on x86-32
@ 2020-09-15 9:14 Chris Wilson
2020-09-15 9:14 ` [Intel-gfx] [CI 2/3] drm/i915/gem: Prevent using pgprot_writecombine() if PAT is not supported Chris Wilson
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Chris Wilson @ 2020-09-15 9:14 UTC (permalink / raw)
To: intel-gfx
On 32b, highmem using a finite set of indirect PTE (i.e. vmap) to provide
virtual mappings of the high pages. As these are finite, map_new_virtual()
must wait for some other kmap() to finish when it runs out. If we map a
large number of objects, there is no method for it to tell us to release
the mappings, and we deadlock.
However, if we make an explicit vmap of the page, that uses a larger
vmalloc arena, and also has the ability to tell us to release unwanted
mappings. Most importantly, it will fail and propagate an error instead
of waiting forever.
Fixes: fb8621d3bee8 ("drm/i915: Avoid allocating a vmap arena for a single page") #x86-32
References: e87666b52f00 ("drm/i915/shrinker: Hook up vmap allocation failure notifier")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Cc: <stable@vger.kernel.org> # v4.7+
---
drivers/gpu/drm/i915/gem/i915_gem_pages.c | 26 +++++++++++++++++++++--
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
index e8a083743e09..49ce5777c511 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
@@ -255,8 +255,30 @@ static void *i915_gem_object_map(struct drm_i915_gem_object *obj,
return NULL;
/* A single page can always be kmapped */
- if (n_pte == 1 && type == I915_MAP_WB)
- return kmap(sg_page(sgt->sgl));
+ if (n_pte == 1 && type == I915_MAP_WB) {
+ struct page *page = sg_page(sgt->sgl);
+
+ /*
+ * On 32b, highmem using a finite set of indirect PTE (i.e.
+ * vmap) to provide virtual mappings of the high pages.
+ * As these are finite, map_new_virtual() must wait for some
+ * other kmap() to finish when it runs out. If we map a large
+ * number of objects, there is no method for it to tell us
+ * to release the mappings, and we deadlock.
+ *
+ * However, if we make an explicit vmap of the page, that
+ * uses a larger vmalloc arena, and also has the ability
+ * to tell us to release unwanted mappings. Most importantly,
+ * it will fail and propagate an error instead of waiting
+ * forever.
+ *
+ * So if the page is beyond the 32b boundary, make an explicit
+ * vmap. On 64b, this check will be optimised away as we can
+ * directly kmap any page on the system.
+ */
+ if (!PageHighMem(page))
+ return kmap(page);
+ }
mem = stack;
if (n_pte > ARRAY_SIZE(stack)) {
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] [CI 2/3] drm/i915/gem: Prevent using pgprot_writecombine() if PAT is not supported
2020-09-15 9:14 [Intel-gfx] [CI 1/3] drm/i915/gem: Avoid implicit vmap for highmem on x86-32 Chris Wilson
@ 2020-09-15 9:14 ` Chris Wilson
2020-09-15 9:14 ` [Intel-gfx] [CI 3/3] drm/i915/gt: Clear the buffer pool age before use Chris Wilson
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2020-09-15 9:14 UTC (permalink / raw)
To: intel-gfx
Let's not try and use PAT attributes for I915_MAP_WC if the CPU doesn't
support PAT.
Fixes: 6056e50033d9 ("drm/i915/gem: Support discontiguous lmem object maps")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Cc: <stable@vger.kernel.org> # v5.6+
---
drivers/gpu/drm/i915/gem/i915_gem_pages.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
index 49ce5777c511..d6eeefab3d01 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
@@ -254,6 +254,10 @@ static void *i915_gem_object_map(struct drm_i915_gem_object *obj,
if (!i915_gem_object_has_struct_page(obj) && type != I915_MAP_WC)
return NULL;
+ if (GEM_WARN_ON(type == I915_MAP_WC &&
+ !static_cpu_has(X86_FEATURE_PAT)))
+ return NULL;
+
/* A single page can always be kmapped */
if (n_pte == 1 && type == I915_MAP_WB) {
struct page *page = sg_page(sgt->sgl);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] [CI 3/3] drm/i915/gt: Clear the buffer pool age before use
2020-09-15 9:14 [Intel-gfx] [CI 1/3] drm/i915/gem: Avoid implicit vmap for highmem on x86-32 Chris Wilson
2020-09-15 9:14 ` [Intel-gfx] [CI 2/3] drm/i915/gem: Prevent using pgprot_writecombine() if PAT is not supported Chris Wilson
@ 2020-09-15 9:14 ` Chris Wilson
2020-09-15 9:34 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/3] drm/i915/gem: Avoid implicit vmap for highmem on x86-32 Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2020-09-15 9:14 UTC (permalink / raw)
To: intel-gfx
If we create a new node, it is possible for the slab allocator to return
us a recently freed node. If that node was just retired, it will retain
the current jiffy as its node->age. There is then a miniscule window,
where as that node is retired, it will appear on the free list with an
incorrect age and be eligible for reuse by one thread, and then by a
second thread as the correct node->age is written.
Fixes: 8080ffd81600 ("drm/i915/gt: Delay taking the spinlock for grabbing from the buffer pool")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c b/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c
index 4b7671ac5dca..104cb30e8c13 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c
@@ -134,6 +134,7 @@ static void pool_retire(struct i915_active *ref)
/* Return this object to the shrinker pool */
i915_gem_object_make_purgeable(node->obj);
+ GEM_BUG_ON(node->age);
spin_lock_irqsave(&pool->lock, flags);
list_add_rcu(&node->link, list);
WRITE_ONCE(node->age, jiffies ?: 1); /* 0 reserved for active nodes */
@@ -155,6 +156,7 @@ node_create(struct intel_gt_buffer_pool *pool, size_t sz)
if (!node)
return ERR_PTR(-ENOMEM);
+ node->age = 0;
node->pool = pool;
i915_active_init(&node->active, pool_active, pool_retire);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/3] drm/i915/gem: Avoid implicit vmap for highmem on x86-32
2020-09-15 9:14 [Intel-gfx] [CI 1/3] drm/i915/gem: Avoid implicit vmap for highmem on x86-32 Chris Wilson
2020-09-15 9:14 ` [Intel-gfx] [CI 2/3] drm/i915/gem: Prevent using pgprot_writecombine() if PAT is not supported Chris Wilson
2020-09-15 9:14 ` [Intel-gfx] [CI 3/3] drm/i915/gt: Clear the buffer pool age before use Chris Wilson
@ 2020-09-15 9:34 ` Patchwork
2020-09-15 10:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-09-15 11:34 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-09-15 9:34 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [CI,1/3] drm/i915/gem: Avoid implicit vmap for highmem on x86-32
URL : https://patchwork.freedesktop.org/series/81682/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
19c64629256b drm/i915/gem: Avoid implicit vmap for highmem on x86-32
-:18: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#18:
References: e87666b52f00 ("drm/i915/shrinker: Hook up vmap allocation failure notifier")
-:18: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit e87666b52f00 ("drm/i915/shrinker: Hook up vmap allocation failure notifier")'
#18:
References: e87666b52f00 ("drm/i915/shrinker: Hook up vmap allocation failure notifier")
total: 1 errors, 1 warnings, 0 checks, 32 lines checked
957070151f2f drm/i915/gem: Prevent using pgprot_writecombine() if PAT is not supported
b1bfb2b6d79a drm/i915/gt: Clear the buffer pool age before use
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/3] drm/i915/gem: Avoid implicit vmap for highmem on x86-32
2020-09-15 9:14 [Intel-gfx] [CI 1/3] drm/i915/gem: Avoid implicit vmap for highmem on x86-32 Chris Wilson
` (2 preceding siblings ...)
2020-09-15 9:34 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/3] drm/i915/gem: Avoid implicit vmap for highmem on x86-32 Patchwork
@ 2020-09-15 10:05 ` Patchwork
2020-09-15 11:34 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-09-15 10:05 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 9244 bytes --]
== Series Details ==
Series: series starting with [CI,1/3] drm/i915/gem: Avoid implicit vmap for highmem on x86-32
URL : https://patchwork.freedesktop.org/series/81682/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9008 -> Patchwork_18498
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/index.html
Known issues
------------
Here are the changes found in Patchwork_18498 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_flink_basic@flink-lifetime:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#402]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/fi-tgl-y/igt@gem_flink_basic@flink-lifetime.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/fi-tgl-y/igt@gem_flink_basic@flink-lifetime.html
* igt@i915_selftest@live@execlists:
- fi-tgl-y: [PASS][3] -> [INCOMPLETE][4] ([i915#2268])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/fi-tgl-y/igt@i915_selftest@live@execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/fi-tgl-y/igt@i915_selftest@live@execlists.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-kefka: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
- fi-icl-u2: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- fi-tgl-y: [PASS][9] -> [DMESG-WARN][10] ([i915#1982]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/fi-tgl-y/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/fi-tgl-y/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
#### Possible fixes ####
* {igt@core_hotunplug@unbind-rebind}:
- {fi-tgl-dsi}: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/fi-tgl-dsi/igt@core_hotunplug@unbind-rebind.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/fi-tgl-dsi/igt@core_hotunplug@unbind-rebind.html
* igt@gem_flink_basic@double-flink:
- fi-tgl-y: [DMESG-WARN][13] ([i915#402]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/fi-tgl-y/igt@gem_flink_basic@double-flink.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/fi-tgl-y/igt@gem_flink_basic@double-flink.html
* igt@i915_module_load@reload:
- fi-byt-j1900: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/fi-byt-j1900/igt@i915_module_load@reload.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/fi-byt-j1900/igt@i915_module_load@reload.html
- fi-tgl-u2: [DMESG-WARN][17] ([i915#1982] / [k.org#205379]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/fi-tgl-u2/igt@i915_module_load@reload.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/fi-tgl-u2/igt@i915_module_load@reload.html
* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [DMESG-WARN][19] ([i915#62] / [i915#92] / [i915#95]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/fi-kbl-x1275/igt@kms_busy@basic@flip.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/fi-kbl-x1275/igt@kms_busy@basic@flip.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:
- fi-icl-u2: [DMESG-WARN][21] ([i915#1982]) -> [PASS][22] +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
* igt@vgem_basic@unload:
- fi-skl-guc: [DMESG-WARN][23] ([i915#2203]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/fi-skl-guc/igt@vgem_basic@unload.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/fi-skl-guc/igt@vgem_basic@unload.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][25] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][26] ([i915#1982] / [i915#62] / [i915#92])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-tgl-y: [DMESG-WARN][27] ([i915#2411]) -> [DMESG-WARN][28] ([i915#1982] / [i915#2411])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/fi-tgl-y/igt@i915_pm_rpm@basic-pci-d3-state.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/fi-tgl-y/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_pm_rpm@module-reload:
- fi-tgl-y: [DMESG-WARN][29] ([i915#1982] / [i915#2411]) -> [DMESG-WARN][30] ([i915#2411])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/fi-tgl-y/igt@i915_pm_rpm@module-reload.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/fi-tgl-y/igt@i915_pm_rpm@module-reload.html
- fi-kbl-x1275: [DMESG-FAIL][31] ([i915#62]) -> [DMESG-FAIL][32] ([i915#62] / [i915#95])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
- fi-kbl-guc: [DMESG-WARN][33] ([i915#2203]) -> [DMESG-FAIL][34] ([i915#2203])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html
* igt@kms_force_connector_basic@force-connector-state:
- fi-kbl-x1275: [DMESG-WARN][35] ([i915#62] / [i915#92]) -> [DMESG-WARN][36] ([i915#62] / [i915#92] / [i915#95]) +4 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/fi-kbl-x1275/igt@kms_force_connector_basic@force-connector-state.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/fi-kbl-x1275/igt@kms_force_connector_basic@force-connector-state.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-kbl-x1275: [DMESG-WARN][37] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][38] ([i915#62] / [i915#92]) +8 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/fi-kbl-x1275/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/fi-kbl-x1275/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#2268]: https://gitlab.freedesktop.org/drm/intel/issues/2268
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379
Participating hosts (45 -> 41)
------------------------------
Additional (2): fi-bwr-2160 fi-snb-2600
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9008 -> Patchwork_18498
CI-20190529: 20190529
CI_DRM_9008: 14dc141acc195be5b1d0ffb563c5c0a277569715 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5784: 265f1d4a5a14998b98f963ee04d695cf3f3c2d3a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18498: b1bfb2b6d79a051ba91b295c3d32ea977ef93095 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b1bfb2b6d79a drm/i915/gt: Clear the buffer pool age before use
957070151f2f drm/i915/gem: Prevent using pgprot_writecombine() if PAT is not supported
19c64629256b drm/i915/gem: Avoid implicit vmap for highmem on x86-32
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/index.html
[-- Attachment #1.2: Type: text/html, Size: 12464 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/3] drm/i915/gem: Avoid implicit vmap for highmem on x86-32
2020-09-15 9:14 [Intel-gfx] [CI 1/3] drm/i915/gem: Avoid implicit vmap for highmem on x86-32 Chris Wilson
` (3 preceding siblings ...)
2020-09-15 10:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2020-09-15 11:34 ` Patchwork
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-09-15 11:34 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 14100 bytes --]
== Series Details ==
Series: series starting with [CI,1/3] drm/i915/gem: Avoid implicit vmap for highmem on x86-32
URL : https://patchwork.freedesktop.org/series/81682/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9008_full -> Patchwork_18498_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18498_full:
### Piglit changes ###
#### Possible regressions ####
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-int_ivec3_array3-position-double_dvec2 (NEW):
- {pig-icl-1065g7}: NOTRUN -> [INCOMPLETE][1] +6 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/pig-icl-1065g7/spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-int_ivec3_array3-position-double_dvec2.html
New tests
---------
New tests have been introduced between CI_DRM_9008_full and Patchwork_18498_full:
### New Piglit tests (7) ###
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-double_dmat4x2-float_float_array3-position:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-float_mat2x3_array3-position-double_dvec3:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-int_ivec3_array3-double_dvec4-position:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-int_ivec3_array3-position-double_dvec2:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-position-double_dmat4-double_dvec3:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-position-double_dmat4x3-float_mat3:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-position-double_dmat4x3-int_ivec2_array3:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18498_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][2] -> [SKIP][3] ([i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-tglb1/igt@gem_huc_copy@huc-copy.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-tglb6/igt@gem_huc_copy@huc-copy.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- shard-kbl: [PASS][4] -> [DMESG-WARN][5] ([i915#1982])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-kbl6/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-kbl6/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [PASS][6] -> [FAIL][7] ([i915#96])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-hsw8/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
* igt@kms_flip@2x-busy-flip@ab-vga1-hdmi-a1:
- shard-hsw: [PASS][8] -> [DMESG-WARN][9] ([i915#1982])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-hsw1/igt@kms_flip@2x-busy-flip@ab-vga1-hdmi-a1.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-hsw6/igt@kms_flip@2x-busy-flip@ab-vga1-hdmi-a1.html
* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-skl: [PASS][10] -> [FAIL][11] ([i915#79])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-skl4/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-skl4/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-skl: [PASS][12] -> [DMESG-WARN][13] ([i915#1982]) +8 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-skl7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-skl7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-kbl: [PASS][14] -> [DMESG-WARN][15] ([i915#180]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][16] -> [SKIP][17] ([fdo#109441]) +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-iclb2/igt@kms_psr@psr2_basic.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-iclb5/igt@kms_psr@psr2_basic.html
* igt@perf_pmu@module-unload:
- shard-apl: [PASS][18] -> [DMESG-WARN][19] ([i915#1635] / [i915#1982])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-apl8/igt@perf_pmu@module-unload.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-apl7/igt@perf_pmu@module-unload.html
#### Possible fixes ####
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-hsw: [FAIL][20] ([i915#2389]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-hsw1/igt@gem_exec_reloc@basic-many-active@rcs0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-hsw6/igt@gem_exec_reloc@basic-many-active@rcs0.html
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: [INCOMPLETE][22] ([i915#155]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-kbl6/igt@gem_exec_suspend@basic-s3.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-kbl7/igt@gem_exec_suspend@basic-s3.html
* igt@i915_pm_dc@dc5-psr:
- shard-skl: [INCOMPLETE][24] ([i915#198]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-skl8/igt@i915_pm_dc@dc5-psr.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-skl7/igt@i915_pm_dc@dc5-psr.html
* igt@i915_pm_sseu@full-enable:
- shard-glk: [FAIL][26] -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-glk8/igt@i915_pm_sseu@full-enable.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-glk1/igt@i915_pm_sseu@full-enable.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-0:
- shard-iclb: [DMESG-WARN][28] ([i915#1982]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-iclb3/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-iclb4/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- shard-apl: [DMESG-WARN][30] ([i915#1635] / [i915#1982]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-apl6/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-apl1/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: [FAIL][32] ([i915#96]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-hsw4/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-skl: [FAIL][34] ([i915#2346]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-skl5/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_flip@2x-dpms-vs-vblank-race@ab-hdmi-a1-hdmi-a2:
- shard-glk: [DMESG-WARN][36] ([i915#1982]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-glk6/igt@kms_flip@2x-dpms-vs-vblank-race@ab-hdmi-a1-hdmi-a2.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-glk6/igt@kms_flip@2x-dpms-vs-vblank-race@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [FAIL][38] ([i915#2122]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-skl3/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-skl6/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
- shard-kbl: [DMESG-WARN][40] ([i915#1982]) -> [PASS][41] +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-shrfb-scaledprimary:
- shard-tglb: [DMESG-WARN][42] ([i915#1982]) -> [PASS][43] +2 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-shrfb-scaledprimary.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-shrfb-scaledprimary.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][44] ([i915#1188]) -> [PASS][45] +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-skl3/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [DMESG-WARN][46] ([i915#180]) -> [PASS][47] +2 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-kbl2/igt@kms_hdr@bpc-switch-suspend.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-kbl6/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][48] ([fdo#108145] / [i915#265]) -> [PASS][49] +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr@psr2_dpms:
- shard-iclb: [SKIP][50] ([fdo#109441]) -> [PASS][51] +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-iclb1/igt@kms_psr@psr2_dpms.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-iclb2/igt@kms_psr@psr2_dpms.html
* igt@perf@blocking:
- shard-skl: [FAIL][52] ([i915#1542]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-skl9/igt@perf@blocking.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-skl5/igt@perf@blocking.html
* igt@prime_busy@hang-wait@vecs0:
- shard-skl: [DMESG-WARN][54] ([i915#1982]) -> [PASS][55] +7 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-skl4/igt@prime_busy@hang-wait@vecs0.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/shard-skl4/igt@prime_busy@hang-wait@vecs0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9008 -> Patchwork_18498
CI-20190529: 20190529
CI_DRM_9008: 14dc141acc195be5b1d0ffb563c5c0a277569715 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5784: 265f1d4a5a14998b98f963ee04d695cf3f3c2d3a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18498: b1bfb2b6d79a051ba91b295c3d32ea977ef93095 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18498/index.html
[-- Attachment #1.2: Type: text/html, Size: 16485 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-15 11:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15 9:14 [Intel-gfx] [CI 1/3] drm/i915/gem: Avoid implicit vmap for highmem on x86-32 Chris Wilson
2020-09-15 9:14 ` [Intel-gfx] [CI 2/3] drm/i915/gem: Prevent using pgprot_writecombine() if PAT is not supported Chris Wilson
2020-09-15 9:14 ` [Intel-gfx] [CI 3/3] drm/i915/gt: Clear the buffer pool age before use Chris Wilson
2020-09-15 9:34 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/3] drm/i915/gem: Avoid implicit vmap for highmem on x86-32 Patchwork
2020-09-15 10:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-09-15 11:34 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.