* [PATCH] Input: elants_i2c - fix typo for an attribute to show calibration count
@ 2020-09-16 6:46 Johnny Chuang
2020-09-16 18:03 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Johnny Chuang @ 2020-09-16 6:46 UTC (permalink / raw)
To: Dmitry Torokhov, Benjamin Tissoires, Peter Hutterer,
linux-kernel, linux-input, Harry Cutts, Johnny Chuang
Cc: James Chen, Jennifer Tsai, Paul Liang, Jeff Chuang
Fixed typo for command from 0xE0 to 0xD0.
commit cf520c643012 ("Input: elants_i2c - provide an attribute
to show calibration count")
There is an non-touch case by non-calibration after update firmware.
Elan could know calibrate or not by calibration count.
The value of '0xffff' means we didn't calibrate after update firmware.
If calibrate success, it will plus one and change to '0x0000'.
Signed-off-by: Johnny Chuang <johnny.chuang.emc@gmail.com>
---
drivers/input/touchscreen/elants_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
index c8d7bdd..50c3482 100644
--- a/drivers/input/touchscreen/elants_i2c.c
+++ b/drivers/input/touchscreen/elants_i2c.c
@@ -90,7 +90,7 @@
/* FW read command, 0x53 0x?? 0x0, 0x01 */
#define E_ELAN_INFO_FW_VER 0x00
#define E_ELAN_INFO_BC_VER 0x10
-#define E_ELAN_INFO_REK 0xE0
+#define E_ELAN_INFO_REK 0xD0
#define E_ELAN_INFO_TEST_VER 0xE0
#define E_ELAN_INFO_FW_ID 0xF0
#define E_INFO_OSR 0xD6
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: elants_i2c - fix typo for an attribute to show calibration count
2020-09-16 6:46 [PATCH] Input: elants_i2c - fix typo for an attribute to show calibration count Johnny Chuang
@ 2020-09-16 18:03 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2020-09-16 18:03 UTC (permalink / raw)
To: Johnny Chuang
Cc: Benjamin Tissoires, Peter Hutterer, linux-kernel, linux-input,
Harry Cutts, Johnny Chuang, James Chen, Jennifer Tsai,
Paul Liang, Jeff Chuang
On Wed, Sep 16, 2020 at 02:46:23PM +0800, Johnny Chuang wrote:
> Fixed typo for command from 0xE0 to 0xD0.
>
> commit cf520c643012 ("Input: elants_i2c - provide an attribute
> to show calibration count")
>
> There is an non-touch case by non-calibration after update firmware.
> Elan could know calibrate or not by calibration count.
> The value of '0xffff' means we didn't calibrate after update firmware.
> If calibrate success, it will plus one and change to '0x0000'.
>
> Signed-off-by: Johnny Chuang <johnny.chuang.emc@gmail.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-16 18:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16 6:46 [PATCH] Input: elants_i2c - fix typo for an attribute to show calibration count Johnny Chuang
2020-09-16 18:03 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.