All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler
@ 2020-09-21  3:50 Zbigniew Kempczyński
  2020-09-21  3:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 8+ messages in thread
From: Zbigniew Kempczyński @ 2020-09-21  3:50 UTC (permalink / raw)
  To: intel-gfx; +Cc: Chris Wilson

On !llc platforms when buffer is mapped with WB using GEM_MMAP_OFFSET
pagefault handler clears its dirty flag. This has consequences
buffer is not flushed on exec before moving to render domain.
So make sure we keep dirty flag for buffers mapped to write until
it leaves cpu domain.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gem/i915_gem_mman.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
index 3d69e51f3e4d..3f61a5ccbdd5 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
@@ -239,6 +239,7 @@ static vm_fault_t vm_fault_cpu(struct vm_fault *vmf)
 	struct i915_mmap_offset *mmo = area->vm_private_data;
 	struct drm_i915_gem_object *obj = mmo->obj;
 	resource_size_t iomap;
+	u16 prev_write_domain;
 	int err;
 
 	/* Sanity check that we allow writing into this object */
@@ -246,6 +247,8 @@ static vm_fault_t vm_fault_cpu(struct vm_fault *vmf)
 		     area->vm_flags & VM_WRITE))
 		return VM_FAULT_SIGBUS;
 
+	prev_write_domain = obj->write_domain;
+
 	err = i915_gem_object_pin_pages(obj);
 	if (err)
 		goto out;
@@ -268,6 +271,10 @@ static vm_fault_t vm_fault_cpu(struct vm_fault *vmf)
 
 	i915_gem_object_unpin_pages(obj);
 
+	/* On !llc we need to flush before moving to render domain */
+	if (!obj->cache_coherent && prev_write_domain == I915_GEM_DOMAIN_CPU)
+		obj->cache_dirty = true;
+
 out:
 	return i915_error_to_vmf_fault(err);
 }
-- 
2.26.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-09-21  8:54 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21  3:50 [Intel-gfx] [PATCH] drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler Zbigniew Kempczyński
2020-09-21  3:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-09-21  4:22 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-09-21  5:20 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler (rev2) Patchwork
2020-09-21  5:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-09-21  6:55 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-09-21  7:21   ` Zbigniew Kempczyński
2020-09-21  8:54 ` [Intel-gfx] [PATCH] drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler Chris Wilson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.