* [PATCH -next] clk: qcom: Remove set but not used variable
@ 2020-09-22 11:21 Li Heng
0 siblings, 0 replies; 3+ messages in thread
From: Li Heng @ 2020-09-22 11:21 UTC (permalink / raw)
To: agross, bjorn.andersson, mturquette, sboyd
Cc: linux-arm-msm, linux-clk, linux-kernel
This addresses the following gcc warning with "make W=1":
drivers/clk/qcom/gcc-sdm660.c:52:32:warning:
‘gcc_parent_map_xo_gpll0’ defined but not used [-Wunused-const-variable=]
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Li Heng <liheng40@huawei.com>
---
drivers/clk/qcom/gcc-sdm660.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/clk/qcom/gcc-sdm660.c b/drivers/clk/qcom/gcc-sdm660.c
index f0b47b7..db0fb7e 100644
--- a/drivers/clk/qcom/gcc-sdm660.c
+++ b/drivers/clk/qcom/gcc-sdm660.c
@@ -49,11 +49,6 @@ static const char * const gcc_parent_names_xo_gpll0_gpll0_early_div[] = {
"gpll0_early_div",
};
-static const struct parent_map gcc_parent_map_xo_gpll0[] = {
- { P_XO, 0 },
- { P_GPLL0, 1 },
-};
-
static const char * const gcc_parent_names_xo_gpll0[] = {
"xo",
"gpll0",
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] clk: qcom: Remove set but not used variable
2020-09-22 12:30 ` Konrad Dybcio
@ 2020-09-22 12:36 ` Konrad Dybcio
0 siblings, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2020-09-22 12:36 UTC (permalink / raw)
To: Li Heng, Andy Gross, Bjorn Andersson, mturquette, sboyd
Cc: linux-arm-msm, linux-clk, lkml
Hi,
This is not the correct solution. I sent a proper fix here [1].
Please do not modify critical platform drivers without having tested them on real hardware (I don't see any Tested-by's?). Instead, file a bug report so that more people can take a look at this. If this got merged, it would have had to be reverted eventually anyway..
[1] https://patchwork.kernel.org/patch/11792407/
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] clk: qcom: Remove set but not used variable
[not found] <1600773678-46320-1-git-send-email-liheng40 () huawei ! com>
@ 2020-09-22 12:30 ` Konrad Dybcio
2020-09-22 12:36 ` Konrad Dybcio
0 siblings, 1 reply; 3+ messages in thread
From: Konrad Dybcio @ 2020-09-22 12:30 UTC (permalink / raw)
To: Li Heng, agross; +Cc: linux-arm-msm
Hi,
This is not the correct solution. I sent a proper fix here [1].
Please do not modify critical platform drivers without having tested them on real hardware (I don't see any Tested-by's?). Instead, file a bug report so that more people can take a look at this. If this got merged, it would have had to be reverted eventually anyway..
[1] https://patchwork.kernel.org/patch/11792407/
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-22 12:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-22 11:21 [PATCH -next] clk: qcom: Remove set but not used variable Li Heng
[not found] <1600773678-46320-1-git-send-email-liheng40 () huawei ! com>
2020-09-22 12:30 ` Konrad Dybcio
2020-09-22 12:36 ` Konrad Dybcio
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.