All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] locking/atomics: Check atomic-arch-fallback.h too
@ 2020-10-01 20:20 Paul Bolle
  2020-10-02 13:00 ` Mark Rutland
  2020-10-07 16:20 ` [tip: locking/core] " tip-bot2 for Paul Bolle
  0 siblings, 2 replies; 3+ messages in thread
From: Paul Bolle @ 2020-10-01 20:20 UTC (permalink / raw)
  To: Will Deacon, Peter Zijlstra, Boqun Feng; +Cc: linux-kernel

The sha1sum of include/linux/atomic-arch-fallback.h isn't checked by
check-atomics.sh. It's not clear why it's skipped so let's check it too.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
It seems it never has been checked. So this does cast some doubt about
the usefulness of these tests. But I'm clueless about this atomic stuff
so what do I know?

 scripts/atomic/check-atomics.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/atomic/check-atomics.sh b/scripts/atomic/check-atomics.sh
index 8378c63a1e09..82748d42ecc5 100755
--- a/scripts/atomic/check-atomics.sh
+++ b/scripts/atomic/check-atomics.sh
@@ -16,6 +16,7 @@ fi
 cat <<EOF |
 asm-generic/atomic-instrumented.h
 asm-generic/atomic-long.h
+linux/atomic-arch-fallback.h
 linux/atomic-fallback.h
 EOF
 while read header; do
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] locking/atomics: Check atomic-arch-fallback.h too
  2020-10-01 20:20 [PATCH] locking/atomics: Check atomic-arch-fallback.h too Paul Bolle
@ 2020-10-02 13:00 ` Mark Rutland
  2020-10-07 16:20 ` [tip: locking/core] " tip-bot2 for Paul Bolle
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Rutland @ 2020-10-02 13:00 UTC (permalink / raw)
  To: Paul Bolle, Peter Zijlstra; +Cc: Will Deacon, Boqun Feng, linux-kernel

On Thu, Oct 01, 2020 at 10:20:28PM +0200, Paul Bolle wrote:
> The sha1sum of include/linux/atomic-arch-fallback.h isn't checked by
> check-atomics.sh. It's not clear why it's skipped so let's check it too.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>

This was an oversight; Peter and I forgot to add this when Peter added
the arch fallbacks in commit:

  37f8173dd84936ea ("locking/atomics: Flip fallbacks and instrumentation")

... for which we could arguably add a fixes tag.

Either way:

Reviewed-by: Mark Rutland <mark.rutland@arm.com>

Peter, I assume you'll pick this up (and also that the hash is
up-to-date as it should be).

> ---
> It seems it never has been checked. So this does cast some doubt about
> the usefulness of these tests. But I'm clueless about this atomic stuff
> so what do I know?

The tests have been useful to ensure people fixed up the scripts when
altering other files, so I think it makes sense to keep this even if we
did miss one file recently.

Mark.

> 
>  scripts/atomic/check-atomics.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/atomic/check-atomics.sh b/scripts/atomic/check-atomics.sh
> index 8378c63a1e09..82748d42ecc5 100755
> --- a/scripts/atomic/check-atomics.sh
> +++ b/scripts/atomic/check-atomics.sh
> @@ -16,6 +16,7 @@ fi
>  cat <<EOF |
>  asm-generic/atomic-instrumented.h
>  asm-generic/atomic-long.h
> +linux/atomic-arch-fallback.h
>  linux/atomic-fallback.h
>  EOF
>  while read header; do
> -- 
> 2.26.2
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [tip: locking/core] locking/atomics: Check atomic-arch-fallback.h too
  2020-10-01 20:20 [PATCH] locking/atomics: Check atomic-arch-fallback.h too Paul Bolle
  2020-10-02 13:00 ` Mark Rutland
@ 2020-10-07 16:20 ` tip-bot2 for Paul Bolle
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Paul Bolle @ 2020-10-07 16:20 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Paul Bolle, Peter Zijlstra (Intel), Mark Rutland, x86, LKML

The following commit has been merged into the locking/core branch of tip:

Commit-ID:     d89d5f855f84ccf3f7e648813b4bb95c780bd7cd
Gitweb:        https://git.kernel.org/tip/d89d5f855f84ccf3f7e648813b4bb95c780bd7cd
Author:        Paul Bolle <pebolle@tiscali.nl>
AuthorDate:    Thu, 01 Oct 2020 22:20:28 +02:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Wed, 07 Oct 2020 18:14:14 +02:00

locking/atomics: Check atomic-arch-fallback.h too

The sha1sum of include/linux/atomic-arch-fallback.h isn't checked by
check-atomics.sh. It's not clear why it's skipped so let's check it too.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Link: https://lkml.kernel.org/r/20201001202028.1048418-1-pebolle@tiscali.nl
---
 scripts/atomic/check-atomics.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/atomic/check-atomics.sh b/scripts/atomic/check-atomics.sh
index 8378c63..82748d4 100755
--- a/scripts/atomic/check-atomics.sh
+++ b/scripts/atomic/check-atomics.sh
@@ -16,6 +16,7 @@ fi
 cat <<EOF |
 asm-generic/atomic-instrumented.h
 asm-generic/atomic-long.h
+linux/atomic-arch-fallback.h
 linux/atomic-fallback.h
 EOF
 while read header; do

^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-07 16:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-01 20:20 [PATCH] locking/atomics: Check atomic-arch-fallback.h too Paul Bolle
2020-10-02 13:00 ` Mark Rutland
2020-10-07 16:20 ` [tip: locking/core] " tip-bot2 for Paul Bolle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.