All of lore.kernel.org
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: zhaolichang@huawei.com
Cc: qemu-trivial@nongnu.org, zhaolichang@huawei.com, qemu-devel@nongnu.org
Subject: Re: [PATCH V2 00/14] fix some comment spelling errors
Date: Fri, 9 Oct 2020 00:12:45 -0700 (PDT)	[thread overview]
Message-ID: <160222756374.6597.16112863698408546855@66eaa9a8a123> (raw)
In-Reply-To: <20201009064449.2336-1-zhaolichang@huawei.com>

Patchew URL: https://patchew.org/QEMU/20201009064449.2336-1-zhaolichang@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201009064449.2336-1-zhaolichang@huawei.com
Subject: [PATCH V2 00/14] fix some comment spelling errors

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20201009064449.2336-1-zhaolichang@huawei.com -> patchew/20201009064449.2336-1-zhaolichang@huawei.com
 * [new tag]         patchew/20201009064858.323624-1-armbru@redhat.com -> patchew/20201009064858.323624-1-armbru@redhat.com
Switched to a new branch 'test'
25b65d8 target/: fix some comment spelling errors
085cdde alpha/: fix some comment spelling errors
ec812f0 arm/: fix some comment spelling errors
729762d avr/: fix some comment spelling errors
3e0605c i386/: fix some comment spelling errors
02d26f2 sh4/: fix some comment spelling errors
cc0c6a7 m68k/: fix some comment spelling errors
d3713f0 s390x/: fix some comment spelling errors
be98a94 mips/: fix some comment spelling errors
68e09fe tricore/: fix some comment spelling errors
a8a59c3 rx/: fix some comment spelling errors
c6e1b75 riscv/: fix some comment spelling errors
a898e79 ppc/: fix some comment spelling errors
b6fffd3 cris/: fix some comment spelling errors

=== OUTPUT BEGIN ===
1/14 Checking commit b6fffd33b968 (cris/: fix some comment spelling errors)
WARNING: Block comments use a leading /* on a separate line
#23: FILE: target/cris/helper.c:144:
+        /* These exceptions are generated by the core itself.

WARNING: Block comments use a leading /* on a separate line
#32: FILE: target/cris/helper.c:200:
+        /* These exceptions are generated by the core itself.

WARNING: Block comments use a leading /* on a separate line
#41: FILE: target/cris/helper.c:259:
+    /* Clear the excption_index to avoid spurious hw_aborts for recursive

ERROR: trailing whitespace
#112: FILE: target/cris/translate.c:3056:
+ * The TB containing the branch insn will set up env->btarget and evaluate $

total: 1 errors, 3 warnings, 86 lines checked

Patch 1/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/14 Checking commit a898e796b356 (ppc/: fix some comment spelling errors)
3/14 Checking commit c6e1b757e105 (riscv/: fix some comment spelling errors)
4/14 Checking commit a8a59c37ccbf (rx/: fix some comment spelling errors)
5/14 Checking commit 68e09fe5f350 (tricore/: fix some comment spelling errors)
WARNING: Block comments use a trailing */ on a separate line
#46: FILE: target/tricore/translate.c:400:
+                                    since no exception occurs */

total: 0 errors, 1 warnings, 21 lines checked

Patch 5/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/14 Checking commit be98a94fb597 (mips/: fix some comment spelling errors)
7/14 Checking commit d3713f00a7b9 (s390x/: fix some comment spelling errors)
8/14 Checking commit cc0c6a7697e5 (m68k/: fix some comment spelling errors)
9/14 Checking commit 02d26f2e1170 (sh4/: fix some comment spelling errors)
ERROR: code indent should never use tabs
#24: FILE: target/sh4/cpu.h:163:
+    uint32_t ttb;^I^I/* translation table base register */$

WARNING: Block comments use a trailing */ on a separate line
#37: FILE: target/sh4/op_helper.c:403:
+       IEEE rule that other exceptions take precedence.  */

WARNING: Block comments use a leading /* on a separate line
#50: FILE: target/sh4/translate.c:1962:
+        /* Here we want to recognize ld_dst being saved for later consumption,

total: 1 errors, 2 warnings, 24 lines checked

Patch 9/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/14 Checking commit 3e0605cc7e54 (i386/: fix some comment spelling errors)
WARNING: Block comments use a leading /* on a separate line
#23: FILE: target/i386/cpu.c:4680:
+/* Compatibility hack to maintain legacy +-feat semantic,

WARNING: Block comments use a trailing */ on a separate line
#121: FILE: target/i386/translate.c:896:
+   value 'b'. In the fast case, T0 is guaranteed not to be used. */

WARNING: Block comments use a trailing */ on a separate line
#130: FILE: target/i386/translate.c:1029:
+   value 'b'. In the fast case, T0 is guaranteed not to be used. */

WARNING: Block comments use a leading /* on a separate line
#148: FILE: target/i386/translate.c:6844:
+                /* Needs no atomic ops; we suppressed the normal

total: 0 errors, 4 warnings, 110 lines checked

Patch 10/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/14 Checking commit 729762daa63d (avr/: fix some comment spelling errors)
12/14 Checking commit ec812f092ed3 (arm/: fix some comment spelling errors)
WARNING: Block comments use a leading /* on a separate line
#24: FILE: target/arm/cpu.h:2093:
+/* Function for determining whether guest cp register reads and writes should

total: 0 errors, 1 warnings, 56 lines checked

Patch 12/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/14 Checking commit 085cdde202db (alpha/: fix some comment spelling errors)
WARNING: Block comments use a leading /* on a separate line
#33: FILE: target/alpha/cpu.h:373:
+/* CPUAlphaState->flags constants.  These are laid out so that we

total: 0 errors, 1 warnings, 24 lines checked

Patch 13/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/14 Checking commit 25b65d88a33a (target/: fix some comment spelling errors)
ERROR: code indent should never use tabs
#37: FILE: target/sparc/asi.h:234:
+#define ASI_IC_INSTR^I^I0x66 /* Insn cache instruction ram diag^I*/$

total: 1 errors, 0 warnings, 24 lines checked

Patch 14/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20201009064449.2336-1-zhaolichang@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

  parent reply	other threads:[~2020-10-09  7:14 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09  6:44 [PATCH V2 00/14] fix some comment spelling errors zhaolichang
2020-10-09  6:44 ` [PATCH V2 01/14] cris/: " zhaolichang
2020-10-09 13:14   ` Eric Blake
2020-10-09  6:44 ` [PATCH V2 02/14] ppc/: " zhaolichang
2020-10-26  9:14   ` Thomas Huth
2020-10-26 10:04     ` Greg Kurz
2020-10-27  2:05     ` David Gibson
2020-10-27  2:07   ` David Gibson
2020-10-09  6:44 ` [PATCH V2 03/14] riscv/: " zhaolichang
2020-10-09  7:15   ` Bin Meng
2020-10-09  6:44 ` [PATCH V2 04/14] rx/: " zhaolichang
2020-10-26 22:14   ` Philippe Mathieu-Daudé
2020-10-09  6:44 ` [PATCH V2 05/14] tricore/: " zhaolichang
2020-10-09  6:44 ` [PATCH V2 06/14] mips/: " zhaolichang
2020-10-09 14:36   ` Philippe Mathieu-Daudé
2020-10-09 15:15     ` Philippe Mathieu-Daudé
2020-10-09  6:44 ` [PATCH V2 07/14] s390x/: " zhaolichang
2020-10-09  7:31   ` Thomas Huth
2020-10-09  6:44 ` [PATCH V2 08/14] m68k/: " zhaolichang
2020-12-12 17:10   ` Laurent Vivier
2020-12-12 17:56     ` Philippe Mathieu-Daudé
2020-12-12 19:58       ` Laurent Vivier
2020-12-12 20:04         ` Philippe Mathieu-Daudé
2020-10-09  6:44 ` [PATCH V2 09/14] sh4/: " zhaolichang
2020-10-25  0:37   ` Philippe Mathieu-Daudé
2020-10-09  6:44 ` [PATCH V2 10/14] i386/: " zhaolichang
2020-10-09  6:44 ` [PATCH V2 11/14] avr/: " zhaolichang
2020-10-09  6:44 ` [PATCH V2 12/14] arm/: " zhaolichang
2020-10-09  6:44 ` [PATCH V2 13/14] alpha/: " zhaolichang
2020-10-09  6:44 ` [PATCH V2 14/14] target/: " zhaolichang
2020-10-09  7:12 ` no-reply [this message]
     [not found] ` <a5a68476-0ed8-08f9-f993-464317d798bf@huawei.com>
2020-10-20  6:42   ` [PATCH V2 00/14] " Philippe Mathieu-Daudé
2020-10-29  2:22     ` Lichang Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160222756374.6597.16112863698408546855@66eaa9a8a123 \
    --to=no-reply@patchew.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=zhaolichang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.