From: Stephen Boyd <swboyd@chromium.org>
To: Akash Asthana <akashast@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Douglas Anderson <dianders@chromium.org>,
Wolfram Sang <wsa@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Andy Gross <agross@kernel.org>,
Girish Mahadevan <girishm@codeaurora.org>,
Karthikeyan Ramasubramanian <kramasub@codeaurora.org>,
Mukesh Kumar Savaliya <msavaliy@codeaurora.org>,
linux-kernel@vger.kernel.org,
Roja Rani Yarubandi <rojay@codeaurora.org>
Subject: Re: [PATCH 0/3] i2c: i2c-qcom-geni: More properly fix the DMA race
Date: Fri, 09 Oct 2020 17:26:37 -0700 [thread overview]
Message-ID: <160228959768.310579.3696247619283748151@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20201008225235.2035820-1-dianders@chromium.org>
+Roja
Quoting Douglas Anderson (2020-10-08 15:52:32)
> Previously I landed commit 02b9aec59243 ("i2c: i2c-qcom-geni: Fix DMA
> transfer race") to fix a race we were seeing. While that most
> definitely fixed the race we were seeing, it looks like it causes
> problems in the TX path, which we didn't stress test until we started
> trying to update firmware on devices.
>
> Let's revert that patch and try another way: fix the original problem
> by disabling the interrupts that aren't relevant to DMA transfers.
> Now we can stress both TX and RX cases and see no problems. I also
> can't find any place to put an msleep() that causes problems anymore.
>
> Since this problem only affects i2c, I'm hoping for an Ack from Bjorn
> and then all these patches can go through the i2c tree. However, if
> maintainers want to work a different way out to land that's OK too.
>
> NOTE: the 3rd patch in the series could certianly be squashed with
> patch #1 or I could re-order / rejigger. To me it seemed like a good
> idea to first fix the probelm (and make the two functions as much of
> an inverse as possible) and later try to clean things up. Yell if you
> want something different.
>
>
> Douglas Anderson (3):
> soc: qcom: geni: More properly switch to DMA mode
> Revert "i2c: i2c-qcom-geni: Fix DMA transfer race"
> soc: qcom: geni: Optimize select fifo/dma mode
>
> drivers/i2c/busses/i2c-qcom-geni.c | 6 ++--
> drivers/soc/qcom/qcom-geni-se.c | 47 ++++++++++++++++++++----------
> 2 files changed, 34 insertions(+), 19 deletions(-)
>
> --
> 2.28.0.1011.ga647a8990f-goog
>
next prev parent reply other threads:[~2020-10-10 0:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 22:52 [PATCH 0/3] i2c: i2c-qcom-geni: More properly fix the DMA race Douglas Anderson
2020-10-08 22:52 ` [PATCH 1/3] soc: qcom: geni: More properly switch to DMA mode Douglas Anderson
2020-10-10 0:39 ` Stephen Boyd
2020-10-12 9:05 ` Akash Asthana
2020-10-13 21:35 ` Doug Anderson
2020-10-12 8:09 ` Akash Asthana
2020-10-08 22:52 ` [PATCH 2/3] Revert "i2c: i2c-qcom-geni: Fix DMA transfer race" Douglas Anderson
2020-10-10 0:39 ` Stephen Boyd
2020-10-12 8:12 ` Akash Asthana
2020-10-08 22:52 ` [PATCH 3/3] soc: qcom: geni: Optimize select fifo/dma mode Douglas Anderson
2020-10-10 0:32 ` Stephen Boyd
2020-10-13 21:38 ` Doug Anderson
2020-10-10 0:26 ` Stephen Boyd [this message]
2020-10-10 13:16 ` [PATCH 0/3] i2c: i2c-qcom-geni: More properly fix the DMA race Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160228959768.310579.3696247619283748151@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=girishm@codeaurora.org \
--cc=kramasub@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msavaliy@codeaurora.org \
--cc=rojay@codeaurora.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.