All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <Julia.Lawall@inria.fr>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
	"Joe Perches" <joe@perches.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	kernel-janitors@vger.kernel.org,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>,
	"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
	"Daniel Baluta" <daniel.baluta@nxp.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>,
	sound-open-firmware@alsa-project.org,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH 5/8] ASoC: SOF: Intel: hda: use semicolons rather than commas to separate statements
Date: Sun, 11 Oct 2020 11:19:36 +0200	[thread overview]
Message-ID: <1602407979-29038-6-git-send-email-Julia.Lawall@inria.fr> (raw)
In-Reply-To: <1602407979-29038-1-git-send-email-Julia.Lawall@inria.fr>

Replace commas with semicolons.  What is done is essentially described by
the following Coccinelle semantic patch (http://coccinelle.lip6.fr/):

// <smpl>
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

---
 sound/soc/sof/intel/hda-dsp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sof/intel/hda-dsp.c b/sound/soc/sof/intel/hda-dsp.c
index 18ff1c2f5376..2b001151fe37 100644
--- a/sound/soc/sof/intel/hda-dsp.c
+++ b/sound/soc/sof/intel/hda-dsp.c
@@ -44,7 +44,7 @@ int hda_dsp_core_reset_enter(struct snd_sof_dev *sdev, unsigned int core_mask)
 	reset = HDA_DSP_ADSPCS_CRST_MASK(core_mask);
 	snd_sof_dsp_update_bits_unlocked(sdev, HDA_DSP_BAR,
 					 HDA_DSP_REG_ADSPCS,
-					 reset, reset),
+					 reset, reset);
 
 	/* poll with timeout to check if operation successful */
 	ret = snd_sof_dsp_read_poll_timeout(sdev, HDA_DSP_BAR,


WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <Julia.Lawall@inria.fr>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org,
	"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
	"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
	linux-kernel@vger.kernel.org, "Takashi Iwai" <tiwai@suse.com>,
	kernel-janitors@vger.kernel.org,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Joe Perches" <joe@perches.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Daniel Baluta" <daniel.baluta@nxp.com>,
	sound-open-firmware@alsa-project.org
Subject: [PATCH 5/8] ASoC: SOF: Intel: hda: use semicolons rather than commas to separate statements
Date: Sun, 11 Oct 2020 09:19:36 +0000	[thread overview]
Message-ID: <1602407979-29038-6-git-send-email-Julia.Lawall@inria.fr> (raw)
In-Reply-To: <1602407979-29038-1-git-send-email-Julia.Lawall@inria.fr>

Replace commas with semicolons.  What is done is essentially described by
the following Coccinelle semantic patch (http://coccinelle.lip6.fr/):

// <smpl>
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

---
 sound/soc/sof/intel/hda-dsp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sof/intel/hda-dsp.c b/sound/soc/sof/intel/hda-dsp.c
index 18ff1c2f5376..2b001151fe37 100644
--- a/sound/soc/sof/intel/hda-dsp.c
+++ b/sound/soc/sof/intel/hda-dsp.c
@@ -44,7 +44,7 @@ int hda_dsp_core_reset_enter(struct snd_sof_dev *sdev, unsigned int core_mask)
 	reset = HDA_DSP_ADSPCS_CRST_MASK(core_mask);
 	snd_sof_dsp_update_bits_unlocked(sdev, HDA_DSP_BAR,
 					 HDA_DSP_REG_ADSPCS,
-					 reset, reset),
+					 reset, reset);
 
 	/* poll with timeout to check if operation successful */
 	ret = snd_sof_dsp_read_poll_timeout(sdev, HDA_DSP_BAR,

WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <Julia.Lawall@inria.fr>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org,
	"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
	"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
	linux-kernel@vger.kernel.org, "Takashi Iwai" <tiwai@suse.com>,
	kernel-janitors@vger.kernel.org,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Joe Perches" <joe@perches.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Daniel Baluta" <daniel.baluta@nxp.com>,
	sound-open-firmware@alsa-project.org
Subject: [PATCH 5/8] ASoC: SOF: Intel: hda: use semicolons rather than commas to separate statements
Date: Sun, 11 Oct 2020 11:19:36 +0200	[thread overview]
Message-ID: <1602407979-29038-6-git-send-email-Julia.Lawall@inria.fr> (raw)
In-Reply-To: <1602407979-29038-1-git-send-email-Julia.Lawall@inria.fr>

Replace commas with semicolons.  What is done is essentially described by
the following Coccinelle semantic patch (http://coccinelle.lip6.fr/):

// <smpl>
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

---
 sound/soc/sof/intel/hda-dsp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sof/intel/hda-dsp.c b/sound/soc/sof/intel/hda-dsp.c
index 18ff1c2f5376..2b001151fe37 100644
--- a/sound/soc/sof/intel/hda-dsp.c
+++ b/sound/soc/sof/intel/hda-dsp.c
@@ -44,7 +44,7 @@ int hda_dsp_core_reset_enter(struct snd_sof_dev *sdev, unsigned int core_mask)
 	reset = HDA_DSP_ADSPCS_CRST_MASK(core_mask);
 	snd_sof_dsp_update_bits_unlocked(sdev, HDA_DSP_BAR,
 					 HDA_DSP_REG_ADSPCS,
-					 reset, reset),
+					 reset, reset);
 
 	/* poll with timeout to check if operation successful */
 	ret = snd_sof_dsp_read_poll_timeout(sdev, HDA_DSP_BAR,


  parent reply	other threads:[~2020-10-11 10:02 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-11  9:19 [PATCH 0/8] use semicolons rather than commas to separate statements Julia Lawall
2020-10-11  9:19 ` Julia Lawall
2020-10-11  9:19 ` Julia Lawall
2020-10-11  9:19 ` [PATCH 1/8] ASoC: wm8350: " Julia Lawall
2020-10-11  9:19   ` Julia Lawall
2020-10-11  9:19   ` Julia Lawall
2020-10-12  9:26   ` Charles Keepax
2020-10-12  9:26     ` Charles Keepax
2020-10-11  9:19 ` [PATCH 2/8] ALSA: hda: " Julia Lawall
2020-10-11  9:19   ` Julia Lawall
2020-10-11  9:19   ` Julia Lawall
2020-10-12  6:52   ` Takashi Iwai
2020-10-12  6:52     ` Takashi Iwai
2020-10-12  6:52     ` Takashi Iwai
2020-10-11  9:19 ` [PATCH 3/8] ASoC: Intel: bytcr_rt5651: " Julia Lawall
2020-10-11  9:19   ` Julia Lawall
2020-10-11  9:19   ` Julia Lawall
2020-10-12  7:14   ` Rojewski, Cezary
2020-10-12  7:14     ` Rojewski, Cezary
2020-10-11  9:19 ` [PATCH 4/8] ALSA: fireworks: " Julia Lawall
2020-10-11  9:19   ` Julia Lawall
2020-10-11  9:19   ` Julia Lawall
2020-10-11 11:32   ` Takashi Sakamoto
2020-10-11 11:32     ` Takashi Sakamoto
2020-10-11 11:32     ` Takashi Sakamoto
2020-10-12  6:53   ` Takashi Iwai
2020-10-12  6:53     ` Takashi Iwai
2020-10-12  6:53     ` Takashi Iwai
2020-10-11  9:19 ` Julia Lawall [this message]
2020-10-11  9:19   ` [PATCH 5/8] ASoC: SOF: Intel: hda: " Julia Lawall
2020-10-11  9:19   ` Julia Lawall
2020-10-11  9:19 ` [PATCH 6/8] ASoC: samsung: snow: " Julia Lawall
2020-10-11  9:19   ` Julia Lawall
2020-10-11  9:19   ` Julia Lawall
2020-10-12  7:12   ` Krzysztof Kozlowski
2020-10-12  7:12     ` Krzysztof Kozlowski
2020-10-12  7:12     ` Krzysztof Kozlowski
2020-10-11  9:19 ` [PATCH 7/8] ASoC: madera: " Julia Lawall
2020-10-11  9:19   ` Julia Lawall
2020-10-11  9:19   ` Julia Lawall
2020-10-12  9:26   ` Charles Keepax
2020-10-12  9:26     ` Charles Keepax
2020-10-11  9:19 ` [PATCH 8/8] ASoC: dapm: " Julia Lawall
2020-10-11  9:19   ` Julia Lawall
2020-10-11  9:19   ` Julia Lawall
2020-10-26 23:45 ` [PATCH 0/8] " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1602407979-29038-6-git-send-email-Julia.Lawall@inria.fr \
    --to=julia.lawall@inria.fr \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=joe@perches.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=sound-open-firmware@alsa-project.org \
    --cc=tglx@linutronix.de \
    --cc=tiwai@suse.com \
    --cc=valdis.kletnieks@vt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.