* [PATCH] spapr: Clarify why DR connectors aren't user creatable
@ 2020-10-12 11:26 Greg Kurz
2020-10-13 0:39 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Greg Kurz @ 2020-10-12 11:26 UTC (permalink / raw)
To: David Gibson; +Cc: qemu-ppc, qemu-devel
DR connector is a device that emulates a firmware abstraction used by PAPR
compliant guests to manage hotplug/dynamic-reconfiguration of PHBs, PCI
devices, memory, and CPUs.
It is internally created by the spapr platform and requires to be owned by
either the machine (PHBs, CPUs, memory) or by a PHB (PCI devices).
Signed-off-by: Greg Kurz <groug@kaod.org>
---
hw/ppc/spapr_drc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
index 697b28c34305..77718cde1ff2 100644
--- a/hw/ppc/spapr_drc.c
+++ b/hw/ppc/spapr_drc.c
@@ -586,7 +586,8 @@ static void spapr_dr_connector_class_init(ObjectClass *k, void *data)
dk->realize = realize;
dk->unrealize = unrealize;
/*
- * Reason: it crashes FIXME find and document the real reason
+ * Reason: DR connector needs to be wired to either the machine or to a
+ * PHB in spapr_dr_connector_new().
*/
dk->user_creatable = false;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] spapr: Clarify why DR connectors aren't user creatable
2020-10-12 11:26 [PATCH] spapr: Clarify why DR connectors aren't user creatable Greg Kurz
@ 2020-10-13 0:39 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2020-10-13 0:39 UTC (permalink / raw)
To: Greg Kurz; +Cc: qemu-ppc, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]
On Mon, Oct 12, 2020 at 01:26:39PM +0200, Greg Kurz wrote:
> DR connector is a device that emulates a firmware abstraction used by PAPR
> compliant guests to manage hotplug/dynamic-reconfiguration of PHBs, PCI
> devices, memory, and CPUs.
>
> It is internally created by the spapr platform and requires to be owned by
> either the machine (PHBs, CPUs, memory) or by a PHB (PCI devices).
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
Applied to ppc-for-5.2, thanks.
> ---
> hw/ppc/spapr_drc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
> index 697b28c34305..77718cde1ff2 100644
> --- a/hw/ppc/spapr_drc.c
> +++ b/hw/ppc/spapr_drc.c
> @@ -586,7 +586,8 @@ static void spapr_dr_connector_class_init(ObjectClass *k, void *data)
> dk->realize = realize;
> dk->unrealize = unrealize;
> /*
> - * Reason: it crashes FIXME find and document the real reason
> + * Reason: DR connector needs to be wired to either the machine or to a
> + * PHB in spapr_dr_connector_new().
> */
> dk->user_creatable = false;
> }
>
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-13 0:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-12 11:26 [PATCH] spapr: Clarify why DR connectors aren't user creatable Greg Kurz
2020-10-13 0:39 ` David Gibson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.