* [dunfell/master][PATCH 1/3] linux-ti-staging: extract common rdepends, pass defconfig_builder.sh via variable
@ 2020-10-12 23:31 Denys Dmytriyenko
2020-10-12 23:31 ` [dunfell/master][PATCH 2/3] linux-ti-mainline: add mainline 5.9 using ti-upstream-tools Denys Dmytriyenko
2020-10-12 23:31 ` [dunfell/master][PATCH 3/3] u-boot-ti-mainline: add mainline 2020.10 Denys Dmytriyenko
0 siblings, 2 replies; 3+ messages in thread
From: Denys Dmytriyenko @ 2020-10-12 23:31 UTC (permalink / raw)
To: meta-ti; +Cc: Denys Dmytriyenko
From: Denys Dmytriyenko <denys@ti.com>
Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
recipes-kernel/linux/kernel-rdepends.inc | 40 +++++++++++++++++++++++++
recipes-kernel/linux/linux-ti-staging_5.4.bb | 45 ++--------------------------
recipes-kernel/linux/setup-defconfig.inc | 2 +-
3 files changed, 44 insertions(+), 43 deletions(-)
create mode 100644 recipes-kernel/linux/kernel-rdepends.inc
diff --git a/recipes-kernel/linux/kernel-rdepends.inc b/recipes-kernel/linux/kernel-rdepends.inc
new file mode 100644
index 0000000..56dfe4b
--- /dev/null
+++ b/recipes-kernel/linux/kernel-rdepends.inc
@@ -0,0 +1,40 @@
+# Pull in the devicetree files into the rootfs
+RDEPENDS_${KERNEL_PACKAGE_NAME}-base += "kernel-devicetree"
+
+# Add run-time dependency for PM firmware to the rootfs
+RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_ti33x = " amx3-cm3"
+RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_ti43x = " amx3-cm3"
+
+# Add run-time dependency for VPE VPDMA firmware to the rootfs
+RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_dra7xx = " vpdma-fw"
+
+# Add run-time dependency for Goodix firmware to the rootfs
+RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_dra7xx = " goodix-fw"
+
+# Install boot-monitor skern file into /boot dir of rootfs
+RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_keystone = " boot-monitor"
+
+# Install ti-sci-fw into /boot dir of rootfs
+RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_k2g = " ti-sci-fw"
+
+# Add run-time dependency for SerDes firmware to the rootfs
+RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_keystone = " serdes-fw"
+
+# Add run-time dependency for QMSS PDSP firmware to the rootfs
+RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_keystone = " qmss-pdsp-fw"
+
+# Add run-time dependency for NETCP PA firmware to the rootfs
+RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_k2hk = " netcp-pa-fw"
+RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_k2e = " netcp-pa-fw"
+RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_k2l = " netcp-pa-fw"
+
+# Add run-time dependency for PRU Ethernet firmware to the rootfs
+RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_am57xx-evm = " prueth-fw prusw-fw pruhsr-fw pruprp-fw"
+RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_am57xx-hs-evm = " prueth-fw prusw-fw pruhsr-fw pruprp-fw"
+RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_ti43x = " prueth-fw pruhsr-fw pruprp-fw"
+RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_ti33x = " prueth-fw pruhsr-fw pruprp-fw"
+RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_am65xx = " prueth-fw-am65x"
+RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_am65xx-evm = " prueth-fw-am65x-sr2"
+
+# Add run-time dependency for Cadence MHDP firmware to the rootfs
+RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_j7 = " cadence-mhdp-fw"
diff --git a/recipes-kernel/linux/linux-ti-staging_5.4.bb b/recipes-kernel/linux/linux-ti-staging_5.4.bb
index 2b4557d..eaf4038 100644
--- a/recipes-kernel/linux/linux-ti-staging_5.4.bb
+++ b/recipes-kernel/linux/linux-ti-staging_5.4.bb
@@ -1,59 +1,20 @@
SECTION = "kernel"
-DESCRIPTION = "Linux kernel for TI devices"
+SUMMARY = "Linux kernel for TI devices"
LICENSE = "GPLv2"
LIC_FILES_CHKSUM = "file://COPYING;md5=bbea815ee2795b2f4230826c0c6b8814"
inherit kernel
+DEFCONFIG_BUILDER = "${S}/ti_config_fragments/defconfig_builder.sh"
require recipes-kernel/linux/setup-defconfig.inc
require recipes-kernel/linux/cmem.inc
require recipes-kernel/linux/ti-uio.inc
require recipes-kernel/linux/bundle-devicetree.inc
+require recipes-kernel/linux/kernel-rdepends.inc
# Look in the generic major.minor directory for files
FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-5.4:"
-# Pull in the devicetree files into the rootfs
-RDEPENDS_${KERNEL_PACKAGE_NAME}-base += "kernel-devicetree"
-
-# Add run-time dependency for PM firmware to the rootfs
-RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_ti33x = " amx3-cm3"
-RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_ti43x = " amx3-cm3"
-
-# Add run-time dependency for VPE VPDMA firmware to the rootfs
-RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_dra7xx = " vpdma-fw"
-
-# Add run-time dependency for Goodix firmware to the rootfs
-RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_dra7xx = " goodix-fw"
-
-# Install boot-monitor skern file into /boot dir of rootfs
-RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_keystone = " boot-monitor"
-
-# Install ti-sci-fw into /boot dir of rootfs
-RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_k2g = " ti-sci-fw"
-
-# Add run-time dependency for SerDes firmware to the rootfs
-RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_keystone = " serdes-fw"
-
-# Add run-time dependency for QMSS PDSP firmware to the rootfs
-RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_keystone = " qmss-pdsp-fw"
-
-# Add run-time dependency for NETCP PA firmware to the rootfs
-RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_k2hk = " netcp-pa-fw"
-RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_k2e = " netcp-pa-fw"
-RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_k2l = " netcp-pa-fw"
-
-# Add run-time dependency for PRU Ethernet firmware to the rootfs
-RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_am57xx-evm = " prueth-fw prusw-fw pruhsr-fw pruprp-fw"
-RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_am57xx-hs-evm = " prueth-fw prusw-fw pruhsr-fw pruprp-fw"
-RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_ti43x = " prueth-fw pruhsr-fw pruprp-fw"
-RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_ti33x = " prueth-fw pruhsr-fw pruprp-fw"
-RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_am65xx = " prueth-fw-am65x"
-RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_am65xx-evm = " prueth-fw-am65x-sr2"
-
-# Add run-time dependency for Cadence MHDP firmware to the rootfs
-RDEPENDS_${KERNEL_PACKAGE_NAME}-base_append_j7 = " cadence-mhdp-fw"
-
KERNEL_EXTRA_ARGS += "LOADADDR=${UBOOT_ENTRYPOINT}"
S = "${WORKDIR}/git"
diff --git a/recipes-kernel/linux/setup-defconfig.inc b/recipes-kernel/linux/setup-defconfig.inc
index dcf2ada..850a1dd 100644
--- a/recipes-kernel/linux/setup-defconfig.inc
+++ b/recipes-kernel/linux/setup-defconfig.inc
@@ -28,7 +28,7 @@ do_configure() {
config=`cat ${B}/.config | grep use-tisdk-config | cut -d= -f2`
if [ -n "$config" ]
then
- ${S}/ti_config_fragments/defconfig_builder.sh -w ${S} -t $config
+ ${DEFCONFIG_BUILDER} -w ${S} -t $config
oe_runmake -C ${S} O=${B} "$config"_defconfig
else
# First, check if pointing to a combined config with config fragments
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [dunfell/master][PATCH 2/3] linux-ti-mainline: add mainline 5.9 using ti-upstream-tools
2020-10-12 23:31 [dunfell/master][PATCH 1/3] linux-ti-staging: extract common rdepends, pass defconfig_builder.sh via variable Denys Dmytriyenko
@ 2020-10-12 23:31 ` Denys Dmytriyenko
2020-10-12 23:31 ` [dunfell/master][PATCH 3/3] u-boot-ti-mainline: add mainline 2020.10 Denys Dmytriyenko
1 sibling, 0 replies; 3+ messages in thread
From: Denys Dmytriyenko @ 2020-10-12 23:31 UTC (permalink / raw)
To: meta-ti; +Cc: Denys Dmytriyenko
From: Denys Dmytriyenko <denys@ti.com>
Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
.../defconfig | 0
.../dra7xx/defconfig | 0
.../k2g/defconfig | 0
.../k3/defconfig | 0
.../keystone/defconfig | 0
.../omapl138/defconfig | 0
.../ti33x/defconfig | 0
.../ti43x/defconfig | 0
...-ti-staging_5.4.bb => linux-ti-mainline_git.bb} | 71 +++++++++++++++-------
9 files changed, 49 insertions(+), 22 deletions(-)
copy recipes-kernel/linux/{linux-ti-staging-5.4 => linux-ti-mainline}/defconfig (100%)
copy recipes-kernel/linux/{linux-ti-staging-5.4 => linux-ti-mainline}/dra7xx/defconfig (100%)
copy recipes-kernel/linux/{linux-ti-staging-5.4 => linux-ti-mainline}/k2g/defconfig (100%)
copy recipes-kernel/linux/{linux-ti-staging-5.4 => linux-ti-mainline}/k3/defconfig (100%)
copy recipes-kernel/linux/{linux-ti-staging-5.4 => linux-ti-mainline}/keystone/defconfig (100%)
copy recipes-kernel/linux/{linux-ti-staging-5.4 => linux-ti-mainline}/omapl138/defconfig (100%)
copy recipes-kernel/linux/{linux-ti-staging-5.4 => linux-ti-mainline}/ti33x/defconfig (100%)
copy recipes-kernel/linux/{linux-ti-staging-5.4 => linux-ti-mainline}/ti43x/defconfig (100%)
copy recipes-kernel/linux/{linux-ti-staging_5.4.bb => linux-ti-mainline_git.bb} (20%)
diff --git a/recipes-kernel/linux/linux-ti-staging-5.4/defconfig b/recipes-kernel/linux/linux-ti-mainline/defconfig
similarity index 100%
copy from recipes-kernel/linux/linux-ti-staging-5.4/defconfig
copy to recipes-kernel/linux/linux-ti-mainline/defconfig
diff --git a/recipes-kernel/linux/linux-ti-staging-5.4/dra7xx/defconfig b/recipes-kernel/linux/linux-ti-mainline/dra7xx/defconfig
similarity index 100%
copy from recipes-kernel/linux/linux-ti-staging-5.4/dra7xx/defconfig
copy to recipes-kernel/linux/linux-ti-mainline/dra7xx/defconfig
diff --git a/recipes-kernel/linux/linux-ti-staging-5.4/k2g/defconfig b/recipes-kernel/linux/linux-ti-mainline/k2g/defconfig
similarity index 100%
copy from recipes-kernel/linux/linux-ti-staging-5.4/k2g/defconfig
copy to recipes-kernel/linux/linux-ti-mainline/k2g/defconfig
diff --git a/recipes-kernel/linux/linux-ti-staging-5.4/k3/defconfig b/recipes-kernel/linux/linux-ti-mainline/k3/defconfig
similarity index 100%
copy from recipes-kernel/linux/linux-ti-staging-5.4/k3/defconfig
copy to recipes-kernel/linux/linux-ti-mainline/k3/defconfig
diff --git a/recipes-kernel/linux/linux-ti-staging-5.4/keystone/defconfig b/recipes-kernel/linux/linux-ti-mainline/keystone/defconfig
similarity index 100%
copy from recipes-kernel/linux/linux-ti-staging-5.4/keystone/defconfig
copy to recipes-kernel/linux/linux-ti-mainline/keystone/defconfig
diff --git a/recipes-kernel/linux/linux-ti-staging-5.4/omapl138/defconfig b/recipes-kernel/linux/linux-ti-mainline/omapl138/defconfig
similarity index 100%
copy from recipes-kernel/linux/linux-ti-staging-5.4/omapl138/defconfig
copy to recipes-kernel/linux/linux-ti-mainline/omapl138/defconfig
diff --git a/recipes-kernel/linux/linux-ti-staging-5.4/ti33x/defconfig b/recipes-kernel/linux/linux-ti-mainline/ti33x/defconfig
similarity index 100%
copy from recipes-kernel/linux/linux-ti-staging-5.4/ti33x/defconfig
copy to recipes-kernel/linux/linux-ti-mainline/ti33x/defconfig
diff --git a/recipes-kernel/linux/linux-ti-staging-5.4/ti43x/defconfig b/recipes-kernel/linux/linux-ti-mainline/ti43x/defconfig
similarity index 100%
copy from recipes-kernel/linux/linux-ti-staging-5.4/ti43x/defconfig
copy to recipes-kernel/linux/linux-ti-mainline/ti43x/defconfig
diff --git a/recipes-kernel/linux/linux-ti-staging_5.4.bb b/recipes-kernel/linux/linux-ti-mainline_git.bb
similarity index 20%
copy from recipes-kernel/linux/linux-ti-staging_5.4.bb
copy to recipes-kernel/linux/linux-ti-mainline_git.bb
index eaf4038..6159725 100644
--- a/recipes-kernel/linux/linux-ti-staging_5.4.bb
+++ b/recipes-kernel/linux/linux-ti-mainline_git.bb
@@ -1,43 +1,70 @@
SECTION = "kernel"
-SUMMARY = "Linux kernel for TI devices"
+SUMMARY = "Mainline Linux kernel for TI devices (with ti-upstream-tools)"
LICENSE = "GPLv2"
-LIC_FILES_CHKSUM = "file://COPYING;md5=bbea815ee2795b2f4230826c0c6b8814"
+LIC_FILES_CHKSUM = "file://COPYING;md5=6bc538ed5bd9a7fc9398086aedcd7e46"
inherit kernel
-DEFCONFIG_BUILDER = "${S}/ti_config_fragments/defconfig_builder.sh"
+DEFCONFIG_BUILDER = "${WORKDIR}/ti-upstream-tools/config/defconfig_builder.sh"
require recipes-kernel/linux/setup-defconfig.inc
-require recipes-kernel/linux/cmem.inc
-require recipes-kernel/linux/ti-uio.inc
-require recipes-kernel/linux/bundle-devicetree.inc
require recipes-kernel/linux/kernel-rdepends.inc
-# Look in the generic major.minor directory for files
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-5.4:"
-
KERNEL_EXTRA_ARGS += "LOADADDR=${UBOOT_ENTRYPOINT}"
S = "${WORKDIR}/git"
-BRANCH = "ti-linux-5.4.y"
+BRANCH = "master"
-SRCREV = "f85baf8e2e6374594eb76d4c14ada9d62a2fa98b"
-PV = "5.4.69+git${SRCPV}"
+# 5.9 Mainline version
+SRCREV = "bbf5c979011a099af5dc76498918ed7df445635b"
+PV = "5.9+git${SRCPV}"
# Append to the MACHINE_KERNEL_PR so that a new SRCREV will cause a rebuild
MACHINE_KERNEL_PR_append = "a"
PR = "${MACHINE_KERNEL_PR}"
-KERNEL_GIT_URI = "git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git"
+KERNEL_GIT_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git"
KERNEL_GIT_PROTOCOL = "git"
-SRC_URI += "${KERNEL_GIT_URI};protocol=${KERNEL_GIT_PROTOCOL};branch=${BRANCH} \
- file://defconfig"
+SRC_URI += " \
+ ${KERNEL_GIT_URI};protocol=${KERNEL_GIT_PROTOCOL};branch=${BRANCH};name=linux \
+ git://git.ti.com/ti-linux-kernel/ti-upstream-tools.git;protocol=${KERNEL_GIT_PROTOCOL};name=ti-upstream-tools;destsuffix=ti-upstream-tools \
+ file://defconfig \
+"
-FILES_${KERNEL_PACKAGE_NAME}-devicetree += "/${KERNEL_IMAGEDEST}/*.itb"
+SRCREV_ti-upstream-tools = "3f36f66594d7905f7b97bc7870931173fd2466bd"
+SRCREV_FORMAT = "linux"
+
+KERNEL_DEVICETREE = ""
+
+kernel_do_compile_append() {
+ oe_runmake dtbs CC="${KERNEL_CC} $cc_extra " LD="${KERNEL_LD}" ${KERNEL_EXTRA_ARGS}
+ oe_runmake -C ${WORKDIR}/ti-upstream-tools LINUX=${S} DTC=${B}/scripts/dtc/dtc O=${B} CC="${KERNEL_CC} $cc_extra " LD="${KERNEL_LD}" ${KERNEL_EXTRA_ARGS}
+}
-# Special configuration for remoteproc/rpmsg IPC modules
-module_conf_rpmsg_client_sample = "blacklist rpmsg_client_sample"
-module_conf_ti_k3_r5_remoteproc = "softdep ti_k3_r5_remoteproc pre: virtio_rpmsg_bus"
-module_conf_ti_k3_dsp_remoteproc = "softdep ti_k3_dsp_remoteproc pre: virtio_rpmsg_bus"
-KERNEL_MODULE_PROBECONF += "rpmsg_client_sample ti_k3_r5_remoteproc ti_k3_dsp_remoteproc"
-KERNEL_MODULE_AUTOLOAD_append_j7 = " rpmsg_kdrv_switch"
+do_install_append() {
+ for dtbf in `find arch/${ARCH}/boot/dts/ \( -name '*.dtb' -or -name '*.dtbo' \)`; do
+ dtb="$dtbf"
+ dtb_ext=${dtb##*.}
+ dtb_base_name=`basename $dtb .$dtb_ext`
+ dtb_path=`get_real_dtb_path_in_kernel "$dtb"`
+ install -m 0644 $dtbf ${D}/${KERNEL_IMAGEDEST}/$dtb_base_name.$dtb_ext
+ done
+}
+
+do_deploy_append() {
+ for dtbf in `find arch/${ARCH}/boot/dts/ \( -name '*.dtb' -or -name '*.dtbo' \) -printf '%P\n'`; do
+ dtb="$dtbf"
+ dtb_ext=${dtb##*.}
+ dtb_base_name=`basename $dtb .$dtb_ext`
+ dtb_dir=`dirname $dtb`
+ install -d ${DEPLOYDIR}
+ install -m 0644 ${D}/${KERNEL_IMAGEDEST}/$dtb_base_name.$dtb_ext ${DEPLOYDIR}/$dtb_base_name.$dtb_ext
+ done
+}
+
+do_shared_workdir_prepend() {
+ cd ${B}
+ echo >> Module.symvers
+}
+
+FILES_${KERNEL_PACKAGE_NAME}-devicetree += "/${KERNEL_IMAGEDEST}/*.itb"
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [dunfell/master][PATCH 3/3] u-boot-ti-mainline: add mainline 2020.10
2020-10-12 23:31 [dunfell/master][PATCH 1/3] linux-ti-staging: extract common rdepends, pass defconfig_builder.sh via variable Denys Dmytriyenko
2020-10-12 23:31 ` [dunfell/master][PATCH 2/3] linux-ti-mainline: add mainline 5.9 using ti-upstream-tools Denys Dmytriyenko
@ 2020-10-12 23:31 ` Denys Dmytriyenko
1 sibling, 0 replies; 3+ messages in thread
From: Denys Dmytriyenko @ 2020-10-12 23:31 UTC (permalink / raw)
To: meta-ti; +Cc: Denys Dmytriyenko
From: Denys Dmytriyenko <denys@ti.com>
Update md5 README checksum for u-boot. No actual licensing changes.
Change is with u-boot commit
35bd70c5107f0 ("Convert CONFIG_SPLASH_SCREEN et al to Kconfig")
Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
.../{u-boot-ti-staging_2020.01.bb => u-boot-ti-mainline_git.bb} | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
copy recipes-bsp/u-boot/{u-boot-ti-staging_2020.01.bb => u-boot-ti-mainline_git.bb} (9%)
diff --git a/recipes-bsp/u-boot/u-boot-ti-staging_2020.01.bb b/recipes-bsp/u-boot/u-boot-ti-mainline_git.bb
similarity index 9%
copy from recipes-bsp/u-boot/u-boot-ti-staging_2020.01.bb
copy to recipes-bsp/u-boot/u-boot-ti-mainline_git.bb
index 5b09cb5..ee0b176 100644
--- a/recipes-bsp/u-boot/u-boot-ti-staging_2020.01.bb
+++ b/recipes-bsp/u-boot/u-boot-ti-mainline_git.bb
@@ -1,7 +1,10 @@
require u-boot-ti.inc
-PR = "r18"
+LIC_FILES_CHKSUM = "file://Licenses/README;md5=5a7450c57ffe5ae63fd732446b988025"
-BRANCH = "ti-u-boot-2020.01"
+PR = "r0"
-SRCREV = "eea73800730b3d9125f5c12a629db2f88e566b71"
+PV = "2020.10"
+UBOOT_GIT_URI = "git://gitlab.denx.de/u-boot/u-boot.git"
+UBOOT_GIT_PROTOCOL = "http"
+SRCREV = "050acee119b3757fee3bd128f55d720fdd9bb890"
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-12 23:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-12 23:31 [dunfell/master][PATCH 1/3] linux-ti-staging: extract common rdepends, pass defconfig_builder.sh via variable Denys Dmytriyenko
2020-10-12 23:31 ` [dunfell/master][PATCH 2/3] linux-ti-mainline: add mainline 5.9 using ti-upstream-tools Denys Dmytriyenko
2020-10-12 23:31 ` [dunfell/master][PATCH 3/3] u-boot-ti-mainline: add mainline 2020.10 Denys Dmytriyenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.