* [Intel-gfx] [CI] drm/i915/gt: Confirm the context survives execution @ 2020-10-15 19:08 Chris Wilson 2020-10-15 20:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Confirm the context survives execution (rev3) Patchwork ` (2 more replies) 0 siblings, 3 replies; 4+ messages in thread From: Chris Wilson @ 2020-10-15 19:08 UTC (permalink / raw) To: intel-gfx Repeat our sanitychecks from before execution to after execution. One expects that if we were to see these, the gpu would already be on fire, but the timing may be informative. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> --- drivers/gpu/drm/i915/gt/intel_engine_pm.c | 37 +++++++++++++++-------- drivers/gpu/drm/i915/gt/intel_lrc.c | 12 ++++++-- 2 files changed, 34 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_engine_pm.c b/drivers/gpu/drm/i915/gt/intel_engine_pm.c index f7b2e07e2229..499b09cb4acf 100644 --- a/drivers/gpu/drm/i915/gt/intel_engine_pm.c +++ b/drivers/gpu/drm/i915/gt/intel_engine_pm.c @@ -17,6 +17,25 @@ #include "intel_ring.h" #include "shmem_utils.h" +static void dbg_poison_ce(struct intel_context *ce) +{ + if (!IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)) + return; + + if (ce->state) { + struct drm_i915_gem_object *obj = ce->state->obj; + int type = i915_coherent_map_type(ce->engine->i915); + void *map; + + map = i915_gem_object_pin_map(obj, type); + if (!IS_ERR(map)) { + memset(map, CONTEXT_REDZONE, obj->base.size); + i915_gem_object_flush_map(obj); + i915_gem_object_unpin_map(obj); + } + } +} + static int __engine_unpark(struct intel_wakeref *wf) { struct intel_engine_cs *engine = @@ -32,20 +51,14 @@ static int __engine_unpark(struct intel_wakeref *wf) if (ce) { GEM_BUG_ON(test_bit(CONTEXT_VALID_BIT, &ce->flags)); + /* Flush all pending HW writes before we touch the context */ + while (unlikely(intel_context_inflight(ce))) + intel_engine_flush_submission(engine); + /* First poison the image to verify we never fully trust it */ - if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM) && ce->state) { - struct drm_i915_gem_object *obj = ce->state->obj; - int type = i915_coherent_map_type(engine->i915); - void *map; - - map = i915_gem_object_pin_map(obj, type); - if (!IS_ERR(map)) { - memset(map, CONTEXT_REDZONE, obj->base.size); - i915_gem_object_flush_map(obj); - i915_gem_object_unpin_map(obj); - } - } + dbg_poison_ce(ce); + /* Scrub the context image after our loss of control */ ce->ops->reset(ce); } diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c index 287537089c77..6170f6874f52 100644 --- a/drivers/gpu/drm/i915/gt/intel_lrc.c +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c @@ -1216,7 +1216,8 @@ static void intel_engine_context_out(struct intel_engine_cs *engine) static void execlists_check_context(const struct intel_context *ce, - const struct intel_engine_cs *engine) + const struct intel_engine_cs *engine, + const char *when) { const struct intel_ring *ring = ce->ring; u32 *regs = ce->lrc_reg_state; @@ -1251,7 +1252,7 @@ execlists_check_context(const struct intel_context *ce, valid = false; } - WARN_ONCE(!valid, "Invalid lrc state found before submission\n"); + WARN_ONCE(!valid, "Invalid lrc state found %s submission\n", when); } static void restore_default_state(struct intel_context *ce, @@ -1347,7 +1348,7 @@ __execlists_schedule_in(struct i915_request *rq) reset_active(rq, engine); if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)) - execlists_check_context(ce, engine); + execlists_check_context(ce, engine, "before"); if (ce->tag) { /* Use a fixed tag for OA and friends */ @@ -1418,6 +1419,9 @@ __execlists_schedule_out(struct i915_request *rq, * refrain from doing non-trivial work here. */ + if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)) + execlists_check_context(ce, engine, "after"); + /* * If we have just completed this context, the engine may now be * idle and we want to re-enter powersaving. @@ -4078,6 +4082,8 @@ static void reset_csb_pointers(struct intel_engine_cs *engine) static void execlists_sanitize(struct intel_engine_cs *engine) { + GEM_BUG_ON(execlists_active(&engine->execlists)); + /* * Poison residual state on resume, in case the suspend didn't! * -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Confirm the context survives execution (rev3) 2020-10-15 19:08 [Intel-gfx] [CI] drm/i915/gt: Confirm the context survives execution Chris Wilson @ 2020-10-15 20:35 ` Patchwork 2020-10-16 0:58 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2020-10-16 7:00 ` [Intel-gfx] [CI] drm/i915/gt: Confirm the context survives execution Mika Kuoppala 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2020-10-15 20:35 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 4227 bytes --] == Series Details == Series: drm/i915/gt: Confirm the context survives execution (rev3) URL : https://patchwork.freedesktop.org/series/82633/ State : success == Summary == CI Bug Log - changes from CI_DRM_9143 -> Patchwork_18707 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/index.html Known issues ------------ Here are the changes found in Patchwork_18707 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_flink_basic@basic: - fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#402]) +1 similar issue [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/fi-tgl-y/igt@gem_flink_basic@basic.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/fi-tgl-y/igt@gem_flink_basic@basic.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-icl-u2: [PASS][3] -> [DMESG-WARN][4] ([i915#2203]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html * igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1: - fi-icl-u2: [PASS][5] -> [DMESG-WARN][6] ([i915#1982]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html #### Possible fixes #### * igt@i915_module_load@reload: - fi-icl-y: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/fi-icl-y/igt@i915_module_load@reload.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/fi-icl-y/igt@i915_module_load@reload.html * igt@vgem_basic@dmabuf-fence: - fi-tgl-y: [DMESG-WARN][9] ([i915#402]) -> [PASS][10] +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/fi-tgl-y/igt@vgem_basic@dmabuf-fence.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/fi-tgl-y/igt@vgem_basic@dmabuf-fence.html #### Warnings #### * igt@i915_pm_rpm@module-reload: - fi-tgl-y: [DMESG-WARN][11] ([i915#1982] / [i915#2411]) -> [DMESG-WARN][12] ([i915#2411]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/fi-tgl-y/igt@i915_pm_rpm@module-reload.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/fi-tgl-y/igt@i915_pm_rpm@module-reload.html - fi-kbl-guc: [DMESG-WARN][13] ([i915#2203]) -> [SKIP][14] ([fdo#109271]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203 [i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 Participating hosts (44 -> 38) ------------------------------ Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus Build changes ------------- * Linux: CI_DRM_9143 -> Patchwork_18707 CI-20190529: 20190529 CI_DRM_9143: 4dbf348a230e183680a5b401cebe278d97411d9a @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5820: 520f88d7817ebb7464907252a32e8e747429102b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_18707: ab3fe0a9352b21b2c9b410f98bca1a8f5e0afee5 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == ab3fe0a9352b drm/i915/gt: Confirm the context survives execution == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/index.html [-- Attachment #1.2: Type: text/html, Size: 5338 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Confirm the context survives execution (rev3) 2020-10-15 19:08 [Intel-gfx] [CI] drm/i915/gt: Confirm the context survives execution Chris Wilson 2020-10-15 20:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Confirm the context survives execution (rev3) Patchwork @ 2020-10-16 0:58 ` Patchwork 2020-10-16 7:00 ` [Intel-gfx] [CI] drm/i915/gt: Confirm the context survives execution Mika Kuoppala 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2020-10-16 0:58 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 17009 bytes --] == Series Details == Series: drm/i915/gt: Confirm the context survives execution (rev3) URL : https://patchwork.freedesktop.org/series/82633/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9143_full -> Patchwork_18707_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_18707_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_18707_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_18707_full: ### IGT changes ### #### Possible regressions #### * igt@kms_lease@page_flip_implicit_plane: - shard-tglb: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-tglb3/igt@kms_lease@page_flip_implicit_plane.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-tglb7/igt@kms_lease@page_flip_implicit_plane.html Known issues ------------ Here are the changes found in Patchwork_18707_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@core_hotunplug@hotrebind-lateclose: - shard-iclb: [PASS][3] -> [DMESG-WARN][4] ([i915#1982]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-iclb4/igt@core_hotunplug@hotrebind-lateclose.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-iclb8/igt@core_hotunplug@hotrebind-lateclose.html * igt@feature_discovery@psr2: - shard-iclb: [PASS][5] -> [SKIP][6] ([i915#658]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-iclb2/igt@feature_discovery@psr2.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-iclb3/igt@feature_discovery@psr2.html * igt@gem_exec_whisper@basic-forked-all: - shard-glk: [PASS][7] -> [DMESG-WARN][8] ([i915#118] / [i915#95]) +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-glk9/igt@gem_exec_whisper@basic-forked-all.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-glk9/igt@gem_exec_whisper@basic-forked-all.html * igt@gem_userptr_blits@unsync-unmap-cycles: - shard-skl: [PASS][9] -> [TIMEOUT][10] ([i915#2424]) +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl8/igt@gem_userptr_blits@unsync-unmap-cycles.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-skl10/igt@gem_userptr_blits@unsync-unmap-cycles.html * igt@i915_pm_dc@dc6-psr: - shard-iclb: [PASS][11] -> [FAIL][12] ([i915#454]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-iclb5/igt@i915_pm_dc@dc6-psr.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-iclb6/igt@i915_pm_dc@dc6-psr.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-skl: [PASS][13] -> [FAIL][14] ([i915#2346]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_draw_crc@draw-method-rgb565-render-untiled: - shard-snb: [PASS][15] -> [FAIL][16] ([i915#54]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-snb7/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-snb7/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html * igt@kms_flip@flip-vs-blocking-wf-vblank@a-dp1: - shard-kbl: [PASS][17] -> [DMESG-WARN][18] ([i915#1982]) +1 similar issue [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-kbl2/igt@kms_flip@flip-vs-blocking-wf-vblank@a-dp1.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-kbl7/igt@kms_flip@flip-vs-blocking-wf-vblank@a-dp1.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1: - shard-skl: [PASS][19] -> [FAIL][20] ([i915#79]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-kbl: [PASS][21] -> [DMESG-WARN][22] ([i915#180]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip@modeset-vs-vblank-race@a-hdmi-a1: - shard-glk: [PASS][23] -> [FAIL][24] ([i915#407]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-glk7/igt@kms_flip@modeset-vs-vblank-race@a-hdmi-a1.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-glk2/igt@kms_flip@modeset-vs-vblank-race@a-hdmi-a1.html * igt@kms_flip@plain-flip-fb-recreate@a-edp1: - shard-skl: [PASS][25] -> [FAIL][26] ([i915#2122]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl4/igt@kms_flip@plain-flip-fb-recreate@a-edp1.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-skl8/igt@kms_flip@plain-flip-fb-recreate@a-edp1.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff: - shard-tglb: [PASS][27] -> [DMESG-WARN][28] ([i915#1982]) +2 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html * igt@kms_frontbuffer_tracking@fbc-stridechange: - shard-glk: [PASS][29] -> [DMESG-WARN][30] ([i915#1982]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-glk4/igt@kms_frontbuffer_tracking@fbc-stridechange.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-glk8/igt@kms_frontbuffer_tracking@fbc-stridechange.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [PASS][31] -> [DMESG-FAIL][32] ([fdo#108145] / [i915#1982]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441]) +3 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-iclb3/igt@kms_psr@psr2_sprite_plane_move.html * igt@kms_universal_plane@disable-primary-vs-flip-pipe-c: - shard-skl: [PASS][35] -> [DMESG-WARN][36] ([i915#1982]) +6 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl7/igt@kms_universal_plane@disable-primary-vs-flip-pipe-c.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-skl8/igt@kms_universal_plane@disable-primary-vs-flip-pipe-c.html - shard-apl: [PASS][37] -> [DMESG-WARN][38] ([i915#1635] / [i915#1982]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-apl8/igt@kms_universal_plane@disable-primary-vs-flip-pipe-c.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-apl4/igt@kms_universal_plane@disable-primary-vs-flip-pipe-c.html #### Possible fixes #### * igt@gem_ctx_isolation@preservation-s3@rcs0: - shard-kbl: [INCOMPLETE][39] ([i915#794]) -> [PASS][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-kbl6/igt@gem_ctx_isolation@preservation-s3@rcs0.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-kbl7/igt@gem_ctx_isolation@preservation-s3@rcs0.html * igt@gem_exec_balancer@bonded-dual: - shard-kbl: [INCOMPLETE][41] -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-kbl4/igt@gem_exec_balancer@bonded-dual.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-kbl6/igt@gem_exec_balancer@bonded-dual.html * {igt@gem_exec_capture@pi@vcs0}: - shard-apl: [INCOMPLETE][43] ([i915#1635]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-apl1/igt@gem_exec_capture@pi@vcs0.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-apl1/igt@gem_exec_capture@pi@vcs0.html * igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen: - shard-skl: [FAIL][45] ([i915#54]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl10/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-skl10/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html * igt@kms_draw_crc@draw-method-rgb565-render-untiled: - shard-skl: [FAIL][47] ([i915#52] / [i915#54]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl5/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-skl5/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1: - shard-skl: [FAIL][49] ([i915#2122]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move: - shard-tglb: [DMESG-WARN][51] ([i915#1982]) -> [PASS][52] +3 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min: - shard-skl: [FAIL][53] ([fdo#108145] / [i915#265]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html * igt@kms_plane_lowres@pipe-a-tiling-yf: - shard-skl: [DMESG-WARN][55] ([i915#1982]) -> [PASS][56] +5 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl7/igt@kms_plane_lowres@pipe-a-tiling-yf.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-skl7/igt@kms_plane_lowres@pipe-a-tiling-yf.html * igt@kms_psr@psr2_cursor_render: - shard-iclb: [SKIP][57] ([fdo#109441]) -> [PASS][58] +4 similar issues [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-iclb6/igt@kms_psr@psr2_cursor_render.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-iclb2/igt@kms_psr@psr2_cursor_render.html * igt@kms_vblank@pipe-c-wait-idle: - shard-apl: [DMESG-WARN][59] ([i915#1635] / [i915#1982]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-apl2/igt@kms_vblank@pipe-c-wait-idle.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-apl3/igt@kms_vblank@pipe-c-wait-idle.html * igt@perf@blocking: - shard-skl: [FAIL][61] ([i915#1542]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl9/igt@perf@blocking.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-skl4/igt@perf@blocking.html * igt@perf@polling-parameterized: - shard-tglb: [FAIL][63] ([i915#1542]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-tglb1/igt@perf@polling-parameterized.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-tglb6/igt@perf@polling-parameterized.html * igt@prime_vgem@fence-wait@bcs0: - shard-tglb: [INCOMPLETE][65] -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-tglb8/igt@prime_vgem@fence-wait@bcs0.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-tglb8/igt@prime_vgem@fence-wait@bcs0.html #### Warnings #### * igt@gem_exec_reloc@basic-many-active@vcs0: - shard-snb: [FAIL][67] ([i915#2389]) -> [INCOMPLETE][68] ([i915#82]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-snb7/igt@gem_exec_reloc@basic-many-active@vcs0.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-snb7/igt@gem_exec_reloc@basic-many-active@vcs0.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [DMESG-WARN][69] ([i915#1226]) -> [SKIP][70] ([fdo#109349]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-iclb3/igt@kms_dp_dsc@basic-dsc-enable-edp.html * igt@runner@aborted: - shard-skl: [FAIL][71] ([i915#1436]) -> ([FAIL][72], [FAIL][73]) ([i915#1436] / [i915#2439]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9143/shard-skl9/igt@runner@aborted.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-skl9/igt@runner@aborted.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/shard-skl4/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226 [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542 [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389 [i915#2424]: https://gitlab.freedesktop.org/drm/intel/issues/2424 [i915#2439]: https://gitlab.freedesktop.org/drm/intel/issues/2439 [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521 [i915#2553]: https://gitlab.freedesktop.org/drm/intel/issues/2553 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#407]: https://gitlab.freedesktop.org/drm/intel/issues/407 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#794]: https://gitlab.freedesktop.org/drm/intel/issues/794 [i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (11 -> 12) ------------------------------ Additional (1): pig-snb-2600 Build changes ------------- * Linux: CI_DRM_9143 -> Patchwork_18707 CI-20190529: 20190529 CI_DRM_9143: 4dbf348a230e183680a5b401cebe278d97411d9a @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5820: 520f88d7817ebb7464907252a32e8e747429102b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_18707: ab3fe0a9352b21b2c9b410f98bca1a8f5e0afee5 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18707/index.html [-- Attachment #1.2: Type: text/html, Size: 19585 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [CI] drm/i915/gt: Confirm the context survives execution 2020-10-15 19:08 [Intel-gfx] [CI] drm/i915/gt: Confirm the context survives execution Chris Wilson 2020-10-15 20:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Confirm the context survives execution (rev3) Patchwork 2020-10-16 0:58 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork @ 2020-10-16 7:00 ` Mika Kuoppala 2 siblings, 0 replies; 4+ messages in thread From: Mika Kuoppala @ 2020-10-16 7:00 UTC (permalink / raw) To: Chris Wilson, intel-gfx Chris Wilson <chris@chris-wilson.co.uk> writes: > Repeat our sanitychecks from before execution to after execution. One > expects that if we were to see these, the gpu would already be on fire, > but the timing may be informative. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Noticed that it had a tag after reading, tho double does no harm. Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> > --- > drivers/gpu/drm/i915/gt/intel_engine_pm.c | 37 +++++++++++++++-------- > drivers/gpu/drm/i915/gt/intel_lrc.c | 12 ++++++-- > 2 files changed, 34 insertions(+), 15 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_pm.c b/drivers/gpu/drm/i915/gt/intel_engine_pm.c > index f7b2e07e2229..499b09cb4acf 100644 > --- a/drivers/gpu/drm/i915/gt/intel_engine_pm.c > +++ b/drivers/gpu/drm/i915/gt/intel_engine_pm.c > @@ -17,6 +17,25 @@ > #include "intel_ring.h" > #include "shmem_utils.h" > > +static void dbg_poison_ce(struct intel_context *ce) > +{ > + if (!IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)) > + return; > + > + if (ce->state) { > + struct drm_i915_gem_object *obj = ce->state->obj; > + int type = i915_coherent_map_type(ce->engine->i915); > + void *map; > + > + map = i915_gem_object_pin_map(obj, type); > + if (!IS_ERR(map)) { > + memset(map, CONTEXT_REDZONE, obj->base.size); > + i915_gem_object_flush_map(obj); > + i915_gem_object_unpin_map(obj); > + } > + } > +} > + > static int __engine_unpark(struct intel_wakeref *wf) > { > struct intel_engine_cs *engine = > @@ -32,20 +51,14 @@ static int __engine_unpark(struct intel_wakeref *wf) > if (ce) { > GEM_BUG_ON(test_bit(CONTEXT_VALID_BIT, &ce->flags)); > > + /* Flush all pending HW writes before we touch the context */ > + while (unlikely(intel_context_inflight(ce))) > + intel_engine_flush_submission(engine); > + > /* First poison the image to verify we never fully trust it */ > - if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM) && ce->state) { > - struct drm_i915_gem_object *obj = ce->state->obj; > - int type = i915_coherent_map_type(engine->i915); > - void *map; > - > - map = i915_gem_object_pin_map(obj, type); > - if (!IS_ERR(map)) { > - memset(map, CONTEXT_REDZONE, obj->base.size); > - i915_gem_object_flush_map(obj); > - i915_gem_object_unpin_map(obj); > - } > - } > + dbg_poison_ce(ce); > > + /* Scrub the context image after our loss of control */ > ce->ops->reset(ce); > } > > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c > index 287537089c77..6170f6874f52 100644 > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c > @@ -1216,7 +1216,8 @@ static void intel_engine_context_out(struct intel_engine_cs *engine) > > static void > execlists_check_context(const struct intel_context *ce, > - const struct intel_engine_cs *engine) > + const struct intel_engine_cs *engine, > + const char *when) > { > const struct intel_ring *ring = ce->ring; > u32 *regs = ce->lrc_reg_state; > @@ -1251,7 +1252,7 @@ execlists_check_context(const struct intel_context *ce, > valid = false; > } > > - WARN_ONCE(!valid, "Invalid lrc state found before submission\n"); > + WARN_ONCE(!valid, "Invalid lrc state found %s submission\n", when); > } > > static void restore_default_state(struct intel_context *ce, > @@ -1347,7 +1348,7 @@ __execlists_schedule_in(struct i915_request *rq) > reset_active(rq, engine); > > if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)) > - execlists_check_context(ce, engine); > + execlists_check_context(ce, engine, "before"); > > if (ce->tag) { > /* Use a fixed tag for OA and friends */ > @@ -1418,6 +1419,9 @@ __execlists_schedule_out(struct i915_request *rq, > * refrain from doing non-trivial work here. > */ > > + if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)) > + execlists_check_context(ce, engine, "after"); > + > /* > * If we have just completed this context, the engine may now be > * idle and we want to re-enter powersaving. > @@ -4078,6 +4082,8 @@ static void reset_csb_pointers(struct intel_engine_cs *engine) > > static void execlists_sanitize(struct intel_engine_cs *engine) > { > + GEM_BUG_ON(execlists_active(&engine->execlists)); > + > /* > * Poison residual state on resume, in case the suspend didn't! > * > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-16 7:02 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-10-15 19:08 [Intel-gfx] [CI] drm/i915/gt: Confirm the context survives execution Chris Wilson 2020-10-15 20:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Confirm the context survives execution (rev3) Patchwork 2020-10-16 0:58 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2020-10-16 7:00 ` [Intel-gfx] [CI] drm/i915/gt: Confirm the context survives execution Mika Kuoppala
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.